Bug 787310

Summary: Error during sync causes stacktrace in pulp log
Product: [Retired] Pulp Reporter: Mike McCune <mmccune>
Component: user-experienceAssignee: Sayli Karmarkar <skarmark>
Status: CLOSED CURRENTRELEASE QA Contact: Preethi Thomas <pthomas>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: cperry, skarmark
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-24 20:11:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 684061    

Description Mike McCune 2012-02-03 22:07:00 UTC
Syncing RHEL 6.2 and near the end we got this error in the pulp.log file:

2012-02-03 20:45:08,971 22061:139650716919552: pulp.server.webservices.controllers.repositories:INFO: repositories:1175 sync timeout passed : None
2012-02-03 20:45:09,715 22061:139650633000704: pulp.server.api.repo_sync:INFO: repo_sync:254 Sync invoked for repo <red_hat-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_RPMs_x86_64_6_2>
2012-02-03 20:45:09,719 22061:139650633000704: pulp.server.api.repo_sync:INFO: repo_sync:268 Sync of red_hat-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_RPMs_x86_64_6_2 starting, skip_dict = {}
2012-02-03 20:45:09,725 22061:139650633000704: pulp.server.api.synchronizers:INFO: synchronizers:726 cacert = </etc/pki/pulp/content/red_hat-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_RPMs_x86_64_6_2/feed-red_hat-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_RPMs_x86_64_6_2.ca>, cert = </etc/pki/pulp/content/red_hat-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_RPMs_x86_64_6_2/feed-red_hat-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_RPMs_x86_64_6_2.cert>
2012-02-03 20:45:09,747 22061:139650633000704: pulp.server.api.synchronizers:INFO: synchronizers:775 Fetching repo to </var/lib/pulp//repos/red hat/Library/content/dist/rhel/server/6/6.2/x86_64/os> with verify_options <{'checksum': True, 'size': True}>
2012-02-03 20:52:37,553 22061:139650633000704: pulp.server.api.synchronizers:INFO: synchronizers:783 YumSynchronizer reported 6812 successes, 0 downloads, 0 errors
2012-02-03 20:52:38,261 22061:139650633000704: pulp.server.tasking.task:ERROR: task:474 Task failed: Task dec2bad1-4ed1-11e1-8c9e-001a4a60121c: _sync(red_hat-Red_Hat_Enterprise_Linux_Server-Red_Hat_Enterprise_Linux_6_Server_RPMs_x86_64_6_2, synchronizer=<pulp.server.api.synchronizers.YumSynchronizer object at 0x7f02e4078810>, skip={}, max_speed=None, threads=4, progress_callback=<bound method RepoSyncTask.progress_callback of <pulp.server.api.repo_sync_task.RepoSyncTask object at 0x7f02e4078150>>)
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/pulp/server/tasking/task.py", line 420, in run
    result = self.callable(*self.args, **self.kwargs)
  File "/usr/lib/python2.6/site-packages/pulp/server/api/repo_sync.py", line 272, in _sync
    progress_callback, synchronizer, max_speed, threads)
  File "/usr/lib/python2.6/site-packages/pulp/server/api/repo_sync.py", line 360, in fetch_content
    added_packages = synchronizer.process_packages_from_source(repo_dir, repo_id, skip_dict, progress_callback)
  File "/usr/lib/python2.6/site-packages/pulp/server/api/synchronizers.py", line 214, in process_packages_from_source
    added_packages = self.add_packages_from_dir(dir, repo_id, skip_dict)
  File "/usr/lib/python2.6/site-packages/pulp/server/api/synchronizers.py", line 234, in add_packages_from_dir
    unfiltered_pkglist = pulp.server.util.get_repo_packages(dir)
  File "/usr/lib/python2.6/site-packages/pulp/server/util.py", line 342, in get_repo_packages
    #r.close()
UnboundLocalError: local variable 'r' referenced before assignment

Comment 1 Mike McCune 2012-02-06 16:12:09 UTC
Repo being synced was:

   "source": {
      "url": "https://cdn.redhat.com/content/dist/rhel/server/6/6.2/x86_64/os",
      "type": "remote"
    },

Comment 2 Sayli Karmarkar 2012-02-06 18:26:54 UTC
commit 9f7b5aab4a2f538c39d28c2baf9c3f6b5d7c1142
Author: Sayli Karmarkar <skarmark>
Date:   Mon Feb 6 10:17:32 2012 -0800

    787310 - fixing error during repo sync when trying to access a variable before assignment when failed to load repo-md data

Comment 3 Jeff Ortel 2012-02-06 22:22:57 UTC
build: 0.265

Comment 4 Preethi Thomas 2012-02-16 15:44:04 UTC
[root@preethi ~]# rpm -q pulp
pulp-0.0.266-1.fc15.noarch
[root@preethi ~]# 

[root@preethi ~]# pulp-admin -u admin -p admin repo create --id=test@red$ --feed=https://cdn.redhat.com/content/dist/rhel/rhui/server/6/6Server/x86_64/os/ --feed_ca=CDN/cdn.redhat.com-chain.crt --feed_cert CDN/rhcontent.pem Successfully created repository [ test@red$ ]

[root@preethi ~]# pulp-admin repo sync --id=test@red$ -FSync for repository test@red$ started
Sync: Canceled

Item Details: 
Tree Files: 6/6
RPMs: 1480/6855

[root@preethi ~]# pulp-admin repo sync --id=test@red$ -F
Sync for repository test@red$ started
Sync: Finished
5375/6861 new items downloaded
1486/6861 existing items processed

Item Details: 
Tree Files: 6/6
RPMs: 6855/6855

Comment 5 Preethi Thomas 2012-02-24 20:11:49 UTC
Pulp v1.0 is released
Closed Current Release.