Bug 787383

Summary:	fedpkg cannot generate readable SRPMs for EL5
Product:	[Fedora] Fedora	Reporter:	Michel Alexandre Salim <michel>
Component:	fedpkg	Assignee:	David Cantrell <dcantrell>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	16	CC:	dcantrell
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-06 21:14:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Michel Alexandre Salim 2012-02-04 17:02:25 UTC

Description of problem:
I'm updating one of my packages (nickle) and wanted to do a scratch build *before* pushing my commit. So on the el5 branch, I did 'fedpkg srpm' (after committing locally) and then 'koji build --scratch dist-5E-epel ...'. To my surprise it fails with cpio complaining about an MD5 sum mismatch for the source tarball.

Version-Release number of selected component (if applicable):
fedpkg-1.7-1.fc16.noarch
redhat-rpm-config-9.1.0-24.fc16.noarch

How reproducible:
Always

Steps to Reproduce:
1. fedpkg clone nickle; cd nickle
2. fedpkg switch-branch el5; fedpkg srpm
3. koji build --scratch dist-5E-epel ./nickle-2.72-1.el5.src.rpm
4. also, upload to the EPEL5 test machine and try rpm -i ./nickle-2.72-1.el5.src.rpm
  
Actual results:
For (3) and (4):
error: unpacking of archive failed on file /usr/src/redhat/SOURCES/nickle-2.72.tar.gz;4f2d6330: cpio: MD5 sum mismatch


Expected results:
A proper SRPM should be generated.

Additional info:

Comment 1 Jesse Keating 2012-02-06 21:14:30 UTC

You need to pass the --md5  option to the srpm command if you're building an srpm that you're going to throw at a RHEL5 or older host.

Some argument could be made for automatically doing that if you're on a rhel-5 branch, but we don't always know what the user's intention is to do with the srpm.