Bug 787593

Summary: [virt-manager]Grab key combination changed to 'Meta_L' if set it with 'Shift_L'+'Alt_L'
Product: Red Hat Enterprise Linux 6 Reporter: Geyang Kong <gkong>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED UPSTREAM QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 6.3CC: jwu, mjenner, mzhan, rwu, zpeng
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-07 18:54:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
This is virt-manager's log
none
This is libvirtd's log
none
This is screenshot, virt-manager's UI. none

Description Geyang Kong 2012-02-06 09:21:43 UTC
Version-Release number of selected component (if applicable):
libvirt-0.9.9-2.el6.x86_64
python-virtinst-0.600.0-5.el6.noarch
qemu-kvm-0.12.1.2-2.218.el6.x86_64
virt-manager-0.9.0-7.el6.x86_64
Linux version 2.6.32-220.el6.x86_64

How reproducible:
100%

Steps to Reproduce:

1. Start virt-manager.

2. Click Edit->Preferences->VM Details.

3. Click 'Change...' button besides 'Grab keys'.

4. Press 'Shift_L' key and hold it, then press 'Alt_L' in 'Configure grab key combination' form.

5. Release 'Shift_L' key first, then release 'Alt_L' key.

Actual results:

1. After step 4, 'OK' button cannot be clicked.

2. After step 5, there is a key called 'Meta_L' left on the form.

3. Some error message appeared in the virt-manager.log, and there is nothing in libvirtd.log, below is the error message
   Virt manager's error
--------------------------------------------------------------------------------
[Mon, 06 Feb 2012 11:31:47 virt-manager 10522] ERROR (cli:85) Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/preferences.py", line 230, in grabkeys_dlg_release
    defs['keysyms'].remove(ev.keyval)
ValueError: list.remove(x): x not in list
None
--------------------------------------------------------------------------------

Expected results:

1. There is nothing left on the form after keys have been released just like other key combinations.

2. Key combination could be successfully defined without error or refused clearly by virt-manager.

Additional info:

1. This issue could be also repuced by 'Shift_L'+'Alt_R', 'Shift_R'+'Alt_R', 'Shift_R'+'Alt_L' combinations.

Comment 1 Geyang Kong 2012-02-06 09:22:28 UTC
Created attachment 559574 [details]
This is virt-manager's log

Comment 2 Geyang Kong 2012-02-06 09:22:56 UTC
Created attachment 559575 [details]
This is libvirtd's log

Comment 3 Geyang Kong 2012-02-06 09:24:08 UTC
Created attachment 559576 [details]
This is screenshot, virt-manager's UI.

Comment 4 Cole Robinson 2012-02-07 18:54:51 UTC
Thanks for the report. I've fixed the Meta issue upstream:

http://git.fedorahosted.org/git?p=virt-manager.git;a=commit;h=97d3b46b77a6d259c01153a6e33bf95a15b69ac9

Not being able to click the 'OK' button when pressing Shift+Alt seems to not be specific to virt-manager, so I assume it's some weird gtk or X issue/feature.

That said, this is a minor issue and not really the effort/risk of backporting to RHEL, so just closing as UPSTREAM.