Bug 787658

Summary: Review Request: jgoodies-animation - Framework for time-based real-time animations in Java
Product: [Fedora] Fedora Reporter: Jaromír Cápík <jcapik>
Component: Package ReviewAssignee: Tomas 'Sheldon' Radej <tradej>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: akurtako, notting, ovasik, package-review, tradej
Target Milestone: ---Flags: tradej: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-21 13:18:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jaromír Cápík 2012-02-06 12:51:10 UTC
Spec URL: http://jcapik.fedorapeople.org/files/jgoodies-animation/jgoodies-animation.spec
SRPM URL: http://jcapik.fedorapeople.org/files/jgoodies-animation/jgoodies-animation-1.3.0-1.fc17.src.rpm
Description: 
he JGoodies Animation framework enables you to produce time-based real-time
animations in Java. It uses concepts and notions as described by the W3C
specification for the Synchronized Multimedia Integration Language (SMIL).

This animation framework has been designed for a seemless, flexible
and powerful integration with Java, ease-of-use and a small library size.
Unlike SMIL we use Java to describe the animations – not XML.

Comment 1 Tomas 'Sheldon' Radej 2012-02-09 12:47:18 UTC
Taking it.

Comment 2 Tomas 'Sheldon' Radej 2012-02-09 13:11:42 UTC
Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Rpmlint output: 
jgoodies-animation.noarch: W: spelling-error %description -l en_US seemless -> seamless, stemless, seedless
jgoodies-animation.noarch: W: non-standard-group Development/Java
jgoodies-animation.src: W: spelling-error %description -l en_US seemless -> seamless, stemless, seedless
jgoodies-animation.src: W: non-standard-group Development/Java
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
       >> You might reconsider moving it into Development/Libraries, but 
          this is good with me

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other
     legal requirements as defined in the legal section of Packaging
     Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
     License type: BSD
[x]  If (and only if) the source package includes the text of the license(s) in
     its own file, then that file, containing the text of the license(s) for the
     package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
     in the spec URL.
     MD5sum of sources:  a258108dd199b57ce535a2455963b6c0
     MD5sum of upstream: a258108dd199b57ce535a2455963b6c0
[x]  All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with
     good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
     (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
     mixing)
[x]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
     application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks) 
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that
     tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be
     removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when
     building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of
     %{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a
     comment 
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why
     it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on
     jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[!]  Latest version is packaged.
       >> Version 1.4.0 is available. Not blocking it on this, though

*** ISSUES ***
- Version 1.4.0 available

*** APPROVED ***

Comment 3 Jaromír Cápík 2012-02-15 17:36:47 UTC
New Package SCM Request
=======================
Package Name: jgoodies-animation
Short Description: Framework for time-based real-time animations in Java
Owners: jcapik
Branches: f15 f16 f17
InitialCC: java-sig

Comment 4 Gwyn Ciesla 2012-02-15 18:06:52 UTC
Git done (by process-git-requests).

Comment 5 Jaromír Cápík 2012-02-21 13:18:57 UTC
Thanks guys.

built ... closing ...