| Summary: | Review Request: ghc-temporary - portable temp file library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
| Component: | Package Review | Assignee: | Michel Alexandre Salim <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | haskell-devel, michel, notting, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ghc-temporary-1.1.2.3-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-19 01:58:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 787636 | ||
|
Description
Jens Petersen
2012-02-07 08:24:49 UTC
Will do the review in a bit. Everything looks good; APPROVED
* DONE Review [100%]
- [X] Names [2/2]
- [X] Package name
- [X] Spec name
- [X] Package version [2/2]
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning
- [X] Version number
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag
- [X] Release tag
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
- [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
- [X] Source files match upstream
b47b3db33766621927b577b53c1451c73af9448c temporary-1.1.2.3.tar.gz
b47b3db33766621927b577b53c1451c73af9448c ../SOURCES/temporary-1.1.2.3.tar.gz
- [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]]
- [X] License [4/4]
- [X] License is Fedora-approved
- [X] No licensing conflict
- [X] License field accurate
- [X] License included iff packaged by upstream
- [X] rpmlint [2/2]
- [X] on src.rpm
ghc-temporary.src: W: spelling-error %description -l en_US unixutils -> uninstalls
==> ignore this; false positive
- [X] on x86_64.rpm
ghc-temporary.x86_64: W: spelling-error %description -l en_US unixutils -> uninstalls
ghc-temporary-devel.x86_64: W: spelling-error %description -l en_US unixutils -> uninstalls
=> likewise
- [X] Language & locale [2/2]
- [X] Spec in US English
- [X] Spec legible
- [X] Build [3/3]
- [X] Koji results
Rawhide: as posted by Jens
F16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3772605
- [X] BRs complete
- [X] Directory ownership
- [X] Spec inspection [6/6]
- [X] No duplicate files
- [X] File permissions
- [X] Filenames must be UTF-8
- [X] Macro usage consistent
- [X] Documentation [2/2]
- [X] If large docs, separate -doc
- [X] %doc files are non-essential
- [X] Development [2/2]
- [X] Headers in -devel
- [X] -devel, -static requires main
Thank you for reviewing! :-) New Package SCM Request ======================= Package Name: ghc-temporary Short Description: Portable temp file library Owners: petersen Branches: f17 f16 f15 el6 InitialCC: haskell-sig Git done (by process-git-requests). ghc-temporary-1.1.2.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-temporary-1.1.2.3-1.fc16 ghc-temporary-1.1.2.3-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-temporary-1.1.2.3-1.fc15 ghc-temporary-1.1.2.3-1.fc16 has been pushed to the Fedora 16 testing repository. ghc-temporary-1.1.2.3-1.fc15 has been pushed to the Fedora 15 stable repository. ghc-temporary-1.1.2.3-1.fc16 has been pushed to the Fedora 16 stable repository. |