Bug 788027

Summary:	Spice and vnc connection buffer keyboard and mouse event after guest stopped
Product:	Red Hat Enterprise Linux 6	Reporter:	Shaolong Hu <shu>
Component:	qemu-kvm	Assignee:	Gerd Hoffmann <kraxel>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.3	CC:	acathrow, areis, bsarathy, juzhang, michen, minovotn, mkenneth, qzhang, tburke, virt-maint
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	qemu-kvm-0.12.1.2-2.236.el6	Doc Type:	Bug Fix
Doc Text:	No Documentation Needed	Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-20 11:39:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Shaolong Hu 2012-02-07 09:24:46 UTC

Description of problem:
------------------------
Spice and vnc connection buffer keyboard and mouse event after guest stopped, after guest resumed, these event are delivered to guest, causing unpredictable result.

Version-Release number of selected component (if applicable):
---------------------------------------------------------------
qemu-kvm-0.12.1.2-2.223.el6.x86_64


How reproducible:
-----------------
100%

Steps to Reproduce:
--------------------
1.boot guest with vnc or spice connection
2.in qemu monitor:
(qemu) stop
3.switch vnc or spice client window to the top, type some thing or click mouse
4.in qemu monitor:
(qemu) cont
  
Actual results:
----------------
after step 4, keyboard and mouse event are delivered to guest.

Expected results:
------------------
Do not buffer keyboard and mouse event.

Additional info:
------------------
A simple example why the current behavior is not appropriate:
1.in guest, open a shell
2.stop guest
3.type "reboot" + "Enter" in guest connection window
4.cont guest
5.guest reboots

Lots of people are used to type keyboard and click mouse randomly when they find system frozen to see what's going on, if these operation combine happens to have some meaning to system, after guest resumed, it will be implemented, this may hazard system operation and is hard to diagnose.

Comment 2 Gerd Hoffmann 2012-02-17 09:04:11 UTC

http://patchwork.ozlabs.org/patch/141264/

Comment 3 Gerd Hoffmann 2012-02-23 14:38:29 UTC

http://git.qemu.org/?p=qemu.git;a=commit;h=7bc9318bfb68b2d773449a55d4fa800d0fdb0918

Comment 4 Gerd Hoffmann 2012-02-29 12:54:29 UTC

Oops wrong commit, here is the real one:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=99c7f87826337fa81f2f0f9baa9ca0a44faf90e9

Comment 5 Gerd Hoffmann 2012-02-29 12:58:41 UTC

Patch posted.

Comment 9 Qunfang Zhang 2012-03-12 11:53:10 UTC

Reproduced on qemu-kvm-0.12.1.2-2.235.el6 and verified pass on qemu-kvm-0.12.1.2-2.241.el6.x86_64 with the same steps in Comment 0. Tested both vnc and spice, after stop guest, try input strings in the terminal, click the icons in desktop, etc.  Can not reproduce. 
So this issue is fixed.

Comment 11 Michal Novotny 2012-05-04 09:53:44 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No Documentation Needed

Comment 12 errata-xmlrpc 2012-06-20 11:39:03 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0746.html