Bug 788136

Summary: No validation for empty fields when importing as non -admin user
Product: [Retired] CloudForms Cloud Engine Reporter: Shveta <ssachdev>
Component: aeolus-conductorAssignee: Shveta <ssachdev>
Status: CLOSED ERRATA QA Contact: wes hayutin <whayutin>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 1.0.0CC: akarol, athomas, deltacloud-maint, ssachdev
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-05-15 22:26:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
no_provider
none
invalid_msg
none
continue button disabled none

Description Shveta 2012-02-07 15:09:00 UTC
Created attachment 559977 [details]
no_provider

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a user shveta
2. As shveta go to clouds --> Component outlines -- > Import Component Outlines
3. No providers are displayed 
4. Click on Continue button 
"The record you tried to access does not exist, it may have been deleted " 
is displayed
  
validation for empty fields or a better message is required.
Actual results:


Expected results:


Additional info:

rpm -qa|grep aeolus
aeolus-conductor-daemons-0.8.0-21.el6.noarch
aeolus-configure-2.5.0-12.el6.noarch
aeolus-conductor-doc-0.8.0-21.el6.noarch
rubygem-aeolus-image-0.3.0-7.el6.noarch
rubygem-aeolus-cli-0.3.0-8.el6.noarch
aeolus-conductor-0.8.0-21.el6.noarch
aeolus-all-0.8.0-21.el6.noarch

Comment 1 Shveta 2012-02-07 15:09:57 UTC
Created attachment 559982 [details]
invalid_msg

Comment 2 wes hayutin 2012-02-22 23:46:09 UTC
moving version to 1.0.0 .  version = found in version

Comment 4 Angus Thomas 2012-02-23 14:20:19 UTC
Please check if this can be reproduced in current build.

Comment 6 Tzu-Mainn Chen 2012-02-23 18:28:44 UTC
Yep, it can definitely be reproduced.  If there are no accounts, should we even allow the user to submit the form?  Or should we have a flash warning instructing the user to create a provider account?

Mainn

Comment 7 Angus Thomas 2012-03-06 17:38:19 UTC
Please add a flash error message, warning the user that a provider account is required before they can import a template, to be shown when the click on the "Continue" button referred to in the steps to reproduce above.

Comment 8 Tzu-Mainn Chen 2012-03-06 19:10:25 UTC
Patch created:

https://fedorahosted.org/pipermail/aeolus-devel/2012-March/009437.html

Comment 9 Tzu-Mainn Chen 2012-03-06 19:58:10 UTC
Patch pushed to master:

commit a55bb5a5164d6f1aa4fb1fffc2efc95420926f38
BZ 788136 add checks to see if accounts exist

Comment 11 Shveta 2012-03-07 08:31:24 UTC
Created attachment 568193 [details]
continue button disabled

If no provider accounts are there "Images cannot be imported, as no provider accounts are currently enabled for this environment." error is flashed 
and continue button is disabled




rpm -qa|grep aeolus
aeolus-conductor-doc-0.8.0-41.el6.noarch
aeolus-conductor-daemons-0.8.0-41.el6.noarch
rubygem-aeolus-cli-0.3.0-13.el6.noarch
aeolus-all-0.8.0-41.el6.noarch
aeolus-conductor-0.8.0-41.el6.noarch
rubygem-aeolus-image-0.3.0-12.el6.noarch
aeolus-configure-2.5.0-18.el6.noarch

Comment 12 errata-xmlrpc 2012-05-15 22:26:22 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2012-0583.html