Bug 788443

Summary: f16 guest w/ vnc+tablet doesn't see alt+tab unless we force pointer grab
Product: [Fedora] Fedora Reporter: Kamil Páral <kparal>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: berrange, crobinso, dougsland, dpierce, hbrock, jforbes, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-manager-0.9.1-2.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-17 23:53:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kamil Páral 2012-02-08 08:45:05 UTC
Description of problem:
In the past when I hit Ctrl+Alt in a VM, the title bar would change indicating they keyboard grab was active and all the keyboard shortcuts (like Alt+Tab) would be redirected to the VM. This is no longer the case. When I hit Ctrl+Alt, I toggle keyboard grab, but I see no indicator whatsoever (no title bar change, no nothing). Therefore I am never sure whether the keyboard shortcuts will or will be not redirected. That is annoying.

Please put back some indicator whether keyboard grab is active. In title bar, in tool bar, I don't care.

Thanks.

Version-Release number of selected component (if applicable):
virt-manager-0.9.1-1.fc16.noarch

How reproducible:
always

Steps to Reproduce:
1. Hit Ctrl+Alt
2. See no indicator of keyboard grab

Comment 1 Cole Robinson 2012-02-08 22:59:25 UTC
Thanks for the report Kamil. I can kind of reproduce: an f16 guest with spice, qxl, and virtual tablet device (the defaults when creating a new vm) indeed never shows a ctrl+alt in the title bar, because the spice widget will never grab the pointer if using a tablet

The title changing was always for pointer grab, not keyboard grab, although you don't usually get pointer grab without keyboard grab so the confusion is understandable.

However, I definitely don't need to press ctrl+alt to get the guest to see alt-tab vs the host seeing it, that seems to automatically happen when the mouse spice widget is focused and the mouse is over the widget. So can you verify that ctrl-alt is really required, and it's not just focusing the console?

That said I did notice a bit of a defect wrt VNC: you if using the virtual tablet, you do need to manually press ctrl+alt in order for the guest to see all keyboard presses like alt+tab, but when pressing ctrl+alt we correctly update the window title. I've pushed a fix for that, to make things act more like spice:

http://git.fedorahosted.org/git?p=virt-manager.git;a=commit;h=32456e5ed736ee70e3da153bf95eacec3052fc9c

I'll use this bug to track that issue, but please provide more details if you are seeing other problems.

Comment 2 Kamil Páral 2012-02-09 13:51:45 UTC
My original bug report was referring to VNC+cirrus, the old defaults. I tried again, I don't see any indication of pointer grab (toggled by Ctrl+Alt). Alt+Tab works in guest only if I manually force pointer grab. If I don't, Alt+Tab always applies for host, no matter if my mouse cursor is currently over the VM window or not.

I re-tested with spice+qxl. I can confirm that pointer grab is indicated in the title bar and just clicking into the VM is sufficient to activate the pointer grab. But this only applies for machine boot, GRUB, etc. Once my Fedora is booted, Ctrl+Alt has no effect. All keyboard shortcuts are automatically redirected when the mouse cursor is over the VM. That's nice. OTOH you can't redirect keyboard shortcuts when your cursor is not over the VM, because as I said, Ctrl+Alt has no effect. That's a bit inconvenient.

So it seems there are several bugs here.

Comment 3 Cole Robinson 2012-02-09 16:54:31 UTC
Oops, yes, I forgot that there was a bug in the new virt-manager about VNC that would affect updating the window title:

http://git.fedorahosted.org/git?p=virt-manager.git;a=commit;h=c47fc5454039a9e7093f179c1e06ffc576dc1ad3

That explains the initial piece you reported.

SPICE stealing keyboard focus on mouse over is annoying, I agree. I talked with elmarco, one of the spice guys, and he asked me to file an upstream bug:

https://bugs.freedesktop.org/show_bug.cgi?id=45846

So we can use this to keep tracking the virt-manager changes to backport.

Comment 4 Kamil Páral 2012-02-09 17:02:54 UTC
> SPICE stealing keyboard focus on mouse over is annoying, I agree.

Actually I like it. But grabbing keyboard focus not on mouse over but on mouse click (which is what you propose IIUC) is fine as well - that's the way VirtualBox works, I believe.

What I don't like is that you can't grab keyboard focus without using your mouse.

Comment 5 Fedora Update System 2012-02-14 00:31:53 UTC
virt-manager-0.9.1-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/virt-manager-0.9.1-2.fc16

Comment 6 Fedora Update System 2012-02-14 00:42:41 UTC
virt-manager-0.9.1-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/virt-manager-0.9.1-2.fc15

Comment 7 Fedora Update System 2012-02-15 11:29:01 UTC
Package virt-manager-0.9.1-2.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing virt-manager-0.9.1-2.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-1671/virt-manager-0.9.1-2.fc16
then log in and leave karma (feedback).

Comment 8 Kamil Páral 2012-02-16 12:05:22 UTC
virt-manager-0.9.1-2.fc16 fixes this bug for VNC displays. For Spice the shortcut Ctrl+Alt simply does not have any effect (I don't know whether it is intentional).

Comment 9 Fedora Update System 2012-02-17 23:53:27 UTC
virt-manager-0.9.1-2.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Cole Robinson 2012-02-20 18:33:24 UTC
Kamil, that's the behavior of spice-gtk. IMO it should behave like virt-manager as well, in that the user can force a keyboard/mouse grab, since this is desireable in some situations, like trying to track the edge of the VM screen when the guest resolution is small enough to fit in a window.

But it's a spice-gtk RFE, not a virt-manager issue I don't think.

Comment 11 Kamil Páral 2012-02-21 10:10:58 UTC
(In reply to comment #10)
> Kamil, that's the behavior of spice-gtk. IMO it should behave like virt-manager
> as well, in that the user can force a keyboard/mouse grab, since this is
> desireable in some situations, like trying to track the edge of the VM screen
> when the guest resolution is small enough to fit in a window.

Or when someone doesn't have mouse.

> But it's a spice-gtk RFE, not a virt-manager issue I don't think.

Thanks for explanation.

Comment 12 Fedora Update System 2012-02-23 02:26:37 UTC
virt-manager-0.9.1-2.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.