Bug 788546

Summary:	webadmin [RFE]: query for disk space on multiple domains when creating new vm+disk
Product:	[Retired] oVirt	Reporter:	Dafna Ron <dron>
Component:	ovirt-engine-webadmin	Assignee:	Einav Cohen <ecohen>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	unspecified	CC:	abaron, acathrow, amureini, ecohen, iheim, michal.skrivanek, ykaul
Target Milestone:	---
Target Release:	3.3.4
Hardware:	x86_64
OS:	Linux
Whiteboard:	storage
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-17 07:41:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Dafna Ron 2012-02-08 12:20:14 UTC

Description of problem:

when we have multiple domains, and we create a new VM+disk we automatically load one of the domains (from what I see its alphabetical, excluding the master domain). 
I think we should create a query that will calculate free space and select as default the domain that has more disk space (actual size).

Version-Release number of selected component (if applicable):

ovirt-engine-webadmin-portal-3.0.0_0001-1.4.fc16.x86_64

How reproducible:

100%

Steps to Reproduce:
1. create 2 domains
2. create a vm and add a new preallocated large disk to the first loaded domain (create a large enough disk so that the domain will be completely full)
3. create a second vm+disk - look at the domain scroll 
  
Actual results:

the same domain will be loaded even though it is full and we have a second domain which is empty.
trying to create a disk on the full domain will propagate an error from engine

Expected results:

we should create a query that will calculate the disk space on domains and load the domain that has more space. 

Additional info:

Comment 1 Einav Cohen 2012-02-09 06:45:01 UTC

I actually suggest introducing an "auto-select-domain" as one of the possible "target-storage-domain" values that will be sent to the backend; when this value will be sent to the backend, the backend will choose according to its rules (could be space-load on the storage-domains and/or something else) the best storage domain on which the disk should be created.

This will save each client from implementing a storage-domain selection algorithm of its own.

This option should be introduced also in New VM and Import VM, not only in New Disk.

Comment 2 Itamar Heim 2012-02-09 09:52:12 UTC

(In reply to comment #1)
> I actually suggest introducing an "auto-select-domain" as one of the possible
> "target-storage-domain" values that will be sent to the backend; when this
> value will be sent to the backend, the backend will choose according to its
> rules (could be space-load on the storage-domains and/or something else) the
> best storage domain on which the disk should be created.
> 
> This will save each client from implementing a storage-domain selection
> algorithm of its own.
> 
> This option should be introduced also in New VM and Import VM, not only in New
> Disk.

is this same level of relevancy/simplicity with quotas?

Comment 3 Einav Cohen 2012-02-09 11:52:37 UTC

(In reply to comment #2)
> (In reply to comment #1)
> > I actually suggest introducing an "auto-select-domain" as one of the possible
> > "target-storage-domain" values that will be sent to the backend; when this
> > value will be sent to the backend, the backend will choose according to its
> > rules (could be space-load on the storage-domains and/or something else) the
> > best storage domain on which the disk should be created.
> > 
> > This will save each client from implementing a storage-domain selection
> > algorithm of its own.
> > 
> > This option should be introduced also in New VM and Import VM, not only in New
> > Disk.
> 
> is this same level of relevancy/simplicity with quotas?

With quotas, the "storage-domain" drop down should include only the storage domains that are available within the quota for consumption. 
You can still have an "auto-select-domain" option in the drop down which, when sent to the backend, triggers the storage-domain-selection-algorithm, only the list of available storage domains to choose from should include only available storage domains within the relevant quota (the quota should also arrive to the backend as a parameter to the AddDisk/AddVm/ImportVm action), rather than all the storage domains in the data-center.

You can, of course, think also of a quota-auto-selection-algorithm, but that's one step further, and isn't relevant only for storage-domain selection.

Comment 4 Itamar Heim 2012-12-17 07:41:11 UTC

Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.