| Summary: | Review Request: rubygem-rbovirt - A Ruby client for oVirt REST API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | Package Review | Assignee: | Michal Fojtik <mfojtik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mfojtik, notting, package-review, tdawson |
| Target Milestone: | --- | Flags: | mfojtik:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-rbovirt-0.0.6-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-25 08:29:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Vít Ondruch
2012-02-08 14:41:08 UTC
Review:
* Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification.
OK
The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version
OK
The package must have a Requires and a BuildRequires on rubygems
OK
The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification. For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem
OK
The %prep and %build sections of the specfile should be empty.
OK (Patch is being applied, so %prep is not empty)
The Gem must be installed into %{gemdir}
OK
gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}
OK
The package must own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
It's possible to update guidelines to for excluding cache ^^ ? (not a review blocker)
=====================================
This package looks safe, license is sane and patching was properly described in a comment. REVIEW+
+ Can you please import this packages to EL6 ? + I would need this package for Fedora 16 too. Can you please import it with ruby(abi) = 1.8 and avoid the new Ruby RPM macros? Thanks! Thank you for your review. I'm going to request f16 f17 and el6. See bellow New Package SCM Request ======================= Package Name: rubygem-rbovirt Short Description: A Ruby client for oVirt REST API Owners: vondruch Branches: f16 f17 el6 Git done (by process-git-requests). rubygem-rbovirt-0.0.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-rbovirt-0.0.5-1.el6 rubygem-rbovirt-0.0.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-rbovirt-0.0.5-1.fc16 Package rubygem-rbovirt-0.0.5-1.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing rubygem-rbovirt-0.0.5-1.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-0421/rubygem-rbovirt-0.0.5-1.el6 then log in and leave karma (feedback). rubygem-rbovirt-0.0.6-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-rbovirt-0.0.6-1.fc16 rubygem-rbovirt-0.0.6-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-rbovirt-0.0.6-1.el6 rubygem-rbovirt-0.0.6-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. rubygem-rbovirt-0.0.6-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: rubygem-rbovirt New Branches: epel7 Owners: tdawson Git done (by process-git-requests). |