| Summary: | Review Request: beefy-miracle-kde-theme - Beefy Miracle KDE Theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Reznik <jreznik> |
| Component: | Package Review | Assignee: | Radek Novacek <rnovacek> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, ovasik, package-review, rnovacek |
| Target Milestone: | --- | Flags: | rnovacek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-14 15:58:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Jaroslav Reznik
2012-02-09 14:36:18 UTC
Name: ok
License: ok
Source: ok
BRs/Reqs: ok
Macros used consistently: ok
ldconfig: NA
Desktop file validations: NA
Locales: NA
Docs: ok
Devel: NA
Files: ok
Build: ok
rpmlint: no issues
beefy-miracle-kde-theme.src:59: W: macro-in-comment %{buildroot}
beefy-miracle-kde-theme.src:59: W: macro-in-comment %{_kde4_appsdir}
beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/1920x1200/beefy-miracle.png ../../../../../../backgrounds/beefy-miracle/default/wide/beefy-miracle.png
beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/2048x1536/beefy-miracle.png ../../../../../../backgrounds/beefy-miracle/default/standard/beefy-miracle.png
beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/1280x1024/beefy-miracle.png ../../../../../../backgrounds/beefy-miracle/default/normalish/beefy-miracle.png
beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/kdm/themes/BeefyMiracle/system-logo-white.png ../../../../../pixmaps/system-logo-white.png
beefy-miracle-kde-theme.noarch: W: dangling-relative-symlink /usr/share/kde4/apps/ksplash/Themes/BeefyMiracle/2048x1536/logo.png ../../../../../../pixmaps/system-logo-white.png
There is mistake in condition for Provides, there should be version bump in "%if 0%{?fedora} > 15" and in the second condition too.
Please correct the version before adding the package to the distribution. No other issues found, setting fedora-review+.
The dangling symlinks are ok, there's dependency on beefy-miracle-backgrounds. Fixed Fedora version conditionals (has to be coupled with Verne theme) Spec URL: http://rezza.hofyland.cz/fedora/packages/beefy-miracle-kde-theme/beefy-miracle-kde-theme.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/beefy-miracle-kde-theme/beefy-miracle-kde-theme-16.91.0-2.fc16.src.rpm New Package SCM Request ======================= Package Name: beefy-miracle-kde-theme Short Description: Beefy Miracle KDE Theme Owners: jreznik kkofler than rdieter ltinkl Branches: f17 InitialCC: Git done (by process-git-requests). |