Bug 789124
| Summary: | circular dependency in the server/jar/pom.xml | ||
|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Simeon Pinder <spinder> |
| Component: | Build System | Assignee: | John Mazzitelli <mazz> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> |
| Severity: | low | Docs Contact: | |
| Priority: | high | ||
| Version: | 4.3 | CC: | hrupp, jshaughn, mazz |
| Target Milestone: | --- | ||
| Target Release: | JON 3.1.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-03 15:01:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 782579 | ||
|
Description
Simeon Pinder
2012-02-09 21:13:24 UTC
FWIW, server jar, I think, has to depend on client-api. client-api defines all of the server services, which are implemented in server jar classes. I'm not sure you'll be able to fix this any better than what's already been done for bug 789039. "client-api defines all of the server services, which are implemented in server jar classes." Then it sounds like client-api should not be depending on server.jar. But then as Jay says, we may just have to fix this like bug 789039. how can client-api depend on server/jar? client-api is for inclusion both in the server AND THE AGENT. The agent can't have server/jar in its classpath. wait - which client-api are we talking about? there is core/client-api (which is the one I'm familiar with - this is the API between server and agent) and there is enterprise/remoting/client-api (which is one I am not familiar with - looks CLI related) I assume, reading the rest of the comments, we are talking about this latter one (the remoting/CLI one) i think its due to this in the client-api pom.xml
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>rhq-script-bindings</artifactId>
<version>${project.version}</version>
</dependency>
which, in turn, depends on rhq-enterprise-server
I think this was introduced by this commit: 8e0df522a432a66392d428aeb8e86a71c6d1061e whose commit message says "Starting to rip out common ScriptEngine bindings out of the CLI code into a reusable component that could be used on the serverside without a standard input attached." So obviously, this was done on purpose - this stuff is supposed to be in the CLI and the server. Therefore, I doubt it will be trivial to actually REMOVE this circular dependency, since its obviously done on purpose that this client-api is meant to be in the CLI and server. Here is the original BZ that was being worked that led to the creation of this bug: https://bugzilla.redhat.com/show_bug.cgi?id=788603 Here's the commit where this was fixed in the release branch: 4e86eace4a3f0511afee26db461720d2988 It should be noted that this issue showed up because we were doing special product branding steps for a JON release. I am not certain if this fix needs to be applied for an RHQ community release build. looks like this was already fixed in master by jay on 2/9/2012 - see commit 34d9cc0624bc871b6092acc27a734751c7823566 When I say fixed, I mean the same maven exclusions were added to the ear pom as was done in the release branch. the circular dependency still exists, which on the face of it seems correct - since both need each other. this was fixed and verified earlier. Bulk closing of old issues in VERIFIED state. |