Bug 789250

Summary: Create a test case and enable symlink validation code
Product: [Community] PulpDist Reporter: Nick Coghlan <ncoghlan>
Component: Pulp PluginsAssignee: Nick Coghlan <ncoghlan>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecified   
Target Milestone: 0.1.0   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-15 01:18:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Nick Coghlan 2012-02-10 07:52:52 UTC
The previous version of the sync algorithm included a check that validated symlinks. However, I'm not entirely sure *what* it was trying to guard against, so I don't know how to craft a good test case for it.

Comment 1 Nick Coghlan 2012-02-10 08:35:28 UTC
On closer inspection, the test case just needs to cover all the cases handled by the link validator:
- if the link target doesn't exist locally or isn't a directory don't do anything beyond the default rsync handling
- if the link target is a directory that also exists locally, then:
  - ensure a local symlink that points to the wrong place is overwritten with a new symlink
  - ensure a local directory that collides with the symlink name is overwritten (unless guarded by a PROTECTED file, OR the link target is itself a symlink that points back to the existing local directory. In the latter case, report a SYNC_PARTIAL to indicate that there's something weird going on that may require manual adjustment)