Bug 789278
Summary: | Issues reported by Coverity static analysis tool | |||
---|---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Ujjwala <ujjwala> | |
Component: | build | Assignee: | bugs <bugs> | |
Status: | CLOSED UPSTREAM | QA Contact: | ||
Severity: | high | Docs Contact: | ||
Priority: | medium | |||
Version: | mainline | CC: | gluster-bugs, hchiramm, nladha, srangana, sunkumar | |
Target Milestone: | --- | Keywords: | Reopened, Tracking, Triaged | |
Target Release: | --- | |||
Hardware: | x86_64 | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1122834 1215026 1352281 (view as bug list) | Environment: | ||
Last Closed: | 2020-03-19 22:12:34 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1215026, 1352281 |
Description
Ujjwala
2012-02-10 09:32:26 UTC
CHANGE: http://review.gluster.com/3145 (core: coverity issues fixed) merged in master by Anand Avati (avati) Analysis summary report: ------------------------ Files analyzed : 227 Total LoC input to cov-analyze : 234721 Functions analyzed : 6735 Paths analyzed : 1201804 Defect occurrences found : 345 Total 4 ARRAY_VS_SINGLETON (HIGH) 1 CHAR_IO 38 CHECKED_RETURN 48 DEADCODE 106 FORWARD_NULL 5 MISSING_BREAK 7 NEGATIVE_RETURNS 22 NO_EFFECT 6 NULL_RETURNS 3 OVERRUN_STATIC (HIGH) 74 RESOURCE_LEAK (HIGH) 13 REVERSE_INULL 2 STRAY_SEMICOLON 1 UNINIT (HIGH) 4 UNREACHABLE 5 UNUSED_VALUE 6 VARARGS ------------------------- Shows that most of the HIGH issues compared to earlier codebase are fixed now. Other than 'RESOURCE LEAK', we have most of the HIGH issues as false positive. http://review.gluster.com/3265 && http://review.gluster.com/3266 sent, but looking at it, its better to take this bug as a ERRATA fix, and not a release blocker, because the changes involved to fix all of these are significant code change (and touches most part of the code), so QA will become very serious problem. Taking it off the 'beta' blocker list. CHANGE: http://review.gluster.com/3266 (geo-replication: coverity resource leak fixes) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3345 (geo-rep / gsyncd.c: fix coverity fix) merged in master by Vijay Bellur (vijay) Keep this open till we fix all the valid coverity warnings. releng-test1.englab.brq.redhat.com/covscan/task/757/ CHANGE: http://review.gluster.com/3589 (xlator options: remove overwritten data-self-heal initializer) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3594 (nfs-common: don't let 0-length path cause buf[-1] access) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3591 (glusterd: avoid buffer overrun for over-long volname) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3596 (gsyncd: don't let a bogus config file make us read/write buf[-1]) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3603 (read_conf: don't let a corrupt config file cause invalid line[-1] reference) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3646 (cli: print_brick_status: don't smash stack) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3606 (cli: cli_cmd_get_confirmation: don't reference answer[-1] for NUL input) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3648 (glusterfsd: don't ignore tmpfile write failure (2x)) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3647 (geo-rep: don't let unexpected status provoke undefined behavior) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3669 (gsyncd: don't dereference NULL upon failed realloc) merged in master by Anand Avati (avati) CHANGE: http://review.gluster.com/3670 (cli-xml-output.c: avoid NULL-deref upon OOM) merged in master by Anand Avati (avati) considering this bug will be open forever (ie, coverity issues may be present in any versions, and will be valid for all versions), reducing the priority, and marking it as ON_DEV (to separate out from ASSIGNED state). I was not aware of this bug, so have sent some patches as RFC to fix Coverity issues. Just to keep a track, I am putting the links of the patches here. http://review.gluster.org/#/c/6626/ http://review.gluster.org/#/c/6667/ http://review.gluster.org/#/c/6313/ http://review.gluster.org/#/c/6645/ REVIEW: http://review.gluster.org/6697 (libgfapi: Fixing possible dereferencing of null pointer "glfd" Fix: Putting a check so that pointer derefrence does not happen when "gfld" is null) posted (#1) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6700 (geo-rep: Fixing null pointer dereference of "op_value") posted (#1) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6701 (core: Fixing Coverity issue "Use of uninitialized scalar variable") posted (#1) for review on master by Lalatendu Mohanty (lmohanty) COMMIT: http://review.gluster.org/6700 committed in master by Vijay Bellur (vbellur) ------ commit f3e227d525ee04a3ea0196f7a15aa9b1a8f8cae1 Author: Lalatendu Mohanty <lmohanty> Date: Tue Jan 14 23:24:50 2014 +0530 geo-rep: Fixing null pointer dereference of "op_value" Change-Id: Id39743eaa5a52cc7fd4e2a1378a23384f5ef1fed BUG: 789278 Signed-off-by: Lalatendu Mohanty <lmohanty> Reviewed-on: http://review.gluster.org/6700 Reviewed-by: Avra Sengupta <asengupt> Tested-by: Avra Sengupta <asengupt> REVIEW: http://review.gluster.org/6697 (libgfapi: Fixing possible dereferencing of null pointer "glfd") posted (#2) for review on master by Anand Avati (avati) COMMIT: http://review.gluster.org/6697 committed in master by Vijay Bellur (vbellur) ------ commit c9008fe6a1a4d9c25c4b11804bcc9e5b6edf9bec Author: Lalatendu Mohanty <lmohanty> Date: Tue Jan 14 12:35:54 2014 +0530 libgfapi: Fixing possible dereferencing of null pointer "glfd" Fix: Putting a check so that pointer derefrence does not happen when "gfld" is null Change-Id: I281b10be445bbeec3a2728fc139d5ac94372e5b6 BUG: 789278 Signed-off-by: Lalatendu Mohanty <lmohanty> Reviewed-on: http://review.gluster.org/6697 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Shyamsundar Ranganathan <srangana> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6701 (core: Fixing Coverity issue "Use of uninitialized scalar variable") posted (#2) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6701 (core: Fixing Coverity issue "Use of uninitialized scalar variable") posted (#3) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6701 (core: Coverity issue "Use of uninitialized scalar variable") posted (#4) for review on master by Lalatendu Mohanty (lmohanty) COMMIT: http://review.gluster.org/6701 committed in master by Vijay Bellur (vbellur) ------ commit 1ffc3ac9639e25c91ac26488b648d5523becb08e Author: Lalatendu Mohanty <lmohanty> Date: Tue Jan 14 23:50:51 2014 +0530 core: Coverity issue "Use of uninitialized scalar variable" Issue: 1. In "unlink (export_path)" "export_path" might contain an arbitrary value left from earlier computations. 2. In "(msg[0] != '\0')" msg might contain an arbitrary value Change-Id: Icca8f557fd6b5e046dff1d5a84a72061975868d0 BUG: 789278 Signed-off-by: Lalatendu Mohanty <lmohanty> Reviewed-on: http://review.gluster.org/6701 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6738 (posix: Fix an incorrect alloca found by Coverity) posted (#1) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6739 (posix: Fix an incorrect alloca found by Coverity) posted (#1) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6740 (geo-rep: Fixing a memory leak issue reported by Coverity) posted (#1) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6741 (quota: Fixing an incorrect GF_FREE on an array type value) posted (#1) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6743 (mgmt: Fix resource leak found by Coverity.) posted (#1) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6749 (Fix for dereference null pointer Checking of frame before calling STACK_DESTROY (frame->root) Signed-off-by: surabhi <sbhaloth>) posted (#1) for review on master by Surabhi Bhalothia (surabhi.bhalothia) REVIEW: http://review.gluster.org/6749 (core: Fix for dereference null pointer Checking of frame before calling STACK_DESTROY (frame->root) Signed-off-by: surabhi <sbhaloth>) posted (#2) for review on master by Surabhi Bhalothia (surabhi.bhalothia) REVIEW: http://review.gluster.org/6749 (core:Fixing NULL dereference issue Checking of frame before calling STACK_DESTROY (frame->root) Signed-off-by: surabhi <sbhaloth>) posted (#3) for review on master by Surabhi Bhalothia (surabhi.bhalothia) REVIEW: http://review.gluster.org/6749 (core:Fixing NULL dereference issue.) posted (#4) for review on master by Surabhi Bhalothia (surabhi.bhalothia) REVIEW: http://review.gluster.org/6754 (glusterd: Fix memory leak of hostname.) posted (#1) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6755 (mgmt: Fix memory leak of brickid from gf_asprintf.) posted (#1) for review on master by Ira Cooper (ira) COMMIT: http://review.gluster.org/6754 committed in master by Vijay Bellur (vbellur) ------ commit 2fe405c808fdbc9109bced9ec52be9d79ca321e7 Author: Ira Cooper <ira> Date: Tue Jan 21 20:42:22 2014 -0500 glusterd: Fix memory leak of hostname. The if causes a goto that allows the GF_FREE to be missed. BUG: 789278 Change-Id: Ic2c20b7623ea880b8ab2d11ebe510a62633a036d CID: 1124785 Signed-off-by: Ira Cooper <ira> Reviewed-on: http://review.gluster.org/6754 Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Gluster Build System <jenkins.com> COMMIT: http://review.gluster.org/6749 committed in master by Vijay Bellur (vbellur) ------ commit 57edad947b4c43d7c8f05bac45c8e63c788f43ca Author: surabhi <sbhaloth> Date: Tue Jan 21 14:55:29 2014 +0530 core:Fixing NULL dereference issue. 1.Checking of frame before calling STACK_DESTROY (frame->root) Signed-off-by: surabhi <sbhaloth> Change-Id: I21d27a8b4e556c00cd123afe8512e010a1a1f80d BUG: 789278 Signed-off-by: surabhi <sbhaloth> Reviewed-on: http://review.gluster.org/6749 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6763 (libgfapi: Fix pointer dereference before NULL check) posted (#1) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6769 (cluster/stripe: Remove redundant code blocks) posted (#1) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6769 (cluster/stripe: Remove redundant code blocks) posted (#2) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6771 (cluster/dht: goto statements may cause loop exit before memory is freed.) posted (#1) for review on master by Christopher R. Hertel (crh) COMMIT: http://review.gluster.org/6769 committed in master by Vijay Bellur (vbellur) ------ commit 3340a896a15fdfbfff2777f3f53a472eb62ae2e9 Author: Christopher R. Hertel <crh> Date: Thu Jan 23 13:43:14 2014 -0600 cluster/stripe: Remove redundant code blocks This appears to have been a cut&paste error. The same set of 12 lines was repeated three times, causing a pointer to allocated memory to be overwritten twice resulting in a memory leak. This patch removes the redundant code. BUG: 789278 CID: 1128915 Change-Id: I3e4a3703b389c00e2a4e99e0a7368c5a3dda74d0 Signed-off-by: Christopher R. Hertel <crh> Reviewed-on: http://review.gluster.org/6769 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/6771 committed in master by Vijay Bellur (vbellur) ------ commit 4ac61e7354d0c79e235e1b3be269a989ee0a83e6 Author: Christopher R. Hertel <crh> Date: Thu Jan 23 15:37:09 2014 -0600 cluster/dht: goto statements may cause loop exit before memory is freed. Memory is allocated at the top of the while loop via a call to gf_strdup(), but there are several goto calls that exit the loop, and the memory is not freed before each of those calls to goto. This fix moves the final call to GF_FREE() higher in the loop so that the memory is correctly freed. Two variables, dup_str and str_tmp1, point to portions of the allocated memory. Neither are used past the final call to GF_FREE( dup_str ). BUG: 789278 CID: 1124780 Change-Id: Id24b80cdbfd8b8855c80fffec63d7fce98cbed4a Signed-off-by: Christopher R. Hertel <crh> Reviewed-on: http://review.gluster.org/6771 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/6763 committed in master by Vijay Bellur (vbellur) ------ commit bb63256b7ea1f186bbe3fae9040a6c191c9d6544 Author: Jose A. Rivera <jarrpa> Date: Wed Jan 22 21:51:42 2014 -0600 libgfapi: Fix pointer dereference before NULL check Call to dict_keys_join dereferences xattr before it is checked for NULL. Restructured the function to check for NULL earlier and call dict_unref only when needed. BUG: 789278 CID: 1124826 Change-Id: I732fa304ad6f3b921c589832d13f73bbd36f589c Signed-off-by: Jose A. Rivera <jarrpa> Reviewed-on: http://review.gluster.org/6763 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6778 (nfs/server: Logic error in mount tab handling.) posted (#1) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6779 (glusterd: Free leaked error message.) posted (#1) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6780 (glusterd: Free dup_value when error path is taken.) posted (#1) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6782 (libgfapi: Fix pointer dereference before NULL check) posted (#1) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6783 (libgfapi: Remove useless call to lstat) posted (#1) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6784 (glusterd: Free op_errstr before it goes out of scope.) posted (#1) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6755 (mgmt: Fix memory leak of brickid from gf_asprintf.) posted (#2) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6783 (libgfapi: Remove useless call to lstat) posted (#2) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6782 (libgfapi: Fix pointer dereference before NULL check) posted (#2) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6783 (libgfapi: Remove useless call to lstat) posted (#3) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6787 (cluster/dht: goto statements may cause loop exit before memory is freed.) posted (#1) for review on master by Christopher R. Hertel (crh) COMMIT: http://review.gluster.org/6782 committed in master by Anand Avati (avati) ------ commit 8814fdafab377139cdf3863096234f4d5b6e543e Author: Jose A. Rivera <jarrpa> Date: Fri Jan 24 09:56:17 2014 -0600 libgfapi: Fix pointer dereference before NULL check ctx is not checked for NULL before it is dereferenced, though the check in "err" seems to suggest we should guard against it. BUG: 789278 CID: 1124827 Change-Id: I6ed0b42992af5f370cce9aa2feb56811cdd54b42 Signed-off-by: Jose A. Rivera <jarrpa> Reviewed-on: http://review.gluster.org/6782 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6783 committed in master by Anand Avati (avati) ------ commit c0ac21222383315b9fe84ac7c0afdf01e3ecef7b Author: Jose A. Rivera <jarrpa> Date: Fri Jan 24 10:00:02 2014 -0600 libgfapi: Remove useless call to lstat There's no need to lstat cmd_args->volfile, since we already check to see if fopen fails. The error message was largely the same. BUG: 789278 CID: 1124869 Change-Id: I10827154b32c72d2e4a1ab0d3c1e464f8af6ffee Signed-off-by: Jose A. Rivera <jarrpa> Reviewed-on: http://review.gluster.org/6783 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6755 committed in master by Anand Avati (avati) ------ commit 1968ec12e62a22fc6e55c4bcc7170d036bf28932 Author: Ira Cooper <ira> Date: Tue Jan 21 22:46:59 2014 -0500 mgmt: Fix memory leak of brickid from gf_asprintf. No GF_FREE, so one was put into the return path with proper checking. Change-Id: Idde2803608409dcbf216062f83b7f4493946ba70 CID: 1124718 BUG: 789278 Signed-off-by: Ira Cooper <ira> Reviewed-on: http://review.gluster.org/6755 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6779 committed in master by Anand Avati (avati) ------ commit 580d91eb563e8d8a9eb11dbe1c285541c70dbe16 Author: Ira Cooper <ira> Date: Fri Jan 24 09:54:19 2014 -0500 glusterd: Free leaked error message. The way the previous code was written you couldn't tell if the string was from the data area, or allocated, so we switched how the error message is printed, and now free unconditionally. Change-Id: Ia83cf9893acdfb5d537a61cc0bbf4aa7689e483d CID: 1124704 BUG: 789278 Signed-off-by: Ira Cooper <ira> Reviewed-on: http://review.gluster.org/6779 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6778 committed in master by Anand Avati (avati) ------ commit 0f6fb218e41e3f5d2a1b76b217197b2ca7597ff7 Author: Ira Cooper <ira> Date: Fri Jan 24 09:25:58 2014 -0500 nfs/server: Logic error in mount tab handling. This error likely causes a double free and also a memory leak. Change-Id: I299209a8b5bf8aaf487e52e9a4f00948e1d40eb5 CID: 1124703 BUG: 789278 Signed-off-by: Ira Cooper <ira> Reviewed-on: http://review.gluster.org/6778 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6784 committed in master by Anand Avati (avati) ------ commit d9fbebde0d2ae166c750121f807c440f6ea65478 Author: Ira Cooper <ira> Date: Fri Jan 24 11:24:28 2014 -0500 glusterd: Free op_errstr before it goes out of scope. Also removed the NULL check on path_list, as it shouldn't be needed. Change-Id: I5b655f7b383f301afa8fc1c1c09b31e2afe47f0f CID: 1138527 BUG: 789278 Signed-off-by: Ira Cooper <ira> Reviewed-on: http://review.gluster.org/6784 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> REVIEW: http://review.gluster.org/6787 (cluster/dht: goto statements may cause loop exit before memory is freed.) posted (#2) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6799 (libglusterfs:Fixing Dereference NULL return value. Checking of data for NULL.) posted (#1) for review on master by Surabhi Bhalothia (surabhi.bhalothia) REVIEW: http://review.gluster.org/6799 (libglusterfs:Fixing Dereference NULL return value.) posted (#2) for review on master by Surabhi Bhalothia (surabhi.bhalothia) REVIEW: http://review.gluster.org/6799 (libglusterfs:Fixing Dereference NULL return value.) posted (#3) for review on master by Surabhi Bhalothia (surabhi.bhalothia) REVIEW: http://review.gluster.org/6822 (performance/io-cache: Fix dereferencing of freed pointer) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6823 (quick-read: Remove unref of a freed iobuf.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6824 (features/qemu-block: Remove unref of freed iobuf) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6826 (cluster/dht: Abandoned memory if a call fails) posted (#1) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6827 (performance/quick-read: Allocated memory not freed when not used.) posted (#1) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6828 (features/index: Loop exit without freeing in-use memory.) posted (#1) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6829 (cli: Fixing resource leak) posted (#1) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6829 (cli: Fixing resource leak) posted (#2) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6826 (cluster/dht: Abandoned memory if a call fails) posted (#2) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6741 (quota: Fixing a possibility of GF_FREE on an array pointer) posted (#2) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6852 (gNFS: Coverity fix) posted (#1) for review on master by Santosh Pradhan (spradhan) REVIEW: http://review.gluster.org/6780 (glusterd: Free dup_value when error path is taken.) posted (#2) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6852 (gNFS: Coverity fix) posted (#2) for review on master by Santosh Pradhan (spradhan) REVIEW: http://review.gluster.org/6852 (gNFS: Coverity fix) posted (#3) for review on master by Santosh Pradhan (spradhan) REVIEW: http://review.gluster.org/6741 (quota: Fixing a possibility of GF_FREE on an array pointer) posted (#3) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6739 (posix: Fix allocation of struct dirent.) posted (#2) for review on master by Ira Cooper (ira) COMMIT: http://review.gluster.org/6824 committed in master by Anand Avati (avati) ------ commit 410fe979b4e2492f04e9cc8949f5ef5041e1135a Author: Poornima <pgurusid> Date: Thu Jan 23 22:55:45 2014 +0000 features/qemu-block: Remove unref of freed iobuf Change-Id: I507a6504b379eef54be77b54d6e2beee63975ebf BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6824 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra Talur <rtalur> Reviewed-by: Anand Avati <avati> REVIEW: http://review.gluster.org/6739 (posix: Fix allocation of struct dirent.) posted (#3) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6799 (libglusterfs:Fixing Dereference NULL return value.) posted (#4) for review on master by Surabhi Bhalothia (surabhi.bhalothia) REVIEW: http://review.gluster.org/6799 (libglusterfs:Fixing Dereference NULL return value.) posted (#5) for review on master by Surabhi Bhalothia (surabhi.bhalothia) REVIEW: http://review.gluster.org/6868 (Fix for 'use after free' errors reported by coverity.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6869 (performance/io-cache: Fix for the bugs reported by coverity) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6870 (changelog: Restrict length of unix socket files to UNIX_PATH_MAX.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6870 (changelog: Restrict length of unix socket files to UNIX_PATH_MAX.) posted (#2) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6881 (mgmt/glusterd: Fix double free.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6826 (cluster/dht: Abandoned memory if a call fails) posted (#3) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6828 (features/index: Loop exit without freeing in-use memory.) posted (#2) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6828 (features/index: Loop exit without freeing in-use memory.) posted (#3) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6826 (cluster/dht: Abandoned memory if a call fails) posted (#4) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6826 (cluster/dht: Abandoned memory if a call fails) posted (#5) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6883 (features/index: Close directories left open on error.) posted (#1) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6826 (cluster/dht: Abandoned memory if a call fails) posted (#6) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6884 (libglusterfs: Allow all valid file handle values to be closed.) posted (#1) for review on master by Christopher R. Hertel (crh) REVIEW: http://review.gluster.org/6852 (gNFS: Coverity fix) posted (#4) for review on master by Santosh Pradhan (spradhan) COMMIT: http://review.gluster.org/6740 committed in master by Vijay Bellur (vbellur) ------ commit f676d5a3e037a205c93751b862b856b7639058c4 Author: Lalatendu Mohanty <lmohanty> Date: Mon Jan 20 19:24:31 2014 +0530 geo-rep: Fixing a memory leak issue reported by Coverity Issue: "errmsg" is allocated memory through GF_CALLOC in function "gf_strdup" Fix: using GF_FREE to free the memory Change-Id: Iee8f8d806ea995591feee8e4ed0a0798ad07a8c4 BUG: 789278 Signed-off-by: Lalatendu Mohanty <lmohanty> Reviewed-on: http://review.gluster.org/6740 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Venky Shankar <vshankar> REVIEW: http://review.gluster.org/6852 (gNFS: Coverity fix for possible memory leak) posted (#5) for review on master by Santosh Pradhan (spradhan) REVIEW: http://review.gluster.org/6890 (gNFS: Possible NULL pointer dereference) posted (#1) for review on master by Santosh Pradhan (spradhan) REVIEW: http://review.gluster.org/6893 (features/quota: Fix the "Data race condition" reported by coverity.) posted (#1) for review on master by Poornima G (pgurusid) COMMIT: http://review.gluster.org/6826 committed in master by Anand Avati (avati) ------ commit d2b0a016e713aea8920abe23f6113517d78e260a Author: Christopher R. Hertel <crh> Date: Mon Jan 27 14:52:37 2014 -0600 cluster/dht: Abandoned memory if a call fails If the call to dict_set_dynstr() fails, the memory indicated by xattr_buf will not have been stored in the dictionary, so it must be freed. Patch set 2: Added a missed call to GF_FREE(). Fixed a formatting consistency issue. Patch set 3: Cleaned a minor style nit. BUG: 789278 CID: 1124786 Change-Id: Id1f85bd2cbfac0b8727a3f6901f0a50ba921817d Signed-off-by: Christopher R. Hertel <crh> Reviewed-on: http://review.gluster.org/6826 Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6741 committed in master by Anand Avati (avati) ------ commit 33e9e8fcb98cd8ddd483b37ff7114ea9fd8d75fb Author: Lalatendu Mohanty <lmohanty> Date: Tue Jan 21 02:27:03 2014 +0530 quota: Fixing a possibility of GF_FREE on an array pointer Issue: when the charecter pointer is not heap allocated by the program we should not do GF_FREE on it. Change-Id: Ibccc25491a9ab924fd5b82c14566f551a061ec2e BUG: 789278 Signed-off-by: Lalatendu Mohanty <lmohanty> Reviewed-on: http://review.gluster.org/6741 Reviewed-by: Raghavendra G <rgowdapp> Reviewed-by: Vijay Bellur <vbellur> Tested-by: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/6829 (cli: Fixing a resource leak) posted (#3) for review on master by Lalatendu Mohanty (lmohanty) REVIEW: http://review.gluster.org/6890 (gNFS: Possible NULL pointer dereference) posted (#2) for review on master by Santosh Pradhan (spradhan) REVIEW: http://review.gluster.org/6900 (changelog: When connection is unsuccessful, close socket too.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6901 (glusterd: Fix the NULL dereference errors reported by coverity.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6902 (glusterd: Fix a memory leak.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6890 (gNFS: Possible NULL pointer dereference) posted (#3) for review on master by Santosh Pradhan (spradhan) COMMIT: http://review.gluster.org/6828 committed in master by Vijay Bellur (vbellur) ------ commit 21a83b8be06aa73f40b83b9cfc97dc8a1972190a Author: Christopher R. Hertel <crh> Date: Mon Jan 27 17:49:29 2014 -0600 features/index: Loop exit without freeing in-use memory. If the while loop is exited via the goto, the call to closedir(3) is skipped, leaving an open directory stream. This patch ensure that the directory is closed if the loop is exited via the goto. BUG: 789278 CID: 1124763 Change-Id: Iec5da4b8d32c0a93c10d035ff38d0c063fd97cda Signed-off-by: Christopher R. Hertel <crh> Reviewed-on: http://review.gluster.org/6828 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/6799 committed in master by Vijay Bellur (vbellur) ------ commit 7282094c5f387d7be1a353c7ed19c8e4a1e49eec Author: surabhi <sbhaloth> Date: Mon Jan 27 14:09:10 2014 +0530 libglusterfs:Fixing Dereference NULL return value. 1.Checking of data for NULL. Change-Id: If49513f7c3fd1dc443c05dc62ed07d3254059e6e BUG: 789278 Signed-off-by: surabhi <sbhaloth> Reviewed-on: http://review.gluster.org/6799 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6905 (glusterd/geo-rep: Fix the resource leaks.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6905 (glusterd/geo-rep: Fix the resource leaks.) posted (#2) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6906 (cluster/afr: Fix memory leak.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6907 (features/quota: Fix NULL dereference error reported by coverity.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6905 (glusterd/geo-rep: Fix the resource leaks.) posted (#3) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6908 (libgfapi: Move two NULL checks up to a sensible common point.) posted (#1) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6909 (libgfapi: Remove uneccessary NULL check.) posted (#1) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#1) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#2) for review on master by Jose A. Rivera (jarrpa) COMMIT: http://review.gluster.org/6881 committed in master by Vijay Bellur (vbellur) ------ commit 60c1fa2ada704343c841b9a95d3f1cc1632fa00a Author: Poornima <pgurusid> Date: Fri Jan 31 01:12:32 2014 +0000 mgmt/glusterd: Fix double free. Change-Id: I7a8b7772849715b019c86c6c768f33c1d9dcb27c BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6881 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6905 (glusterd/geo-rep: Fix the resource leaks.) posted (#4) for review on master by Poornima G (pgurusid) COMMIT: http://review.gluster.org/6868 committed in master by Vijay Bellur (vbellur) ------ commit e021078220c30e781ef016b42f8cee8229042bb1 Author: Poornima <pgurusid> Date: Thu Jan 30 02:23:13 2014 +0000 Fix for 'use after free' errors reported by coverity. Change-Id: I941fc89b2d696c7f227330321ed4bba3ed1deac4 BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6868 Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6906 (cluster/afr: Fix memory leak.) posted (#2) for review on master by Poornima G (pgurusid) COMMIT: http://review.gluster.org/6884 committed in master by Vijay Bellur (vbellur) ------ commit e3162ed7e91510185316eae36f5c2c25bde53a68 Author: Christopher R. Hertel <crh> Date: Fri Jan 31 15:11:37 2014 -0600 libglusterfs: Allow all valid file handle values to be closed. Zero (0) is a valid file handle. The code, as written, interprets return values of open(2) that are less than or equal to zero to indicate an error. Only -1 indicates an error. BUG: 789278 CID: 1124756 Change-Id: Ie77c25f1f557d5d5adcec464b49dc7df2e3dc7e5 Signed-off-by: Christopher R. Hertel <crh> Reviewed-on: http://review.gluster.org/6884 Reviewed-by: Lalatendu Mohanty <lmohanty> Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/6870 committed in master by Vijay Bellur (vbellur) ------ commit 3bc23e1ad08e212538d325ec0196ec7488ae7e62 Author: Raghavendra Talur <rtalur> Date: Thu Jan 30 19:50:06 2014 +0530 changelog: Restrict length of unix socket files to UNIX_PATH_MAX. Bug fix for Coverity-CID 1124847. Change-Id: I410ef8e06cbc491b1f72535298fae5e9bc77220d BUG: 789278 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/6870 Reviewed-by: Venky Shankar <vshankar> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6929 (cluster/afr: goto statements may cause exit before memory is freed.) posted (#1) for review on master by Christopher R. Hertel (chertel) REVIEW: http://review.gluster.org/6931 (libgfapi: Don't ignore return value of glfs_loc_touchup()) posted (#1) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6929 (cluster/afr: goto statements may cause exit before memory is freed.) posted (#2) for review on master by Christopher R. Hertel (chertel) REVIEW: http://review.gluster.org/6933 (libglusterfs..xlator.c: Close a library handle.) posted (#1) for review on master by Christopher R. Hertel (chertel) COMMIT: http://review.gluster.org/6900 committed in master by Vijay Bellur (vbellur) ------ commit 432f7e45b2ddf511660d269548f248217a2b45ad Author: Raghavendra Talur <rtalur> Date: Tue Feb 4 15:57:05 2014 +0530 changelog: When connection is unsuccessful, close socket too. Bug fix for Coverity CID: 1124791 Change-Id: I0362d45123ebc250290f3a5231f7fb113fa41212 BUG: 789278 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/6900 Reviewed-by: Krishnan Parthasarathi <kparthas> Reviewed-by: Santosh Pradhan <spradhan> Reviewed-by: Venky Shankar <vshankar> Tested-by: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/6937 (glusterfsd: Remove dead code.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6908 (libgfapi: Move two NULL checks up to a sensible common point.) posted (#2) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6909 (libgfapi: Remove uneccessary NULL check.) posted (#2) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#3) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#4) for review on master by Jose A. Rivera (jarrpa) COMMIT: http://review.gluster.org/6890 committed in master by Vijay Bellur (vbellur) ------ commit 9f699ccd42712e5b991bd33319caf1e5c902f894 Author: Santosh Kumar Pradhan <spradhan> Date: Mon Feb 3 15:12:22 2014 +0530 gNFS: Possible NULL pointer dereference In NFS-ACL code (acl3.c) i.e. acl3svc_setacl(), contol can go to "acl3err" block from setaclargs.mask validation or acl3_validate_gluster_fh() and acl3_map_fh_to_volume() macros. But at this point of time "cs" is yet to be init'd (the macro acl3_handle_call_state_init() is not yet invoked) which can cause a NULL ptr deref. FIX: Refactor the acl3 code. Coverity ID (CID): 1124491 Change-Id: I3aca38770e03ce59d1705653b6d8349e6cc153b2 BUG: 789278 Signed-off-by: Santosh Kumar Pradhan <spradhan> Reviewed-on: http://review.gluster.org/6890 Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/6901 committed in master by Vijay Bellur (vbellur) ------ commit 9433cc43efd8d63b66ce5c0927a7bde01a6b7304 Author: Poornima <pgurusid> Date: Tue Feb 4 05:55:02 2014 +0000 glusterd: Fix the NULL dereference errors reported by coverity. Change-Id: I51c120dfe2db44a2b74f35e5cafb4f364ed6e66e BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6901 Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6787 (cluster/dht: goto statements may cause loop exit before memory is freed.) posted (#3) for review on master by Christopher R. Hertel (chertel) REVIEW: http://review.gluster.org/6940 (xlators/rot-13: Free memory when returning on error.) posted (#1) for review on master by Christopher R. Hertel (chertel) COMMIT: http://review.gluster.org/6823 committed in master by Vijay Bellur (vbellur) ------ commit 38e23d727a8fb5a4d688d9f8dc9178e6718215f5 Author: Poornima <pgurusid> Date: Thu Jan 23 02:08:19 2014 +0000 quick-read: Remove unref of a freed iobuf. Change-Id: Ie21414658db571c9a483730b6d5e8997f04255c1 BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6823 Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Gluster Build System <jenkins.com> COMMIT: http://review.gluster.org/6883 committed in master by Vijay Bellur (vbellur) ------ commit 13b68bc693e92378f78f452763a6097bf1755072 Author: Christopher R. Hertel <crh> Date: Fri Jan 31 12:13:30 2014 -0600 features/index: Close directories left open on error. Two directory streams are opened, but not always closed if the function exits with an error. This patch aims to ensure that the directories are closed in call cases. Some return values may be explicitly discarded. This is done to avoid having a successful call to closedir() overwrite the value of ret. Also, the errno value is preserved in case a calling function needs to check errno. BUG: 789278 CID: 1124710 CID: 1124711 Change-Id: I6bf3b5c9c6a1ec9a99cc9178243ea98572c2bac2 Signed-off-by: Christopher R. Hertel <crh> Reviewed-on: http://review.gluster.org/6883 Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6852 (gNFS: Coverity fix for possible memory leak) posted (#6) for review on master by Santosh Pradhan (spradhan) COMMIT: http://review.gluster.org/6902 committed in master by Anand Avati (avati) ------ commit 032854831a3dd338d7d5aee9228937d0418b8876 Author: Raghavendra Talur <rtalur> Date: Tue Feb 4 18:26:57 2014 +0530 glusterd: Fix a memory leak. errmsg may have malloc'ed memory, free it before leaving function. Change-Id: I4ab3b9db7a48a5e256eb8a08b8ab49818ce6ca1b BUG: 789278 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/6902 Reviewed-by: Poornima G <pgurusid> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6906 committed in master by Vijay Bellur (vbellur) ------ commit f32e00692e2dd2b375c95d26f69529d48d1d2a80 Author: Poornima <pgurusid> Date: Wed Feb 5 00:15:33 2014 +0000 cluster/afr: Fix memory leak. Change-Id: I811d104684905a5a9a794cde8e925bd1a97f6546 BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6906 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/6931 committed in master by Anand Avati (avati) ------ commit ff28179310c761a77210f1294cd2db70555fdad8 Author: Jose A. Rivera <jarrpa> Date: Thu Feb 6 14:19:43 2014 -0600 libgfapi: Don't ignore return value of glfs_loc_touchup() BUG: 789278 CID: 1124353 Change-Id: I7d2958cbc98faf45d723f17868c515762c50c618 Signed-off-by: Jose A. Rivera <jarrpa> Reviewed-on: http://review.gluster.org/6931 Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6933 committed in master by Anand Avati (avati) ------ commit 104e8df41073036eb47583503035bad298bdbe87 Author: Christopher R. Hertel <crh> Date: Thu Feb 6 19:32:35 2014 -0600 libglusterfs..xlator.c: Close a library handle. Simple fix to ensure that a library handle is closed if it is not actually used. BUG: 789278 CID: 1124783 Change-Id: Ia3e734c46e1ad8c97cb8cc7f1a5616606bfbc550 Signed-off-by: Christopher R. Hertel <crh> Reviewed-on: http://review.gluster.org/6933 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6827 committed in master by Anand Avati (avati) ------ commit 8b5b2bfcda0dc95aa170b8752ad97d94701172f2 Author: Christopher R. Hertel <crh> Date: Mon Jan 27 16:38:14 2014 -0600 performance/quick-read: Allocated memory not freed when not used. If memory is successfully allocated in the call to qr_content_extract(), but is not used, it is not being freed. This patch frees the allocated memory if it is not passed to qr_content_refresh(). BUG: 789278 CID: 1124735 Change-Id: I1c1f03a3b92fa26321ec6ee8822e6fa41da79875 Signed-off-by: Christopher R. Hertel <crh> Reviewed-on: http://review.gluster.org/6827 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> REVIEW: http://review.gluster.org/6949 (io-cache: Unlock and then goto out in failure case.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6950 (protocol: Fix the possible memory leak.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6951 (cluster/stripe: Fix the resource leaks.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6950 (protocol: Fix a possible memory leak.) posted (#2) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#5) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#6) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6954 (glusterd: Fix possible leaks on failure code path) posted (#1) for review on master by Santosh Pradhan (spradhan) REVIEW: http://review.gluster.org/6954 (glusterd: Fix possible leaks on failure code path) posted (#2) for review on master by Santosh Pradhan (spradhan) COMMIT: http://review.gluster.org/6929 committed in master by Vijay Bellur (vbellur) ------ commit c1c3ab9e4c96e059ba1abc1a0b5ba221ef6e3d8d Author: Christopher R. Hertel <crh> Date: Thu Feb 6 12:39:24 2014 -0600 cluster/afr: goto statements may cause exit before memory is freed. Memory is allocated for pump_priv and for pump_priv->resume_path, but if an error is detected the references to that memory go out of scope and the memory is never freed. This patch assures that the memory is freed on error. Patchset 2: These are Kaleb's recommended changes which, compared to my original fix, are more comprehensive and provide a more complete resolution to the memory leakage bugs in this function. The bug reported by Coverity was limited to a single memory allocation. BUG: 789278 CID: 1124737 Change-Id: Ie239e3b5d28d97308bf948efec6a92f107bc648b Signed-off-by: Christopher R. Hertel <crh> Reviewed-on: http://review.gluster.org/6929 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6909 (glusterfsd: Check for NULL before dereference.) posted (#3) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#7) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6908 (libgfapi: Add proper NULL checks) posted (#3) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6909 (glusterfsd: Check for NULL before dereference.) posted (#4) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#8) for review on master by Jose A. Rivera (jarrpa) COMMIT: http://review.gluster.org/6907 committed in master by Vijay Bellur (vbellur) ------ commit 6b8ed063bb8a551856d0e659fa9fe4f5afa48c19 Author: Poornima <pgurusid> Date: Tue Feb 4 23:11:59 2014 +0000 features/quota: Fix NULL dereference error reported by coverity. Change-Id: I48c1ebcb3261fa5da721e5b48d17c6c873df256d BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6907 Reviewed-by: Vijay Bellur <vbellur> Tested-by: Gluster Build System <jenkins.com> COMMIT: http://review.gluster.org/6869 committed in master by Vijay Bellur (vbellur) ------ commit fcfd2b973cdb9d798861bca1d30a4a42b819b73f Author: Poornima <pgurusid> Date: Thu Jan 30 05:36:42 2014 +0000 performance/io-cache: Fix for the bugs reported by coverity Change-Id: I24c10d874511a2f24dda2fb84d31f5074da1616f BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6869 Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6954 (glusterd: Fix possible leaks on failure code path) posted (#3) for review on master by Santosh Pradhan (spradhan) REVIEW: http://review.gluster.org/6780 (glusterd: Free dup_value when error path is taken.) posted (#3) for review on master by Ira Cooper (ira) REVIEW: http://review.gluster.org/6780 (glusterd: Free dup_value when error path is taken.) posted (#4) for review on master by Ira Cooper (ira) COMMIT: http://review.gluster.org/6852 committed in master by Vijay Bellur (vbellur) ------ commit 99c84c250501a676f73c0dd7e9b842f8c95b1f98 Author: Santosh Kumar Pradhan <spradhan> Date: Wed Jan 29 17:09:55 2014 +0530 gNFS: Coverity fix for possible memory leak In nfs_gfid_dict(), if dict_new() fails, the control goes to out: block and dyngfid resource (dynamically allocated by GF_CALLOC()) is leaked. Add a validation for memory returned by GF_CALLOC() Drop unnecessary "goto" statements Coverity CID: 1124764 Change-Id: Idda7923cc1c32260b3353f7a9141aa1cf43e4fe1 BUG: 789278 Signed-off-by: Santosh Kumar Pradhan <spradhan> Reviewed-on: http://review.gluster.org/6852 Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/6905 (glusterd/geo-rep: Fix the resource leaks.) posted (#5) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6984 (glusterfsd: Use gf_strdup instead of assigning a literal.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6937 (glusterfsd: Remove dead code.) posted (#2) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6937 (glusterfsd: Remove dead code.) posted (#3) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6985 (protocol/client: Fix the possible resource leaks.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6986 (cluster/stripe: Fix the possible resource leaks.) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/6990 (mount/fuse: Fix the NULL dereference errors reported by coverity.) posted (#1) for review on master by Poornima G (pgurusid) COMMIT: http://review.gluster.org/6951 committed in master by Anand Avati (avati) ------ commit db3b2149eeb44bcb716d994224d57eccf873d2a9 Author: Poornima <pgurusid> Date: Sun Feb 9 22:57:56 2014 +0000 cluster/stripe: Fix the resource leaks. Change-Id: Ieb1fe112686f4932a6272a0117c1373e736d5b4e BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6951 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6822 committed in master by Anand Avati (avati) ------ commit a9181877e3013dcaca5b59ef7764246163c10585 Author: Poornima <pgurusid> Date: Sun Jan 26 22:08:46 2014 +0000 performance/io-cache: Fix dereferencing of freed pointer Change-Id: Ic4276c6d76c36f4eb77282dc06d2b8b212b58f08 BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6822 Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Gluster Build System <jenkins.com> COMMIT: http://review.gluster.org/6954 committed in master by Anand Avati (avati) ------ commit 1b88d86a660a5f4e007fb229d79c54666ce04ffb Author: Santosh Kumar Pradhan <spradhan> Date: Mon Feb 10 20:52:57 2014 +0530 glusterd: Fix possible leaks on failure code path Fix the memory leaks in socket and glusterd in failure code paths reported by Coverity. CIDs: 1124777, 1124781, 124782 Change-Id: I63472c6b5900f308f19e64fc93bf7ed2f7b06ade BUG: 789278 Signed-off-by: Santosh Kumar Pradhan <spradhan> Reviewed-on: http://review.gluster.org/6954 Reviewed-by: Raghavendra Talur <rtalur> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6940 committed in master by Anand Avati (avati) ------ commit fbcae0d20a409bccd8fc4daeceac010fab66d0a0 Author: Christopher R. Hertel <crh> Date: Fri Feb 7 16:46:23 2014 -0600 xlators/rot-13: Free memory when returning on error. Added GF_FREE() calls to free allocated memory that was left behind otherwise. BUG: 789278 CID: 1124725 Change-Id: I5aa086d6b13a93e14de50e47e02b0e9813af9572 Signed-off-by: Christopher R. Hertel <crh> Reviewed-on: http://review.gluster.org/6940 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6986 committed in master by Vijay Bellur (vbellur) ------ commit 43f71899c4533ef6e160c7a8fb8c62bf0e6c3bba Author: Poornima <pgurusid> Date: Wed Feb 12 02:44:09 2014 +0000 cluster/stripe: Fix the possible resource leaks. Change-Id: Ic6fbc8c843f80edd7458d15229eb72a5609973a5 BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6986 Reviewed-by: Amar Tumballi <amarts> Tested-by: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/6993 (protocol/auth: Fix a possible double free.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/7000 (libglusterfs: Stat and alloc mem before reading file into memory.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/7000 (libglusterfs: Stat and alloc mem before reading file into memory.) posted (#2) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/7000 (libglusterfs: Stat and alloc mem before reading file into memory.) posted (#3) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/7002 (glusterd: Memory leaks in negative code path) posted (#1) for review on master by Santosh Pradhan (spradhan) COMMIT: http://review.gluster.org/6909 committed in master by Vijay Bellur (vbellur) ------ commit db95a98527caf1b5a52ef49e537d0ee575a9bc61 Author: Jose A. Rivera <jarrpa> Date: Wed Feb 5 09:11:55 2014 -0600 glusterfsd: Check for NULL before dereference. BUG: 789278 CID: 1124805 Change-Id: I5926a4e59790f142d65f034726c9c369c2ad7808 Signed-off-by: Jose A. Rivera <jarrpa> Reviewed-on: http://review.gluster.org/6909 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/6908 committed in master by Vijay Bellur (vbellur) ------ commit 5f0a857c70863eb685ac03d4183502d3bd460b7c Author: Jose A. Rivera <jarrpa> Date: Wed Feb 5 08:50:30 2014 -0600 libgfapi: Add proper NULL checks Two spots check for NULL after the pointer in question has already been dereferenced. Checked for NULL (and set errno when needed) at appripriate spots, added a few NULL checks further up the stack, and some whitespace cleanup. BUG: 789278 CID: 1124800 CID: 1124805 Change-Id: I1dd4ad3f285cca36f4e3f739288f154ec120aebb Signed-off-by: Jose A. Rivera <jarrpa> Reviewed-on: http://review.gluster.org/6908 Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/7002 (glusterd: Memory leaks in negative code path) posted (#2) for review on master by Santosh Pradhan (spradhan) REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#9) for review on master by Jose A. Rivera (jarrpa) COMMIT: http://review.gluster.org/6780 committed in master by Anand Avati (avati) ------ commit 5fb60ca150efbf9072dd7b2de13362c8cc4daa1b Author: Ira Cooper <ira> Date: Tue Feb 11 07:05:29 2014 -0500 glusterd: Free dup_value when error path is taken. When the error path is taken here, the data that was allocated for dup_value is never freed. This patch frees it. Thanks to Kaleb Keithley <kkeithle> for his suggestions on how to fix this. Change-Id: Iad88b9ab035602d15961b46c4954d54d54e0d65e CID: 1124705 BUG: 789278 Signed-off-by: Ira Cooper <ira> Reviewed-on: http://review.gluster.org/6780 Reviewed-by: Krishnan Parthasarathi <kparthas> Reviewed-by: Kaleb KEITHLEY <kkeithle> Tested-by: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/7002 (glusterd: Memory leaks in negative code path) posted (#3) for review on master by Santosh Pradhan (spradhan) COMMIT: http://review.gluster.org/6985 committed in master by Vijay Bellur (vbellur) ------ commit 1ad41c4ca167e4600f163408c1f859d55cdbdc07 Author: Poornima <pgurusid> Date: Wed Feb 12 03:18:43 2014 +0000 protocol/client: Fix the possible resource leaks. Change-Id: Ib86dee366f5a6f0971c6472d1fb2c32dbf7f0102 BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6985 Reviewed-by: Vijay Bellur <vbellur> Reviewed-by: Raghavendra Talur <rtalur> Tested-by: Gluster Build System <jenkins.com> COMMIT: http://review.gluster.org/6984 committed in master by Anand Avati (avati) ------ commit 82f995e6a9ba9ac4ca02d9db2f42bc9037936151 Author: Raghavendra Talur <rtalur> Date: Wed Feb 12 14:37:23 2014 +0530 glusterfsd: Use gf_strdup instead of assigning a literal. Fix for coverity bug CID:1124340 Change-Id: Ibf8700bdeaaddade02e63470a773c5fe2aabc645 BUG: 789278 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/6984 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6949 committed in master by Vijay Bellur (vbellur) ------ commit 4b36051ce195d9ae7ec32bd614d32a023873ab29 Author: Raghavendra Talur <rtalur> Date: Mon Feb 10 17:11:03 2014 +0530 io-cache: Unlock and then goto out in failure case. Fix for coverity bug CID:1124625 Change-Id: I76df453a17f2af7c48a80b6fc0ccd411ab96e371 BUG: 789278 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/6949 Reviewed-by: Santosh Pradhan <spradhan> Tested-by: Gluster Build System <jenkins.com> COMMIT: http://review.gluster.org/6990 committed in master by Vijay Bellur (vbellur) ------ commit da7972c10cd0495621ea95c186db86cfa8d997b6 Author: Poornima <pgurusid> Date: Tue Feb 4 22:52:14 2014 +0000 mount/fuse: Fix the NULL dereference errors reported by coverity. Change-Id: I9df57e11b115d7323931735c86b586c0b65fa414 BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6990 Reviewed-by: Vijay Bellur <vbellur> Tested-by: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/7025 (glusterd: Check for ctx before dereferencing it.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/7025 (glusterd: Check for ctx before dereferencing it.) posted (#2) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/6993 (protocol/auth: Fix a possible double free.) posted (#2) for review on master by Raghavendra Talur (rtalur) COMMIT: http://review.gluster.org/6993 committed in master by Anand Avati (avati) ------ commit 9e0ec224148e1d3e0406eb5aa4479f3dca0d597b Author: Raghavendra Talur <rtalur> Date: Thu Feb 13 12:31:58 2014 +0530 protocol/auth: Fix a possible double free. Assign NULL to addr_cpy to avoid double free. Fix for coverity CID: 1124891 Change-Id: I0cd6721f066170190d8b5441ecdbc1704ed5e75b BUG: 789278 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/6993 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krishnan Parthasarathi <kparthas> Reviewed-by: Anand Avati <avati> REVIEW: http://review.gluster.org/6937 (glusterfsd: Remove dead code.) posted (#4) for review on master by Raghavendra Talur (rtalur) COMMIT: http://review.gluster.org/7025 committed in master by Vijay Bellur (vbellur) ------ commit 3a5914e421d10bca363f020b748e8648a4819495 Author: Raghavendra Talur <rtalur> Date: Tue Feb 18 12:22:59 2014 +0530 glusterd: Check for ctx before dereferencing it. Fix for coverity CID: 1175010 & 1175011 Change-Id: Ib894fadf94c36704166ac0e2a3b6febf9b3fe446 BUG: 789278 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/7025 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/7167 (libglusterfs/inode: Fix NULL dereferences.) posted (#1) for review on master by Poornima G (pgurusid) COMMIT: http://review.gluster.org/7167 committed in master by Anand Avati (avati) ------ commit 9f45d0f6212d6d5c96dafc4aba73d9d12b39c3d6 Author: Poornima G <pgurusid> Date: Fri Feb 28 12:13:55 2014 +0530 libglusterfs/inode: Fix NULL dereferences. There could be scenarios where the inode_ctx_get() can be called to only check if the context exists, in such cases the buffer for the context might not have been passed. Hence fix inode_ctx_get() to not crash, when the buffer is not passed. Change-Id: I607d86eb401ccab0e5cd75f6f977c454994ec063 BUG: 789278 Signed-off-by: Poornima G <pgurusid> Reviewed-on: http://review.gluster.org/7167 Reviewed-by: Santosh Pradhan <spradhan> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6937 committed in master by Vijay Bellur (vbellur) ------ commit 2a77659e9c25cc51fed193147ba3bfea56c5f8f9 Author: Raghavendra Talur <rtalur> Date: Fri Feb 7 16:45:58 2014 +0530 glusterfsd: Remove dead code. Previous cleanup of this function had removed some lines which had left dead code. Just removing that. Fix for coverity CID: 1167461 . Change-Id: I2a34fc407ce0eb4c4ba759c8ce6574a00b37020a BUG: 789278 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/6937 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/7389 (cli : Removal of dead code) posted (#1) for review on master by Atin Mukherjee (amukherj) COMMIT: http://review.gluster.org/7389 committed in master by Vijay Bellur (vbellur) ------ commit d5072db4c56c2351437aa4c2d340bf2766e318ce Author: Atin Mukherjee <amukherj> Date: Thu Apr 3 15:10:58 2014 +0530 cli : Removal of dead code dead code reported by covscan is removed from cli-cmd-parser.c Fix for coverity CID: 1195423 Change-Id: Ice1771dc8b3ef47fd2e63b380b12e850dc1d5d95 BUG: 789278 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/7389 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krishnan Parthasarathi <kparthas> REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#10) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation.) posted (#11) for review on master by Jose A. Rivera (jarrpa) REVIEW: http://review.gluster.org/7695 ([glusterd/cli/snapshot] Fixes for coverity issues) posted (#1) for review on master by Joseph Fernandes (josferna) REVIEW: http://review.gluster.org/7695 ([glusterd/cli/snapshot] Fixes for coverity issues) posted (#2) for review on master by Joseph Fernandes (josferna) REVIEW: http://review.gluster.org/7695 ([glusterd/cli/snapshot] Fixes for coverity issues) posted (#3) for review on master by Joseph Fernandes (josferna) REVIEW: http://review.gluster.org/7695 ([glusterd/cli/snapshot] Fixes for coverity issues) posted (#4) for review on master by Joseph Fernandes (josferna) REVIEW: http://review.gluster.org/7695 ([glusterd/cli/snapshot] Fixes for coverity issues) posted (#5) for review on master by Joseph Fernandes (josferna) REVIEW: http://review.gluster.org/7743 ([glusterd/cli/snapshot] Fixes for coverity issues) posted (#1) for review on master by Joseph Fernandes (josferna) REVIEW: http://review.gluster.org/7743 ([glusterd/cli/snapshot] Fixes for coverity issues) posted (#2) for review on master by Joseph Fernandes (josferna) REVIEW: http://review.gluster.org/7695 ([glusterd/cli/snapshot] Fixes for coverity issues) posted (#6) for review on master by Joseph Fernandes (josferna) REVIEW: http://review.gluster.org/7695 ([glusterd/cli/snapshot] Fixes for coverity issues) posted (#7) for review on master by Joseph Fernandes (josferna) REVIEW: http://review.gluster.org/6950 (protocol: Fix a possible memory leak.) posted (#3) for review on master by Poornima G (pgurusid) COMMIT: http://review.gluster.org/6950 committed in master by Vijay Bellur (vbellur) ------ commit cc6608dbaabac6e46d7f36d964c861cfbaac8f59 Author: Poornima <pgurusid> Date: Sun Feb 9 23:29:23 2014 +0000 protocol: Fix a possible memory leak. Change-Id: Ia3e7e33389b4d3a5e058b6b2fb2f1c3cb224d6fd BUG: 789278 Signed-off-by: Poornima <pgurusid> Signed-off-by: Poornima G <pgurusid> Reviewed-on: http://review.gluster.org/6950 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/6905 committed in master by Vijay Bellur (vbellur) ------ commit 073264c63185c1b3af41c2b1ca6749fcd36a5e94 Author: Poornima <pgurusid> Date: Wed Feb 5 02:50:08 2014 +0000 glusterd/geo-rep: Fix the resource leaks. Change-Id: Ic741250999880bdf9e1226cd3eefa791fb66a888 BUG: 789278 Signed-off-by: Poornima <pgurusid> Reviewed-on: http://review.gluster.org/6905 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/8088 (glusterd: Coverity fix for going out of scope leaks of directory pointer) posted (#1) for review on master by Gaurav Kumar Garg (ggarg) REVIEW: http://review.gluster.org/8091 (glusterd : Coverity fix in __server_getspec) posted (#1) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/8088 (glusterd: Coverity fix for going out of scope leaks of directory pointer) posted (#2) for review on master by Gaurav Kumar Garg (ggarg) REVIEW: http://review.gluster.org/8088 (glusterd: Coverity fix for going out of scope leaks of directory pointer) posted (#3) for review on master by Gaurav Kumar Garg (ggarg) REVIEW: http://review.gluster.org/8091 (glusterd : Coverity fix in __server_getspec) posted (#2) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/8091 (glusterd : Coverity fix in __server_getspec) posted (#3) for review on master by Atin Mukherjee (amukherj) COMMIT: http://review.gluster.org/8091 committed in master by Kaushal M (kaushal) ------ commit d78d53e853e43f78c59202f1c2e761d17dad93c5 Author: Atin Mukherjee <amukherj> Date: Tue Jun 17 17:37:46 2014 +0530 glusterd : Coverity fix in __server_getspec spec_fd handle should be closed in all the possible cases CID : 1124768 Change-Id: I28390dc76a646a19258520570acef562b8d6fb1e BUG: 789278 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/8091 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Gaurav Kumar Garg <ggarg> Reviewed-by: Kaushal M <kaushal> REVIEW: http://review.gluster.org/8211 (dict: Remove the redundant hash calculation when the hash size is 1) posted (#1) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/8211 (dict: Remove the redundant hash calculation when the hash size is 1) posted (#2) for review on master by Poornima G (pgurusid) REVIEW: http://review.gluster.org/8252 (glusterd: Fix for resource leak coverity bug 1223045.) posted (#1) for review on master by Raghavendra Talur (rtalur) REVIEW: http://review.gluster.org/8252 (glusterd: Fix for resource leak coverity bug 1223045.) posted (#2) for review on master by Raghavendra Talur (rtalur) COMMIT: http://review.gluster.org/8252 committed in master by Vijay Bellur (vbellur) ------ commit f924f8e28b2d4753e4c4bc89a83d4ab330205de2 Author: Raghavendra Talur <rtalur> Date: Mon Jul 7 14:36:18 2014 +0530 glusterd: Fix for resource leak coverity bug 1223045. Change-Id: I96261e7f5cd7b5550d3100750c80190dd932a8ab BUG: 789278 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/8252 Reviewed-by: Avra Sengupta <asengupt> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Rajesh Joseph <rjoseph> REVIEW: http://review.gluster.org/8317 (ec: Fixed coveriry scan issues) posted (#1) for review on master by Xavier Hernandez (xhernandez) REVIEW: http://review.gluster.org/8317 (ec: Fixed coveriry scan issues) posted (#2) for review on master by Xavier Hernandez (xhernandez) COMMIT: http://review.gluster.org/8317 committed in master by Vijay Bellur (vbellur) ------ commit 464ff8f7592e7d6a9239ca1fab1928d4a608f253 Author: Xavier Hernandez <xhernandez> Date: Wed Jul 16 13:50:53 2014 +0200 ec: Fixed coveriry scan issues CID list: 1226163 Logically dead code 1226166 Missing break in switch 1226167 Missing break in switch 1226168 Missing break in switch 1226169 Missing break in switch 1226170 Missing break in switch 1226171 Missing break in switch 1226172 Missing break in switch 1226173 Missing break in switch 1226174 Missing break in switch 1226175 Missing break in switch 1226176 Missing break in switch 1226177 Missing break in switch 1226178 Data race condition 1226179 Data race condition 1226180 Data race condition 1226181 Thread deadlock 1226182 Uninitialized pointer read 1226183 Uninitialized pointer read 1226184 Read from pointer after free Change-Id: I4d33aa42289371927175c43bb29e018df64fb943 BUG: 789278 Signed-off-by: Xavier Hernandez <xhernandez> Reviewed-on: http://review.gluster.org/8317 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/8088 (glusterd: Coverity fix for going out of scope leaks of directory pointer) posted (#4) for review on master by Gaurav Kumar Garg (ggarg) COMMIT: http://review.gluster.org/8088 committed in master by Kaushal M (kaushal) ------ commit c03e07b4147bb2fe902be77f0bbef9c9bae977ab Author: ggarg <ggarg> Date: Tue Jun 17 16:25:03 2014 +0530 glusterd: Coverity fix for going out of scope leaks of directory pointer In function volgen_apply_filters() directory stream associated with "filterdir" should be close after opening directory stream corresponding to directory name. closedir() also closes the underlying file descriptor associated with "filterdir". Coverity CID: 1124723 Change-Id: I78ed04047ded98bf95d201afed01c727aa506882 BUG: 789278 Reviewed-on: http://review.gluster.org/8088 Reviewed-by: Atin Mukherjee <amukherj> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaushal M <kaushal> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report. glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html [2] http://supercolony.gluster.org/mailman/listinfo/gluster-users COMMIT: http://review.gluster.org/8211 committed in master by Vijay Bellur (vbellur) ------ commit 8f07191a4ab312c8b99e2eb08c7a1fc7e2c5eff2 Author: Poornima Gurusiddaiah <pgurusid> Date: Tue Jul 1 14:38:54 2014 +0530 dict: Remove the redundant hash calculation when the hash size is 1 Currently the dict is created with hash size 1, i.e. there is only one hash bucket and the calculation of hash decomes redundant. Change-Id: Id70aea0d798902494ebb6d82955d97d591bc73d2 BUG: 789278 Signed-off-by: Poornima Gurusiddaiah <pgurusid> Reviewed-on: http://review.gluster.org/8211 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra Talur <rtalur> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9208 (glusterd: Coverity fix for string_overflow overrun) posted (#1) for review on master by Gaurav Kumar Garg (ggarg) REVIEW: http://review.gluster.org/9213 (api, glusterfsd: Cleanup upon failure in glusterfs_ctx_defaults_init()) posted (#1) for review on master by Vijay Bellur (vbellur) REVIEW: http://review.gluster.org/9256 (api: revive dead code in glusterfs_ctx_defaults_init()) posted (#1) for review on master by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/9257 (nfs: prevent potential NULL dereference in mnt3_readlink_cbk()) posted (#1) for review on master by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/9257 (nfs: prevent potential NULL dereference in mnt3_readlink_cbk()) posted (#2) for review on master by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/9213 committed in master by Vijay Bellur (vbellur) ------ commit ecb58c9a3f716a87da7174c1aa721561b18ad27b Author: Vijay Bellur <vbellur> Date: Fri Nov 28 17:54:52 2014 +0530 api, glusterfsd: Cleanup upon failure in glusterfs_ctx_defaults_init() This got introduced due to 656711d935000c16. Coverity also picked this up as CIDs 1256176, 1256178, 1256180. Signed-off-by: Vijay Bellur <vbellur> Change-Id: If12fa0075634383975846181917a2f9650f790e3 BUG: 789278 Reviewed-on: http://review.gluster.org/9213 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Shyamsundar Ranganathan <srangana> COMMIT: http://review.gluster.org/9257 committed in master by Niels de Vos (ndevos) ------ commit 1877c43a6530e92ef9dee52463ddc4216a703329 Author: Niels de Vos <ndevos> Date: Tue Dec 9 12:24:38 2014 +0100 nfs: prevent potential NULL dereference in mnt3_readlink_cbk() In case 'mres' is NULL, we jump to 'mnterr' where 'mres->req' will be used. This will cause a segmentation fault, which we really do not want. Change-Id: I01d6f3aa0343def54dcd4a5610001ff7d62c8834 CID: 1256179 BUG: 789278 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/9257 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: jiffin tony Thottan <jthottan> Reviewed-by: Humble Devassy Chirammal <humble.devassy> REVIEW: http://review.gluster.org/9262 (client_t: fix for potential NULL pointer dereference) posted (#1) for review on master by Niels de Vos (ndevos) Re-opening because we still Coverity is still detecting defects. Re-opening because Coverity is still detecting defects. Latest run results are available at http://scan.coverity.com/projects/987 COMMIT: http://review.gluster.org/9262 committed in master by Niels de Vos (ndevos) ------ commit 9ca800392106201c555ff8d5e2bf7a77aa52234d Author: Niels de Vos <ndevos> Date: Wed Dec 10 11:10:52 2014 +0100 client_t: fix for potential NULL pointer dereference In case an error occurs, 'client' is free'd. The log message just before exiting the function should therefore not use the structure anymore. BUG: 789278 Change-Id: I0848328b29585057cd037a5972c4e5f06a7f978b CID: 1226165 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/9262 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> REVIEW: http://review.gluster.org/9287 (protocol/client: Prevent "Dereference after NULL check" errors.) posted (#1) for review on master by Vijay Bellur (vbellur) COMMIT: http://review.gluster.org/9287 committed in master by Vijay Bellur (vbellur) ------ commit 9ab533ff86dbf914b47228a9326fefd9ba04c65f Author: Vijay Bellur <vbellur> Date: Wed Dec 17 13:19:00 2014 +0530 protocol/client: Prevent "Dereference after NULL check" errors. Fixes 46 defects marked as "Dereference after NULL check" errors in coverity scan for client xlator. Change-Id: I0b4c991a3995ce74d7885fc5470ec7f5c589b411 BUG: 789278 Signed-off-by: Vijay Bellur <vbellur> Reviewed-on: http://review.gluster.org/9287 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krishnan Parthasarathi <kparthas> Reviewed-by: Niels de Vos <ndevos> REVIEW: http://review.gluster.org/9539 (glusterd: Coverity fix for string overflow.) posted (#1) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9540 (Cluster/afr : Coverity fix) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string from coverity check and cppcheck) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string from coverity check and cppcheck) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string from coverity check and cppcheck) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/9539 (glusterd : Coverity fix for string overflow) posted (#2) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9540 (Cluster/afr : Coverity fix) posted (#2) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string from coverity check and cppcheck.) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects Coverity IDs: 1124853 1134021 1134022 1134023) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects) posted (#2) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9555 (glusterd: Coverity fix for string overflow.) posted (#1) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9556 (Xlators/storage/bd : Unused value is removed.) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects Coverity IDs: 1124853 1134021 1134022 1134023) posted (#3) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string from coverity check and cppcheck) posted (#5) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9557 (changelog: Fixing buffer overrun coverity issues) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9558 (glusterd: Coverity fix for insecure temporary file.) posted (#1) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9555 (glusterd: Coverity fix for string overflow) posted (#2) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9563 (Xlators/dht : Divide by zero coverity fix) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9565 (libglusterfs: Fixing insecure temp file coverity issue) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9556 (xlators/storage/bd : Unused value is removed.) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/9563 (xlators/dht : divide by zero coverity fix) posted (#2) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9555 (glusterd: coverity fix for string overflow) posted (#3) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9558 (glusterd: coverity fix for insecure temporary file.) posted (#2) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9539 (glusterd : coverity fix for string overflow) posted (#3) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string from coverity check and cppcheck.) posted (#6) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string) posted (#7) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects) posted (#4) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9558 (glusterd: coverity fix for insecure temporary file) posted (#3) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9563 (xlators/dht : divide by zero coverity fix) posted (#3) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9565 (libglusterfs: Fixing insecure temp file coverity issue) posted (#2) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9571 (afr : null dereference coverity fix) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9573 (libglusterfs : null dereference coverity fix) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9574 (gluster-cli: Removing logically dead code) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9577 (gluster-cli : Fixing "argument can't be negative" coverity issue) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9579 (gluster-cli : Removing logically dead code) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9579 (gluster-cli : Removing logically dead code) posted (#2) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9581 (dht : logical error fix) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9582 (gluster-cli : Removing logically dead code) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9579 (gluster-cli : Removing logically dead code) posted (#3) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9574 (gluster-cli: Removing logically dead code) posted (#2) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9574 (gluster-cli: Coverity issue fix, removing redundant check.) posted (#3) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9582 (gluster-cli : Extra checks for word_count removed.) posted (#2) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string) posted (#8) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9565 (libglusterfs: Fixing insecure temp file coverity issue.) posted (#3) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9574 (gluster-cli: Coverity issue fix, removing redundant check.) posted (#4) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9579 (gluster-cli : Removing logically dead code.) posted (#4) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9581 (dht : logical error fix) posted (#2) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9584 (dht : logically dead code removed.) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9581 (dht : logical error fix.) posted (#3) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9581 (dht : logical error fix.) posted (#4) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9581 (dht : logical-error fix) posted (#5) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9574 (gluster-cli: Fixing operand error and removing logically dead code) posted (#5) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9586 (glusterd: coverity fix) posted (#1) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9581 (dht : logical error fix.) posted (#6) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string) posted (#9) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9587 (geo-rep: Fixing of STRING_OVERFLOW) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9555 (glusterd: coverity fix for string overflow.) posted (#4) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string) posted (#10) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9588 (bd: coverity fixes, removing logically dead code and correcting checks) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string) posted (#11) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects Coverity IDs: 1124853 1134021 1134022 1134023) posted (#5) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string) posted (#12) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9589 (geo-rep: Fixing of STRING_OVERFLOW) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9590 (geo-rep: Fixing of STRING_OVERFLOW) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9586 (glusterd: coverity fix.) posted (#2) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9565 (libglusterfs: Fixing insecure temp file coverity issue) posted (#4) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9563 (xlators/dht : divide by zero coverity fix) posted (#4) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9581 (dht : logical error fix.) posted (#7) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9574 (gluster-cli: Fixing operand error and removing logically dead code.) posted (#6) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9581 (dht : logical error fix.) posted (#8) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9581 (dht : logical error fix & Null dereference removal) posted (#9) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9590 (geo-rep: Fixing of STRING_OVERFLOW) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9581 (dht : logical error fix & null dereference fix.) posted (#10) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9577 (gluster-cli : Fixing "argument can't be negative" coverity issue.) posted (#2) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9600 (rpc-lib: Fixing the coverity issues) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9577 (gluster-cli : Fixing "argument can't be negative" coverity issue) posted (#3) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9557 (changelog: Fixing buffer overrun coverity issues) posted (#2) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9577 (gluster-cli : Fixing "argument can't be negative" coverity issue.) posted (#4) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9558 (glusterd: coverity fix for insecure temporary file) posted (#4) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9601 (protocol/client : logical dead code removed) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9581 (dht : logical error fix and null dereference fix) posted (#11) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9563 (xlators/dht : divide by zero coverity fix.) posted (#5) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9558 (glusterd: Coverity fix for insecure temporary file) posted (#5) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9557 (changelog: Fixing buffer overrun coverity issues.) posted (#3) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9563 (xlators/dht : divide by zero coverity fix.) posted (#6) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9563 (xlators/dht : divide by zero coverity fix.) posted (#7) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9563 (xlators/dht : divide by zero coverity fix.) posted (#8) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9581 (dht : logical error fix & null dereference fix.) posted (#12) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9581 (dht : logical error fix & null dereference fix.) posted (#13) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9581 (dht : logical error fix & null dereference fix.) posted (#14) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9606 (cli : logically dead code removed) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9608 (glusterfsd: coverity fix.) posted (#1) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9610 (api: coverity fix) posted (#1) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9581 (dht : logical error fix & null dereference fix) posted (#15) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9606 (cli : logically dead code removed.) posted (#2) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9571 (afr : null dereference coverity fix.) posted (#2) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9610 (api: coverity fix.) posted (#2) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9612 (features/changelog: Fixing Insecure temporary file) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9614 (marker, quota: Fixing the coverity issues) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9615 (snapview: Fixing the coverity issues) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9565 (libglusterfs: Fixing insecure temp file coverity issue) posted (#5) for review on master by Nandaja Varma (nandaja.varma) COMMIT: http://review.gluster.org/9610 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 1353aeadcd080c356a4c404dbfb10ff3f23ab4cf Author: Sakshi Bansal <sabansal> Date: Mon Feb 9 15:41:37 2015 +0530 api: coverity fix. CID 1214617: dereference NULL return value. Change-Id: I57447c3b1663edadfa966892c53bc2a16d4a166f BUG: 789278 Signed-off-by: Sakshi Bansal <sabansal> Reviewed-on: http://review.gluster.org/9610 Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/9606 (cli : logically dead code removed) posted (#3) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9581 (dht : logical error fix and null dereference fix.) posted (#16) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9617 (features/changelog: Fixing Deference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9618 (auth: Adding missing break.) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9619 (bd: Fixing dereference after null check(FORWARD_NULL)) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects) posted (#6) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9620 (rpc-transport : added missing break) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9620 (rpc-transport : added missing break.) posted (#2) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects.) posted (#7) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9608 (glusterfsd: coverity fix.) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/9622 (dht : coverity fixes) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9625 (glusterd: Fixing Dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9581 (dht : logical error fix and null dereference fix) posted (#17) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects) posted (#8) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9626 (features/changelog: Fixing Dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9626 (features/changelog: Fixing Dereference after null check.) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects.) posted (#9) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9563 (xlators/dht : divide by zero coverity fix.) posted (#9) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9622 (dht : coverity fixes) posted (#2) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9628 (dht : logical error and null dereference fix) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9629 (fuse: Fixing the coverity issues) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9630 (libglusterfs: coverity fix) posted (#1) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9584 (dht : logically dead code removed.) posted (#2) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9629 (fuse: Fixing the coverity issues) posted (#2) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9584 (dht : logically dead code removed.) posted (#3) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9622 (dht : coverity fixes.) posted (#3) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9631 (features/marker: Fixing dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9626 (features/changelog: Fixing Dereference after null check.) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9632 (fuse: Fixing dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9626 (features/changelog: Fixing Dereference after null check) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9636 (glusterd: Dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9639 (io-stats: Fixing dereference after null check.) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check.) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9636 (glusterd: Dereference after null check.) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9640 (fuse: Fixing dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9641 (features/marker: Fixing dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9629 (fuse: Fixing the coverity issues.) posted (#3) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects) posted (#10) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9622 (dht : coverity fixes) posted (#4) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9584 (dht : logically dead code removed) posted (#4) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9563 (xlators/dht : divide by zero coverity fix) posted (#10) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9628 (dht : logical error and null dereference fix.) posted (#2) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9642 (qemu-block: Fixing coverity issue(Unused value)) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9629 (fuse: Fixing the coverity issues) posted (#4) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9643 (protocol-client : dead code removed) posted (#1) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check.) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9644 (features/quota: FIxing Logically dead code) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9645 (features/snapview: Fixing Logically dead code) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9646 (protocol-client: Removal of Logically dead code) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9647 (protocol-server: Removal of Logically dead code) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9628 (dht : logical error and null dereference fix) posted (#3) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9628 (dht : logical error and null dereference fix.) posted (#4) for review on master by Manikandan S Selvaganesh (11bc049.in) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects) posted (#11) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9650 (glusterd: coverity fix for TOCTOU.) posted (#1) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9651 (io-cache: Removing Logically dead code) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9658 (protocol-client: Fixing unchecked return value) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9659 (io-stats : null dereference coverity fix) posted (#1) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9660 (dht : null dereference coverity fix) posted (#1) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9659 (io-stats : null dereference coverity fix.) posted (#2) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9619 (bd: Fixing dereference after null check(FORWARD_NULL)) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9661 (glusterd: Fixing dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9662 (features/snapview-server: Fixing explicit null dereferencing.) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9663 (dht: Fixing dereference after null check.) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9666 (dht: Fixing dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9667 (posix : unchecked return value coverity fix) posted (#1) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9669 (cli: Removing negative value check for unsigned variable. (coverity fix)) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9590 (geo-rep: Fixing of STRING_OVERFLOW features/changelog: Fixing copy into fixed size buffer) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9667 (posix : unchecked return value coverity fix.) posted (#2) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9659 (io-stats : null dereference coverity fix) posted (#3) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9628 (dht : logical error and null dereference fix) posted (#5) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9643 (protocol-client : dead code removed.) posted (#2) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9674 (rpc: Fixing dereferencing after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9675 (cli: Fixing dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9675 (cli: Fixing dereference after null check) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9676 (protocol-client: Removal of Dead Code) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9675 (cli: Fixing dereference after null check) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9677 (libglusterfs : dead code fix) posted (#1) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9669 (cli: Removing negative value check for unsigned variable (coverity fix)) posted (#2) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9669 (cli: Removing negative value check for unsigned variable. (coverity fix)) posted (#3) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9678 (glusterd: Fixing wrong array comparison (Coverity fix)) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9679 (glusterd: Fixing wrong array comparison (Coverity fix)) posted (#1) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9675 (cli: Fixing dereference after null check and dead code removal) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9690 (fuse: Removal of dead code) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9677 (libglusterfs : dead code fix.) posted (#2) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9659 (io-stats : null dereference coverity fix.) posted (#4) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9667 (posix : unchecked return value coverity fix) posted (#3) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9628 (dht : logical error and null dereference fixes.) posted (#6) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9694 (symlink-cache: Fixing coverity issues) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9667 (posix : unchecked return value coverity fix) posted (#4) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9617 (features/changelog: Fixing Deference after null check) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9584 (dht : logically dead code removed) posted (#5) for review on master by Humble Devassy Chirammal (humble.devassy) COMMIT: http://review.gluster.org/9584 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 4ff398987805ba72010d328c61a5682088d32cf4 Author: Manikandan Selvaganesh <mselvaga> Date: Thu Feb 5 10:59:48 2015 +0530 dht : logically dead code removed CID :1124378 1124401 Change-Id: Ib48e4a8d3fb12c4e0323a3946afb46eeb3926984 BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9584 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: N Balachandran <nbalacha> Reviewed-by: Shyamsundar Ranganathan <srangana> REVIEW: http://review.gluster.org/9628 (dht : logical error and null dereference fixes.) posted (#7) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/9628 (dht : logical error and null dereference fixes.) posted (#8) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/9586 (glusterd: coverity fix.) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/9667 (posix : unchecked return value coverity fix) posted (#5) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9677 (libglusterfs : dead code fix.) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/9640 (fuse: Fixing dereference after null check) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy) COMMIT: http://review.gluster.org/9556 committed in master by Vijay Bellur (vbellur) ------ commit 510b1f6292da249a641aea6bc06ede433cc66936 Author: Manikandan Selvaganesh <mselvaga> Date: Tue Feb 3 13:17:19 2015 +0530 xlators/storage/bd : Unused value is removed. CID:1128926 Change-Id: I5ad1229e225a36f995245a847db1a19609a18cd8 BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9556 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Humble Devassy Chirammal <humble.devassy> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Raghavendra Bhat <raghavendra> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9640 committed in master by Vijay Bellur (vbellur) ------ commit d8c18855caa07ff9d529395a760457281dd2f08e Author: arao <arao> Date: Thu Feb 12 10:12:35 2015 +0530 fuse: Fixing dereference after null check CID: 1124496 The pointer is not checked against null and is dereferenced anyway, which is now checked. Change-Id: Ib810546445596671b3656f01a14bbad02cdc221c BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9640 Reviewed-by: Humble Devassy Chirammal <humble.devassy> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9667 (posix : unchecked return value coverity fix.) posted (#6) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9667 (posix : unchecked return value coverity fix) posted (#7) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9667 (posix : unchecked return value coverity fix.) posted (#8) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects.) posted (#12) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects) posted (#13) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9579 (gluster-cli : Removing logically dead code.) posted (#5) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/9628 (dht : logical error and null dereference fixes.) posted (#9) for review on master by Kaleb KEITHLEY (kkeithle) COMMIT: http://review.gluster.org/9679 committed in master by Vijay Bellur (vbellur) ------ commit d71418ac4e2da989fc49eece4e2acbb9288b71f9 Author: Nandaja Varma <nandaja.varma> Date: Wed Feb 18 16:40:03 2015 +0530 glusterd: Fixing wrong array comparison (Coverity fix) Coverity CID: 1256175 Change-Id: Ib29fc2eaa54a7ce8369918e68bf117d0f04ca94d BUG: 789278 Signed-off-by: Nandaja Varma <nandaja.varma> Reviewed-on: http://review.gluster.org/9679 Reviewed-by: Vijaikumar Mallikarjuna <vmallika> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Humble Devassy Chirammal <humble.devassy> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9658 (protocol-client: Fixing unchecked return value.) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9641 (features/marker: Fixing dereference after null check.) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9651 (io-cache: Removing Logically dead code.) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9646 (protocol-client: Removal of Logically dead code.) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9644 (features/quota: Fixing Logically dead code) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9647 (protocol-server: Removal of Logically dead code.) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9663 (dht: Fixing dereference after null check.) posted (#2) for review on master by Anusha B.Rao (anusha91rao) COMMIT: http://review.gluster.org/9667 committed in master by Vijay Bellur (vbellur) ------ commit b7d8567145b948c7a51b6ecccfd5ff5c10c5a17a Author: Manikandan Selvaganesh <mselvaga> Date: Tue Feb 17 17:17:40 2015 +0530 posix : unchecked return value coverity fix. CID : 1124364 Change-Id: I1e16e3ff46b191ba2ea527e628c77a99a56f6c31 BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9667 Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Kaleb KEITHLEY <kkeithle> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9601 committed in master by Vijay Bellur (vbellur) ------ commit 298e94f8049df7e89f77bbd3d42d3c91981d492c Author: Manikandan Selvaganesh <mselvaga> Date: Fri Feb 6 16:29:09 2015 +0530 protocol/client : logical dead code removed CID :112438{2,3,4,5} 11244{03,04,05,06,07,08,09,10,11,12,13,14,30,31,32,33} 11244{34,35,36,37,38,39,40,41,42,43,44,56,57,58,59,60} 11244{61,62,63,64,65,66,67,68,69,70} 1128902 Change-Id: I1b53aeee83209728d5711540210d19314f4165bc BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9601 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9643 committed in master by Vijay Bellur (vbellur) ------ commit d680cbb47a2f630bbe062b48f910528e7ffad97d Author: Manikandan Selvaganesh <mselvaga> Date: Thu Feb 12 11:47:31 2015 +0530 protocol-client : dead code removed. CID : 1124415,1124416, 1124417,1124418, 1124419,1124420, 1124425,1124426, 1124427,1124428, 1124445,1124446. Change-Id: Ib140b8907f4548f41fccb8044772397760fff835 BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9643 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9659 committed in master by Vijay Bellur (vbellur) ------ commit 49d68945c01cdb29490de3ebbee42036ca23ef87 Author: Manikandan Selvaganesh <mselvaga> Date: Mon Feb 16 14:26:54 2015 +0530 io-stats : null dereference coverity fix. CID :1124502 Change-Id: I2911be340e8e48a52e951d0f04f6a96f3c219fab BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9659 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Humble Devassy Chirammal <humble.devassy> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9606 committed in master by Vijay Bellur (vbellur) ------ commit 2355012f3843859d639819d2308f995e08e270e5 Author: Manikandan Selvaganesh <mselvaga> Date: Mon Feb 9 12:56:17 2015 +0530 cli : logically dead code removed CID : 1124396 1124398 Change-Id: I708703529bbfe78c295523d2f4b85a55566a6249 BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9606 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9646 committed in master by Vijay Bellur (vbellur) ------ commit 059e085752d09e841fd685e3ca53aeb2983cd48b Author: arao <arao> Date: Thu Feb 12 15:27:00 2015 +0530 protocol-client: Removal of Logically dead code. CID: 1124447 The values of the pointer varibale checked, before going to out label was always NULL, hence dead code related to that is removed. Change-Id: I0f9b84c7feb34072814557ddd023f2ae1c64ef7e BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9646 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9619 committed in master by Vijay Bellur (vbellur) ------ commit 9272b1cf5655fff625b254a1ea952dcefd3c3af1 Author: arao <arao> Date: Tue Feb 10 11:06:27 2015 +0530 bd: Fixing dereference after null check(FORWARD_NULL) CID: 1128907 The pointer variable 'bdatt' redirected to a goto label when the value was NULL and in the other condition when it is not NULL , hence the bdatt is again checked for NULL at 'reverse xattr' label. Change-Id: I2289cbf30fde9faf97e6eebd4902953a44049f9e BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9619 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9694 committed in master by Vijay Bellur (vbellur) ------ commit dcff68eb2e9837a1db6634571e8e03fc57ff3182 Author: arao <arao> Date: Thu Feb 19 14:37:18 2015 +0530 symlink-cache: Fixing coverity issues CID: 1124389 Misspelt variable leading to dead code and memory leak, corrected. Change-Id: I1278f07f81e2db33640e0f289558d919343cb6ce BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9694 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects.) posted (#14) for review on master by Nandaja Varma (nandaja.varma) COMMIT: http://review.gluster.org/9676 committed in master by Vijay Bellur (vbellur) ------ commit f2c1261123798403dd254926db4f2008de4b6d84 Author: arao <arao> Date: Wed Feb 18 14:57:31 2015 +0530 protocol-client: Removal of Dead Code CID: 1124448 CID: 1124449 Removal of the dead code in the 'out' label. Change-Id: Ibdd05cbb6e2204f6aefdf442698225883c2d7734 BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9676 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9588 committed in master by Vijay Bellur (vbellur) ------ commit b828932c1430bfc62d7c3c83fec8e4a79ca4dbe6 Author: Nandaja Varma <nvarma> Date: Thu Feb 5 13:37:37 2015 +0530 bd: coverity fixes, removing logically dead code and correcting checks Coverity CIDs: 1128910 1128911 1128913 1128912 1134020 Change-Id: I2d871723fbfe43f9ff6b3beba7a99b0d81d4aff5 BUG: 789278 Signed-off-by: Nandaja Varma <nvarma> Reviewed-on: http://review.gluster.org/9588 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9669 (cli: Removing negative value check for unsigned variable (coverity fix)) posted (#4) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9628 (dht : logical error and null dereference fix.) posted (#10) for review on master by Manikandan S Selvaganesh (mselvaga) COMMIT: http://review.gluster.org/9642 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 8e2a0f35e0ac66e75f2dcbe6a9ca8815d4233edf Author: Nandaja Varma <nandaja.varma> Date: Thu Feb 12 11:20:49 2015 +0530 qemu-block: Fixing coverity issue(Unused value) Coverity ID: 1124889 1124889 1124889 1124889 1124889 1124889 1124889 1124889 1124889 1124889 1124889 Change-Id: I82d57022c4a06fb70573b4e9436f934185f8fb84 BUG: 789278 Signed-off-by: Nandaja Varma <nandaja.varma> Reviewed-on: http://review.gluster.org/9642 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Humble Devassy Chirammal <humble.devassy> Reviewed-by: Kaleb KEITHLEY <kkeithle> REVIEW: http://review.gluster.org/10055 (features/bit-rot: fix assignment instead of check (Coverity fix)) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10056 (features/bit-rot: fix CID 1124725 - use after free) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10057 (fuse: add missing return in error path (CID 1288092)) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10058 (features/changelog: fix possible memory illegal access (1 of 2, coverity)) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10059 (features/changelog: fix possible memory illegal access (2 of 2, coverity)) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects) posted (#15) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/10061 (features/changelog: fix possible illegal memory access (CID 1288821)) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10062 (features/changelog: fix possible illegal memory access (CID 1288819)) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10063 (libgfdb: fix possible illegal memory access (CID 1288820)) posted (#1) for review on master by Michael Adam (obnox) COMMIT: http://review.gluster.org/10057 committed in master by Vijay Bellur (vbellur) ------ commit 10f3289bac31a2b0020dfe1e97ed98601e4e4521 Author: Michael Adam <obnox> Date: Tue Mar 31 02:01:40 2015 +0200 fuse: add missing return in error path (CID 1288092) Fixes Coverity CID 1288092. Change-Id: I95347915b1dee6003d7a1cfb86f12cf2cd7310f8 BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10057 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Venky Shankar <vshankar> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9577 committed in master by Vijay Bellur (vbellur) ------ commit a2fa3ba3f6b604b9a5b305092226b12e812fcaf1 Author: Nandaja Varma <nvarma> Date: Wed Feb 4 14:47:36 2015 +0530 gluster-cli : Fixing "argument can't be negative" coverity issue. Here value of fd can never have a negative value if it is to be closed. So changing the check from if (fd) to if (fd >= 0) Coverity CIDs: 1124652 1124653 Change-Id: I8491afa93bab10acd2c2e01993a7f7468ca9ff87 BUG: 789278 Signed-off-by: Nandaja Varma <nvarma> Reviewed-on: http://review.gluster.org/9577 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9614 committed in master by Vijay Bellur (vbellur) ------ commit d7374684f648c1e45d695454f95a65acfe6d04e8 Author: Nandaja Varma <nandaja.varma> Date: Mon Feb 9 17:16:22 2015 +0530 marker, quota: Fixing the coverity issues Coverity CIDs: 1124601 1124690 1134008 1134009 Change-Id: I93992b11bb6d8f7edd065f602aec2cd7a8b433d0 BUG: 789278 Signed-off-by: Nandaja Varma <nandaja.varma> Reviewed-on: http://review.gluster.org/9614 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9629 committed in master by Vijay Bellur (vbellur) ------ commit 2acb5325828a68b06b39ab44e6736c6ad4ca3a06 Author: Nandaja Varma <nandaja.varma> Date: Wed Feb 11 11:29:20 2015 +0530 fuse: Fixing the coverity issues Coverity CID: 1124806 1124692 Change-Id: I6dcf245ded9796fb42516eca63211d855262c26f BUG: 789278 Signed-off-by: Nandaja Varma <nandaja.varma> Reviewed-on: http://review.gluster.org/9629 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9662 committed in master by Vijay Bellur (vbellur) ------ commit 17d719c9ba08ba6b6eb040723f78cfa45b0c2ae7 Author: arao <arao> Date: Tue Feb 17 14:54:45 2015 +0530 features/snapview-server: Fixing explicit null dereferencing. CID: 1238184 The pointer was not checked for null before dereferencing in the 'out' label, which is resolved now. Change-Id: I8aa7520102b84f63727754b8ac9c1f87ef8a6671 BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9662 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9690 committed in master by Vijay Bellur (vbellur) ------ commit e59e3a341308a9f47231d0205359da6886bb82be Author: arao <arao> Date: Thu Feb 19 10:13:22 2015 +0530 fuse: Removal of dead code CID: 1124386 Dead code/ Unreachable code and related unsed variable are removed. Change-Id: Iafd317f01778dfe61f8a0e5398341e4f3a62d7a5 BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9690 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9617 committed in master by Vijay Bellur (vbellur) ------ commit 6522f059eeec1b9962525b61c4c6640ae1afe85c Author: arao <arao> Date: Tue Feb 10 02:51:43 2015 +0530 features/changelog: Fixing Deference after null check CID: 1124481 The goto label 'out' was trying to dereference a pointer which might be null, hence a check on not null is made before the use of it. Change-Id: I813e523207b8218a7a28c2b3ac36a8e472e36c89 BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9617 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9677 committed in master by Vijay Bellur (vbellur) ------ commit e92270044e358ca5b290557026fab32f5d8368e9 Author: Manikandan Selvaganesh <mselvaga> Date: Wed Feb 18 16:32:17 2015 +0530 libglusterfs : dead code fix. CID : 1124884 Change-Id: I3332e844a01c1432f1d80a6acda7a87e8b01801c BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9677 Reviewed-by: Humble Devassy Chirammal <humble.devassy> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9574 committed in master by Vijay Bellur (vbellur) ------ commit 6df8d1d8781f59fbab46c4b016dde0b2d33dd189 Author: Nandaja Varma <nvarma> Date: Wed Feb 4 13:21:50 2015 +0530 gluster-cli: Fixing operand error and removing logically dead code. Assign used instead of comparison Coverity CIDs: 1124391 1124346 1124369 1124370 1124702 1124390 1124397 Change-Id: If015382917cad65edc2fee38ae6328f1d072d6f6 BUG: 789278 Signed-off-by: Nandaja Varma <nvarma> Reviewed-on: http://review.gluster.org/9574 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Humble Devassy Chirammal <humble.devassy> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/10064 (features/trash: fix remove_trash_path() to do what it is intended.) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10068 (features/trash: fix storing/wiping of eliminate path (coverity)) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10064 (features/trash: fix remove_trash_path() to do what it is intended.) posted (#2) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10056 (features/bit-rot: fix CID 1124725 - use after free) posted (#2) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10064 (features/trash: fix remove_trash_path() to do what it is intended.) posted (#3) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/9579 (gluster-cli : Removing logically dead code) posted (#6) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9669 (cli: Removing negative value check for unsigned variable. (coverity fix)) posted (#5) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9600 (rpc-lib: Fixing the coverity issues) posted (#2) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9557 (changelog: Fixing buffer overrun coverity issues) posted (#4) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/10082 (features/trash: More coverity fixes) posted (#1) for review on master by Anoop C S (achiraya) REVIEW: http://review.gluster.org/9669 (cli: Removing negative value check for unsigned variable) posted (#6) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/9622 (dht : coverity fixes) posted (#5) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9622 (dht : coverity fixes) posted (#6) for review on master by Manikandan S Selvaganesh (mselvaga) COMMIT: http://review.gluster.org/10068 committed in master by Vijay Bellur (vbellur) ------ commit 562cdace9152add786f156e38dc3fbc8805a69b7 Author: Michael Adam <obnox> Date: Tue Mar 31 12:30:06 2015 +0200 features/trash: fix storing/wiping of eliminate path (coverity) Functions store_eliminate_path() and wipe_eliminate_path() take eliminate as a plain pointer not pointer to pointer. Hence store_eliminate_path fails to hand the allocated and filled eliminate data out to the caller (in particular leaking memory), and wipe_eliminate_path() fails to NULL the freed eliminate path. This leads to several leak and access after free errors found by Coverity. This patch fixes the issue by handing in eliminate by reference and in the case of wipe_eliminate path, also NULLing out the free'd pointer. This fixes the following coverity IDs: CID 1288759 CID 1288790 Change-Id: I7520ae42c5f6e369a145bea67b4ff95b75d2ae73 BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10068 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anoop C S <achiraya> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9571 (afr : null dereference coverity fix) posted (#3) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9557 (changelog: Fixing buffer overrun coverity issues) posted (#5) for review on master by Nandaja Varma (nandaja.varma) COMMIT: http://review.gluster.org/10064 committed in master by Vijay Bellur (vbellur) ------ commit 5c1ce6d29ee52af9daa23c1c7a54f23ce29a687e Author: Michael Adam <obnox> Date: Tue Mar 31 10:30:22 2015 +0200 features/trash: fix remove_trash_path() to do what it is intended. The intention is to set the the rem_path string pointer that is handed in from the outside. So the string has to be passed in by reference, or else the function just sets a pointer on the stack. Found by Coverity, CID 1288791 Also fixes: CID 1288791 CID 1288809 CID 1288810 CID 1288814 CID 1288815 CID 1288817 CUD 1288818 Change-Id: I6ef5eeb58b83a875cf90513291abe37dee3fc9fb BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10064 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anoop C S <achiraya> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9553 (posix: Fixing buffer overrun coverity defects) posted (#16) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/10083 (cli: Fixing dereference after null check and dead code removal) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9571 (afr : null dereference coverity fix) posted (#4) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9557 (changelog: Fixing buffer overrun coverity issues) posted (#6) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9540 (Cluster/afr : Coverity fix) posted (#3) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9674 (rpc: Fixing dereferencing after null check) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9647 (protocol-server: Removal of Logically dead code) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#5) for review on master by Anusha B.Rao (anusha91rao) COMMIT: http://review.gluster.org/10055 committed in master by Venky Shankar (vshankar) ------ commit 3fdd3de1a148cfaf4c1ccf72e8ce2893557cfff6 Author: Michael Adam <obnox> Date: Mon Mar 30 19:25:02 2015 +0200 features/bit-rot: fix assignment instead of check (Coverity fix) Fixes Coverity CIDs 1291728, 1291723, 1291732. Change-Id: I62f3d540cac0f555fe2839b8418e59691c3ff4fd BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10055 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra Talur <rtalur> Reviewed-by: Venky Shankar <vshankar> Tested-by: Venky Shankar <vshankar> REVIEW: http://review.gluster.org/9663 (dht: Fixing dereference after null check) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9540 (Cluster/afr : Coverity fix.) posted (#4) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/10056 (features/bit-rot: fix CID 1124725 - use after free) posted (#3) for review on master by Michael Adam (obnox) COMMIT: http://review.gluster.org/10059 committed in master by Venky Shankar (vshankar) ------ commit dc26a253f5f393745bd435721e31d6e2e598eed1 Author: Michael Adam <obnox> Date: Tue Mar 31 02:36:30 2015 +0200 features/changelog: fix possible memory illegal access (2 of 2, coverity) Coverity CID 1288822 (#2 of 2) strncpy executed with a limit equal to the target array size potentially leaves the target string not null terminated. Make sure the copied string is a valid 0 terminated string. Change-Id: If283dd6f716912f65729edf6ea26a4331a697151 BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10059 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Poornima G <pgurusid> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Venky Shankar <vshankar> Tested-by: Venky Shankar <vshankar> REVIEW: http://review.gluster.org/10083 (cli: Fixing dereference after null check and dead code removal) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/10058 (features/changelog: fix possible illegal mem access (CID 1288822)) posted (#2) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/9669 (cli: Removing negative value check for unsigned variable (coverity fix)) posted (#7) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/10113 (glusterd: fix Null pointer dereference in bitrot disable) posted (#1) for review on master by Atin Mukherjee (amukherj) COMMIT: http://review.gluster.org/10063 committed in master by Vijay Bellur (vbellur) ------ commit 7616738176f44cce8b6cfb0e1f65be8e1dc72f49 Author: Michael Adam <obnox> Date: Tue Mar 31 09:56:35 2015 +0200 libgfdb: fix possible illegal memory access (CID 1288820) Coverity CID 1288820 strncpy executed with a limit equal to the target array size potentially leaves the target string not null terminated. Make sure the copied string is a valid 0 terminated string. Change-Id: I39ff6a64ca5b9e30562226dd34c5b06267b75b87 BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10063 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Poornima G <pgurusid> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Joseph Fernandes <josferna> Tested-by: Joseph Fernandes <josferna> REVIEW: http://review.gluster.org/10056 (features/bit-rot: fix CID 1124725 - use after free) posted (#4) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10058 (features/changelog: fix possible illegal mem access (CID 1288822)) posted (#3) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10061 (features/changelog: fix possible illegal memory access (CID 1288821)) posted (#2) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10062 (features/changelog: fix possible illegal memory access (CID 1288819)) posted (#2) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/10113 (glusterd: fix Null pointer dereference in bitrot disable) posted (#2) for review on master by Vijay Bellur (vbellur) REVIEW: http://review.gluster.org/9669 (cli: Removing negative value check for unsigned variable (coverity fix)) posted (#8) for review on master by Vijay Bellur (vbellur) COMMIT: http://review.gluster.org/10056 committed in master by Venky Shankar (vshankar) ------ commit 41bc3f7f023de198c695bdb7708afef3910cc761 Author: Michael Adam <obnox> Date: Mon Mar 30 19:48:27 2015 +0200 features/bit-rot: fix CID 1124725 - use after free Coverity fixes: CID 1124725 CID 1291742 The problem is that gf_tw_cleanup_timers() frees the handed in priv->timer_wheel but it can not set the pointer to NULL, so subsequent checks for priv->timer_wheel show it as not NULL and allow for access after free. The proper change might be to change gf_tw_cleanup_timers() to take a reference to the pointer and set it to NULL after free, but since it is under contrib/, I did not want to change that function. Instead this patch uses the function's return code which was not used previously. (Maybe this should even be done in a wrapper macro or function?) Change-Id: I31d80d3df2e4dc7503d62c7819429e1a388fdfdd BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10056 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Venky Shankar <vshankar> Tested-by: Venky Shankar <vshankar> COMMIT: http://review.gluster.org/10058 committed in master by Vijay Bellur (vbellur) ------ commit f4be9bc3c530ab35a0cd1939df8c43abe54e540d Author: Michael Adam <obnox> Date: Tue Mar 31 02:28:07 2015 +0200 features/changelog: fix possible illegal mem access (CID 1288822) Coverity CID 1288822 (#1 of 2) strncpy executed with a limit equal to the target array size potentially leaves the target string not null terminated. In this case the strncpy is not needed due to the snprintf with the same target buffer which follows immediately. This patch also removes the now unneeded scratch_dir argument to gf_changelog_init_history(), which is semantically correct, since scratch_dir has previously been filled into jnl->jnl_working_dir by the caller, and this is now used to fill hist_scratch_dir. Change-Id: Ib1ed3a1058e80e34191758921b49c29030d6c9db BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10058 Reviewed-by: Kotresh HR <khiremat> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9674 committed in master by Vijay Bellur (vbellur) ------ commit cf5bf1863d58f823f9c67b0e5dda3ba9261ccf27 Author: arao <arao> Date: Wed Feb 18 13:11:42 2015 +0530 rpc: Fixing dereferencing after null check CID: 1124607 The pointer variable is checked for NULL and logged accordingly. Change-Id: Ied0d7f7ff33da22198eca65f14816b943cae5541 BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9674 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/10083 (cli: Fixing dereference after null check and dead code removal) posted (#3) for review on master by Vijay Bellur (vbellur) REVIEW: http://review.gluster.org/9647 (protocol-server: Removal of Logically dead code) posted (#4) for review on master by Vijay Bellur (vbellur) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#6) for review on master by Vijay Bellur (vbellur) REVIEW: http://review.gluster.org/10082 (features/trash: More coverity fixes) posted (#2) for review on master by Anoop C S (achiraya) REVIEW: http://review.gluster.org/9669 (cli: Removing negative value check for unsigned variable (coverity fix)) posted (#9) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9632 (fuse: Fixing dereference after null check) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#3) for review on master by Anusha B.Rao (anusha91rao) COMMIT: http://review.gluster.org/9669 committed in master by Vijay Bellur (vbellur) ------ commit 5e7cc20d3cc37a03f594237bdf85c67397c3ceac Author: Nandaja Varma <nandaja.varma> Date: Tue Feb 17 17:27:03 2015 +0530 cli: Removing negative value check for unsigned variable (coverity fix) CID: 1124663 Change-Id: Ic24014cdb9a68ed310c5e3dcf21fcebd6bf9da60 BUG: 789278 Signed-off-by: Nandaja Varma <nandaja.varma> Reviewed-on: http://review.gluster.org/9669 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/10082 committed in master by Vijay Bellur (vbellur) ------ commit d2ada381fe332b6151d12d3ef1d1e47f9f7c77f7 Author: Anoop C S <achiraya> Date: Tue Mar 24 14:34:52 2015 +0530 features/trash: More coverity fixes The following CIDs are being addressed: 1288792 1288794 Change-Id: Ic2cdaf43f05488e04616ceb801b47a47c6a93656 BUG: 789278 Signed-off-by: Anoop C S <achiraya> Reviewed-on: http://review.gluster.org/10082 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9615 committed in master by Vijay Bellur (vbellur) ------ commit 17827defd6703298b68fee8fd08aef69ab0e2866 Author: Nandaja Varma <nandaja.varma> Date: Mon Feb 9 17:39:20 2015 +0530 snapview: Fixing the coverity issues Coverity CIDs: 1228601 1220056 1238185 1257624 Change-Id: Idb4cc3b44bc3ccb8b497ce355e1e3bacfb176db9 BUG: 789278 Signed-off-by: Nandaja Varma <nandaja.varma> Reviewed-on: http://review.gluster.org/9615 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9557 (changelog: Fixing buffer overrun coverity issues.) posted (#7) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9600 (rpc-lib: Fixing the coverity issues) posted (#3) for review on master by Nandaja Varma (nandaja.varma) COMMIT: http://review.gluster.org/10061 committed in master by Venky Shankar (vshankar) ------ commit 90f72efed8313efe0410634677f36d0fbdc5eab4 Author: Michael Adam <obnox> Date: Tue Mar 31 09:41:10 2015 +0200 features/changelog: fix possible illegal memory access (CID 1288821) Coverity CID 1288821 strncpy executed with a limit equal to the target array size potentially leaves the target string not null terminated. Make sure the copied string is a valid 0 terminated string. Change-Id: I5ecc60549864cf50e3facbb8a2d9228cd67b57b5 BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10061 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Venky Shankar <vshankar> Tested-by: Venky Shankar <vshankar> REVIEW: http://review.gluster.org/10113 (glusterd: fix Null pointer dereference in bitrot disable) posted (#3) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/9600 (rpc-lib: Fixing the coverity issues.) posted (#4) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9571 (afr : null dereference coverity fix) posted (#5) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9571 (afr : null dereference coverity fix) posted (#6) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9571 (afr : null dereference coverity fix) posted (#7) for review on master by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/10113 committed in master by Vijay Bellur (vbellur) ------ commit e5f59739b210672480115177cbd4dbd391fabb92 Author: Atin Mukherjee <amukherj> Date: Thu Apr 2 15:07:31 2015 +0530 glusterd: fix Null pointer dereference in bitrot disable CID : 128806 Change-Id: Ia143a28a3dcb80d2175c908bd152c3d0b821bbb5 BUG: 789278 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/10113 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Venky Shankar <vshankar> REVIEW: http://review.gluster.org/9571 (afr : null dereference coverity fix.) posted (#8) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/10062 (features/changelog: fix possible illegal memory access (CID 1288819)) posted (#3) for review on master by Venky Shankar (vshankar) COMMIT: http://review.gluster.org/9622 committed in master by Vijay Bellur (vbellur) ------ commit aa0befea352402922839dd846c798c0da2afd271 Author: Manikandan Selvaganesh <mselvaga> Date: Tue Feb 10 14:59:09 2015 +0530 dht : coverity fixes CID : 1124352,1124365 (unchecked return value), 1124377 ( logically dead code), 1124511 (null dereference) Change-Id: I61e029a078559cfe15d36bf0aa53418f6214e5cb BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9622 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Shyamsundar Ranganathan <srangana> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: N Balachandran <nbalacha> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9540 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 5ac39ab3cd4ba8c5c3a103912a13c443036bfe2e Author: Manikandan Selvaganesh <mselvaga> Date: Mon Feb 2 19:19:07 2015 +0530 Cluster/afr : Coverity fix. CID:1194644 Childup[] value will not be equal to -1 when afr_xl_op() function gets called Change-Id: Iaf7a9d41a54f6b2d52d9ba5dadb638f328afe14b BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9540 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Humble Devassy Chirammal <humble.devassy> Reviewed-by: Krutika Dhananjay <kdhananj> Reviewed-by: Kaleb KEITHLEY <kkeithle> COMMIT: http://review.gluster.org/9571 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit 20e86a1b4c733934ff9960314d06697ad05a4528 Author: Manikandan Selvaganesh <mselvaga> Date: Wed Feb 4 12:14:52 2015 +0530 afr : null dereference coverity fix. CID : 1194648 Change-Id: Ib26e7cdbf412d563240885fb3113bcc1fe5c9c49 BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9571 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Krutika Dhananjay <kdhananj> Reviewed-by: Kaleb KEITHLEY <kkeithle> REVIEW: http://review.gluster.org/9628 (dht : null dereference coverity fix) posted (#11) for review on master by Manikandan S Selvaganesh (mselvaga) COMMIT: http://review.gluster.org/10062 committed in master by Venky Shankar (vshankar) ------ commit 2a224653df93c4b3a6b3914509f314196ad61008 Author: Michael Adam <obnox> Date: Tue Mar 31 09:50:44 2015 +0200 features/changelog: fix possible illegal memory access (CID 1288819) Coverity CID 1288819 strncpy executed with a limit equal to the target array size potentially leaves the target string not null terminated. Make sure the copied string is a valid 0 terminated string. Change-Id: Ie2d2970f37840146aa18724be3b89e93194c8160 BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10062 Reviewed-by: Niels de Vos <ndevos> Reviewed-by: Venky Shankar <vshankar> Tested-by: Venky Shankar <vshankar> COMMIT: http://review.gluster.org/9628 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 71897c714f570ae9a64ad0809fd890d1d5265b23 Author: Manikandan Selvaganesh <mselvaga> Date: Wed Apr 8 12:19:18 2015 +0530 dht : null dereference coverity fix Change-Id: I700e7ebdfe4929a6d74406ea081059bdddcf7a79 BUG: 789278 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/9628 Reviewed-by: N Balachandran <nbalacha> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Humble Devassy Chirammal <humble.devassy> Reviewed-by: Shyamsundar Ranganathan <srangana> COMMIT: http://review.gluster.org/10083 committed in master by Vijay Bellur (vbellur) ------ commit 093639d8003695889923cc7a106519c1f9a4e2f0 Author: arao <arao> Date: Wed Apr 1 12:29:24 2015 +0530 cli: Fixing dereference after null check and dead code removal CID: 1124609 CID: 1124596 CID: 1124471 CID: 1124475 CID: 1124476 The pointer variables are checked before dereferencing and the dead code is removed BUG: 789278 Change-Id: Ia532733a64401d71ccf1f2b6e434d7bc910e0ed1 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/10083 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9644 committed in master by Vijay Bellur (vbellur) ------ commit 2b9a4799ef6caaeeca438c019f4a1f6cf423324a Author: arao <arao> Date: Thu Feb 12 12:49:33 2015 +0530 features/quota: Fixing Logically dead code CID: 1134007 The code never reaches the condition check on retlen in ret label, hence removing the dead code. Change-Id: Ia0108b69489bb78a2561ff8da6e00685f472ae82 BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9644 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9582 committed in master by Vijay Bellur (vbellur) ------ commit ca9e4bf6bcc947dd7c179c93dae206c6cde4d3b5 Author: Nandaja Varma <nvarma> Date: Wed Feb 4 17:19:40 2015 +0530 gluster-cli : Extra checks for word_count removed. Coverity IDs: 1124453 1124454 In the first case, In the beginning of the function check is made to see of the word_count is less than 4. If yes it returns. So it wouldn't reach this part if that check takes the true path. So this code is logically dead. In second and third case, this is in false branch for word_cound <6. So word_count can't possibly be less than 5 at this point. Change-Id: Id5e1c81045ce7bc0ee6b7612ea54ef2b7f54b699 BUG: 789278 Signed-off-by: Nandaja Varma <nvarma> Reviewed-on: http://review.gluster.org/9582 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Humble Devassy Chirammal <humble.devassy> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9579 (gluster-cli : Removing logically dead code) posted (#7) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9600 (rpc-lib: Fixing the coverity issues) posted (#5) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9639 (io-stats: Fixing dereference after null check.) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/10188 (features/marker: Fixing dereference after null check) posted (#1) for review on master by Anusha B.Rao (anusha91rao) COMMIT: http://review.gluster.org/9579 committed in master by Vijay Bellur (vbellur) ------ commit d57642044b720663c6474d318106c19e84f2c8bf Author: Nandaja Varma <nvarma> Date: Wed Feb 4 16:59:55 2015 +0530 gluster-cli : Removing logically dead code Coverity CID: 1124451 Change-Id: I7b2901fdd2ace4666f9e2c6deaf3838322a1c6ff BUG: 789278 Signed-off-by: Nandaja Varma <nvarma> Reviewed-on: http://review.gluster.org/9579 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9639 committed in master by Vijay Bellur (vbellur) ------ commit 320455bddfbadcfbe1b173b0de54b3b25bf228f7 Author: arao <arao> Date: Wed Feb 11 18:58:08 2015 +0530 io-stats: Fixing dereference after null check. CID: 1124492 If 'this' pointer fails to exist then the component is hard-coded in the gf_log if not it is dereferenced. Change-Id: I988137d4f5ac4c9aedef7cef0c75b167a8a5c59f BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9639 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9600 committed in master by Vijay Bellur (vbellur) ------ commit 26cbd3bdf5dad190559afbdf0ac125262c4e90a6 Author: Nandaja Varma <nandaja.varma> Date: Fri Feb 6 11:44:22 2015 +0530 rpc-lib: Fixing the coverity issues Coverity CIDs: 1210973 1124887 1124888 1124682 1124849 1124503 Change-Id: I012f6cf9d14753f572ab94aae6d442d1ef8df79a BUG: 789278 Signed-off-by: Nandaja Varma <nandaja.varma> Reviewed-on: http://review.gluster.org/9600 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9663 (dht: Fixing dereference after null check) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#5) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9608 (glusterfsd: coverity fix) posted (#3) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9630 (libglusterfs: coverity fix) posted (#2) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9539 (glusterd : coverity fix for a string overflow) posted (#4) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9586 (glusterd: coverity fix) posted (#4) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9663 (dht: Fixing dereference after null check) posted (#5) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9651 (io-cache: Removing Logically dead code.) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/10242 (upcall: fix use-after free (CID 1288760, 1288761)) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/9539 (glusterd : coverity fix for the string overflow) posted (#5) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9586 (glusterd: coverity fix) posted (#5) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/10247 (gfapi: fix potential non-0-terminated string (CID 1134002)) posted (#1) for review on master by Michael Adam (obnox) REVIEW: http://review.gluster.org/9608 (glusterfsd: coverity fix.) posted (#4) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9630 (libglusterfs: coverity fix.) posted (#3) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9586 (glusterd: coverity fix) posted (#6) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#6) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9658 (protocol-client: Fixing unchecked return value.) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#7) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9641 (features/marker: Fixing dereference after null check.) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string) posted (#13) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9558 (glusterd: Coverity fix for insecure temporary file) posted (#6) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/10252 (xlators/storage/posix: Fix Dereference before null check (CID 1293501).) posted (#1) for review on master by Günther Deschner (gd) REVIEW: http://review.gluster.org/9539 (glusterd : coverity fix for the string overflow) posted (#6) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9586 (glusterd: coverity fix) posted (#7) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9608 (glusterfsd: coverity fix) posted (#5) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/10282 (posix: coverity fix for string overflow) posted (#1) for review on master by Sakshi Bansal (sabansal) COMMIT: http://review.gluster.org/10242 committed in master by Niels de Vos (ndevos) ------ commit 7fb85e3670cb4743436fd2cf0fbbf9c0869728ec Author: Michael Adam <obnox> Date: Wed Apr 15 08:34:13 2015 +0200 upcall: fix use-after free (CID 1288760, 1288761) Coverity IDs: 1288760 - Read from pointer after free 1288761 - Use after free. Change-Id: Ide9405b9c30a3e27941054a4ae61f585ef09cd8c BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10242 Tested-by: NetBSD Build System Tested-by: Gluster Build System <jenkins.com> Reviewed-by: soumya k <skoduri> Reviewed-by: Niels de Vos <ndevos> COMMIT: http://review.gluster.org/10247 committed in master by Niels de Vos (ndevos) ------ commit fc451b5b0fb8d7b3952ca6ecf91779cbcf00187f Author: Michael Adam <obnox> Date: Wed Apr 15 09:15:23 2015 +0200 gfapi: fix potential non-0-terminated string (CID 1134002) Use correct target buffer length for strncpy and make sure that the target string is 0 terminated. Fixes Coverity ID 1134002. Change-Id: I97a74a94a818eb08a711e547f2ac6ae46087f065 BUG: 789278 Signed-off-by: Michael Adam <obnox> Reviewed-on: http://review.gluster.org/10247 Tested-by: NetBSD Build System Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kotresh HR <khiremat> Reviewed-by: Niels de Vos <ndevos> COMMIT: http://review.gluster.org/10252 committed in master by Vijay Bellur (vbellur) ------ commit 2ae52207f40c8ec840d6ab0907a08fed6b30282a Author: Günther Deschner <gd> Date: Wed Apr 15 12:10:34 2015 +0200 xlators/storage/posix: Fix Dereference before null check (CID 1293501). Coverity CID 1293501. Everywhere in this call "name" is explicitly checked for NULL derreference just not here in this path. Guenther Change-Id: Ie3e7b704702cb979a036052238ed65eda1531407 BUG: 789278 Signed-off-by: Günther Deschner <gd> Reviewed-on: http://review.gluster.org/10252 Tested-by: NetBSD Build System Reviewed-by: Raghavendra Talur <rtalur> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> REVIEW: http://review.gluster.org/9660 (dht : null dereference coverity fix.) posted (#2) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9660 (dht : null dereference coverity fix) posted (#3) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9660 (dht : null dereference coverity fix) posted (#4) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/10315 (features/trash: Minor coverity fixes) posted (#1) for review on master by Anoop C S (achiraya) REVIEW: http://review.gluster.org/10315 (features/trash: Minor coverity fixes) posted (#2) for review on master by Anoop C S (achiraya) REVIEW: http://review.gluster.org/10315 (features/trash: Minor coverity fixes) posted (#3) for review on master by Anoop C S (achiraya) REVIEW: http://review.gluster.org/9658 (protocol-client: Fixing unchecked return value.) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#7) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#5) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/10315 (features/trash: Minor coverity fixes) posted (#4) for review on master by Anoop C S (achiraya) REVIEW: http://review.gluster.org/9660 (dht : null dereference coverity fix) posted (#5) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9660 (dht : Dereference coverity fix) posted (#6) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/9660 (dht : null dereference coverity fix) posted (#7) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/10348 (dht : null dereference coverity fix) posted (#1) for review on master by Manikandan S Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/10348 (dht : null dereference coverity fix.) posted (#2) for review on master by Manikandan S Selvaganesh (mselvaga) COMMIT: http://review.gluster.org/9663 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 272b55b54b3f760f0b95b29ec37ed719852ce4ed Author: arao <arao> Date: Tue Feb 17 15:14:53 2015 +0530 dht: Fixing dereference after null check CID: 1175023 The check for null is made before dereferencing the pointer variable alongside. Change-Id: I827927f2fcf6d1f365f4d6b5a678373020b9daf9 BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9663 Tested-by: NetBSD Build System Tested-by: Gluster Build System <jenkins.com> Reviewed-by: N Balachandran <nbalacha> Reviewed-by: Shyamsundar Ranganathan <srangana> COMMIT: http://review.gluster.org/10315 committed in master by Vijay Bellur (vbellur) ------ commit 2e16e383128707806cecd9027088cde573ff182d Author: Anoop C S <achiraya> Date: Wed Apr 15 13:01:51 2015 +0530 features/trash: Minor coverity fixes CID 1288784 CID 1288785 CID 1288795 CID 1288796 CID 1288797 CID 1288802 Change-Id: I51dd7653a2dce3b7b6387e5d91c1c07eb157a04b BUG: 789278 Signed-off-by: Anoop C S <achiraya> Reviewed-on: http://review.gluster.org/10315 Tested-by: Gluster Build System <jenkins.com> Tested-by: NetBSD Build System Tested-by: jiffin tony Thottan <jthottan> Reviewed-by: jiffin tony Thottan <jthottan> REVIEW: http://review.gluster.org/9565 (libglusterfs: Fixing insecure temp file coverity issue) posted (#6) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9565 (libglusterfs: Fixing insecure temp file coverity issue) posted (#7) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#6) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/10301 (xlators/cluster/dht: Fix Resource leak (CID 1291751)) posted (#2) for review on master by Shyamsundar Ranganathan (srangana) COMMIT: http://review.gluster.org/10301 committed in master by Vijay Bellur (vbellur) ------ commit de9d06cd7cfca0b42beffe003e7c1e09d469ca7e Author: Günther Deschner <gd> Date: Mon Apr 20 13:16:59 2015 +0200 xlators/cluster/dht: Fix Resource leak (CID 1291751) Coverity CID 1291751. Guenther Change-Id: Ibe9dc3662811dc5889f85fa063ab9211fcaf7f12 BUG: 789278 Signed-off-by: Guenther Deschner <gd> Reviewed-on: http://review.gluster.org/10301 Reviewed-by: Shyamsundar Ranganathan <srangana> Reviewed-by: Dan Lambright <dlambrig> Tested-by: NetBSD Build System Tested-by: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/9641 (features/marker: Fixing dereference after null check.) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#8) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9658 (protocol-client: Fixing unchecked return value.) posted (#5) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#8) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#7) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9565 (libglusterfs: Fixing insecure temp file coverity issue) posted (#8) for review on master by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#9) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#9) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9641 (features/marker: Fixing dereference after null check.) posted (#5) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9658 (protocol-client: Fixing unchecked return value.) posted (#6) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9641 (features/marker: Fixing dereference after null check) posted (#6) for review on master by Anusha B.Rao (anusha91rao) COMMIT: http://review.gluster.org/9557 committed in master by Venky Shankar (vshankar) ------ commit 7d7b80efe8c745f3ff7de76fc31c4977098cae01 Author: Nandaja Varma <nvarma> Date: Tue Feb 3 13:17:04 2015 +0530 changelog: Fixing buffer overrun coverity issues. Coverity IDs: 1214630 1214631 1214633 1234643 Change-Id: I172c4f49bf651b2324522f9e661023f73ca05339 BUG: 789278 Signed-off-by: Nandaja Varma <nvarma> Reviewed-on: http://review.gluster.org/9557 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Sakshi Bansal Reviewed-by: Venky Shankar <vshankar> REVIEW: http://review.gluster.org/9590 (geo-rep: Fixing of STRING_OVERFLOW features/changelog: Fixing copy into fixed size buffer) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/10595 (changelog: Fixing buffer overrun coverity issues.) posted (#1) for review on release-3.7 by Nandaja Varma (nandaja.varma) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#8) for review on master by Anusha B.Rao (anusha91rao) COMMIT: http://review.gluster.org/10595 committed in release-3.7 by Venky Shankar (vshankar) ------ commit e4c14bccb5abff6dcb8194b0da66dc1e73744256 Author: Nandaja Varma <nvarma> Date: Tue Feb 3 13:17:04 2015 +0530 changelog: Fixing buffer overrun coverity issues. Coverity IDs: 1214630 1214631 1214633 1234643 Backport of: http://review.gluster.org/9557 Change-Id: I172c4f49bf651b2324522f9e661023f73ca05339 BUG: 789278 Signed-off-by: Nandaja Varma <nvarma> Reviewed-on: http://review.gluster.org/9557 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Sakshi Bansal Reviewed-by: Venky Shankar <vshankar> (cherry picked from commit 7d7b80efe8c745f3ff7de76fc31c4977098cae01) Reviewed-on: http://review.gluster.org/10595 Tested-by: NetBSD Build System Tested-by: Venky Shankar <vshankar> REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#10) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9666 (dht: Fixing dereference after null check) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9550 (geo-rep: Fixing memory leak and tainted string) posted (#14) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#11) for review on master by Anusha B.Rao (anusha91rao) COMMIT: http://review.gluster.org/9666 committed in master by Raghavendra G (rgowdapp) ------ commit 1a9df097463d41679b87b6cbd4634fc3390fe82c Author: arao <arao> Date: Tue Feb 17 16:53:14 2015 +0530 dht: Fixing dereference after null check CID: 1223229 The 'loc' ptr is not checked before dereferencing, which is handled. Change-Id: Icf668150bde190e6f1b9f58a038099338516efe8 BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9666 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Raghavendra G <rgowdapp> REVIEW: http://review.gluster.org/9632 (fuse: Fixing dereference after null check) posted (#3) for review on master by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/10300 (xlators/cluster/dht: Fix Explicit null dereferenced (CID 1291727).) posted (#2) for review on master by Günther Deschner (gd) REVIEW: http://review.gluster.org/10782 (gfapi : zero size issue in glfs_h_acl_set()) posted (#1) for review on master by jiffin tony Thottan (jthottan) REVIEW: http://review.gluster.org/10782 (gfapi: zero size issue in glfs_h_acl_set()) posted (#2) for review on master by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#12) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#9) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#10) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9641 (features/marker: Fixing dereference after null check) posted (#8) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/10839 (io-cache: Removing Logically dead code) posted (#1) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#10) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9650 (glusterd: coverity fix for TOCTOU) posted (#2) for review on master by Sakshi Bansal REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#13) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9539 (glusterd: coverity fix for string overflow) posted (#7) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9630 (libglusterfs: coverity fix) posted (#4) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9558 (glusterd: Coverity fix for insecure temporary file) posted (#7) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9608 (glusterfsd: coverity fix) posted (#6) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/10282 (posix: coverity fix for string overflow) posted (#2) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9555 (glusterd: coverity fix for string overflow) posted (#6) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9586 (glusterd: coverity fix) posted (#8) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#11) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#14) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#12) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#15) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/10782 (gfapi: zero size issue in glfs_h_acl_set()) posted (#3) for review on master by jiffin tony Thottan (jthottan) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#13) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9658 (protocol-client: Fixing unchecked return value) posted (#7) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9670 (features/changelog: Fixing missing unlock) posted (#11) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#16) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9625 (glusterd: Fixing Dereference after null check) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9636 (glusterd: Dereference after null check) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/10782 (gfapi: zero size issue in glfs_h_acl_set()) posted (#4) for review on master by jiffin tony Thottan (jthottan) REVIEW: http://review.gluster.org/10782 (gfapi: zero size issue in glfs_h_acl_set()) posted (#5) for review on master by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/9658 (protocol-client: Fixing unchecked return value) posted (#8) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9625 (glusterd: Fixing Dereference after null check) posted (#3) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9636 (glusterd: Dereference after null check) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9658 (protocol-client: Fixing unchecked return value) posted (#9) for review on master by Anusha B.Rao (anusha91rao) COMMIT: http://review.gluster.org/10782 committed in master by Niels de Vos (ndevos) ------ commit ae9604bbdb4f87ee3f6f11adc3ce6cd140620055 Author: Jiffin Tony Thottan <jthottan> Date: Thu May 14 14:37:25 2015 +0530 gfapi: zero size issue in glfs_h_acl_set() When setting the stringified ACLs in the xattr dict through pub_glfs_h_setxattrs(), the size of the string is always passed as 0. The correct way is to pass the length of the ACL in text form. While verifying this issues, it seems that posix_pacl_set() should return the errno instead of -1. This helps in debugging, otherwise EPERM would always be returned on an error. [ndevos: fix off-by-one strlen() and return errno in posix_pacl_set()] Change-Id: Ia7a7fa1f3a7d615a813c703057dc97b09a0bbb34 BUG: 789278 Signed-off-by: Jiffin Tony Thottan <jthottan> Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/10782 Tested-by: NetBSD Build System Tested-by: Gluster Build System <jenkins.com> COMMIT: http://review.gluster.org/10300 committed in master by Vijay Bellur (vbellur) ------ commit 19d7b6097393e4bf20f77e96cc4b3dd8f2561513 Author: Günther Deschner <gd> Date: Thu Apr 16 11:29:00 2015 +0200 xlators/cluster/dht: Fix Explicit null dereferenced (CID 1291727). Coverity CID 1291727. Guenther Change-Id: I95f01b638f74370f0ef04383f0f9d5799abe31f5 BUG: 789278 Signed-off-by: Guenther Deschner <gd> Reviewed-on: http://review.gluster.org/10300 Reviewed-by: Dan Lambright <dlambrig> Tested-by: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#18) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/9636 (glusterd: Dereference after null check) posted (#5) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/9586 (glusterd: coverity fix) posted (#9) for review on master by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/9650 (glusterd: coverity fix for TOCTOU) posted (#3) for review on master by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/9647 (protocol-server: Removal of Logically dead code) posted (#5) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/9645 (features/snapview: Fixing Logically dead code) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#15) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#16) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/10869 (dht:updating return value for layout set function) posted (#3) for review on master by Sakshi Bansal REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#18) for review on master by Anusha B.Rao (anusha91rao) COMMIT: http://review.gluster.org/9565 committed in master by Niels de Vos (ndevos) ------ commit 886f65fabc50c256a7de57fd05281a75bba3cac9 Author: Nandaja Varma <nvarma> Date: Tue Feb 3 16:35:33 2015 +0530 libglusterfs: Fixing insecure temp file coverity issue Coverity CID: 1124835 Change-Id: I7e87f2b3bad35cf8a9c64c8502de23662d9f677f BUG: 789278 Signed-off-by: Nandaja Varma <nvarma> Reviewed-on: http://review.gluster.org/9565 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Sakshi Bansal Tested-by: NetBSD Build System <jenkins.org> Reviewed-by: Prashanth Pai <ppai> REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#25) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9897 (afr: Porting messages to new logging framework updated) posted (#27) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9625 (glusterd: Fixing Dereference after null check) posted (#4) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#19) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9661 (glusterd: Fixing dereference after null check) posted (#2) for review on master by Anusha B.Rao (anusha91rao) REVIEW: http://review.gluster.org/9661 (glusterd: Fixing dereference after null check) posted (#3) for review on master by Anusha B.Rao (anusha91rao) COMMIT: http://review.gluster.org/9661 committed in master by Krishnan Parthasarathi (kparthas) ------ commit 608a9f24954c716492d9dd69b1e56e439aa66243 Author: arao <arao> Date: Mon Feb 16 16:59:48 2015 +0530 glusterd: Fixing dereference after null check CID: 1124557 Checking for the pointer itself before dereferencing it to check for the variable's value it is pointed to. Change-Id: Idcbb034e4c6d58501697e01e90647b6233a5e5ba BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9661 Tested-by: NetBSD Build System <jenkins.org> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Krishnan Parthasarathi <kparthas> REVIEW: http://review.gluster.org/11665 (cli: coverity) posted (#1) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/11665 (cli: fixing the coverity issue) posted (#2) for review on master by Manikandan Selvaganesh (mselvaga) COMMIT: http://review.gluster.org/9641 committed in master by Kaleb KEITHLEY (kkeithle) ------ commit b21f3b3ce69c6b1b0eb6f8243b5c601c5c4b7cbe Author: arao <arao> Date: Thu Feb 12 10:22:42 2015 +0530 features/marker: Fixing dereference after null check CID: 1124494 The variable was sent as a parameter to the function without the null check, hence added a check on null and error log accordingly. Change-Id: I11a649fc9a1bedad17422aeddb8dd8fa225d404e BUG: 789278 Signed-off-by: arao <arao> Reviewed-on: http://review.gluster.org/9641 Tested-by: NetBSD Build System <jenkins.org> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> REVIEW: http://review.gluster.org/6910 (libgfapi & glusterfsd: Safe temp file creation) posted (#12) for review on master by Niels de Vos (ndevos) REVIEW: http://review.gluster.org/11665 (cli: coverity fix for conditional operator) posted (#3) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/11665 (cli: coverity fix for conditional operator) posted (#4) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/11665 (cli: coverity fix for comparison) posted (#5) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/10869 (dht :updating return value for layout set function) posted (#4) for review on master by Sakshi Bansal (sabansal) REVIEW: http://review.gluster.org/11665 (cli: coverity fix for comparison) posted (#6) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/11665 (cli: changing the assignment to comparison operator on an if statement) posted (#7) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/11665 (cli: changing the assignment to comparison operator on an if statement) posted (#8) for review on master by hari gowtham (hari.gowtham005) REVIEW: http://review.gluster.org/11665 (cli: changing the assignment to comparison operator on an if statement) posted (#9) for review on master by hari gowtham (hari.gowtham005) COMMIT: http://review.gluster.org/10869 committed in master by Raghavendra G (rgowdapp) ------ commit 830ad21fa8100eb15586eee771274d6d3caf4347 Author: Sakshi <sabansal> Date: Wed May 20 17:33:57 2015 +0530 dht : updating return value for layout set function Change-Id: I7fd89e00b418391afe0a13c2033919c979cc8bbb BUG: 789278 Signed-off-by: Sakshi <sabansal> Reviewed-on: http://review.gluster.org/10869 Tested-by: NetBSD Build System <jenkins.org> Reviewed-by: N Balachandran <nbalacha> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> COMMIT: http://review.gluster.org/11665 committed in master by Niels de Vos (ndevos) ------ commit 15796b3d3efb998bdb5413ac0ad1af1903cae493 Author: Hari Gowtham <hgowtham> Date: Tue Jul 14 18:23:16 2015 +0530 cli: changing the assignment to comparison operator on an if statement CID: 1124702 Change-Id: I6366834224a8176824070150b7f2af76b4d65b7f BUG: 789278 Signed-off-by: Hari Gowtham <hgowtham> Reviewed-on: http://review.gluster.org/11665 Tested-by: NetBSD Build System <jenkins.org> Reviewed-by: Humble Devassy Chirammal <humble.devassy> Reviewed-by: Manikandan Selvaganesh <mselvaga> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> REVIEW: http://review.gluster.org/12150 (BZ 789278: Coverity bug fixes for logically dead code) posted (#1) for review on master by Akhil Bhansali (bhansaliakhil) REVIEW: http://review.gluster.org/12150 (BZ 789278: Coverity bug fixes for logically dead code) posted (#2) for review on master by Akhil Bhansali (bhansaliakhil) REVIEW: http://review.gluster.org/12150 (BZ 789278: Coverity bug fixes for logically dead code) posted (#3) for review on master by Akhil Bhansali (bhansaliakhil) REVIEW: http://review.gluster.org/12359 (BZ 789278 : missing break in switch) posted (#1) for review on master by Ashta Bhuja Tripathi (tripathiab13) because of the large number of bugs filed against mainline version\ is ambiguous and about to be removed as a choice. If you believe this is still a bug, please change the status back to NEW and choose the appropriate, applicable version for it. REVIEW: http://review.gluster.org/9637 (cli: Fixing dereference after null check) posted (#20) for review on master by Humble Devassy Chirammal (humble.devassy) REVIEW: http://review.gluster.org/13496 (ganesha : minor coverity fixes) posted (#1) for review on master by jiffin tony Thottan (jthottan) REVIEW: http://review.gluster.org/13496 (ganesha : coverity fix in glusterd-ganesha.c) posted (#2) for review on master by jiffin tony Thottan (jthottan) This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions REVIEW: http://review.gluster.org/10282 (posix: coverity fix for string overflow) posted (#4) for review on master by Sakshi Bansal REVIEW: http://review.gluster.org/9539 (glusterd: coverity fix for string overflow) posted (#8) for review on master by Sakshi Bansal REVIEW: http://review.gluster.org/9558 (glusterd: coverity fix for insecure temporary file) posted (#9) for review on master by Sakshi Bansal REVIEW: http://review.gluster.org/9539 (glusterd: coverity fix for string overflow) posted (#9) for review on master by Sakshi Bansal REVIEW: http://review.gluster.org/10282 (posix: coverity fix for string overflow) posted (#5) for review on master by Sakshi Bansal REVIEW: http://review.gluster.org/9650 (glusterd: coverity fix for TOCTOU) posted (#4) for review on master by Sakshi Bansal REVIEW: http://review.gluster.org/9608 (glusterfsd: coverity fix) posted (#8) for review on master by Sakshi Bansal REVIEW: http://review.gluster.org/9630 (libglusterfs: coverity fix) posted (#5) for review on master by Sakshi Bansal COMMIT: http://review.gluster.org/9558 committed in master by Jeff Darcy (jdarcy) ------ commit 9395b30964ede412ff48e744360b02920daa3a17 Author: Sakshi <sabansal> Date: Wed Apr 15 15:30:51 2015 +0530 glusterd: coverity fix for insecure temporary file Set umask before creating temporary file Change-Id: Ia39af63b05ce68f3f3af6585b70d4129a5530269 BUG: 789278 Signed-off-by: Sakshi <sabansal> Reviewed-on: http://review.gluster.org/9558 Smoke: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> CentOS-regression: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> COMMIT: http://review.gluster.org/9608 committed in master by Jeff Darcy (jdarcy) ------ commit eb7cbf37df611fc5288eb75c7d46ef44fe7d6bab Author: Sakshi Bansal <sabansal> Date: Mon Feb 9 14:28:21 2015 +0530 glusterfsd: coverity fix CID 1124846: string overflow CID 1124363: checked return value CID 1210982: unsigned compare Change-Id: I5995d98c07750615657668535fcc23ac30b3523b BUG: 789278 Signed-off-by: Sakshi Bansal <sabansal> Reviewed-on: http://review.gluster.org/9608 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Jeff Darcy <jdarcy> REVIEW: http://review.gluster.org/9630 (libglusterfs: coverity fix) posted (#6) for review on master by Sakshi Bansal COMMIT: http://review.gluster.org/9630 committed in master by Jeff Darcy (jdarcy) ------ commit d5409aae63a7ac5e5b3ea6cfa16c6250a028291c Author: Sakshi <sabansal> Date: Wed Apr 15 13:28:24 2015 +0530 libglusterfs: coverity fix fix missing varargs cleanup CID 1124856: string overflow CID 1124656: NULL return CID 1124374: constant expression Change-Id: Iead530c599bdfef05a40c68b892215f4e4f02247 BUG: 789278 Signed-off-by: Sakshi Bansal <sabansal> Reviewed-on: http://review.gluster.org/9630 Smoke: Gluster Build System <jenkins.com> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Jeff Darcy <jdarcy> REVIEW: http://review.gluster.org/14818 (glusterd/cli: coverity fixes) posted (#1) for review on master by Atin Mukherjee (amukherj) COMMIT: http://review.gluster.org/14818 committed in master by Jeff Darcy (jdarcy) ------ commit c2d3703ed70d13063d693f135d89538db526ad5c Author: Atin Mukherjee <amukherj> Date: Tue Jun 28 15:32:17 2016 +0530 glusterd/cli: coverity fixes A downstream coverity run has revealed few of the following coverity defects. Since the downstream code is a clone of a specific upstream branch the defects hold true for the upstream as well. Defect type: NEGATIVE_RETURNS xlators/mgmt/glusterd/src/glusterd-rpc-ops.c:641: negative_returns: "op_errno" is passed to a parameter that cannot be negative. Defect type: BUFFER_SIZE_WARNING xlators/mgmt/glusterd/src/glusterd-volume-ops.c:2124: buffer_size_warning: Calling strncpy with a maximum size argument of 261 bytes on destination array "volinfo->volname" of size 261 bytes might leave the destination string unterminated. Defect type: BUFFER_SIZE_WARNING xlators/mgmt/glusterd/src/glusterd-volgen.c:4888: buffer_size_warning: Calling strncpy with a maximum size argument of 261 bytes on destination array "volinfo->volname" of size 261 bytes might leave the destination string unterminated. Defect type: STRING_OVERFLOW xlators/mgmt/glusterd/src/glusterd-volgen.c:3449: string_overflow: You might overrun the 256 byte destination string "tmp_volname" by writing 261 bytes from "volinfo->volname". Defect type: BUFFER_SIZE_WARNING xlators/mgmt/glusterd/src/glusterd-utils.c:3392: buffer_size_warning: Calling strncpy with a maximum size argument of 261 bytes on destination array "new_volinfo->volname" of size 261 bytes might leave the destination string unterminated. Defect type: NO_EFFECT xlators/mgmt/glusterd/src/glusterd-utils.c:7359: remediation: Was "rebal->rebalance_id" formerly declared as a pointer? Defect type: USE_AFTER_FREE xlators/mgmt/glusterd/src/glusterd-utils.c:7115: pass_freed_arg: Passing freed pointer "volinfo" as an argument to "glusterd_friend_contains_vol_bricks". Defect type: DEADCODE cli/src/cli-cmd-parser.c:1767: dead_error_begin: Execution cannot reach this statement: "ret = -1;". Change-Id: Ie941bdf31923e2f39618dd94bfae16fdb3ad65f1 BUG: 789278 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/14818 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> REVIEW: http://review.gluster.org/14899 (cli: fixing resource leak) posted (#1) for review on master by Anonymous Coward REVIEW: http://review.gluster.org/14899 (cli: fixing resource leak) posted (#2) for review on master by Anonymous Coward REVIEW: http://review.gluster.org/14899 (cli : fixing resource leak) posted (#3) for review on master by Anonymous Coward REVIEW: http://review.gluster.org/14902 (cli: fixing the resource leak) posted (#2) for review on master by Anonymous Coward REVIEW: http://review.gluster.org/14902 (cli: fixing the resource leak) posted (#3) for review on master by Anonymous Coward REVIEW: http://review.gluster.org/14902 (cli: fixing the resource leak) posted (#4) for review on master by Anonymous Coward REVIEW: http://review.gluster.org/14902 (cli: fixing the resource leak) posted (#5) for review on master by Anonymous Coward REVIEW: http://review.gluster.org/14902 (cli: fixing the resource leak) posted (#6) for review on master by Anonymous Coward REVIEW: http://review.gluster.org/14902 (cli: fixing the resource leak) posted (#7) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/14975 (core: missunderstanding about GF_PROTOCOL_DICT_SERIALIZE) posted (#3) for review on master by Zhou Zhengping (johnzzpcrystal) REVIEW: http://review.gluster.org/15094 (rpc: fixing illegal memory access) posted (#1) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/15094 (rpc: fixing illegal memory access CID:1357876) posted (#2) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/15094 (rpc: fixing illegal memory access) posted (#3) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/15148 (cli,rpc : Removing logically dead code) posted (#1) for review on master by Muthu Vigneshwaran COMMIT: http://review.gluster.org/15094 committed in master by Jeff Darcy (jdarcy) ------ commit d7c7f87ee3f442ef24cbffb30df289bb26b20a5d Author: Muthu-vigneshwaran <mvignesh> Date: Fri Aug 5 14:05:36 2016 +0530 rpc: fixing illegal memory access CID:1357876 Change-Id: I34eee0bf0367f963ddf6e9d6b28b7d3a9af12c90 BUG: 789278 Signed-off-by: Muthu-vigneshwaran <mvignesh> Reviewed-on: http://review.gluster.org/15094 Tested-by: Muthu Vigneshwaran NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> REVIEW: http://review.gluster.org/15310 (rpc: dead code fix) posted (#3) for review on master by ankitraj REVIEW: http://review.gluster.org/15310 (rpc: dead code fix) posted (#4) for review on master by ankitraj REVIEW: http://review.gluster.org/15317 (rpc: dead code change) posted (#1) for review on master by ankitraj REVIEW: http://review.gluster.org/15310 (rpc: dead code fix) posted (#5) for review on master by ankitraj REVIEW: http://review.gluster.org/15320 (dht: dht_refresh_layout_cbk) posted (#1) for review on master by ankitraj REVIEW: http://review.gluster.org/15320 (dht: dht_refresh_layout_cbk) posted (#2) for review on master by ankitraj REVIEW: http://review.gluster.org/15326 (dht: incorrect data type expression in chunk) posted (#1) for review on master by ankitraj REVIEW: http://review.gluster.org/15326 (dht: incorrect data type expression in chunk) posted (#2) for review on master by ankitraj REVIEW: http://review.gluster.org/15310 (rpc: dead code fix) posted (#6) for review on master by ankitraj COMMIT: http://review.gluster.org/15148 committed in master by Jeff Darcy (jdarcy) ------ commit ddcf0183adebe528a3b069358a1f856eeeae5857 Author: Muthu-vigneshwaran <mvignesh> Date: Thu Aug 11 17:07:29 2016 +0530 cli,rpc : Removing logically dead code CID = 1357865, 1357866 Change-Id: I05eb345e9357d889872d259a600759392b188bb3 BUG: 789278 Signed-off-by: Muthu-vigneshwaran <mvignesh> Reviewed-on: http://review.gluster.org/15148 Tested-by: Muthu Vigneshwaran Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Prashanth Pai <ppai> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Manikandan Selvaganesh <mselvaga> COMMIT: http://review.gluster.org/15310 committed in master by Jeff Darcy (jdarcy) ------ commit ec5c0ca6768b33761aa438f9948c4a6daaf4ee3c Author: ankit <anraj> Date: Wed Aug 24 21:34:35 2016 +0530 rpc: dead code fix CID: 1357866 Change-Id: I117cfd455b05df8d2bd9c8df4a081ffe4d053d09 BUG: 789278 Signed-off-by: ankit <anraj> Reviewed-on: http://review.gluster.org/15310 Smoke: Gluster Build System <jenkins.org> Tested-by: ankitraj NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> REVIEW: http://review.gluster.org/15515 (dht: derefrence null pointer coverity fix) posted (#1) for review on master by ankitraj REVIEW: http://review.gluster.org/15515 (dht: derefrence null pointer coverity fix) posted (#2) for review on master by ankitraj REVIEW: http://review.gluster.org/15515 (dht: derefrence null pointer coverity fix) posted (#3) for review on master by ankitraj REVIEW: http://review.gluster.org/15515 (dht: derefrence null pointer coverity fix) posted (#4) for review on master by ankitraj REVIEW: http://review.gluster.org/15515 (dht: derefrence null pointer coverity fix) posted (#5) for review on master by ankitraj REVIEW: http://review.gluster.org/15515 (dht: derefrence null pointer coverity fix) posted (#6) for review on master by ankitraj REVIEW: http://review.gluster.org/15515 (dht: derefrence null pointer coverity fix) posted (#7) for review on master by ankitraj REVIEW: http://review.gluster.org/15515 (dht: derefrence null pointer coverity fix From the code inspection, I have obseved that at two places there is a need of derefrencing for dht_refresh_layout and dht_refresh_layout_cbk functions to avoid an extra reference.) posted (#8) for review on master by ankitraj REVIEW: http://review.gluster.org/15515 (dht: derefrence null pointer coverity fix) posted (#9) for review on master by ankitraj REVIEW: http://review.gluster.org/15930 (posix : fixing unused values) posted (#1) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/15930 (posix : fixing unused values) posted (#2) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/15989 (glusterd : coverity fix for string overflow) posted (#1) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/15989 (glusterd : coverity fix for string overflow) posted (#2) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/15989 (glusterd : coverity fix for string overflow) posted (#3) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/16028 (glusterfs : Removing logically dead code) posted (#1) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/16028 (rpc : Removing logically dead code) posted (#2) for review on master by Muthu Vigneshwaran REVIEW: http://review.gluster.org/16028 (glusterfs : Removing logically dead code) posted (#3) for review on master by Muthu Vigneshwaran COMMIT: http://review.gluster.org/15989 committed in master by Atin Mukherjee (amukherj) ------ commit b214b643d60cfb30c6578a570963ffc8f79073d8 Author: Muthu-vigneshwaran <mvignesh> Date: Thu Dec 1 15:59:26 2016 +0530 glusterd : coverity fix for string overflow CID : 1357872, 1357873, 1351695 BUG: 789278 Change-Id: I2ee01a6054326f35de621ee7a1f2afd09c5738fe Signed-off-by: Muthu-vigneshwaran <mvignesh> Reviewed-on: http://review.gluster.org/15989 Tested-by: Muthu Vigneshwaran Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Manikandan Selvaganesh <manikandancs333> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> COMMIT: http://review.gluster.org/16028 committed in master by Niels de Vos (ndevos) ------ commit ee6ae7a6d0649c405e8bf096d4781f74494d5263 Author: Muthu-vigneshwaran <mvignesh> Date: Mon Dec 5 21:02:05 2016 +0530 glusterfs : Removing logically dead code CID = 1356502 BUG: 789278 Change-Id: I11a814addc6607902c12aca8f4efec5741cbd7d3 Signed-off-by: Muthu-vigneshwaran <mvignesh> Reviewed-on: http://review.gluster.org/16028 Tested-by: Muthu Vigneshwaran <muthuvigneshwaran77> Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> Reviewed-by: Niels de Vos <ndevos> REVIEW: https://review.gluster.org/16713 (Remove deadcode, found by coverty) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16714 (Remove unused conditionnal) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16715 (Fix ressources leak on error path) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16716 (Fix bad free) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16717 (Reorder the variable initialisation) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16718 (Remove deadcode) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16719 (Free iobuf after using it, not before) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16720 (Remove double free for disk_layout) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16716 (Fix bad free) posted (#2) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16724 (Do no return a pointer that point to a freed memory) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16725 (Do not return a lock that was freed for new_meta_lock) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16726 (Do not return a lock that was already freed in gf_lkmig_info_to_posix_lock) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16727 (Make sure that buffer is null terminated) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16728 (Remove include of mount3.h) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16729 (Refactor the code for posix_handle_pair) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16728 (nfs: remove include of mount3.h) posted (#2) for review on master by Michael Scherer (misc) COMMIT: https://review.gluster.org/16728 committed in master by Niels de Vos (ndevos) ------ commit c1d197c15a836c0131d4d4559e5fdf7394c97963 Author: Michael Scherer <misc> Date: Wed Feb 22 22:08:51 2017 +0100 nfs: remove include of mount3.h While there is proper protection against that, coverity complain of a loop, and nothing in auth-cache.h use a declaration of "mount3.h". Change-Id: I55885ec12496359170f271ae192e9940a35121e1 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16728 Reviewed-by: Niels de Vos <ndevos> Tested-by: Niels de Vos <ndevos> Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> REVIEW: https://review.gluster.org/16738 (Use int instead of int8_t for the 3 variables) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16739 (shared: simplify and fix crash when we run out of memory) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16740 (dnt: Fix crash when showing the error message) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16741 (Do not use va_end before cli_rl_out, since it use ap) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16742 (mgmt: Fix null pointer deref) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16744 (changelog: do not use "this" since that's NULL) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16745 (Do not call va_end twice in _gf_log_eh) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16756 (dnt: Add a GF_DEFRAG_CMD_NONE to gf_defrag_type) posted (#1) for review on master by Michael Scherer (misc) COMMIT: https://review.gluster.org/16727 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 62d3a2c3fc4e09fe8d1cb05f228715eede1a265d Author: Michael Scherer <misc> Date: Wed Feb 22 21:46:14 2017 +0100 Make sure that buffer is null terminated Coverity warn about it, and while that's unlikely to be a issue in practice, it is rather important to not mask more critical problems with false positive. Change-Id: Ibee1a9c37e216635077f05d5ef5de55ad5e0b051 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16727 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Niels de Vos <ndevos> Tested-by: Niels de Vos <ndevos> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/16745 committed in master by Shyamsundar Ranganathan (srangana) ------ commit f08f5bfef923259fe6de6d41a0a2b1b9140fc547 Author: Michael Scherer <misc> Date: Thu Feb 23 23:24:42 2017 +0100 Do not call va_end twice in _gf_log_eh Since va_end is called after the out label, we do not need to call it here, as it make va_end undefined, and thus could cause problem. And this is a error on cppcheck. Change-Id: I6e96c796bd37fa3cde989996ab93f9a438c0ee74 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16745 Smoke: Gluster Build System <jenkins.org> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> REVIEW: https://review.gluster.org/16758 (mgmt: Reset conf_fd to default value to avoid double close) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16759 (nfs: Do not free the same file twice) posted (#1) for review on master by Michael Scherer (misc) COMMIT: https://review.gluster.org/16713 committed in master by Shyamsundar Ranganathan (srangana) ------ commit fe20afb31bdcd92b9c3d41e11872c75ab863f66e Author: Michael Scherer <misc> Date: Wed Feb 22 16:21:11 2017 +0100 Remove deadcode, found by coverty Since ret value is unchanged since last goto out, this code is unreachable. Change-Id: Iff8618739900b44bad6c4e663a4201d9e14cb457 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16713 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/16714 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 04582fa313a4782d7898afb56a0747a5dcca3a92 Author: Michael Scherer <misc> Date: Wed Feb 22 16:31:30 2017 +0100 Remove unused conditionnal The code is using a got to jump 1 line further, which is a no-op. Found by coverty scan Change-Id: Ic8698e2f86ebd9472b3104b09920ab7946c3b4fc BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16714 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/16718 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 8bb29ed9d0d695c66b3be8a9aedb92d87b0c4054 Author: Michael Scherer <misc> Date: Wed Feb 22 17:34:02 2017 +0100 Remove deadcode Found by coverity, ret is already test in the previous 'if'. Change-Id: Iefb7da07c1144470c2322f44b28f98a5904343b4 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16718 Smoke: Gluster Build System <jenkins.org> Tested-by: Michael Scherer <misc> Reviewed-by: Shyamsundar Ranganathan <srangana> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/16717 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 66edcc856d89ffa33318443aa8680c9376772c4d Author: Michael Scherer <misc> Date: Wed Feb 22 17:27:43 2017 +0100 Reorder the variable initialisation Found by coverity, since is_hot_tier is assigned to false, tier_type was always "hot" rather than "cold", making potential debugging likely harder. Change-Id: I49bce1c184548c5de5c00639e83fc3d2dbed90b2 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16717 Smoke: Gluster Build System <jenkins.org> Tested-by: Michael Scherer <misc> Reviewed-by: Shyamsundar Ranganathan <srangana> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/16719 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 730f520a1ee246a5f4a08a321b6f97bdf93536dc Author: Michael Scherer <misc> Date: Wed Feb 22 17:58:24 2017 +0100 Free iobuf after using it, not before Coverity warn of use after free here. I assume that under pressure, this might crash the whole process. Change-Id: I15fb5cfc9b509705e96e4156b739988d816bbef5 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16719 Smoke: Gluster Build System <jenkins.org> Tested-by: Michael Scherer <misc> Reviewed-by: Shyamsundar Ranganathan <srangana> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/16740 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 235ae3528d4e8a914fc208ff05580336c865727c Author: Michael Scherer <misc> Date: Thu Feb 23 21:35:45 2017 +0100 dnt: Fix crash when showing the error message Since this is NULL, this->name would crash the daemon if a incorrect rebal_entry is passed. Found by coverity scan. Change-Id: Ieddf1ef097d13711ab8ec9cd24e125914d2e7245 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16740 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/16756 committed in master by Shyamsundar Ranganathan (srangana) ------ commit d9172b961b85fc2e5431b2970521709680166fe1 Author: Michael Scherer <misc> Date: Fri Feb 24 12:41:45 2017 +0100 dnt: Add a GF_DEFRAG_CMD_NONE to gf_defrag_type Coverity complain about enum mismatch since we assign GF_OP_CMD_NONE to a variable holding gf_defrag_type. Change-Id: I63e71f552b3cc752c26c1b8705420f38908e17e6 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16756 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/16758 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 7fcc85748c54687a1a29f25db7155beccba9d186 Author: Michael Scherer <misc> Date: Fri Feb 24 21:35:38 2017 +0100 mgmt: Reset conf_fd to default value to avoid double close Coverity warn of a path where we use sys_close 2 times on the same file descriptor, which is likely harmless but could cause various hard to debug problems if threads are used (since the file descriptor table is shared among all threads, we could close a newly opened fd by another thread). Change-Id: I0524b31dccc0da94c7b87583e2a88ef06e003518 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16758 Tested-by: Michael Scherer <misc> Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> REVIEW: https://review.gluster.org/16766 (glusterd: Fix the incorrect check) posted (#1) for review on master by Nigel Babu (nigelb) REVIEW: https://review.gluster.org/16766 (glusterd: Fix the incorrect check) posted (#2) for review on master by Nigel Babu (nigelb) REVIEW: https://review.gluster.org/16744 (changelog: do not use "this" since that's NULL) posted (#2) for review on master by Michael Scherer (misc) COMMIT: https://review.gluster.org/16720 committed in master by Jeff Darcy (jdarcy) ------ commit 9c310f7c5ee5e32db349a70120ac82523afb2c51 Author: Michael Scherer <misc> Date: Wed Feb 22 18:04:59 2017 +0100 Remove double free for disk_layout Since disk_layout is freed after the jump to err, we do not need to free it again before the goto. Found by coverity scan. Change-Id: Ie0c0262f6b95c51c61a59faefbca70352bf1e604 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16720 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/16724 committed in master by Jeff Darcy (jdarcy) ------ commit 7759408cb039b13d43143cc8f55a8968e2c15879 Author: Michael Scherer <misc> Date: Wed Feb 22 21:00:02 2017 +0100 Do no return a pointer that point to a freed memory Found by coverity scan. Change-Id: Id4af3b723dfed4acbc878fe462ac0ebc8086759c BUG: 789278 Signed-off-by: Michael Scherer <misc> COMMIT: https://review.gluster.org/16766 committed in master by Jeff Darcy (jdarcy) ------ commit bdabf56a92f4962c10b36d804a34aff8518b1cca Author: Nigel Babu <nigelb> Date: Mon Feb 27 11:07:16 2017 +0530 glusterd: Fix the incorrect check err_str is an array and is therefore never NULL. This condition would always be false. Change-Id: I31eb3338986a3af584e0feca8ec3e16f738378ec BUG: 789278 Signed-off-by: Nigel Babu <nigelb> Reviewed-on: https://review.gluster.org/16766 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> REVIEW: https://review.gluster.org/16782 (Free brick_hint at the end of the function) posted (#1) for review on master by Nigel Babu (nigelb) REVIEW: https://review.gluster.org/16782 (Free brick_hint at the end of the function) posted (#2) for review on master by Nigel Babu (nigelb) REVIEW: https://review.gluster.org/16716 (Fix bad free) posted (#3) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16788 (Free arg_save when malloc fail) posted (#1) for review on master by Michael Scherer (misc) COMMIT: https://review.gluster.org/16788 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 3e66156cf202c56010bfa0c63db95ef0a5998947 Author: Michael Scherer <misc> Date: Tue Feb 28 15:02:18 2017 +0100 Free arg_save when malloc fail Warning found by coverity. Change-Id: Ie755659c33a43a440dadfeb1499a2f6c08e3f625 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16788 Tested-by: Michael Scherer <misc> Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> REVIEW: https://review.gluster.org/16790 (Return ret as soon as `this` is freed) posted (#1) for review on master by Nigel Babu (nigelb) REVIEW: https://review.gluster.org/16782 (Free brick_hint at the end of the function) posted (#3) for review on master by Nigel Babu (nigelb) COMMIT: https://review.gluster.org/16738 committed in master by Raghavendra G (rgowdapp) ------ commit bae7b51d628a3ff4d96be1ec62dca1c8ed008dc8 Author: Michael Scherer <misc> Date: Thu Feb 23 20:17:25 2017 +0100 Use int instead of int8_t for the 3 variables Since strcmp return a int, and since the spec of strcmp do not tell the return value, it could return 256 and this would overflow. Found by Coverity scan. (thanks to Stéphane Marcheusin who explained the details to me) Change-Id: I5195e05b44f8b537226e6cee178d95a1ab904e96 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16738 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Raghavendra G <rgowdapp> COMMIT: https://review.gluster.org/16782 committed in master by Atin Mukherjee (amukherj) ------ commit 13201e55299b4229a4481d886b12fd34d76044ac Author: Nigel Babu <nigelb> Date: Tue Feb 28 13:13:36 2017 +0530 Free brick_hint at the end of the function Not freeing brick_hint causes a memory leak. This error was reported by Coverity. Change-Id: Ic923f892ea5207848cdd3fa6332a1e52e6c996b8 BUG: 789278 Signed-off-by: Nigel Babu <nigelb> Reviewed-on: https://review.gluster.org/16782 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> REVIEW: https://review.gluster.org/16742 (mgmt: Fix null pointer deref) posted (#2) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16793 (Free the mutex even if we can't allocate a inode) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16794 (gidcache: Unlock the gc_lock if the git_list is not yet expired) posted (#1) for review on master by Michael Scherer (misc) COMMIT: https://review.gluster.org/16790 committed in master by Jeff Darcy (jdarcy) ------ commit 9babd965ba885ca8bea4c58e708a3b9f0d6f076c Author: Nigel Babu <nigelb> Date: Wed Mar 1 07:16:19 2017 +0530 Return ret as soon as `this` is freed Omitting this return causes a confusing error message in the next block, which is also a case of use after free. This bug was found by Coverity scan. BUG: 789278 Change-Id: Ifd4932de437e8ae875ff191033ea43cff81b701d Signed-off-by: Nigel Babu <nigelb> Reviewed-on: https://review.gluster.org/16790 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> COMMIT: https://review.gluster.org/16726 committed in master by Jeff Darcy (jdarcy) ------ commit db92780ce57e11ac20cca51bdc4a23d1ae5f129d Author: Michael Scherer <misc> Date: Wed Feb 22 21:16:40 2017 +0100 Do not return a lock that was already freed in gf_lkmig_info_to_posix_lock As others, found by coverity scan. Signed-off-by: Michael Scherer <misc> Change-Id: I3cc6946c865bef90ec7e319311105d0f63caa36f BUG: 789278 COMMIT: https://review.gluster.org/16725 committed in master by Jeff Darcy (jdarcy) ------ commit dd89ad9da5e2b005364cbcf71741c79379c63081 Author: Michael Scherer <misc> Date: Wed Feb 22 21:11:25 2017 +0100 Do not return a lock that was freed for new_meta_lock Found by coverity scan. Change-Id: I9c464914dd421245a00436bf8ab397507ed5178b BUG: 789278 Signed-off-by: Michael Scherer <misc> COMMIT: https://review.gluster.org/16741 committed in master by Jeff Darcy (jdarcy) ------ commit 3c8b3a322d1ecbf99e4718abede32d739bda491c Author: Michael Scherer <misc> Date: Thu Feb 23 22:29:28 2017 +0100 Do not use va_end before cli_rl_out, since it use ap Trigger a cppcheck error Change-Id: I8919fed47ef562319ac6baff38ed993e7cd54708 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16741 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> COMMIT: https://review.gluster.org/16716 committed in master by Jeff Darcy (jdarcy) ------ commit aaa5b2ec2f0ef1a62047c9ab91d957c7b0a1552a Author: Michael Scherer <misc> Date: Wed Feb 22 17:09:46 2017 +0100 Fix bad free Since rsp.path is assigned a constant string, free would operate on a incorrect pointer, with likely bad results. Found by coverity scan Change-Id: I4befdd78573daa3c0c3013100f7ae69a2dcae36a BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16716 Smoke: Gluster Build System <jenkins.org> Tested-by: N Balachandran <nbalacha> Reviewed-by: N Balachandran <nbalacha> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jdarcy> COMMIT: https://review.gluster.org/16793 committed in master by Vijay Bellur (vbellur) ------ commit 7ddab8fa7b05343e4a110fadc227675479f9e358 Author: Michael Scherer <misc> Date: Wed Mar 1 16:38:21 2017 +0100 Free the mutex even if we can't allocate a inode Since GF_CHECK_ALLOC may jump to out, with a mutex locked, we need to make sure the mutex is unlocked before returning. Error found by coverity Change-Id: I81011e18afc90c2c0fd489ceeb78d90ae31e35ba BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16793 Smoke: Gluster Build System <jenkins.org> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Raghavendra Bhat <raghavendra> Reviewed-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/16739 committed in master by Pranith Kumar Karampuri (pkarampu) ------ commit c932c0df4b70abaa85354e56efe6f1ce88ce4a38 Author: Michael Scherer <misc> Date: Thu Feb 23 21:26:33 2017 +0100 shared: simplify and fix crash when we run out of memory Since mem_get0 can return NULL, local->op_ret is gonna crash. Found by coverity. And since we only have ENOMEM as potential error, we can also simplify the code by avoiding using 'local' for that. Change-Id: I778747b57f520b1a52347c0fc9f27efd7a7c5ca0 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16739 Smoke: Gluster Build System <jenkins.org> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Vijay Bellur <vbellur> Reviewed-by: Krutika Dhananjay <kdhananj> Reviewed-by: Pranith Kumar Karampuri <pkarampu> REVIEW: https://review.gluster.org/17023 (upcall: correct the cleanup path in init() when GF_CALLOC() fails) posted (#1) for review on master by Niels de Vos (ndevos) REVIEW: https://review.gluster.org/17024 (gfapi: prevent off-by-one buffer overrun in glfs_sysrq()) posted (#1) for review on master by Niels de Vos (ndevos) REVIEW: https://review.gluster.org/17026 (gfapi: remove unneeded NULL-check in glfs_fsync_async_common()) posted (#1) for review on master by Niels de Vos (ndevos) COMMIT: https://review.gluster.org/17023 committed in master by Jeff Darcy (jeff.us) ------ commit 88551d8567503b3eba17e54fbe7dd9ee6266c1ab Author: Niels de Vos <ndevos> Date: Mon Apr 10 10:10:30 2017 +0200 upcall: correct the cleanup path in init() when GF_CALLOC() fails Coverity found that "priv" can be NULL when the 1st GF_CALLOC() fails, and still is being used with "priv->xattrs" before the functon returns. While cleaning this up, also removing the log message for out of memory, as this is already logged through GF_CALLOC(). BUG: 789278 Change-Id: I887eaa9136dc25a39c107cd2152b1ba11f9fa925 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: https://review.gluster.org/17023 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: soumya k <skoduri> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/17026 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 78c4e657dc2e122b00f99912819357c85e35d54d Author: Niels de Vos <ndevos> Date: Mon Apr 10 11:02:41 2017 +0200 gfapi: remove unneeded NULL-check in glfs_fsync_async_common() Coverity reported that "glfd" has a NULL-check at the end of the function, but is used without checking earlier. Because "glfd" is passed as parameter to the (internal) function, there is no need to have the additional NULL-check. Change-Id: I1390b2ef250fbf624f0bc2b0eda7b7588942aae9 BUG: 789278 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: https://review.gluster.org/17026 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Shyamsundar Ranganathan <srangana> REVIEW: https://review.gluster.org/17024 (gfapi: prevent off-by-one buffer overrun in glfs_sysrq()) posted (#2) for review on master by Niels de Vos (ndevos) REVIEW: https://review.gluster.org/17024 (gfapi: prevent off-by-one buffer overrun in glfs_sysrq()) posted (#3) for review on master by Niels de Vos (ndevos) REVIEW: https://review.gluster.org/17024 (gfapi: prevent off-by-one buffer overrun in glfs_sysrq()) posted (#4) for review on master by Niels de Vos (ndevos) COMMIT: https://review.gluster.org/17024 committed in master by Niels de Vos (ndevos) ------ commit 4c623481986a4697fe7bbb3f553b877d38650422 Author: Niels de Vos <ndevos> Date: Mon Apr 10 10:29:15 2017 +0200 gfapi: prevent off-by-one buffer overrun in glfs_sysrq() Coverity found a potential buffer overrun in the strncat() usage for logging the help message with glfs_sysrq(). This seems to be an off-by-one mistake and should be addressed by reducing the initial size of the remainder calculation. Change-Id: Ide14add1cb28e5200d2c0df6b3a5154999ef3ca9 BUG: 789278 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: https://review.gluster.org/17024 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Amar Tumballi <amarts> REVIEW: https://review.gluster.org/17161 (gfapi: Fix few severe coverity fixes) posted (#1) for review on master by soumya k (skoduri) REVIEW: https://review.gluster.org/17161 (gfapi: Fix few severe coverity issues) posted (#2) for review on master by soumya k (skoduri) REVIEW: https://review.gluster.org/16729 (Refactor the code for posix_handle_pair) posted (#2) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16715 (Fix ressources leak on error path) posted (#2) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/16742 (mgmt: Fix null pointer deref) posted (#3) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/17165 (Remove double free) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/17166 (Fix unused return value warning) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/17161 (gfapi: Fix few severe coverity issues) posted (#3) for review on master by soumya k (skoduri) REVIEW: https://review.gluster.org/17161 (gfapi: Fix few severe coverity issues) posted (#4) for review on master by soumya k (skoduri) COMMIT: https://review.gluster.org/16742 committed in master by Jeff Darcy (jeff.us) ------ commit 7c98143c7928f4ec936c90f0125b2a2aaf8f5174 Author: Michael Scherer <misc> Date: Thu Feb 23 22:57:42 2017 +0100 mgmt: Fix null pointer deref since "this" can be NULL, we should skip this validation, there is another call to GF_VALIDATE_OR_GOTO in the following lines. Found by cppcheck. Change-Id: I329f50b986a9eaf3315e09f851080ab41bea57c0 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16742 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jeff.us> Tested-by: Jeff Darcy <jeff.us> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/16729 committed in master by Jeff Darcy (jeff.us) ------ commit d7cb404d9f75253b86b7a9263cab56ec853c5c94 Author: Michael Scherer <misc> Date: Wed Feb 22 22:47:02 2017 +0100 Refactor the code for posix_handle_pair It was no longer compiling on Darwin, and triggered a cppcheck error: [xlators/storage/posix/src/posix-helpers.c:1097]: (error) Invalid number of character '{' when these macros are defined: 'GF_DARWIN_HOST_OS'. Change-Id: I986609cc6cfc13ddea0ed35d7776736171f40a41 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16729 Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> Reviewed-by: Jeff Darcy <jeff.us> COMMIT: https://review.gluster.org/17165 committed in master by Jeff Darcy (jeff.us) ------ commit b3229ed1071b8e45b0717abef0adf1c17c9df81c Author: Michael Scherer <misc> Date: Wed May 3 16:54:46 2017 +0200 Remove double free Since there is already GF_FREE (value) near the out label, this one is uneeded. Found by coverity. Change-Id: Ib4a4e1a6af186e14fc75e7578c79beb58de053ec BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/17165 Smoke: Gluster Build System <jenkins.org> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/17161 committed in master by Niels de Vos (ndevos) ------ commit fa10c8a3528b95dc575bfedd30bcd68cc2dff25b Author: Soumya Koduri <skoduri> Date: Wed May 3 18:39:14 2017 +0530 gfapi: Fix few severe coverity issues From https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-05-03-6484558c/html/ fixes coverity#189, 248, 250, 488, 546 Change-Id: I7c4aa5bf6c367344602748dfd736de27f341cca2 BUG: 789278 Signed-off-by: Soumya Koduri <skoduri> Reviewed-on: https://review.gluster.org/17161 Smoke: Gluster Build System <jenkins.org> Reviewed-by: Niels de Vos <ndevos> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> CentOS-regression: Gluster Build System <jenkins.org> REVIEW: https://review.gluster.org/17193 (Fix 'flush' type, coverity warning) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/17195 (Remove uneeded goto (as it jump to the next line) posted (#1) for review on master by Michael Scherer (misc) REVIEW: https://review.gluster.org/17195 (Remove uneeded gotos, as it jump to the next line) posted (#2) for review on master by Michael Scherer (misc) COMMIT: https://review.gluster.org/16715 committed in master by Jeff Darcy (jeff.us) ------ commit 1538b7296cc0a3150f33190f97dc99c9ca126322 Author: Michael Scherer <misc> Date: Wed Feb 22 16:40:12 2017 +0100 Fix ressources leak on error path Coverty found a path where blk_fop is not freed, thus leaking memory. The main cause is because we are using the wrong variable for errors. I do not think this is leaking anything in practice, since the error condition seems quite rare, but fixing this should remove around 15 coverty warning. Change-Id: Ida0ea59f501f0a21bd1d8119aa1a299ce655add8 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/16715 Smoke: Gluster Build System <jenkins.org> Reviewed-by: soumya k <skoduri> CentOS-regression: Gluster Build System <jenkins.org> Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Jeff Darcy <jeff.us> COMMIT: https://review.gluster.org/17195 committed in master by Jeff Darcy (jeff.us) ------ commit 5b8e9261f1e8aab1a3475578d56d54037459a5e6 Author: Michael Scherer <misc> Date: Fri May 5 17:20:14 2017 +0200 Remove uneeded gotos, as it jump to the next line Found by coverity Signed-off-by: Michael Scherer <misc> Change-Id: I1fef09a427d18bbeb9af0bf4f5c82c77aa3c0d3d BUG: 789278 Reviewed-on: https://review.gluster.org/17195 Tested-by: Michael Scherer <misc> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Prashanth Pai <ppai> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Jeff Darcy <jeff.us> Smoke: Gluster Build System <jenkins.org> COMMIT: https://review.gluster.org/17193 committed in master by Jeff Darcy (jeff.us) ------ commit 27b04b6c487e789074eb10c93be0f7d4f58fa945 Author: Michael Scherer <misc> Date: Fri May 5 16:01:36 2017 +0200 Fix 'flush' type, coverity warning As getchar returna a int, (which is 4 bytes on most common platforms, and at least 2 bytes), and char being often 1 byte, the conversion would lose information, hence the warning. Change-Id: I5b0b39c636ff49ef5c15d51a7f798e21635eca06 BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/17193 Tested-by: Michael Scherer <misc> Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Prashanth Pai <ppai> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Zhou Zhengping <johnzzpcrystal> Reviewed-by: Jeff Darcy <jeff.us> COMMIT: https://review.gluster.org/9539 committed in master by Jeff Darcy (jeff.us) ------ commit 9dc37dd8aa57bea5b86ac4f2a44e31106aeb58ad Author: Sakshi Bansal <sabansal> Date: Tue Feb 3 10:48:49 2015 +0530 glusterd: coverity fix for string overflow coverity CID: 1124852 Change-Id: Ifb04ad36b0652474007d2768737722231a5c1df0 BUG: 789278 Signed-off-by: Sakshi Bansal <sabansal> Reviewed-on: https://review.gluster.org/9539 Smoke: Gluster Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Kaleb KEITHLEY <kkeithle> Tested-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Jeff Darcy <jeff.us> REVIEW: https://review.gluster.org/16759 (nfs/netgroups: do not free the same file twice) posted (#2) for review on master by Niels de Vos (ndevos) COMMIT: https://review.gluster.org/16759 committed in master by Niels de Vos (ndevos) ------ commit ff1a1694112f141991e24284b90f568506aaca41 Author: Michael Scherer <misc> Date: Fri Feb 24 22:32:06 2017 +0100 nfs/netgroups: do not free the same file twice Coverity warn about a code path where 'file' is freed twice. And reading the code, I also found that 'line' shouldn't be freed using GF_FREE since it was allocated by getline. Also call _ng_deinit_parsers() in the success case, preventing leaking two 'struct parser' upon multiple calls to ng_file_parse(). Change-Id: I05d71fdbf3b48a25d35e7a56a4c245ceb2dd6ed9 BUG: 789278 Signed-off-by: Michael Scherer <misc> [ndevos: add _ng_deinit_parsers() cleanup suggested by Nithya] Reviewed-on: https://review.gluster.org/16759 Reviewed-by: Niels de Vos <ndevos> Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> REVIEW: https://review.gluster.org/18245 (Fix use-after-free in gf_rdma_do_reads) posted (#1) for review on master by Michael Scherer (misc) COMMIT: https://review.gluster.org/18245 committed in master by Raghavendra G (rgowdapp) ------ commit e9acd3130374ce5d512b784310a729734e6655a5 Author: Michael Scherer <misc> Date: Fri Sep 8 18:45:12 2017 +0200 Fix use-after-free in gf_rdma_do_reads If iobref_new can't allocate a ref, we free the iobuf, and then go to the cleanup part of the function, that will run iobuf_unref a 2nd time, which trigger a warning with coverity. Change-Id: Ie9cf7a5d5f98244a390e44e1403c614199eb650c BUG: 789278 Signed-off-by: Michael Scherer <misc> Reviewed-on: https://review.gluster.org/18245 Smoke: Gluster Build System <jenkins.org> Tested-by: Raghavendra G <rgowdapp> Reviewed-by: Raghavendra G <rgowdapp> CentOS-regression: Gluster Build System <jenkins.org> REVIEW: https://review.gluster.org/18332 (Coverity Issue Fix) posted (#1) for review on master by Anonymous Coward REVIEW: https://review.gluster.org/18338 (Changes made in declaration) posted (#1) for review on master by Anonymous Coward REVIEW: https://review.gluster.org/18339 (Coverity Issue Fix) posted (#1) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18340 (Coverity Issue Fix) posted (#1) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18341 (Coverity Issue Fix) posted (#1) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18342 (Coverity Issue Fix) posted (#1) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18339 (Coverity Issue : Always TRUE for the if-condition) posted (#2) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18343 (Fix a coverity error of checker type: BUFFER_SIZE) posted (#1) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18344 (Coverity Issue : Buffer_Size_Warning) posted (#1) for review on master by Anonymous Coward REVIEW: https://review.gluster.org/18345 (Coverity Issue Fix Checker: CHECKED_RETURN) posted (#1) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18345 (Coverity Issue Fix Checker: CHECKED_RETURN) posted (#2) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18347 (Coverity Issue Fix Checker : BUFFER_SIZE) posted (#1) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18348 (Coverity Issue checker: unused_value) posted (#1) for review on master by Anonymous Coward REVIEW: https://review.gluster.org/18351 (Coverity Error Fix: Buffer Size Warning) posted (#1) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18352 (Coverity Issue Fix Checker: MISSING_BREAK) posted (#1) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18353 (Coverity Issue Fix Checker: MISSING_BREAK) posted (#1) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18352 (Coverity Issue Fix: MISSING_BREAK) posted (#2) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18353 (Coverity Issue Fix: MISSING_BREAK) posted (#2) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18345 (Coverity Issue Fix: CHECKED_RETURN) posted (#3) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18347 (Coverity Issue Fix: BUFFER_SIZE) posted (#2) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18352 (Coverity Issue Fix: MISSING_BREAK) posted (#3) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18356 (Coverity Issue Fix: IDENTICAL_BRANCHES) posted (#1) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18357 (Coverity Issue Fix: IDENTICAL_BRANCHES) posted (#1) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18358 (Coverity Issue Fix: NEGATIVE_RETURNS) posted (#1) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18332 (Coverity Issue Fix : CHECKED_RETURN) posted (#2) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18339 (Coverity Issue Fix : CONSTANT_EXPRESSION_RESULT) posted (#3) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18340 (Coverity Issue Fix : UNUSED_VALUE) posted (#2) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18341 (Coverity Issue Fix : DEADCODE) posted (#2) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18342 (Coverity Issue Fix : IDENTICAL_BRANCHES) posted (#2) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18347 (Coverity Issue Fix: BUFFER_SIZE) posted (#3) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18359 (Coverity Issue Fix :NEGATIVE_RETURNS) posted (#1) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18361 (Coverity Issue Fix: NEGATIVE_RETURNS) posted (#1) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18362 (Coverity Issue fix: missing break) posted (#1) for review on master by Anonymous Coward (kburmee) REVIEW: https://review.gluster.org/18363 (Fix a coverity error of checker type: CHECKED_RETURN) posted (#1) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18364 (Fix a coverity error of type: UNUSED_VALUE) posted (#1) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18365 (Coverity Issue Fix : CHECKED_RETURN) posted (#1) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18366 (Fix a coverity error of type: UNREACHABLE) posted (#1) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18367 (Coverity Error fix) posted (#1) for review on master by Anonymous Coward REVIEW: https://review.gluster.org/18370 (Removing the unreachable statements) posted (#1) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18370 (Glusterfsd/snapshot: Unreachable statements) posted (#2) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18372 (Coverity issue fix: IDENTICAL_BRANCHES) posted (#1) for review on master by Kartik Burmee (kburmee) REVIEW: https://review.gluster.org/18373 (Fix a coverity error of type: PW.INCLUDE_RECURSION) posted (#1) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18374 (Coverity issue fix: UNREACHABLE) posted (#1) for review on master by Kartik Burmee (kburmee) REVIEW: https://review.gluster.org/18375 (Coverity Error: Constant Expression usage) posted (#1) for review on master by Anonymous Coward REVIEW: https://review.gluster.org/18377 (Coverity Issue Fix : UNUSED_VALUE) posted (#1) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18378 (Coverity Issue Fix: CONSTANT_EXPRESSION_RESU) posted (#1) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18370 (Glusterfsd: Unreachable statements) posted (#3) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18379 (Coverity issue fix: checked return) posted (#1) for review on master by Kartik Burmee (kburmee) REVIEW: https://review.gluster.org/18380 (Posix: Unused value) posted (#1) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18377 (Coverity Issue Fix : UNUSED_VALUE) posted (#2) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18383 (tack.h:PW.INCLUDE_RECURSION) posted (#1) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18370 (Glusterfsd: Unreachable statements) posted (#4) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18384 (fuse-lib/mount: Checked Return) posted (#1) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18361 (Coverity Issue Fix: NEGATIVE_RETURNS) posted (#2) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18385 (glusterd: FORWARD_NULL coverity fix) posted (#1) for review on master by Akarsha Rai REVIEW: https://review.gluster.org/18383 (stack.h:PW.INCLUDE_RECURSION) posted (#2) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18386 (stack.h:PW.INCLUDE_RECURSION) posted (#1) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18389 (Coverity Error: Forward NULL) posted (#1) for review on master by Anonymous Coward REVIEW: https://review.gluster.org/18390 (Coverity Error: Lock) posted (#1) for review on master by Anonymous Coward REVIEW: https://review.gluster.org/18385 (glusterd: FORWARD_NULL coverity fix) posted (#2) for review on master by Akarsha Rai REVIEW: https://review.gluster.org/18392 (glusterd: FORWARD_NULL coverity fix) posted (#1) for review on master by Akarsha Rai REVIEW: https://review.gluster.org/18361 (Coverity Issue Fix: NEGATIVE_RETURNS) posted (#3) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18385 (glusterd: FORWARD_NULL coverity fix) posted (#3) for review on master by Akarsha Rai REVIEW: https://review.gluster.org/18385 (glusterd: FORWARD_NULL coverity fix) posted (#4) for review on master by Akarsha Rai COMMIT: https://review.gluster.org/18363 committed in master by N Balachandran (nbalacha) ------ commit 490f27c44f0a4feb8c52fc31f28163310690e0a1 Author: Kamal Mohanan <kmohanan> Date: Mon Sep 25 10:57:21 2017 +0530 Fix a coverity error of checker type: CHECKED_RETURN Problem: dht_frame_return was being called without checking the return value. Solution: Typecast the value returned by the function to void. Change-Id: Idfc6a7ed467d1c8f5f8d09ec26d9059f3d23b760 BUG: 789278 Signed-off-by: Kamal Mohanan <kmohanan> REVIEW: https://review.gluster.org/18393 (glusterd: FORWARD_NULL coverity fix) posted (#1) for review on master by Akarsha Rai (akrai) REVIEW: https://review.gluster.org/18393 (cluster/ec: FORWARD_NULL coverity fix) posted (#2) for review on master by Akarsha Rai (akrai) REVIEW: https://review.gluster.org/18394 (cluster/ec: FORWARD_NULL coverity fix) posted (#1) for review on master by Akarsha Rai (akrai) REVIEW: https://review.gluster.org/18361 (Coverity Issue Fix: NEGATIVE_RETURNS) posted (#4) for review on master by Subha sree Mohankumar (smohanku) COMMIT: https://review.gluster.org/18365 committed in master by Jeff Darcy (jeff.us) ------ commit 83d2bf8815bb4d79349659a7d5b9df822acd5430 Author: Subha sree Mohankumar <smohanku> Date: Mon Sep 25 11:49:16 2017 +0530 Coverity Issue Fix : CHECKED_RETURN Issue :Event check_return: Calling "ec_dict_set_number" without checking return value. Fix : Type casted the return value of the function "ec_dict_set_number" to void. Change-Id: Id97034f9b1b8591536d63dca680ca7c7a9c4fcc3 BUG: 789278 Signed-off-by: Subha sree Mohankumar <smohanku> COMMIT: https://review.gluster.org/18370 committed in master by Jeff Darcy (jeff.us) ------ commit b269089a33bd1348d34c861817c3f673206b6a18 Author: Sanju Rakonde <srakonde> Date: Mon Sep 25 12:34:05 2017 +0530 Glusterfsd: Unreachable statements Issue: Event unreachable at line number 1111 in glusterfsd/src/glusterfsd.c There was a statement in outer if block after the break statement. Ideally the break statement should be inside the inner if block so that the statement will not become unreachable. I put the break inside the inner if block. Change-Id: Id4917305333e1638f35b3f2fb59ac42e62a12d02 BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/18380 committed in master by Jeff Darcy (jeff.us) ------ commit 467f1f3c3037efac0497d50510247e62605c3f3a Author: Sanju Rakonde <srakonde> Date: Mon Sep 25 15:53:24 2017 +0530 Posix: Unused value In line number 5179 we are storing -1 into op_ret variable. Before we use the value we are overwriting the same variable in line number 5339. So we are removing the value assigning statement. Change-Id: I8c6dae9f6b0f9f1e3c09d0744d451b9296d12db8 BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/18397 (protocol: UNINIT coverity fix) posted (#1) for review on master by Akarsha Rai (akrai) COMMIT: https://review.gluster.org/18357 committed in master by Atin Mukherjee (amukherj) ------ commit a2bbf75d04e8173c2156a001538564d141a26d4a Author: Girjesh Rajoria <grajoria> Date: Sat Sep 23 02:00:56 2017 +0530 Coverity Issue Fix: IDENTICAL_BRANCHES Issue: Event identical_branches: The same code is executed when the condition "ret" is true or false, because the code in the if-then branch and after the if statement is identical. Function: glusterd_print_gsync_status_by_vol Fix: removed if and goto statement. Change-Id: I966d793c9f3b65487acfb07083a4039caf593105 BUG: 789278 Signed-off-by: Girjesh Rajoria <grajoria> COMMIT: https://review.gluster.org/18385 committed in master by Atin Mukherjee (amukherj) ------ commit 13d2af4ffeb3b968a3c4675247513d429972d31d Author: Akarsha Rai <akrai> Date: Mon Sep 25 08:36:36 2017 -0400 glusterd: FORWARD_NULL coverity fix Problem: Pointer used to print xlator name could be NULL. Solution: Updated the code to use xlator name as appropriate. BUG: 789278 Change-Id: I26927ef1f33f362e17c104684d7f722a643c7f97 Signed-off-by: Akarsha Rai <akrai> REVIEW: https://review.gluster.org/18358 (libglusterfs: Coverity Issue NEGATIVE_RETURNS) posted (#2) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18397 (protocol: UNINIT coverity fix) posted (#2) for review on master by Akarsha Rai (akrai) REVIEW: https://review.gluster.org/18383 (stack.h:PW.INCLUDE_RECURSION) posted (#3) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18373 (libglusterfs: fix a coverity error of type - PW.INCLUDE_RECURSION) posted (#2) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18366 (dht: fix a coverity error of type - UNREACHABLE) posted (#2) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18392 (cluster/ec: FORWARD_NULL coverity fix) posted (#2) for review on master by Akarsha Rai (akrai) REVIEW: https://review.gluster.org/18351 (glusterd/snapshot: Buffer Size Warning) posted (#2) for review on master by Sanju Rakonde (srakonde) REVIEW: https://review.gluster.org/18389 (glusterd: Introduce an extra if condition to check if this points to an address and is not pointing to NULL.) posted (#2) for review on master by Vishal Pandey (vpandey) REVIEW: https://review.gluster.org/18389 (glusterd: Introduce an extra if condition to check if "this" points to an address and is not pointing NULL.) posted (#3) for review on master by Vishal Pandey (vpandey) REVIEW: https://review.gluster.org/18389 (glusterd: Coverity Issue FORWARD_NULL fix) posted (#4) for review on master by Vishal Pandey (vpandey) REVIEW: https://review.gluster.org/18342 (Coverity Issue Fix : IDENTICAL_BRANCHES) posted (#3) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18348 (Coverity Issue checker: unused_value) posted (#2) for review on master by mohammed rafi kc (rkavunga) COMMIT: https://review.gluster.org/18373 committed in master by Jeff Darcy (jeff.us) ------ commit 77f89a2ebac1c19c4f22f33aba536bbe7e19e665 Author: Kamal Mohanan <kmohanan> Date: Mon Sep 25 12:50:43 2017 +0530 libglusterfs: fix a coverity error of type - PW.INCLUDE_RECURSION Problem: xlator.h which is included at inode.h:32 includes itself. Solution: Delete the include statement. Change-Id: I304bbef5293a2fef0584773a1f8e61e838d7cbf1 BUG: 789278 Signed-off-by: Kamal Mohanan <kmohanan> COMMIT: https://review.gluster.org/18397 committed in master by mohammed rafi kc (rkavunga) ------ commit 165827e3812942f8a9bd96880bc316820a297821 Author: Akarsha Rai <akrai> Date: Tue Sep 26 08:51:04 2017 -0400 protocol: UNINIT coverity fix Problem: Coverity issue due uninitialized variable. Solution: Initialized the variable appropriately. Bug: 789278 Change-Id: I6e9356bbcd8fa97006b605ee162458d4a2eb5887 Signed-off-by: Akarsha Rai <akrai> REVIEW: https://review.gluster.org/18358 (libglusterfs: Coverity Issue NEGATIVE_RETURNS) posted (#3) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18358 (libglusterfs: Coverity Issue NEGATIVE_RETURNS) posted (#4) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18352 (rpc/rpc-transport/socket/: Coverity Issue MISSING_BREAK) posted (#4) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18332 (Coverity Issue Fix : CHECKED_RETURN) posted (#3) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18377 (Coverity Issue Fix : UNUSED_VALUE) posted (#3) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18366 (dht: fix a coverity error of type - UNREACHABLE) posted (#3) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18353 (Coverity Issue Fix: MISSING_BREAK) posted (#3) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18353 (glusterfsd: Coverity Issue "MISSING_BREAK" in parse_opts) posted (#4) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18377 (Coverity Issue Fix : UNUSED_VALUE) posted (#4) for review on master by Subha sree Mohankumar (smohanku) COMMIT: https://review.gluster.org/18392 committed in master by Jeff Darcy (jeff.us) ------ commit 3a423437e35fa46befa28fa030cef26d6663e507 Author: Akarsha Rai <akrai> Date: Tue Sep 26 04:58:19 2017 -0400 cluster/ec: FORWARD_NULL coverity fix Problem: Pool pointer could be NULL while destroying it. Solution: Verifying pointer before destroying it. BUG: 789278 Change-Id: I497d1310aa47cb749a4c992aa961bd4dfa23ee48 Signed-off-by: Akarsha Rai <akrai> REVIEW: https://review.gluster.org/18343 (Fix a coverity error of checker type: BUFFER_SIZE) posted (#2) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18378 (xlators/protocol/server: Coverity Issue in server_setvolume()) posted (#2) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18358 (libglusterfs: Coverity Issue NEGATIVE_RETURNS) posted (#5) for review on master by Girjesh Rajoria (grajoria) COMMIT: https://review.gluster.org/18366 committed in master by Shyamsundar Ranganathan (srangana) ------ commit 8daaac1481adc919cb80c6f3d98bc5b3f0b829f5 Author: Kamal Mohanan <kmohanan> Date: Mon Sep 25 12:07:03 2017 +0530 dht: fix a coverity error of type - UNREACHABLE Problem: Unreachable assignment statement at dht-rebalance.c:1040 Fix: Delete line dht-rebalance.c:1040. The goto statements at lines 1037 and 1031 are also deleted since both branches of the if statement finally go to the same immediately-following label anyway. Change-Id: I5f47ea99244cae2a0a9f2aec7284faadf2ea286a BUG: 789278 Signed-off-by: Kamal Mohanan <kmohanan> REVIEW: https://review.gluster.org/18332 (xlators/io-stats: Coverity Fix CHECKED_RETURN in resolve_group_name) posted (#4) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18339 (libglusterfs/common-utils: Coverity Fix CONSTANT_EXPRESSION_RESULT in gf_string2int64) posted (#4) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18341 (cli: fix Coverity warning DEADCODE in gf_cli_attach_tier()) posted (#3) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18342 (protocol/client: Coverity Fix IDENTICAL_BRANCHES in client3_3_flush_cbk) posted (#4) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18339 (libglusterfs: Coverity Fix CONSTANT_EXPRESSION_RESULT in gf_string2int64) posted (#5) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18377 (glusterfs:coverity Issue "UNUSED_VALUE" in afr_get_split_brain_status) posted (#5) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18377 (xlator/cluster/afr:coverity Issue "UNUSED_VALUE" in afr_get_split_brain_status) posted (#6) for review on master by Subha sree Mohankumar (smohanku) COMMIT: https://review.gluster.org/18352 committed in master by Raghavendra G (rgowdapp) ------ commit a2039f3e97049806ca0847a84cc9030e31f4d008 Author: Girjesh Rajoria <grajoria> Date: Fri Sep 22 19:09:34 2017 +0530 rpc/rpc-transport/socket/: Coverity Issue MISSING_BREAK Issue: Event unterminated_case: The case for value "AF_INET_SDP" is not terminated by a 'break' statement. Function: socket_server_get_local_sockaddr Added Fall through in comment after case AF_INET_SDP. Change-Id: I5340cde2257be33ff13c53cee6ccdb33df7d2c88 BUG: 789278 Signed-off-by: Girjesh Rajoria <grajoria> REVIEW: https://review.gluster.org/18377 (xlator/cluster/afr:coverity Issue "UNUSED_VALUE" in afr_get_split_brain_status) posted (#7) for review on master by Subha sree Mohankumar (smohanku) COMMIT: https://review.gluster.org/18383 committed in master by Niels de Vos (ndevos) ------ commit 2c124b5256bac5830d81552bfb4412620aa6cfb0 Author: Sanju Rakonde <srakonde> Date: Mon Sep 25 17:29:25 2017 +0530 stack.h:PW.INCLUDE_RECURSION The headerfile globals.h is recursively adding itself. ( globals.h -> xlator.h -> stack.h -> globals.h). We are finding the source files which are including the header file globals.h and removing the inclusion line. I used git grep -l stack.h | xargs git grep globals.h -- to find out the files and removed the header file from all files except libglusterfs/src/xlator.h and libglusterfs/src/Makefile.am When I try to remove header file from libglusterfs/src/xlator.h I'm getting some errors. In libglusterfs/src/Makefile.am it is required for building RPMs. Change-Id: I537218c09ade6d7ea51717768b26563a247daf60 BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/18378 committed in master by Raghavendra G (rgowdapp) ------ commit 703728dd6f0431ba82821794ca6e9e8b43b35811 Author: Girjesh Rajoria <grajoria> Date: Mon Sep 25 14:52:24 2017 +0530 xlators/protocol/server: Coverity Issue in server_setvolume() Issue: Event result_independent_of_operands: "rsp->dict.dict_len > 4294967295U /* 2147483647 * 2U + 1U */" is always false regardless of the values of its operands. This occurs as the logical operand of "if". Fix: removed if block as the if condition is always false and statement inside block never executes. Change-Id: Ieaa968d6fbc9477428b4658ef725ace0db9b810a BUG: 789278 Signed-off-by: Girjesh Rajoria <grajoria> REVIEW: https://review.gluster.org/18377 (xlator/cluster/afr:coverity Issue "UNUSED_VALUE" in afr_get_split_brain_status) posted (#8) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18377 (xlator/cluster/afr:coverity Issue "UNUSED_VALUE" in afr_get_split_brain_status) posted (#9) for review on master by Subha sree Mohankumar (smohanku) COMMIT: https://review.gluster.org/18394 committed in master by Xavier Hernandez (jahernan) ------ commit eebeb504578e774eef6e762326baadaab014b9ae Author: Akarsha Rai <akrai> Date: Tue Sep 26 06:44:15 2017 -0400 cluster/ec: FORWARD_NULL coverity fix Problem: cbk could be NULL. Solution: Returning NULL when memory is not allocated for cbk. BUG: 789278 Change-Id: Iea9128e0f3b95100deca560f690f9baaae226abf Signed-off-by: Akarsha Rai <akrai> COMMIT: https://review.gluster.org/18342 committed in master by Niels de Vos (ndevos) ------ commit d01a674077f2411ecde7bd6037efbfcf6faa65ba Author: Mohammed Azhar Padariyakam <mpadariy> Date: Thu Sep 21 20:55:05 2017 +0530 protocol/client: Coverity Fix IDENTICAL_BRANCHES in client3_3_flush_cbk Issue : The same code is executed when the condition "ret < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Solution : Remove the if-condition whose output does not alter the program flow of control Fix : The identical branching condition was removed. Change-Id: Iae40f068e5a03946273e1091886ba7011460fcc8 BUG: 789278 Signed-off-by: Mohammed Azhar Padariyakam <mpadariy> COMMIT: https://review.gluster.org/18341 committed in master by Niels de Vos (ndevos) ------ commit e348b4df9bfd80be5c521bc4c76faf2693e90692 Author: Mohammed Azhar Padariyakam <mpadariy> Date: Thu Sep 21 20:19:44 2017 +0530 cli: fix Coverity warning DEADCODE in gf_cli_attach_tier() Issue : At condition "ret", the value of "ret" must be equal to 0. The condition "ret" cannot be true since the value is always 0. Hence, the execution cannot reach the statement "goto out" Solution : The never-true if-condition and its body has to be removed Fix : The always false if-condition and the dead code under this if-condition was removed. Change-Id: I5c038b8ec9abf9b2f06dcfd981904b9dca1a0094 BUG: 789278 Signed-off-by: Mohammed Azhar Padariyakam <mpadariy> COMMIT: https://review.gluster.org/18358 committed in master by Jeff Darcy (jeff.us) ------ commit e994fbc825b0ce48bbe0c23d034e821502359912 Author: Girjesh Rajoria <grajoria> Date: Sat Sep 23 02:28:34 2017 +0530 libglusterfs: Coverity Issue NEGATIVE_RETURNS Issue: Event negative_return_fn: Function "dup(handle->fd)" returns a negative number. Event negative_returns: "dup(handle->fd)" is passed to a parameter that cannot be negative. With this change value of dup(handle->fd) is stored in duped_fd & if condition checks the value of duped_fd is non-negative. Change-Id: I563d717108016d740ffa64fbe0929eb1e08c8f33 BUG: 789278 Signed-off-by: Girjesh Rajoria <grajoria> COMMIT: https://review.gluster.org/18393 committed in master by Jeff Darcy (jeff.us) ------ commit 687908a364efcfb5ed69ff3dd0a8ef5b1551e88e Author: Akarsha Rai <akrai> Date: Tue Sep 26 06:09:28 2017 -0400 cluster/ec: FORWARD_NULL coverity fix Problem: ctx pointer could be NULL Solution: Updated the code to verify ctx pointer BUG: 789278 Change-Id: I25e07a07c6ebe2f630c99ba3aa9a61656fbaa981 Signed-off-by: Akarsha Rai <akrai> COMMIT: https://review.gluster.org/18353 committed in master by Jeff Darcy (jeff.us) ------ commit 8154e044e1b920b10d632d8c1e6d36007927b267 Author: Subha sree Mohankumar <smohanku> Date: Fri Sep 22 19:34:12 2017 +0530 glusterfsd: Coverity Issue "MISSING_BREAK" in parse_opts Issue:Event unterminated_case: The case for value "ARGP_LOCALTIME_LOGGING_KEY" is not terminated by a 'break' statement. Solution: A break statement is added in the fallthrough case. Change-Id: Ie44d1a291afaa0e9fb9ef2aa45368b9401a8bb82 BUG: 789278 Signed-off-by: Subha sree Mohankumar <smohanku> COMMIT: https://review.gluster.org/18339 committed in master by Jeff Darcy (jeff.us) ------ commit 306164fb4121e814b61e9b5685319f889f6b7547 Author: Mohammed Azhar Padariyakam <mpadariy> Date: Thu Sep 21 18:12:59 2017 +0530 libglusterfs: Coverity Fix CONSTANT_EXPRESSION_RESULT in gf_string2int64 Issue : "l <= 9223372036854775807L" is always true regardless of the values of its operands. This occurs as the logical operand of "if". Solution : Remove the comparison which always turns out to be true Fix : The if-condition was removed and the body inside the same was retained. Change-Id: Iba94d7f4f2dee85a180d10cdb7f7235b406cc400 BUG: 789278 Signed-off-by: Mohammed Azhar Padariyakam <mpadariy> REVIEW: https://review.gluster.org/18361 (Xlators/features: Coverity Issue "NEGATIVE_RETURNS" in worm_truncate,worm_ftruncate,worm_link,worn_unlink and worm_rename.) posted (#5) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18345 (contrib/fuse-lib: Coverity Issue CHECKED_RETURN in gf_fuse_unmount_daemon) posted (#4) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18345 (contrib/fuse-lib: Coverity Issue CHECKED_RETURN in gf_fuse_unmount_daemon) posted (#5) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18332 (xlators/io-stats: Coverity Fix CHECKED_RETURN in resolve_group_name) posted (#5) for review on master by Mohammed Azhar Padariyakam (mpadariy) REVIEW: https://review.gluster.org/18364 (cluster/ec: Coverity Fix UNUSED_VALUE in ec_create_name) posted (#2) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18343 (xlators/debug/trace: Coverity Fix BUFFER_SIZE in reconfigure) posted (#3) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18345 (contrib/fuse-lib: Coverity Issue CHECKED_RETURN in gf_fuse_unmount_daemon) posted (#6) for review on master by Girjesh Rajoria (grajoria) REVIEW: https://review.gluster.org/18343 (xlators/debug/trace: Coverity Fix BUFFER_SIZE in reconfigure) posted (#4) for review on master by Kamal Mohanan (kmohanan) COMMIT: https://review.gluster.org/18351 committed in master by Jeff Darcy (jeff.us) ------ commit fe5fc91ab9b74b525d4979e09ce13766b3180381 Author: Sanju Rakonde <srakonde> Date: Fri Sep 22 18:17:03 2017 +0530 glusterd/snapshot: Buffer Size Warning new_brickinfo->mnt_opts is allocated memory using calloc. So it is already zeroed out at allocation. we need not to add null character at the end. we pass one less than maximum size to the strncpy to make sure that destination string is terminated. Change-Id: I463dddd2171fb39a509bb75ffcc074d5b1cf7d62 BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/18332 committed in master by Jeff Darcy (jeff.us) ------ commit 1c0d3ac5c5f9774a0f25f5282d54177af02f984e Author: Mohammed Azhar Padariyakam <mpadariy> Date: Thu Sep 21 14:07:16 2017 +0530 xlators/io-stats: Coverity Fix CHECKED_RETURN in resolve_group_name Issue: Calling "getgrgid_r(gid, &grp, grp_buf, grp_buf_len, &grp_result)" without checking return value. This library function may fail and return an error code Solution: getgrgrid_r returns zero when the operation is successful and a non-zero error code if there's some error in the operation Fix: Checked for the return value and redirected to error if the return value was non-zero Change-Id: I0d082c6d57c6148b9830bc020140946c06d6f800 BUG: 789278 Signed-off-by: Mohammed Azhar Padariyakam <mpadariy> REVIEW: https://review.gluster.org/18340 (xlators/posix: Coverity Fix UNUSED_VALUE in posix_getxattr) posted (#3) for review on master by Mohammed Azhar Padariyakam (mpadariy) COMMIT: https://review.gluster.org/18379 committed in master by Raghavendra G (rgowdapp) ------ commit fabee9d6816077d0f44a7d82c0b35aef60771711 Author: Kartik_Burmee <kburmee> Date: Mon Sep 25 15:49:36 2017 +0530 Coverity issue fix: checked return issue:Calling "client_submit_request" without checking return value (as is done elsewhere 52 out of 58 times). function: client_fdctx_destroy Change-Id: I66a295dd114fc20f04eb1aca9a5b274df53be090 BUG: 789278 fix: typecasted function return value using void Signed-off-by: Kartik_Burmee <kburmee> REVIEW: https://review.gluster.org/18343 (xlators/debug/trace: Coverity Fix BUFFER_SIZE in reconfigure) posted (#5) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18343 (xlators/debug/trace: Coverity Fix BUFFER_SIZE in reconfigure) posted (#6) for review on master by Kamal Mohanan (kmohanan) REVIEW: https://review.gluster.org/18377 (xlator/cluster/afr:coverity Issue "UNUSED_VALUE" in afr_get_split_brain_status) posted (#10) for review on master by Subha sree Mohankumar (smohanku) REVIEW: https://review.gluster.org/18347 (xlator/debug :coverity Issue BUFFER_SIZE) posted (#4) for review on master by Subha sree Mohankumar (smohanku) COMMIT: https://review.gluster.org/18372 committed in master by Jeff Darcy (jeff.us) ------ commit b887915bd30ac98bbc64c6dcac73605cd96855ca Author: Kartik_Burmee <kburmee> Date: Mon Sep 25 12:52:47 2017 +0530 Coverity issue fix: IDENTICAL_BRANCHES issue: The same code is executed when the condition "ret" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed? function: glusterd_print_gsync_status_by_vol Change-Id: Iedad05cbafd9598443b524778056f7740e4f12a5 BUG: 789278 fix: removed the 'if' block because the value of ret will be returned in any case Signed-off-by: Kartik_Burmee <kburmee> COMMIT: https://review.gluster.org/18377 committed in master by Jeff Darcy (jeff.us) ------ commit deea16e59564575d5f211f4fb8e4e5597e570ad1 Author: Subha sree Mohankumar <smohanku> Date: Mon Sep 25 14:58:13 2017 +0530 xlator/cluster/afr:coverity Issue "UNUSED_VALUE" in afr_get_split_brain_status Issue: Event value_overwrite:Overwriting previous write to "ret" with value "-1". Fix : An "If" condition is added to check the value of "ret". Change-Id: I7b6bd4f20f73fa85eb8a5169644e275c7b56af51 BUG: 789278 Signed-off-by: Subha sree Mohankumar <smohanku> REVIEW: https://review.gluster.org/18367 (Coverity Error fix) posted (#2) for review on master by Vishal Pandey (vpandey) REVIEW: https://review.gluster.org/18367 (features/changelog: Coverity Error Check Return) posted (#3) for review on master by Vishal Pandey (vpandey) COMMIT: https://review.gluster.org/18347 committed in master by Jeff Darcy (jeff.us) ------ commit dc3cd44add80fb56fae2492cb8ad264be04f46fc Author: Subha sree Mohankumar <smohanku> Date: Fri Sep 22 16:13:44 2017 +0530 xlator/debug :coverity Issue BUFFER_SIZE Issue :Calling strncpy with a source string whose length (2 chars) is greater than or equal to the size argument (2) will fail to null-terminate "trace_fop_names[i].name". Solution : The size argument is obtained from sizeof(trace_fop_names[i].name). Change-Id: I99fad2693054f3af84d78da34c61258233d3049a BUG: 789278 Signed-off-by: Subha sree Mohankumar <smohanku> COMMIT: https://review.gluster.org/18343 committed in master by Jeff Darcy (jeff.us) ------ commit 7bf30b0e371ad1170cd0773fe5db335683428777 Author: Kamal Mohanan <kmohanan> Date: Fri Sep 22 11:33:47 2017 +0530 xlators/debug/trace: Coverity Fix BUFFER_SIZE in reconfigure Problem: strncpy was being called with a source string of length equal to the size argument at lines 3110 and 3114. Solution: Calculate the size argument from the size of the destination argument. Change-Id: I1fed6f8f47c5512b9489bfb3297e7a9911eacbc8 BUG: 789278 Signed-off-by: Kamal Mohanan <kmohanan> REVIEW: https://review.gluster.org/18527 (stack.h: make sure 'oldgroups' is never null) posted (#1) for review on master by Amar Tumballi (amarts) REVIEW: https://review.gluster.org/18527 (stack.h: make sure 'oldgroups' is never null) posted (#2) for review on master by Amar Tumballi (amarts) COMMIT: https://review.gluster.org/18364 committed in master by Xavier Hernandez (jahernan) ------ commit 117c4560dcd5c7499c17a0bc8e62c62ac39745e1 Author: Kamal Mohanan <kmohanan> Date: Mon Sep 25 11:36:54 2017 +0530 cluster/ec: Coverity Fix UNUSED_VALUE in ec_create_name Problem: The value returned by cluster_mkdir is assigned to ret at ec-heal.c:1076. But this value is overwritten before it can be used. Solution: The return value of cluster_mkdir is ignored. It is not assigned to ret. Change-Id: Iee6b8d8b04e0bd800dd30d2c24cab755b9e63443 BUG: 789278 Signed-off-by: Kamal Mohanan <kmohanan> REVIEW: https://review.gluster.org/18527 (stack.h: make sure 'oldgroups' is never null) posted (#3) for review on master by Amar Tumballi (amarts) REVIEW: https://review.gluster.org/18527 (stack.h: make sure 'oldgroups' is never null) posted (#4) for review on master by Amar Tumballi (amarts) COMMIT: https://review.gluster.org/18527 committed in master by Amar Tumballi (amarts) ------ commit e848410ab6d13871be6b57101788ea5183efe75c Author: Amar Tumballi <amarts> Date: Fri Oct 13 11:46:38 2017 +0530 stack.h: make sure 'oldgroups' is never null If 'oldgroups' is null, it can lead to a crash. Change-Id: I7a4f71256b07dc0ca3b988cad3694c21b150c99e BUG: 789278 Signed-off-by: Amar Tumballi <amarts> REVIEW: https://review.gluster.org/18574 (Make sure attach_brick return a proper error code) posted (#2) for review on master by Michael Scherer (misc) COMMIT: https://review.gluster.org/18574 committed in master by Atin Mukherjee (amukherj) ------ commit 0bb928264a9fb100dc927687eed6ad4d22675950 Author: Michael Scherer <misc> Date: Wed Oct 25 14:36:35 2017 +0200 Make sure attach_brick return a proper error code Coverity warn about "Using uninitialized value "ret".", which is indeed the case. If we can't attach after 15 tries, attach_brick return uninitiliazed return code, which is likely hard to trigger, but bad. I use -1 to follow the UNIX convetion, but there is no specific error code tested by code. Change-Id: I43ad60d25ab169f9cea0db600805ced7f77c37ba BUG: 789278 Signed-off-by: Michael Scherer <misc> REVIEW: https://review.gluster.org/18591 (snapshot: fix coverity issue 'DEADCODE') posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/18592 (cluster/ec: FORWARD_NULL coverity fix) posted (#1) for review on master by Sunil Kumar Acharya REVIEW: https://review.gluster.org/18593 (cluster/ec: REVERSE_INULL coverity fix) posted (#1) for review on master by Sunil Kumar Acharya REVIEW: https://review.gluster.org/18594 (cluster/ec: UNUSED_VALUE coverity fix) posted (#1) for review on master by Sunil Kumar Acharya COMMIT: https://review.gluster.org/18361 committed in master by ------------- Xlators/features: Coverity Issue "NEGATIVE_RETURNS" in worm_truncate,worm_ftruncate,worm_link,worn_unlink and worm_rename. Issue :Event negative_returns: "op_errno" is passed to a parameter that cannot be negative. Fix : In functions worm_link,worm_unlink,worm_truncate,worm_ftruncate and worm_rename, added an condition to check the whether value of "op_errno" is negative or not.If the value is negative, then it is set to EROFS. Change-Id: Ie65601b6cc9799f587cc574408281dab50a58afb BUG: 789278 Signed-off-by: Subha sree Mohankumar <smohanku> REVIEW: https://review.gluster.org/18595 (cluster/ec: MISSING_BREAK coverity fix) posted (#1) for review on master by Sunil Kumar Acharya REVIEW: https://review.gluster.org/18596 (cluster/ec: FORWARD_NULL coverity fix) posted (#1) for review on master by Sunil Kumar Acharya REVIEW: https://review.gluster.org/18597 (cluster/ec: NEGATIVE_RETURNS coverity fix) posted (#1) for review on master by Sunil Kumar Acharya REVIEW: https://review.gluster.org/18598 (cluster/ec: FORWARD_NULL coverity fix) posted (#1) for review on master by Sunil Kumar Acharya COMMIT: https://review.gluster.org/18591 committed in master by ------------- snapshot: fix coverity issue 'DEADCODE' Problem : Unreachable code at glusterd-snapshot.c:6718 Unreachable code at glusterd-snapshot.c:7352 FIx : Remove unreachable code At glusterd-snapshot.c:6718 in if condition the value of "snap" must be "NULL" to call glusterd_snap_remove() which is not possible here. Change-Id: Id865bde7c1474a9b9ed11c0ed614676b4e2443c6 BUG: 789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/18595 committed in master by ------------- cluster/ec: MISSING_BREAK coverity fix Problem: switch case syntax issue. Solution: syntax fixed. BUG: 789278 Change-Id: I76da72c3ab6ffc5db671686a71d6a596beaf496e Signed-off-by: Sunil Kumar Acharya <sheggodu> REVIEW: https://review.gluster.org/18608 (glusterd: UNUSED VALUE coverity fix) posted (#1) for review on master by Sanju Rakonde COMMIT: https://review.gluster.org/18592 committed in master by ------------- cluster/ec: FORWARD_NULL coverity fix Problem: cbk could be NULL. Solution: Assigned appropriate value to cbk. BUG: 789278 Change-Id: I2e4bba9a54f965c6a7bccf0b0cb6c5f75399f6e6 Signed-off-by: Sunil Kumar Acharya <sheggodu> COMMIT: https://review.gluster.org/18598 committed in master by ------------- cluster/ec: FORWARD_NULL coverity fix Problem: frame could be NULL. Solution: Added check to verify frame. BUG: 789278 Change-Id: I55a64c936ae71ec8587a3f9dfa0fdee5d0ea5213 Signed-off-by: Sunil Kumar Acharya <sheggodu> REVIEW: https://review.gluster.org/18609 (glusterd: UNUSED VALUE coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/18610 (glusterd: CHECKED RETURN coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/18611 (glusterd: UNUSED VALUE coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/18612 (glusterd: UNUSED VALUE coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/18613 (glusterd: NULL RETURNS coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/18614 (glusterd: DEADCODE coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/18615 (glusterd: PW.INCLUDE_RECURSION coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/18616 (glusterd/pmap: UNUSED VALUE coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/18617 (glusterd: PW.INCLUDE_RECURSION coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/18619 (cli: Fix coverity errors for cli-rpc-ops.c) posted (#1) for review on master by Kaushal M REVIEW: https://review.gluster.org/18620 (cli: Fix several coverity issues in cli-cmd-parser.c) posted (#1) for review on master by Xavier Hernandez REVIEW: https://review.gluster.org/18621 (cli: Fixed coverity issue in cli-cmd-snapshot.c) posted (#1) for review on master by Xavier Hernandez REVIEW: https://review.gluster.org/18622 (cli: Fixed coverity issue in cli-cmd-system.c) posted (#1) for review on master by Xavier Hernandez REVIEW: https://review.gluster.org/18623 (server-helpers: Coverity Fix CONSTANT_EXPRESSION_RESULT in serialize_rsp_direntp) posted (#1) for review on master by Mohammed Azhar Padariyakam REVIEW: https://review.gluster.org/18624 (cli: Fix several coverity issues in cli-cmd-volume.c) posted (#1) for review on master by Xavier Hernandez REVIEW: https://review.gluster.org/18625 (xlators/bd-helper: Coverity Fix CHECKED_RETURN in bd_do_ioctl_zerofill) posted (#1) for review on master by Mohammed Azhar Padariyakam COMMIT: https://review.gluster.org/18616 committed in master by ------------- glusterd/pmap: UNUSED VALUE coverity fix Problem: port value is assigned to p, which is overwritten before using it. Fix: remaoval of assignment line. Change-Id: If007167f37b0325c7bfe12f8e9075ca68524e40a BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/18617 committed in master by ------------- glusterd: PW.INCLUDE_RECURSION coverity fix Problem: #include file "glusterd.h" includes itself, glusterd.h -> glusterd-pmap.h -> glusterd.h Fix: remove inclusion statement Change-Id: I28f2043a73a50ae2c7b670e2dece4a3f3fffbcd6 BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/18628 (rpc/rpc-transport/rdma/: Coverity Issue MISSING_BREAK) posted (#1) for review on master by Girjesh Rajoria REVIEW: https://review.gluster.org/18629 (tier/glusterd: coverity issues in glusterd-tier.c) posted (#1) for review on master by hari gowtham COMMIT: https://review.gluster.org/18608 committed in master by ------------- glusterd: UNUSED VALUE coverity fix ret is overwritten before it is used, adding a line for checking its value solves it. Change-Id: I4ac4ad33bc236d9294da64b19d16b3bc9bb8807b BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/18630 (gfapi: Fix several coverity issues in glfs-fops.c) posted (#1) for review on master by mohammed rafi kc REVIEW: https://review.gluster.org/18631 (xlators/mgmt/glusterd/: Coverity Issue MISSING_BREAK) posted (#1) for review on master by Girjesh Rajoria REVIEW: https://review.gluster.org/18632 (tier: coverity fix for tier-common.c) posted (#1) for review on master by hari gowtham REVIEW: https://review.gluster.org/18634 (snapshot: Fix several coverity issues in glusterd-snapshot-utils.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/18621 committed in master by ------------- cli: Fixed coverity issue in cli-cmd-snapshot.c This patch fixes issue 132 from [1]. [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I50952614e7edb6dbb1ec70383f1dc58ce1738c2f BUG: 789278 Signed-off-by: Xavier Hernandez <jahernan> REVIEW: https://review.gluster.org/18636 (xlators/mgmt/glusterd/: DEADCODE in client_graph_set_rda_options) posted (#1) for review on master by Girjesh Rajoria REVIEW: https://review.gluster.org/18638 (xlators/client-rpc-fops: Fix Coverity Issue 'DEADCODE') posted (#1) for review on master by Mohammed Azhar Padariyakam REVIEW: https://review.gluster.org/18639 (xlators/performance/io-cache/: DEADCODE in ioc_open_cbk) posted (#1) for review on master by Girjesh Rajoria REVIEW: https://review.gluster.org/18640 (xlators/performance/read-ahead/: MISSING_LOCK in init) posted (#1) for review on master by Girjesh Rajoria REVIEW: https://review.gluster.org/18641 (libglusterfs/: PW.INCLUDE_RECURSION in xlator.h) posted (#1) for review on master by Girjesh Rajoria REVIEW: https://review.gluster.org/18642 (posix: Fix coverity issues in several posix functions) posted (#1) for review on master by MOHIT AGRAWAL COMMIT: https://review.gluster.org/18624 committed in master by ------------- cli: Fix several coverity issues in cli-cmd-volume.c This patch fixes issues 133, 486, 487 and 691 from [1] [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I1a6ca4870ac105ea4c634fc18293229a56ab8596 BUG: 789278 Signed-off-by: Xavier Hernandez <jahernan> REVIEW: https://review.gluster.org/18643 (rpc: Fix several coverity issues in rpc/socket code) posted (#1) for review on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/18644 (glusterd: Fix few coverity errors) posted (#1) for review on master by Prashanth Pai REVIEW: https://review.gluster.org/18646 (xlators/features/trash: STRING_OVERFLOW Coverity fix in trash.c) posted (#1) for review on master by Kamal Mohanan REVIEW: https://review.gluster.org/18647 (xlators/mgmt/glusterd/: PW.INCLUDE_RECURSION in glusterd-utils.h) posted (#1) for review on master by Girjesh Rajoria REVIEW: https://review.gluster.org/18649 (cluster/ec: Remove possibility of NULL deref) posted (#1) for review on master by Ashish Pandey COMMIT: https://review.gluster.org/18605 committed in master by ------------- glusterd/mgmt: coverity fixes This patch fixes coverity issues 179, 59. Problem: control flow won't enter into if block as volname is always NULL and return value of function synctask_barrier_init is unchecked. Fix: remove condition checking which is always resulting in false, and removing if block which is always unreachable. As a result of removal of condition checking volname became a unused variable, so remove declaration of volname. assign return valur of synctask_barrier_init to ret, if it nonzero value goto out. Change-Id: I870aeb020034e97a761e9314f7ace7573f7c520c BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/18653 (snapshot: fix coverity issue 'UNREACHABLE') posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/18655 (gfapi: Fix coverity issues in cli-rl.c) posted (#1) for review on master by mohammed rafi kc COMMIT: https://review.gluster.org/18639 committed in master by ------------- xlators/performance/io-cache/: DEADCODE in ioc_open_cbk Coverity ID: 173 Issue: Event dead_error_line: Execution cannot reach this statement: "fd_ctx_set(fd, this, 1UL);". Removed if block as "weight == 0U" cannot be true, so if block will never execute. Also removed weight variable because it is unused. Change-Id: I4f028df29bfde91167fb15befa99b1fe1892adc6 BUG: 789278 Signed-off-by: Girjesh Rajoria <grajoria> COMMIT: https://review.gluster.org/18609 committed in master by ------------- glusterd: coverity fixes This patch fixes coverity issue 780, 88, 692, 747, 357 Change-Id: I44b0fe9119853a6d2210507c7247e168d7c3ae0a BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/18625 committed in master by ------------- xlators/bd-helper: Coverity Fix CHECKED_RETURN in bd_do_ioctl_zerofill Problem: bd_do_ioctl_zerofill is called and return value is unchecked Fix: Check the returned value and goto skip if the returned value < 0 which means its an error. Coverity Id: 67 from [1] [1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I398873cefaca03f9cd188fa0f4ccba1378a60ed9 BUG: 789278 Signed-off-by: Mohammed Azhar Padariyakam <mpadariy> REVIEW: https://review.gluster.org/18659 (rpc/rpc-transport/socket/: MISSING_BREAK in name.c) posted (#1) for review on master by Girjesh Rajoria REVIEW: https://review.gluster.org/18660 (cluster/dht: Check NULL statvfs) posted (#1) for review on master by Ashish Pandey REVIEW: https://review.gluster.org/18661 (cluster/dht: Check for NULL local before using it) posted (#1) for review on master by Ashish Pandey REVIEW: https://review.gluster.org/18662 (snapview: Coverity Fixes) posted (#1) for review on master by Ashish Pandey REVIEW: https://review.gluster.org/18663 (mem-pool: Check pointer before freeing it) posted (#1) for review on master by Ashish Pandey REVIEW: https://review.gluster.org/18664 (protocol/server : Coverity Fixes) posted (#1) for review on master by Ashish Pandey COMMIT: https://review.gluster.org/18649 committed in master by ------------- cluster/ec: Remove possibility of NULL deref Coverity ID: 237 Problem: In ec_check_status we are trying to deref fop->answer which could be NULL. Solution: Check Null condition before using this pointer. Change-Id: I4f9a73dc2f062ca9c62b4c4baf0a6fcadade88f2 BUG: 789278 Signed-off-by: Ashish Pandey <aspandey> COMMIT: https://review.gluster.org/18644 committed in master by ------------- glusterd: Fix few coverity errors Fixes issues 810, 248, 491, 499, 85, 786, 811, 43, and 44 from the report at [1]. [1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ BUG: 789278 Change-Id: I27ebae2ffb2256b8eef0757d768cc46e5a942e9f Signed-off-by: Prashanth Pai <ppai> COMMIT: https://review.gluster.org/18660 committed in master by ------------- cluster/dht: Check for NULL before using variable Coverity ID: 245 Check statvfs received as cbk before using it Coverity ID: 228 Check NULL loc before freeing it. Change-Id: I1b153ed5e7b81bcf7033bf710808e95908dcfef4 BUG: 789278 Signed-off-by: Ashish Pandey <aspandey> REVIEW: https://review.gluster.org/18668 (mgmt/glusterd glusterd coverity fixes) posted (#1) for review on master by Ashish Pandey COMMIT: https://review.gluster.org/18623 committed in master by ------------- server-helpers: Coverity Fix CONSTANT_EXPRESSION_RESULT in serialize_rsp_direntp Issue : "trav->dict.dict_len > 4294967295U" is always false regardless of the values of its operands. .But dict_serialized_length can return < 0 when error happens. Solution : Remove the comparison which always turns out to be false and add a new condition for error checking. Fix : The if-condition was renewed. Coverity-Id: 108 from [1] [1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I9956b6ca7c4bf7444f19aadd3b32fceac011a44e BUG: 789278 Signed-off-by: Mohammed Azhar Padariyakam <mpadariy> COMMIT: https://review.gluster.org/18638 committed in master by ------------- xlators/client-rpc-fops: Fix Coverity Issues Coverity Id: 557,175,177,184,711,182,180,181,178 from [1] Problem: Unreachable code at client3_3_fgetxattr: 4771 Unreachable code at client3_3_fxattrop: 5087 Unreachable code at client3_3_getxattr: 4890 Unreachable code at client3_3_lookup: 3412 Unreachable code at client3_3_readdir: 5604 Unreachable code at client3_3_readdirp: 5704 Unreachable code at client3_3_xattrop: 4982 NULL checking deref ptr at client3_3_compound: 6045 Unused Value for op_errno at client3_3_getxattr: 4859 Solution: Removed The Unreachable Dead Code Removed NULL Check of dereferenced pointer Removed assignment of op_errno which is overwritten later [1]:https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: Ie26a026dd1475c892faf00dd844bf38092e0a780 BUG: 789278 Signed-off-by: Mohammed Azhar Padariyakam <mpadariy> COMMIT: https://review.gluster.org/18628 committed in master by ------------- rpc/rpc-transport/rdma/: Coverity Issue MISSING_BREAK Issue: Event unterminated_case: The case for value "27" is not terminated by a 'break' statement. Function: gf_rdma_get_transport_identifiers, gf_rdma_server_get_local_sockaddr Added Fall through in comment after case AF_INET_SDP. Change-Id: Ia30d0143a63a63af2b4b1d9b02551b9260444f35 BUG: 789278 Signed-off-by: Girjesh Rajoria <grajoria> REVIEW: https://review.gluster.org/18670 (xlators/client-rpc-fops: Fix Coverity Issues) posted (#1) for review on master by Mohammed Azhar Padariyakam REVIEW: https://review.gluster.org/18671 (tier: coverity fixes in tier.c) posted (#1) for review on master by hari gowtham REVIEW: https://review.gluster.org/18672 (tier/gluster: coverity fixes) posted (#1) for review on master by hari gowtham COMMIT: https://review.gluster.org/18636 committed in master by ------------- xlators/mgmt/glusterd/: DEADCODE in client_graph_set_rda_options Coverity ID: 137 Issue: Event dead_error_begin: Execution cannot reach this statement: "set_graph_errstr(graph, "in...". Assigned return value of gf_string2bytesize_uint64 () to ret. Change-Id: Ibef1b1398b233f6442b23282f5ca205c1869a8ee BUG: 789278 Signed-off-by: Girjesh Rajoria <grajoria> REVIEW: https://review.gluster.org/18676 (cli/xml: Fix coverity issues in cli-xml-output.c) posted (#1) for review on master by mohammed rafi kc REVIEW: https://review.gluster.org/18677 (cli: Fix coverity issues in cli.c) posted (#1) for review on master by mohammed rafi kc COMMIT: https://review.gluster.org/18670 committed in master by ------------- xlators/client-rpc-fops: Fix Coverity Issues Coverity Id: 803, 804 from [1] Problem: USE_AFTER_FREE code at client3_3_lookup: 3371 USE_AFTER_FREE at client3_3_readdir: 5562 Solution: Postponed iobuf_unref(rsp_iobuf) to a location after all dereferences of rsp_iobuf [1]:https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I34f90d72b1248e5526ff1d2b3273cdab619cf4f8 BUG: 789278 Signed-off-by: Mohammed Azhar Padariyakam <mpadariy> REVIEW: https://review.gluster.org/18678 (cli: Fix coverity errors for cli-rpc-ops.c) posted (#1) for review on experimental by Kaushal M REVIEW: https://review.gluster.org/18679 (debug/io-stats: Coverity fix in io-stats) posted (#1) for review on master by Ashish Pandey COMMIT: https://review.gluster.org/18631 committed in master by ------------- xlators/mgmt/glusterd/: Coverity Issue MISSING_BREAK in glusterd_op_stage_rebalance Coverity ID: 297, 298 Issue: Event unterminated_case Added Fall through in comment. Change-Id: Ied742e64d9741cc974906921dcca80f0b738b7d6 BUG: 789278 Signed-off-by: Girjesh Rajoria <grajoria> REVIEW: https://review.gluster.org/18682 (features/shard: Coverity fixes) posted (#1) for review on master by Krutika Dhananjay REVIEW: https://review.gluster.org/18685 (geo-rep/gsyncd: Fix coverity issues in gsyncd.c) posted (#1) for review on master by mohammed rafi kc REVIEW: https://review.gluster.org/18686 (geo-rep/prociter: Fix coverity issues in procdiggy.c) posted (#1) for review on master by mohammed rafi kc REVIEW: https://review.gluster.org/18688 (snapshot : fix coverity issue in glusterd-snapshot.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/18620 committed in master by ------------- cli: Fix several coverity issues in cli-cmd-parser.c This patch fixes coverity issues 115, 191, 274, 462, 463, 508, 588, 612, 614, 618 and 698 from [1]. Also removed the need for some relatively big arrays as local variables of some functions. [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I4f435dbdbedc1b6de067084cce3050b620b28391 BUG: 789278 Signed-off-by: Xavier Hernandez <jahernan> COMMIT: https://review.gluster.org/18596 committed in master by ------------- cluster/ec: FORWARD_NULL coverity fix Problem: xattr could be NULL. Solution: Added check to verify the same. BUG: 789278 Change-Id: Ie013f5655f4621434e5023dd76cef44b976adc68 Signed-off-by: Sunil Kumar Acharya <sheggodu> COMMIT: https://review.gluster.org/18597 committed in master by ------------- cluster/ec: NEGATIVE_RETURNS coverity fix Problem: Source could be negative. Solution: Check has been added to verify the same. BUG: 789278 Change-Id: I8cca6297327e7923b25949c20ec8d1a711207a76 Signed-off-by: Sunil Kumar Acharya <sheggodu> COMMIT: https://review.gluster.org/18630 committed in master by ------------- gfapi: Fix several coverity issues in glfs-fops.c This patch fixes coverity issues 176 [1] : https://download.gluster.org/pub/gluster/glusterfs/static-analysis/ master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I473323db27218ac784b8eae773a1efe911fcfec0 BUG: 789278 Signed-off-by: Mohammed Rafi KC <rkavunga> COMMIT: https://review.gluster.org/18661 committed in master by ------------- cluster/dht: Check for NULL local before using it Coverity ID: 261 Coverity ID: 257 Check if local is NULL or not Change-Id: I570f87f32e1347f891c6a02ee5641fcc5a262a96 BUG: 789278 Signed-off-by: Ashish Pandey <aspandey> COMMIT: https://review.gluster.org/18662 committed in master by ------------- snapview: Coverity Fixes Coverity ID: 259 Coverity ID: 163 Change-Id: I7f7753b870715e1176826fb8dfbe81119750d113 BUG: 789278 Signed-off-by: Ashish Pandey <aspandey> COMMIT: https://review.gluster.org/18593 committed in master by ------------- cluster/ec: REVERSE_INULL coverity fix Problem: fop could be NULL. Solution: Check has been added to verify fop. BUG: 789278 Change-Id: I7e8d2c1bdd8960c609aa485f180688a95606ebf7 Signed-off-by: Sunil Kumar Acharya <sheggodu> COMMIT: https://review.gluster.org/18659 committed in master by ------------- rpc/rpc-transport/: MISSING_BREAK in name.c Coverity ID: 286, 287, 288, 289, 290 Issue: Event unterminated_case: The case for value "27" is not terminated by a 'break' statement. Added Fall through in comment between switch cases. Change-Id: I9e3f205c05ac22a85a87423ef690fc18891eaece BUG: 789278 Signed-off-by: Girjesh Rajoria <grajoria> COMMIT: https://review.gluster.org/18367 committed in master by ------------- features/changelog: Coverity Error Check Return If condition to check error in lseek wrapper sys_lseek. Change-Id: Ic96ddbb0898146bbfae11acc86818d6604e5eb98 BUG: 789278 Signed-off-by: Vishal Pandey <vishpandey2014> REVIEW: https://review.gluster.org/18691 (glusterd: Fix coverity issues in handshake.c) posted (#1) for review on master by Sanju Rakonde COMMIT: https://review.gluster.org/18594 committed in master by ------------- cluster/ec: UNUSED_VALUE coverity fix Problem: Return values are not used. Solution: Removed the unused values. BUG: 789278 Change-Id: Ica2b95bb659dfc7ec5346de0996b9d2fcd340f8d Signed-off-by: Sunil Kumar Acharya <sheggodu> REVIEW: https://review.gluster.org/18693 (features/changelog: Fix coverity issues) posted (#1) for review on master by Aravinda VK REVIEW: https://review.gluster.org/18694 (features/libgfchangelog: Fix coverity issues) posted (#1) for review on master by Aravinda VK COMMIT: https://review.gluster.org/18688 committed in master by ------------- snapshot : fix coverity issue in glusterd-snapshot.c This patch fixes coverity issue 87 from [1]. [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I5c9c67b4dd43ebf1a5a83532cbd06178000da145 BUG: 789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/18664 committed in master by ------------- protocol/server : Coverity Fixes Coverity ID: 802 Coverity ID: 741 Coverity ID: 808 Change-Id: If1b3196f0d1ba850c349c65f1626e41dcf42b6b6 BUG: 789278 Signed-off-by: Ashish Pandey <aspandey> REVIEW: https://review.gluster.org/18697 (features/bitrot: Fix coverity issues) posted (#1) for review on master by Kotresh HR COMMIT: https://review.gluster.org/18677 committed in master by ------------- cli: Fix coverity issues in cli.c This patch fixes coverity issue 536 BUG: 789278 Change-Id: I9fe7b324a3ab1f16b4ee4e63818f93ef71d3405a Signed-off-by: Mohammed Rafi KC <rkavunga> COMMIT: https://review.gluster.org/18682 committed in master by ------------- features/shard: Coverity fixes This patch fixes coverity issues 242 and 453. Change-Id: If18f40539dccc7c2fcdcf8ef9b6fa3efbb3e462f BUG: 789278 Signed-off-by: Krutika Dhananjay <kdhananj> COMMIT: https://review.gluster.org/18389 committed in master by ------------- glusterd: Coverity Issue FORWARD_NULL fix Problems: According to Coverity Issue ID 207 issues are as follows- a-) Dereferencing "this" pointer without checking if it points to NULL. b-) The IF condition on line 1750 should check if any *one* of dict, this or peerinfo is NULL and not *all*. Fix: Replace the && operator with || to check if any *one* of this, dict or peerinfo is NULL and then execute out label. Change-Id: I40057d6cade71d3862c8e491bf4137cf25dda327 BUG: 789278 Signed-off-by: Vishal Pandey <vishpandey2014> REVIEW: https://review.gluster.org/18701 (glusterd: Few coverity fixes) posted (#1) for review on master by Gaurav Yadav COMMIT: https://review.gluster.org/18653 committed in master by ------------- snapshot: fix coverity issue 'UNREACHABLE' Problem : In glusterd-snapshot-utils.c:2778 code path is unreachable as it was intended for n-way replication snapshot support. Fix : Removed code now, will revert back this change in future once we support n-way replication in snapshot. This patch fixes coverity issue 687 from [1]. [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I163f318e62a7e84d211d9930dedee6587d37b2a0 BUG: 789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/18706 (glusterd: Fix coverity issues in glusterd-handler.c) posted (#1) for review on master by Samikshan Bairagya COMMIT: https://review.gluster.org/18641 committed in master by ------------- Coverity Issue: PW.INCLUDE_RECURSION in several files Coverity ID: 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 423, 424, 425, 426, 427, 428, 429, 436, 437, 438, 439, 440, 441, 442, 443 Issue: Event include_recursion Removed redundant, recursive includes from the files. Change-Id: I920776b1fa089a2d4917ca722d0075a9239911a7 BUG: 789278 Signed-off-by: Girjesh Rajoria <grajoria> COMMIT: https://review.gluster.org/18697 committed in master by ------------- features/bitrot: Fix coverity issues 1. br_update_scrub_finish_time: BUFFER_SIZE_WARNING 2. br_read_bad_object_dir : DEADCODE 3. bit-rot.c: init : RESOURCE_LEAK 4. br_stub_fsetxattr : STACK_USE 5. br_stub_setxattr : STACK_USE 6. bit-rot-stub.c: init : BUFFER_SIZE_WARNING Change-Id: Ie620f431bd7548fedae2152aa756ccdcd89ddf89 Signed-off-by: Kotresh HR <khiremat> BUG: 789278 REVIEW: https://review.gluster.org/18713 (glusterd: few coverity fixes in glusterd-handler.c) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/18714 (dict: Fix several coverity issues in dict) posted (#1) for review on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/18715 (xlators/mgmt/glusterd/: PW.INCLUDE_RECURSION in glusterd-utils.h) posted (#1) for review on master by Girjesh Rajoria COMMIT: https://review.gluster.org/18643 committed in master by ------------- rpc: Fix several coverity issues in rpc/socket code This patch fixes issues 287,289,286,809,690,276,401,402,403 from [1] [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ BUG: 789278 Change-Id: I2716d07fbdab59f779c2852bde07756b0e9a4ddc Signed-off-by: Mohit Agrawal <moagrawa> REVIEW: https://review.gluster.org/18718 (libglusterfs:UNUSED VALUE coverity fix) posted (#1) for review on master by Subha sree Mohankumar REVIEW: https://review.gluster.org/18720 (libglusterfs/gfdb:coverity issue fix) posted (#1) for review on master by Subha sree Mohankumar COMMIT: https://review.gluster.org/18668 committed in master by ------------- mgmt/glusterd glusterd coverity fixes Coverity ID: 498 Coverity ID: 756 Coverity ID: 764 Coverity ID: 553 Coverity ID: 562 Coverity ID: 765 Coverity ID: 731 Coverity ID: 545 Coverity ID: 781 Change-Id: I5922db462ba3f71397ae097d7e56739c335114d3 BUG: 789278 Signed-off-by: Ashish Pandey <aspandey> COMMIT: https://review.gluster.org/18713 committed in master by ------------- glusterd: few coverity fixes in glusterd-handler.c This patch fixes coverity issues 695,555,263 Change-Id: I3577cbc793b6652b24cc719037db2bdd5e27f196 BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/18615 committed in master by ------------- glusterd: PW.INCLUDE_RECURSION coverity fix This patch fixes coverity issue 421 Problem: #include file "glusterd-utils.h" includes itself, glusterd-utils.h -> glusterd-peer-utils.h -> glusterd-utils.h Fix: include of glusterd-utils.h into glusterd-peer-utils.c instead of glusterd-peer-utils.h. Change-Id: I164732dfb1f64636577765124ddc5361ff0f1cc5 BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/18728 (glusterd: buffer_size_warning coverity fix) posted (#1) for review on master by Kartik Burmee REVIEW: https://review.gluster.org/18732 (glusterd: dead code coverity fix) posted (#1) for review on master by Kartik Burmee REVIEW: https://review.gluster.org/18735 (glusterd: string_overflow coverity fix) posted (#1) for review on master by Kartik Burmee REVIEW: https://review.gluster.org/18736 (glusterd: checked_return coverity fix) posted (#1) for review on master by Kartik Burmee COMMIT: https://review.gluster.org/18694 committed in master by \"Aravinda VK\" <avishwan> with a commit message- features/libgfchangelog: Fix coverity issues Error: DEADCODE: xlators/features/changelog/lib/src/gf-changelog-journal-handler.c:524: dead_error_begin: Execution cannot reach this statement: "default:". Error: DEADCODE: xlators/features/changelog/lib/src/gf-history-changelog.c:984: dead_error_line: Execution cannot reach the expression "to" inside this statement: "if (!from || !to) ret = -1;". Error: REVERSE_INULL: xlators/features/changelog/lib/src/gf-changelog-journal-handler.c:678: check_after_deref: Null-checking "entry" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Error: STACK_USE: xlators/features/changelog/lib/src/gf-changelog-journal-handler.c:275: stack_use_local_overflow: Local variable "ascii" uses 12288 bytes of stack space, which exceeds the maximum single use of 10000 bytes. Error: STACK_USE: xlators/features/changelog/lib/src/gf-changelog-journal-handler.c:167: stack_use_local_overflow: Local variable "ascii" uses 12288 bytes of stack space, which exceeds the maximum single use of 10000 bytes. Error: STRING_NULL: xlators/features/changelog/lib/src/gf-changelog-journal-handler.c:589:9: string_null_sink_parm_call: Passing parameter "from_path" to "open" which expects a null-terminated string. Error: UNUSED_VALUE: xlators/features/changelog/lib/src/gf-history-changelog.c:628: assigned_value: Assigning value "-1" to "ret" here, but that stored value is overwritten before it can be used. Error: STRING_NULL: xlators/features/changelog/lib/src/gf-history-changelog.c:518: string_null_argument: Function "sys_pread" does not terminate string "*ccd->changelog". BUG: 789278 Change-Id: I1414ec6d4a118ce0c14df4dbe50995c85fe3ecf7 Signed-off-by: Aravinda VK <avishwan> COMMIT: https://review.gluster.org/18679 committed in master by \"Ashish Pandey\" <aspandey> with a commit message- debug/io-stats: Coverity fix in io-stats Coverity ID: 539 Coverity ID: 542 Coverity ID: 365 Coverity ID: 366 Coverity ID: 502 Coverity ID: 76 Change-Id: I0369856e8958e167a43065801096432b8855c114 BUG: 789278 Signed-off-by: Ashish Pandey <aspandey> COMMIT: https://review.gluster.org/18718 committed in master by \"Subha sree Mohankumar\" <smohanku> with a commit message- libglusterfs:UNUSED VALUE coverity fix Problem : Overwriting previous write to "ret" with value "EVENT_SEND_OK" before itr can be used. Fix: The value of ret is used in out. Change-Id: I2cdb32e441c85c94de30de89a7a4121fd54d1acd BUG: 789278 Signed-off-by: Subha sree Mohankumar <smohanku> COMMIT: https://review.gluster.org/18720 committed in master by \"Subha sree Mohankumar\" <smohanku> with a commit message- libglusterfs/gfdb:coverity issue fix Coverity Id:719,748,761 problem : The value of "ret" is overwritten in init_db and add_conection_node Change-Id: Iade8ca8d61c5e25e8c311b1375219f5f61d51bc3 BUG: 789278 Signed-off-by: Subha sree Mohankumar <smohanku> COMMIT: https://review.gluster.org/18728 committed in master by \"Kartik Burmee\" <kburmee> with a commit message- glusterd: buffer_size_warning coverity fix function: glusterd_import_volinfo problem: Calling strncpy with a maximum size argument of 256 bytes on destination array "new_volinfo->parent_volname" of size 256 bytes might leave the destination string unterminated. fix: The third argument of strncpy specifies the number of characters to be copied from the source string to the destination string. To make sure that the final string in destination is always null terminated, we copy 1 less character than the total capacity of the destination array and the last element of the array will be filled by '/0' automatically by the strncpy function. html link of issue: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-11-10-0f524f07/html/1/39glusterd-utils.c.html#error Change-Id: I76b0d10e6a932b0885531c9be3c4f4ce7239f3e1 BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee> COMMIT: https://review.gluster.org/18736 committed in master by \"Kartik Burmee\" <kburmee> with a commit message- glusterd: checked_return coverity fix issue: Calling "recursive_rmdir" without checking return value fix: typecasted return value of function 'recursive_rmdir' to void Change-Id: Ie95c2a2c503bb247afa69823d0043c3af5e036e8 BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee> COMMIT: https://review.gluster.org/18732 committed in master by \"Kartik Burmee\" <kburmee> with a commit message- glusterd: dead code coverity fix function: glusterd_volume_rebalance_use_rsp_dict problem: Execution cannot reach this statement: "goto out;" fix: removed the condition 'if(!ctx_dict)' and the corresponding action 'goto out;' because it will never be executed. reason: if the execution reaches this condition, then the value of '!ctx_dict' will always be false otherwise the execution will reach the 'out' label, skipping the execution of this conditional statement. html link of issue: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-11-10-0f524f07/html/1/99glusterd-utils.c.html#error Change-Id: I7ab6b2386bb01c54edd872f9f83bb8d2a4cd499f BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee> COMMIT: https://review.gluster.org/18614 committed in master by \"Sanju Rakonde\" <srakonde> with a commit message- glusterd: DEADCODE coverity fix Problem: execution cannot enter into if block since the condition !address is always false. Fix: removing if block solves it. Change-Id: I47b4beca7bdc095900b46e3f5a5cb9629aa2a4d7 BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/18757 (cli: dead_code coverity fix) posted (#1) for review on master by Kartik Burmee REVIEW: https://review.gluster.org/18758 (glusterd: dead_code coverity fix) posted (#1) for review on master by Kartik Burmee REVIEW: https://review.gluster.org/18760 (cluster: dead_code coverity fix) posted (#1) for review on master by Kartik Burmee REVIEW: https://review.gluster.org/18762 (features/changetimerecorder:unused value coverity fix) posted (#1) for review on master by Subha sree Mohankumar REVIEW: https://review.gluster.org/18765 (fuse-lib: checked_return coverity fix) posted (#1) for review on master by Kartik Burmee REVIEW: https://review.gluster.org/18771 (features/marker: coverity fix) posted (#1) for review on master by Kartik Burmee REVIEW: https://review.gluster.org/18772 (glusterd: checked_return coverity fix) posted (#1) for review on master by Kartik Burmee REVIEW: https://review.gluster.org/18774 (storage/posix: checked_return coverity fix) posted (#1) for review on master by Kartik Burmee COMMIT: https://review.gluster.org/18758 committed in master by \"Kartik Burmee\" <kburmee> with a commit message- glusterd: dead_code coverity fix issue: Execution cannot reach this statement: "rsp.op_errno = gf_errno_to_...". function:__server_event_notify fix: removed the if statement and the corresponding actions. Also, the variable was not being used anywhere else, so removed its declaration as well Change-Id: I85259e276c482cc9c98b1a829426bcec7412ce3f BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee> COMMIT: https://review.gluster.org/18760 committed in master by \"Kartik Burmee\" <kburmee> with a commit message- cluster: dead_code coverity fix function: stripe_entry_self_heal issue: Execution cannot reach this statement: "dict_unref(xdata);" fix: removed the 'if' condition and the corresponding actions because if the execution reaches this statement, then the value of xdata will always be NULL Change-Id: Iebc825339e2e1236b92bed39d81a1a9aba10164e BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee> COMMIT: https://review.gluster.org/18772 committed in master by \"Kartik Burmee\" <kburmee> with a commit message- glusterd: checked_return coverity fix function: glusterd_store_retrieve_options issue: Calling "gf_store_iter_destroy" without checking return value fix: typecasted the return value of the function to void Change-Id: I6dc4f4308b1eca8d6ee85834a1530ff356c73898 BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee> REVIEW: https://review.gluster.org/18786 (libglusterfs:checked return coverity fix) posted (#1) for review on master by Subha sree Mohankumar COMMIT: https://review.gluster.org/18646 committed in master by \"Kamal Mohanan\" <kmohanan> with a commit message- xlators/features/trash: STRING_OVERFLOW Coverity fixes in trash.c Replaced strcpy, strcat with strncpy, strncat calls. Change-Id: Ibf46a2b5ae4a0dd1632be46d6fe3597f6ace7a41 BUG: 789278 Signed-off-by: Kamal Mohanan <kmohanan> COMMIT: https://review.gluster.org/18706 committed in master by \"Samikshan Bairagya\" <samikshan> with a commit message- glusterd: Fix coverity issues in glusterd-handler.c Fixes get-state CLI related coverity issues 477, 511, 515, 523, 526 and 527 from the report at [1] [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: Ieb6f64c9035b4d9338d9515de003d607b7a4e9bc BUG: 789278 Signed-off-by: Samikshan Bairagya <samikshan> COMMIT: https://review.gluster.org/18714 committed in master by \"MOHIT AGRAWAL\" <moagrawa> with a commit message- dict: Fix several coverity issues in dict This patch fixes issues 230,592,593,110,63 from [1] [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Note: Resolve FORWARD_NULL coverity issue in glusterfs_ctx_new is also fixed with this patch. BUG: 789278 Change-Id: Ic4199a144a14cc9ead7366fb1c9699197141bc86 Signed-off-by: Mohit Agrawal <moagrawa> COMMIT: https://review.gluster.org/18691 committed in master by \"Sanju Rakonde\" <srakonde> with a commit message- glusterd: Fix coverity issues in handshake module This patch fixes coveruty issues 737,738,172,188,728,198,235,35. Change-Id: I632ddc5edbfb03bc81ce27f02886b8e262c1d946 BUG: 789278 Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/18765 committed in master by \"Kartik Burmee\" <kburmee> with a commit message- fuse-lib: checked_return coverity fix issue: Calling "chdir" without checking return value function: gf_fuse_unmount_daemon fix: typecasted return value of function to void. Change-Id: I5f06fbe886a35c2d4c9f763eeb01771e9451f232 BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee> COMMIT: https://review.gluster.org/18632 committed in master by \"hari gowtham\" <hari.gowtham005> with a commit message- tier: coverity fix for tier-common.c fix for the coverity id: 258, 162 Change-Id: I35ba21e37e186b7c1ce54faf5b24f48858e6fc70 BUG: 789278 Signed-off-by: hari gowtham <hgowtham> REVIEW: https://review.gluster.org/18791 (afr: coverity fixes) posted (#1) for review on master by Ravishankar N COMMIT: https://review.gluster.org/18629 committed in master by \"hari gowtham\" <hari.gowtham005> with a commit message- tier/glusterd: coverity issues in glusterd-tier.c Coverity issues fixed in this patch: 254, 256, 295, 791, 546 from: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/ master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I44b7d307a3434040125d8b1d6fb18221f30f678d BUG: 789278 Signed-off-by: hari gowtham <hgowtham> REVIEW: https://review.gluster.org/18800 (rpc-lib: coverity fixes) posted (#1) for review on master by Milind Changire COMMIT: https://review.gluster.org/18762 committed in master by \"Subha sree Mohankumar\" <smohanku> with a commit message- features/changetimerecorder:unused value coverity fix Problem : Overwritting the value of ret in extract_db_params. Fix : The value is used in out. Change-Id: Ib7bee999c6f19e0c83ef47deab61835977162bd5 BUG: 789278 Signed-off-by: Subha sree Mohankumar <smohanku> COMMIT: https://review.gluster.org/18771 committed in master by \"Kartik Burmee\" <kburmee> with a commit message- features/marker: coverity fix issue: Calling "mq_inode_ctx_get" without checking return value function: marker_rename_unwind fix: typecasted the return value of function to void Change-Id: I552b1d76df434dfc3d9c2273ec63ccc4b9f960f2 BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee> REVIEW: https://review.gluster.org/18810 (glusterd:buffer_size_warning coverity fixes) posted (#1) for review on master by Subha sree Mohankumar REVIEW: https://review.gluster.org/18813 (cluster/dht: Coverity fixes for dht-rebalance.c) posted (#1) for review on master by Karthik U S COMMIT: https://review.gluster.org/18805 committed in master by \"Kartik Burmee\" <kburmee> with a commit message- cluster/dht: dead code coverity fix issue: Execution cannot reach this statement: "call_stub_destroy(stub);" function: dht_mkdir_hashed_cbk fix: removed the statement and the corresponding 'if' condition block. Change-Id: I3e31056ee489ede6864e51a8e666edc7da3c175f BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee> REVIEW: https://review.gluster.org/18821 (posix: Fix coverity issues in several posix functions) posted (#1) for review on experimental by Amar Tumballi COMMIT: https://review.gluster.org/18786 committed in master by \"Subha sree Mohankumar\" <smohanku> with a commit message- libglusterfs:checked return coverity fix Problem:Calling "gf_thread_create" without checking return value. Fix:The return value is saved and checked if gf_thread_create fails. Change-Id: Ibdaac1c90a1a8369e92ade50825598b041063da8 BUG: 789278 Signed-off-by: Subha sree Mohankumar <smohanku> COMMIT: https://review.gluster.org/18806 committed in master by \"Kartik Burmee\" <kburmee> with a commit message- rpc/rpc-transport: dead code coverity fix issue: Execution cannot reach this statement: "iobuf_unref(iobuf);" function: gf_rdma_do_reads fix: removed the statement and the corresponding 'if' block Change-Id: Ia21b872996dbc8e0a66c8c28dd90b367d3c9aadd BUG: 789278 Signed-off-by: Kartik_Burmee <kburmee> COMMIT: https://review.gluster.org/18813 committed in master by \"Karthik U S\" <ksubrahm> with a commit message- cluster/dht: Coverity fixes for dht-rebalance.c Warning Functions DEADCODE gf_defrag_handle_migrate_error gf_defrag_get_entry gf_defrag_process_dir gf_defrag_start_crawl dht_migrate_file UNUSED_VALUE migrate_special_files dht_migrate_file FORWARD_NULL gf_tier_do_fix_layout Change-Id: I6f408585b83a267581a4273dae7c22b8993163d5 BUG: 789278 Signed-off-by: karthik-us <ksubrahm> COMMIT: https://review.gluster.org/18619 committed in master by \"Kaushal M\" <kaushal> with a commit message- cli: Fix coverity errors for cli-rpc-ops.c Fixes issues 147, 168, 169, 219, 715, 718, 766, 768, 772, 774, 776, 782, 790 from the report at [1]. Also, fixed some other possible static checker errors as well. [1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ BUG: 789278 Change-Id: I985cea1ef787d239b2632d5a7f467070846f92e4 Signed-off-by: Kaushal M <kaushal> COMMIT: https://review.gluster.org/18800 committed in master by \"Milind Changire\" <mchangir> with a commit message- rpc-lib: coverity fixes Scan URL: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-11-10-0f524f07/html/ ID: 9 (BAD_SHIFT) ID: 58 (CHECKED_RETURN) ID: 98 (DEAD_CODE) ID: 249, 250, 251, 252 (MIXED_ENUMS) ID: 289, 297 (NULL_RETURNS) ID: 609, 613, 622, 644, 653, 655 (UNUSED_VALUE) ID: 432 (RESOURCE_LEAK) Change-Id: I2349877214dd38b789e08b74be05539f09b751b9 BUG: 789278 Signed-off-by: Milind Changire <mchangir> COMMIT: https://review.gluster.org/18671 committed in master by \"hari gowtham\" <hari.gowtham005> with a commit message- tier: coverity fixes in tier.c fixes coverity issues: 127, 83, 312, 314, 48, and 506 from https://download.gluster.org/pub/gluster/glusterfs/static-analysis /master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: Ifb206a8758790faf96619bcc9961dcf169aaad25 BUG: 789278 Signed-off-by: hari gowtham <hgowtham> COMMIT: https://review.gluster.org/18791 committed in master by \"Ravishankar N\" <ravishankar> with a commit message- afr: coverity fixes 1.afr_discover_do: COPY_PASTE_ERROR 2.afr_fav_child_reset_sink_xattrs_cbk: REVERSE_INULL 3.afr_fop_lock_proceed: UNUSED_VALUE 4.afr_local_init: CHECKED_RETURN 5.afr_set_split_brain_choice: REVERSE_INULL 6.__afr_inode_write_finalize: FORWARD_NULL 7.afr_refresh_heal_done: REVERSE_INULL 8.afr_xl_op:UNUSED_VALUE 9.afr_changelog_populate_xdata: DEADCODE 10.set_afr_pending_xattrs_option: RESOURCE_LEAK Note: RESOURCE_LEAK complaints about afr_fgetxattr_pathinfo_cbk, afr_getxattr_list_node_uuids_cbk and afr_getxattr_pathinfo_cbk seem to be false alarms. Change-Id: Ia4ca1478b5e2922084732d14c1e7b1b03ad5ac45 BUG: 789278 Signed-off-by: Ravishankar N <ravishankar> REVIEW: https://review.gluster.org/18886 (glusterd: revert coverity fix for freeing key_dup) posted (#1) for review on master by Atin Mukherjee COMMIT: https://review.gluster.org/18642 committed in master by \"MOHIT AGRAWAL\" <moagrawa> with a commit message- posix: Fix coverity issues in several posix functions Fixes issues 528, 763, 778, 792, 793, 86, 28, 29, 30, 39, 42, 769, 783, 794, 795 from the report at [1]. [1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Note: Apart from coverity resolve other issues in posix_get(f)xattr more cleaner way. BUG: 789278 Change-Id: If0737492198481ad7a8d75a3801c862fd61b8c6e Signed-off-by: Mohit Agrawal <moagrawa> COMMIT: https://review.gluster.org/18886 committed in master by \"Atin Mukherjee\" <amukherj> with a commit message- glusterd: revert coverity fix for freeing key_dup key_dup can't be freed here as the same is referenced at the gd_mgmt_v3_unlock_timer_cbk. Change-Id: I85667f98c82d1acebcce59137dfc0dd1ca93b4eb BUG: 789278 Signed-off-by: Atin Mukherjee <amukherj> COMMIT: https://review.gluster.org/18905 committed in master by \"Karthik U S\" <ksubrahm> with a commit message- dht: coverity fix in dht-rebalance.c Fixed UNUSED_VALUE warning in dht_migrate_file. Issue ID: 526 From: http://download.gluster.org/pub/gluster/glusterfs/ static-analysis/master/glusterfs-coverity/2017-11-30-eb013e4c Change-Id: I37395e8ce7088742501424fcce918f0ee8ab4f3d BUG: 789278 Signed-off-by: karthik-us <ksubrahm> REVIEW: https://review.gluster.org/18908 (leases: Fix coverity issues) posted (#1) for review on master by Saravanakumar Arumugam COMMIT: https://review.gluster.org/18810 committed in master by \"Subha sree Mohankumar\" <smohanku> with a commit message- glusterd:buffer_size_warning coverity fixes Fixes Issues :15,17,18,19,24,38 Change-Id: Ib09d319308e4ef7dfbdd5e49e16064d4f55a54f9 BUG: 789278 Signed-off-by: Subha sree Mohankumar <smohanku> REVIEW: https://review.gluster.org/18952 (posix: Fix coverity issues in several posix functions) posted (#1) for review on experimental by Kotresh HR COMMIT: https://review.gluster.org/18952 committed in experimental by \"Kotresh HR\" <khiremat> with a commit message- posix: Fix coverity issues in several posix functions Fixes issues 528, 763, 778, 792, 793, 86, 28, 29, 30, 39, 42, 769, 783, 794, 795 from the report at [1]. [1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Note: Apart from coverity resolve other issues in posix_get(f)xattr more cleaner way. BUG: 789278 Change-Id: Ib6af74616a4dba00090fc66da459e589ef017641 Signed-off-by: Mohit Agrawal <moagrawa> COMMIT: https://review.gluster.org/18904 committed in master by \"Karthik U S\" <ksubrahm> with a commit message- features/read-only: Coverity fixes Warning File Function NEGATIVE_RETURNS worm.c worm_writev RESOURCE_LEAK worm.c init read-only.c init Note: COPY_PASTE_ERROR in worm_setattr & worm_fsetattr are false alarms. Change-Id: Iba1b0c18137a8797d7d04502acc87f0b307e1a1c BUG: 789278 Signed-off-by: karthik-us <ksubrahm> REVIEW: https://review.gluster.org/19031 (cluster/ec: Fix possible shift overflow) posted (#1) for review on master by Xavier Hernandez COMMIT: https://review.gluster.org/18634 committed in master by with a commit message- snapshot: Fix several coverity issues in glusterd-snapshot-utils.c This patch fixes issues 622, 627, 630, 484, 32, 33 and 34 from [1] [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-10-30-9aa574a5/html/ Change-Id: I4c7ac2b2725474d73643367b38f8bf33eaddd8da BUG: 789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/19051 (snapshot: fix several coverity issues in glusterd-snapshot.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/18622 committed in master by \"Xavier Hernandez\" <jahernan> with a commit message- cli: Fixed coverity issue in cli-cmd-system.c This patch adds a missing check of the return value of strtok_r() and returns an error if it's NULL. It also fixes a couple of leaks. Change-Id: Ib15d6f843516e44c3bd8790a2e3ad936e357f6d4 BUG: 789278 Signed-off-by: Xavier Hernandez <jahernan> COMMIT: https://review.gluster.org/19051 committed in master by \"Sunny Kumar\" <sunkumar> with a commit message- snapshot: fix several coverity issues in glusterd-snapshot.c This patch fixes issues 157, 426, 428, 431, 432, 437,439, 482 from [1]. [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-12-13-e255385a/html/ Change-Id: Iff9df12bd9802db29434155badb1beda045aba5b BUG: 789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/19031 committed in master by \"Xavier Hernandez\" <jahernan> with a commit message- cluster/ec: Fix possible shift overflow A coverity scan has revelaed a potential shift overflow while scanning the bitmap of available subvolumes. The actual overflow cannot happen, but I've changed to test used to control the limit to make it explicit. Change-Id: Ieb55f010bbca68a1d86a93e47822f7c709a26e83 BUG: 789278 Signed-off-by: Xavier Hernandez <jahernan> REVIEW: https://review.gluster.org/19075 (rpc-transport/rdma: Fix coverity issues in rdma transport) posted (#1) for review on master by Yi Wang COMMIT: https://review.gluster.org/19075 committed in master by \"Yi Wang\" <wangyi8848> with a commit message- rpc-transport/rdma: Fix coverity issues in rdma transport Issues: [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-12-25-0bc22bef/cov-errors.txt Resolved: [1] rdma.c:128 var_deref_op: Dereferencing null pointer "post". [2] rdma.c:677: Potentially overflowing expression [3] rdma.c:4250: freed_arg: "rpc_transport_unref" frees "peer->trans". [4] rdma.c:4644: var_deref_op: Dereferencing null pointer "rdma_ctx". [5] rdma.c:4945: cond_false: Condition "rdma_ctx != NULL", taking false branch. Change-Id: Iec38f118d645df4131739da412a6c741ebbd2f85 BUG: 789278 Signed-off-by: Yi Wang <wangyi> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-4.0.0, please open a new bug report. glusterfs-4.0.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2018-March/000092.html [2] https://www.gluster.org/pipermail/gluster-users/ Reopening, inadvertently closed. REVIEW: https://review.gluster.org/19809 (snapview-server: Fix double free) posted (#1) for review on master by REVIEW: https://review.gluster.org/19838 (Remove double free since GF_FREE is called twice) posted (#1) for review on master by Michael Scherer REVIEW: https://review.gluster.org/19869 (glusterd/geo-rep: Fix UNUSED_VALUE coverity issue) posted (#1) for review on master by Varsha Rao COMMIT: https://review.gluster.org/19869 committed in master by "Aravinda VK" <avishwan> with a commit message- glusterd/geo-rep: Fix UNUSED_VALUE coverity issue The return value of glusterd_get_local_brickpaths is unused so add goto statement. As it is reinitialized outside the if block. Also change the if condition to check the failure case, when return value is -1 and path_list is NULL. Change-Id: I6b47d7751263f704bd69a6452a7e71bfcf226d49 updates: bz#789278 Signed-off-by: Varsha Rao <varao> REVIEW: https://review.gluster.org/20116 (performance/io-cache: fix a missing unlock) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20117 (call-stub: Add a missing break) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20118 (features/shard: Fix missing unlock in shard_fsync_shards_cbk()) posted (#1) for review on master by Vijay Bellur COMMIT: https://review.gluster.org/20116 committed in master by "Vijay Bellur" <vbellur> with a commit message- performance/io-cache: fix a missing unlock Fixes: bz789278 Change-Id: If8ca1fef8a10f1e7270390b61121f8a20a76b1d0 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/20119 (mgmt/glusterd: Cleanup dead code) posted (#1) for review on master by Vijay Bellur COMMIT: https://review.gluster.org/20117 committed in master by "Poornima G" <pgurusid> with a commit message- call-stub: Add a missing break updates: bz#789278 Change-Id: Id411e69505209c08f33bb77948ee81936dfaef79 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20118 committed in master by "Amar Tumballi" <amarts> with a commit message- features/shard: Fix missing unlock in shard_fsync_shards_cbk() updates: bz#789278 Change-Id: I745a98e957cf3c6ba69247fcf6b58dd05cf59c3c Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20119 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt/glusterd: Cleanup dead code updates: bz#789278 Change-Id: Id67ab681317eb0a69874400a40e3b249dfc7a7db Signed-off-by: Vijay Bellur <vbellur> REVISION POSTED: https://review.gluster.org/20171 (features/shard: Fix missing unlock in shard_fsync_shards_cbk()) posted (#2) for review on release-4.1 by Krutika Dhananjay REVIEW: https://review.gluster.org/20415 (xlators/meta: Fix resource_leak) posted (#1) for review on master by Varsha Rao REVIEW: https://review.gluster.org/20416 (xlators/features/barrier: Fix RESOURCE_LEAK) posted (#1) for review on master by Varsha Rao COMMIT: https://review.gluster.org/20416 committed in master by "Varsha Rao" <varao> with a commit message- xlators/features/barrier: Fix RESOURCE_LEAK Free priv to fix the resource_leak coverity issue. Change-Id: I1f93f54d7d59eddb0b9523ac2b67ef0b279122bd updates: bz#789278 Signed-off-by: Varsha Rao <varao> COMMIT: https://review.gluster.org/20415 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators/meta: Fix resource_leak Free priv to fix the resource_leak coverity issue. Change-Id: Id116bd2f72332d2f665c25c9ae27241286ac570f updates: bz#789278 Signed-off-by: Varsha Rao <varao> REVIEW: https://review.gluster.org/20556 (glusterd: Coverity issues with type FORWARD_NULL) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/20559 (glusterd: Coverity issues with type DEADCODE) posted (#1) for review on master by COMMIT: https://review.gluster.org/20559 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: Deadcode Coverity issue This patch will fix coverity issue 74 from [1]. we are updating ret value line number 5011, and immediately checking whether ret is having non zero value at line number 5013.If ret is 0, then only we continue to execute and we can reach line number 5036. By the time we reach 5036, ret value is always 0. So this block of code is redundant here and removing it. [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2018-07-23-5fa004f3/html/ Updates: bz#789278 Change-Id: Ia6e8ba2936e350f0d29a9151ab786622f5e750db Signed-off-by: Oshank Kumar <okumar> COMMIT: https://review.gluster.org/20556 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: Coverity issues with type FORWARD_NULL This patch fixes coverity issues 102, 103, 112 and 119 from [1] [1] https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2018-07-23-5fa004f3/html/ Updates: bz#789278 Change-Id: I99762eb0bcbd974a5250434777db63520f2ce2e6 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/20563 (coverity: Ignore most of SECURE_TEMP issues) posted (#1) for review on master by Shyamsundar Ranganathan COMMIT: https://review.gluster.org/20563 committed in master by "Amar Tumballi" <amarts> with a commit message- coverity: Ignore most of SECURE_TEMP issues mkstemp as per the Linux man page, uses 0600 as the permission bits when creating the file. This is hence safe and a Coverity warning that should be ignored. Further, we are mostly a multi-threaded program in all our daemons and cannot set and unset umask at will in a multi-threaded program, to address the coverity issue. This change attempts to nudge coverity to ignore this warning, using the pattern, /* coverity[EVENT_TAG_NAME] ... */ <line of code that has the issue> This commit is an experiment, if post merge the next coverity report ignores these errors, the above pattern (as found using an internet search) works and can be applied to certain other warnings as well. Change-Id: I73a184ce1a54dd9e66542952b1190a74438c826a Updates: bz#789278 Signed-off-by: ShyamsundarR <srangana> REVIEW: https://review.gluster.org/20585 (posix: FORWARD_NULL coverity fix) posted (#1) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20588 (FORWARD_NULL coverity fix) posted (#1) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20588 (locks: FORWARD_NULL coverity fix) posted (#2) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20590 (coverity: Fix remaining SECURE_TEMP issues reported) posted (#1) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/20593 (marker: FORWARD_NULL coverity fix) posted (#1) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20593 (marker: FORWARD_NULL coverity fix) posted (#2) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20600 (geo-rep : fix few coverity issues in procdiggy.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/20590 committed in master by "Amar Tumballi" <amarts> with a commit message- coverity: Fix remaining SECURE_TEMP issues reported Two pending SECURE_TEMP issues still exist in the coverity reports, these are fixed by this patch. In both instances (where functions actually seem to be duplicates of each other) the need was for a FILE * and not an fd. Applied the same pattern in both places as in other parts of the code where mkstemp was used and later a FILE * was created from the resulting fd for use. Coverity report: https://download.gluster.org/pub/gluster/ glusterfs/static-analysis/master/glusterfs-coverity/ 2018-07-30-4d3c62e7/html/ Issues numbered: 382, 383 (named SECURE_TEMP) Further added tmpfile to the blacklist, so that future code changes do not add the same, into symbol-check.sh. Also corrected shellcheck errors in symbol-check.sh as a result of updating the same. Updates: bz#789278 Change-Id: I1d572a16ca5b5df2f597aeaa5f454fad34c8296e Signed-off-by: ShyamsundarR <srangana> REVIEW: https://review.gluster.org/20629 (marker: FORWARD_NULL coverity fix) posted (#1) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20629 (stripe: FORWARD_NULL coverity fix) posted (#2) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20593 (marker: FORWARD_NULL coverity fix) posted (#3) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20629 (stripe: FORWARD_NULL coverity fix) posted (#3) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20646 (cluster/ec: FORWARD_NULL coverity fix) posted (#1) for review on master by Sunil Kumar Acharya REVIEW: https://review.gluster.org/20647 (libglusterfs: FORWARD_NULL coverity fix) posted (#1) for review on master by Sunil Kumar Acharya REVIEW: https://review.gluster.org/20649 (coverity: last of the secure temp fixes) posted (#1) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/20652 (xlators: protocol: Fix deferencing pointer after free coverity issues) posted (#1) for review on master by Bhumika Goyal REVIEW: https://review.gluster.org/20654 (snapshot : fix few coverity issues in glusterd-snapshot-utils.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20656 (geo-rep : fix coverity issues in glusterd-geo-rep.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20683 (cluster/dht: coverity fixes) posted (#1) for review on master by N Balachandran REVIEW: https://review.gluster.org/20689 (cli : fix few coverity in cli) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20690 (POSIX: some coverity fixes) posted (#1) for review on master by Bhumika Goyal REVIEW: https://review.gluster.org/20691 (uss : fix coverity issues) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20703 ([WIP] migrate from strncpy and strcpy to gf_strncpy) posted (#2) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20711 (features/cloudsync: Fix various resource leaks) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20712 (mgmt/glusterd: Fix buffer length to prevent a memory overrun) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20713 (mgmt/glusterd: Fix possible use after free in glusterd_op_ac_commit_op()) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20714 (libglusterfs: Fix a resource leak in graph.c) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20716 (features/changelog: Fix a resource leak) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20718 (libglusterfs : fix coverity issues in common-utils.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20719 (mgmt/glusterd: Fix a memory leak in volgen) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20720 (features/changelog: close htime_fd in fini()) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20721 (nfs-server-mount : fix coverity issues in mount3.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/20649 committed in master by "Amar Tumballi" <amarts> with a commit message- coverity: last of the secure temp fixes Coverity ignore directive is not working if the comment is split across lines (or has an empty line at the end. This can be seen in this report: https://download.gluster.org/pub/gluster/glusterfs/static-analysis /master/glusterfs-coverity/2018-08-06-b982e09f/html/1 /384glusterfsd-mgmt.c.html#error In other places the same pattern has avoided coverity from flagging off the same call, except here. Updates: bz#789278 Change-Id: Ic35ff0fc91d0a42904630728ef7c18215aa277f3 Signed-off-by: ShyamsundarR <srangana> COMMIT: https://review.gluster.org/20714 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs: Fix a resource leak in graph.c Fixes CID 1382367 Change-Id: I02678fc71716ab0046ea2ef437c6594a8a34a4fc updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/20725 (features/acl: Fix a possible null dereference) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20727 (features/changelog: Fix missing unlocks) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20728 (debug/error-gen: Fix null deref and out of bounds read issues) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20729 (error-gen, locks: Fix a typo in comments) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20730 (mgmt/glusterd: Fix resource leak & unused value issues in glusterd-volume-ops.c) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20731 (mgmt/glusterd: Code cleanup in glusterd-volgen.c) posted (#1) for review on master by Vijay Bellur COMMIT: https://review.gluster.org/20729 committed in master by "Amar Tumballi" <amarts> with a commit message- error-gen, locks: Fix a typo in comments s/coverty/coverity/ Change-Id: Iac7c13176162eace4247dd3236373aa76d906380 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/20734 (trash : fix coverity issues in trash.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/20719 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt/glusterd: Fix a memory leak in volgen Fixes CID 1325557 Change-Id: I5e33ae19ddf4c44a49a2b3b3dea0c739bc96d3a7 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/20735 (meta : fix coverity in meta-helpers.c) posted (#2) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20738 (afr: Resource leak coverity fixes) posted (#1) for review on master by Bhumika Goyal REVIEW: https://review.gluster.org/20739 (mountbroker : fix coverity issue in glusterd-mountbroker.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20745 (glusterd: coverity defects fix introduced by commit 1f3bfe7) posted (#1) for review on master by Atin Mukherjee COMMIT: https://review.gluster.org/20741 committed in master by "Amar Tumballi" <amarts> with a commit message- performance/md-cache: Use bitwise AND instead of logical AND Addresses CID: 1394640 Change-Id: I1139222301569d17760df74624acd301594063b9 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20691 committed in master by "Amar Tumballi" <amarts> with a commit message- uss : fix coverity issues This patch fixes coverity issuse in snapview-server.c CID : 1274119, 1325525 Scan details at [1]. [1]. https://scan6.coverity.com/reports.htm#v42401/p10714/fileInstanceId=84476369&defectInstanceId=25631967&mergedDefectId=778645 Change-Id: I825f09eabf84a2262a079c1f920a673727c5792b updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/20646 committed in master by "Amar Tumballi" <amarts> with a commit message- cluster/ec: FORWARD_NULL coverity fix Fixing FORWARD_NULL coverify errors with EC. CID: 1394650 BUG: 789278 Change-Id: I52c99dac3483ca31a86cd7e3a959d4010b195f32 updates: bz#789278 Signed-off-by: Sunil Kumar Acharya <sheggodu> COMMIT: https://review.gluster.org/20647 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs: FORWARD_NULL coverity fix Fixing FORWARD_NULL coverify errors in libglusterfs. CID: 1391407, 1391410 BUG: 789278 Change-Id: I3d20523005e4418759c8a72620edff7c977d2d00 updates: bz#789278 Signed-off-by: Sunil Kumar Acharya <sheggodu> COMMIT: https://review.gluster.org/20734 committed in master by "Amar Tumballi" <amarts> with a commit message- trash : fix coverity issues in trash.c This patch fixes CID : 1382380 and 1382428. Change-Id: Ice3c8f5c2d97a0b541665bff744f32fbea9e294f updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/20753 (block xlator: fix some coverity issues) posted (#1) for review on master by Bhumika Goyal REVIEW: https://review.gluster.org/20754 (changetimerecorder: fix coverity issues) posted (#1) for review on master by Bhumika Goyal REVIEW: https://review.gluster.org/20755 (stripe-helper : fix coverity in stripe-helpers.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20756 (stripe : fix coverity issues in stripe.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20757 (glusterd: BUFFER_SIZE coverity fix) posted (#1) for review on master by Sunil Kumar Acharya COMMIT: https://review.gluster.org/20743 committed in master by "Amar Tumballi" <amarts> with a commit message- jbr : fix coverity issues in jbr This patch fixes CID 1357875 and 1357869. Change-Id: Ief88523e5ad92a2c884ff1b85cd613992bba0dad updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/20742 committed in master by "Amar Tumballi" <amarts> with a commit message- statedump : fix coverity issues Comparing an array to null is not useful, the test will always evaluate as true. Fixes CID 1325566 and 1389371. updates: bz#789278 Change-Id: Id51f84cc62767a432de1d12851ae2669c1596a94 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/20745 committed in master by "Amar Tumballi" <amarts> with a commit message- glusterd: coverity defects fix introduced by commit 1f3bfe7 Commit 1f3bfe7 stripped down the total size of certain path related variables in glusterd_brickinfo_t which considered couple of new coverity defects. Fix the following: CID : 1394969 Destination buffer too small CID : 1394968 Out-of-bounds access Change-Id: Ibc30eac4680cc6c83bd89d248f1435cb6a3d1b75 updates: bz#789278 Signed-off-by: Atin Mukherjee <amukherj> REVIEW: https://review.gluster.org/20758 (coverity: libglusterfs issues) posted (#1) for review on master by Amar Tumballi COMMIT: https://review.gluster.org/20725 committed in master by "Amar Tumballi" <amarts> with a commit message- features/acl: Fix a possible null dereference Addresses CID 1370952 Change-Id: I1f157dbede32e74e38aed8a1a162e38107f2628d updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20735 committed in master by "Amar Tumballi" <amarts> with a commit message- meta : fix coverity in meta-helpers.c This fixes CID 1214627 and 1257625. updates: bz#789278 Change-Id: I6eb1ccf7b498948d1c41ff830e65437ef818cd55 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/20721 committed in master by "Amar Tumballi" <amarts> with a commit message- nfs-server-mount : fix coverity issues in mount3.c Fixes CID 1389033, 1388767, 1288782. Change-Id: I244f88b2ca8487f8926da45d886982558ad45c7a updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/20585 committed in master by "Amar Tumballi" <amarts> with a commit message- posix: FORWARD_NULL coverity fix Problem: filler could be null. Solution: Modified the condition check to avoid NULL pointer dereferencing. BUG: 789278 Change-Id: I0c3e29ede3c226295a9860ddcb3b432832c381dd Signed-off-by: Shwetha Acharya <shwetha174> COMMIT: https://review.gluster.org/20588 committed in master by "Amar Tumballi" <amarts> with a commit message- locks: FORWARD_NULL coverity fix Problem: "dst" could be NULL. Solution: Added a condition check to avoid NULL pointer dereferencing. BUG: 789278 Change-Id: I13ccf3234eda50a197f5fdfaf35b247589302582 Signed-off-by: Shwetha Acharya <shwetha174> COMMIT: https://review.gluster.org/20727 committed in master by "Amar Tumballi" <amarts> with a commit message- features/changelog: Fix missing unlocks Addresses CID 1210981 Change-Id: Icd325588ae0639e09d924fdde171931dedd06ca6 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20720 committed in master by "Amar Tumballi" <amarts> with a commit message- features/changelog: close htime_fd in fini() Addresses CID: 1325549 Change-Id: Ib041c7c288db6810b2e13a05a19ee894a47c9b05 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/20850 (glusterd: fix some coverity issues) posted (#1) for review on master by Bhumika Goyal COMMIT: https://review.gluster.org/20753 committed in master by "Amar Tumballi" <amarts> with a commit message- block xlator: fix some coverity issues Fixes CID: 1128916, 1128917, 1128919, 1192875 Change-Id: I5276b7db4a9650e70c335e25b9b4609a887233c0 updates: bz#789278 Signed-off-by: Bhumika Goyal <bgoyal> COMMIT: https://review.gluster.org/20728 committed in master by "Amar Tumballi" <amarts> with a commit message- debug/error-gen: Fix null deref and out of bounds read issues Addresses CID: 1124492, 1124700, 1124701 Change-Id: If9916df1b0a4e67ad74fe0f6ea6f2544598ddacb updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/20629 (stripe: FORWARD_NULL coverity fix) posted (#4) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20852 (crypt: fix coverity issues) posted (#1) for review on master by Bhumika Goyal REVIEW: https://review.gluster.org/20853 (quota: coverity fixes) posted (#1) for review on master by Bhumika Goyal REVIEW: https://review.gluster.org/20855 (protocol: coverity fixes) posted (#1) for review on master by Bhumika Goyal REVIEW: https://review.gluster.org/20593 (marker: FORWARD_NULL coverity fix) posted (#4) for review on master by Shwetha K Acharya COMMIT: https://review.gluster.org/20758 committed in master by "Niels de Vos" <ndevos> with a commit message- coverity: libglusterfs issues CID: 1391415, 1274122, 1274201, 1382408, 1382437, 1389436 1288798, 1288106, 1288110 updates: bz#789278 Change-Id: I48c7a50f22f5f4580310040c66463d9f7dd26204 Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/20731 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt/glusterd: Code cleanup in glusterd-volgen.c This patch does the following: 1. Addresses CID: 1124815,124816,1124833,1291724,1325535,1325536,1357858 - by adding some null checks - by handling return values from functions - by using an appropriate buffer length in strncpy 2. Cleans up some commented code Change-Id: I5a7079f34e3e460d5a6267734c3bc84bf4ad72f5 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/20860 (dht: FORWARD_NULL coverity fix) posted (#1) for review on master by Sunil Kumar Acharya REVIEW: https://review.gluster.org/20861 (jbr : fix coverity issue in jbr.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20862 (glusterd: FORWARD_NULL coverity fix) posted (#1) for review on master by Sunil Kumar Acharya REVIEW: https://review.gluster.org/20863 (wrote-behind: coverity fixes) posted (#1) for review on master by Bhumika Goyal COMMIT: https://review.gluster.org/20850 committed in master by "Amar Tumballi" <amarts> with a commit message- glusterd: fix some coverity issues Fixes CID: 1241481 1241482 1274079 1274118 1274121 1274131 1274198 1274214 1274220 1274224 1394663 1394641 382454 1382453 1382449 1288095 Link: https://scan6.coverity.com/reports.htm#v42388/p10714/fileInstanceId=84772667&defectInstanceId=25770661&mergedDefectId=744716 Change-Id: Idaf434186231c8b0fff4b27c57fa23636a89c8a7 updates: bz#789278 Signed-off-by: Bhumika Goyal <bgoyal> COMMIT: https://review.gluster.org/20853 committed in master by "Amar Tumballi" <amarts> with a commit message- quota: coverity fixes Fixes CID: 1325638 1288766 1124357 Change-Id: I425f857d0d549da2dfaa6a6e6b8440cb14c21121 updates: bz#789278 Signed-off-by: Bhumika Goyal <bgoyal> COMMIT: https://review.gluster.org/20593 committed in master by "Amar Tumballi" <amarts> with a commit message- marker: FORWARD_NULL coverity fix Problem: Coverity false positive. Solution: Added a comment to ignore the false positive. CID: 1325591 BUG: 789278 Change-Id: I95037efd12c059efcfc04f3c4c13f60c530150b4 Signed-off-by: Shwetha Acharya <shwetha174> REVIEW: https://review.gluster.org/20864 (nfs : fix coverity issues) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20865 (rdma: coverity fixes) posted (#1) for review on master by Bhumika Goyal REVIEW: https://review.gluster.org/20866 (locks: coverity fixes) posted (#1) for review on master by Bhumika Goyal COMMIT: https://review.gluster.org/20863 committed in master by "Amar Tumballi" <amarts> with a commit message- write-behind: coverity fixes Fixes CID: 1124360 1291740 1370918 Change-Id: I008c7ade8f9809d040f42f6d3e9af70fff2f3dc6 updates: bz#789278 Signed-off-by: Bhumika Goyal <bgoyal> COMMIT: https://review.gluster.org/20600 committed in master by "Amar Tumballi" <amarts> with a commit message- geo-rep : fix few coverity issues in procdiggy.c This patch fixes BAD_FREE at line number 75,105 and UNUSED_VALUE at line number 108. CID : 1274068 scan detail at [1]. [1] https://scan6.coverity.com/reports.htm#v42401/p10714/fileInstanceId=84384726&defectInstanceId=25600457&mergedDefectId=727233 Change-Id: I8dff42546204bf78c178c9dcaba534888c5354e9 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/20869 (features/sdfs: Minor improvements for Coverity) posted (#1) for review on master by Vijay Bellur COMMIT: https://review.gluster.org/20861 committed in master by "Amar Tumballi" <amarts> with a commit message- jbr : fix coverity issue in jbr.c This fixes CID 1395069. Change-Id: I0d2fa8fb04adf035c358841f43dea64f6aa8a1d8 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/20652 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators: protocol: Fix deferencing pointer after free coverity issues The pointer of type struct iobuf * is getting dereferenced after getting freed by iobuf_unref function. Therefore, move this function after all the dereferences of this pointer type. Also, it is useful coding standard to have iobuf_unref just after iobref_add. So, move iobref_add too. Occurences found using Coccinelle script: @@ identifier rsphdr_iobuf; expression E; identifier func; @@ *iobuf_unref(rsphdr_iobuf); ... *E = func(rsphdr_iobuf); Fixes CID: 1390517, 1390278, 1388666, 1356588, 1356587 at [1]. and also some more occurences which were found using the above script but not caught by Coverity. [1]. https://scan6.coverity.com/reports.htm#v42388/p10714/fileInstanceId=84384920&defectInstanceId=25600709&mergedDefectId=1388666 Change-Id: I579e9d12698f14e9e24bc926c6efef16bac5c06c updates: bz#789278 Signed-off-by: Bhumika Goyal <bgoyal> REVIEW: https://review.gluster.org/20874 (marker: fix for coverity issues) posted (#1) for review on master by hari gowtham COMMIT: https://review.gluster.org/20869 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- features/sdfs: Minor improvements Addresses: CID 1389688: Prevent op_errno from being -ve in sdfs_rename() CID 1389286: Check for retval from loc_copy() to avoid logically dead code and Initializes op_errno to ENOMEM in sdfs_link() Change-Id: I12e17a98faa5887da94a33ba9ca775e8e0fef359 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20683 committed in master by "N Balachandran" <nbalacha> with a commit message- cluster/dht: coverity fixes Fixes 1133997, 1370910, 1382387, 1382444, 1394635 Change-Id: Ie63ad47abd5519b9b9536da26b61ed4c9eaf2c75 updates: bz#789278 Signed-off-by: N Balachandran <nbalacha> REVIEW: https://review.gluster.org/20884 (features/leases: Initialize op_errno in leases_open()) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20886 (features/changelog: Fix a file handle leak in htime_create()) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20887 (coverity: Multiple coverity fixes for issues with HIGH severity) posted (#1) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/20888 (mgmt/glusterd: Fix memory leaks) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20889 (mgmt/glusterd: Fix resource leaks in glusterd-handshake.c) posted (#1) for review on master by Vijay Bellur COMMIT: https://review.gluster.org/20855 committed in master by "Amar Tumballi" <amarts> with a commit message- protocol: coverity fixes Fixes CID: 1389388 1389320 1274113 1388881 1388623 1124801 1124795 Change-Id: Ia72abc0560c959b0298f42e25abdfc5523755569 updates: bz#789278 Signed-off-by: Bhumika Goyal <bgoyal> REVIEW: https://review.gluster.org/20891 (mgmt/glusterd: Fix memory leaks in glusterd-op-sm.c) posted (#1) for review on master by Vijay Bellur COMMIT: https://review.gluster.org/20887 committed in master by "Amar Tumballi" <amarts> with a commit message- coverity: Multiple coverity fixes for issues with HIGH severity glfs-fops.c 1391414 Uninitialized pointer read List head needed initialization glusterfsd-mgmt.c graph.c 1382431 Buffer not null terminated 1382417 Dereference before null check 1382347 Buffer not null terminated Cleaned usage of volfile_checksum member of gf_volfile_t struct across the code base. glusterd-tier.c 1382426 Resource leak 1370955 Dereference before null check The function fixed needs more work, but with tier almost being deprecated, addressed some parts of the reported coverity issues as appropriate. Tested using the following test cases: ./tests/basic/tier/new-tier-cmds.t ./tests/basic/tier/tier.t ./tests/basic/tier/bug-1214222-directories_missing_after_attach_tier.t ./tests/basic/tier/tier_lookup_heal.t ./tests/basic/tier/tier-heald.t ./tests/basic/tier/tier-snapshot.t ./tests/features/glfs-lease.t Change-Id: I396f1c34bb112bb22d2745ed279e1a4850cac4af Updates: bz#789278 Signed-off-by: ShyamsundarR <srangana> REVIEW: https://review.gluster.org/20893 (cluster/ec: Prevent a possible out-of-bounds read) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20916 (cluster/ec: Prevent a possible out-of-bounds read) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20917 (storage/posix: Coverity fixes in posix-handle.c) posted (#1) for review on master by Vijay Bellur COMMIT: https://review.gluster.org/20852 committed in master by "Amar Tumballi" <amarts> with a commit message- crypt: fix coverity issues Fixes CID: 130760 130759 Change-Id: I40efebd712a3bd769cb1fbc54409f1b0b35eb7b4 updates: bz#789278 Signed-off-by: Bhumika Goyal <bgoyal> COMMIT: https://review.gluster.org/20891 committed in master by "Amar Tumballi" <amarts> with a commit message- mgmt/glusterd: Fix memory leaks in glusterd-op-sm.c Addresses the following CIDs: - 1124704: Removed an unessential variable that caused a memory leak in glusterd_op_set_volume(). Nuked an unnecessary log message upon error as well since failure logging is being done in the caller - 1124772: Memory leak in an error path of glusterd_op_ac_send_brick_op() - 1175021: Removed an unessential variable that caused a memory leak in glusterd_op_build_payload() Also addressed a memory leak in an error path of glusterd_dict_set_volid() Change-Id: I060effbbcebe9d58b91f606175080ede517ba239 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20884 committed in master by "Amar Tumballi" <amarts> with a commit message- features/leases: Initialize op_errno in leases_open() Addresses CID: 1356483 by getting rid of an unessential assignment for op_errno Change-Id: I2327ac17b2875b4dd5f79b76be59e2c8e570b031 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20889 committed in master by "Amar Tumballi" <amarts> with a commit message- mgmt/glusterd: Fix resource leaks in glusterd-handshake.c Addresses the following CIDs: 1124768: fd leak in __server_getspec() if spec_fd happens to be 0 1202400: Memory leak in get_snap_volname_and_volinfo() 1214622: Memory leak in glusterd_create_missed_snap() 1214623: Memory leak in an error path of __server_get_volume_info() Change-Id: I33910b4125d25205e76e0d13cf0256d47bd8fc3c updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20886 committed in master by "Amar Tumballi" <amarts> with a commit message- features/changelog: Fix a file handle leak in htime_create() In a few error scenarios, ht_file_hd was not being cleaned up. Addresses CID: 1325549 Change-Id: If9b4388aa700303c1eebbf1410dc35d18c4637df updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/20629 (stripe: FORWARD_NULL coverity fix) posted (#5) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20956 (feature/shard: Fix Coverity issue) posted (#1) for review on master by Ashish Pandey COMMIT: https://review.gluster.org/20888 committed in master by "Amar Tumballi" <amarts> with a commit message- mgmt/glusterd: Fix memory leaks in glusterd-handler.c Addresses the following CIDs: 1370941: Unconditional memory leak in glusterd_print_snapinfo_by_vol() 1370943: Memory leak when opendir fails for output directory in glusterd_get_state() Change-Id: I9536841629e1ffe1fed79a8e57d266a0e953e5af updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/20629 (stripe: FORWARD_NULL coverity fix) posted (#6) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/20978 (block : fix few coverity issue) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/20979 (dht/switch: Fix coverity issues) posted (#1) for review on master by Shyamsundar Ranganathan COMMIT: https://review.gluster.org/20730 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt/glusterd: Fix resource leak & unused value issues in glusterd-volume-ops.c Addresses CID: 1274132, 1325534 Change-Id: I176612ef5baf5618d543838a5f32db7dcd7002c3 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/20982 (debug/error-gen: Prevent a possible null dereference) posted (#1) for review on master by Vijay Bellur COMMIT: https://review.gluster.org/20979 committed in master by "N Balachandran" <nbalacha> with a commit message- dht/switch: Fix coverity issues CID: 1124779: dup_childs not freed in an err path CID: 1382398: option_string leaked CID: 1382389: memcpy may cause string overflow Also, fixed up NULL termination for the string Potential use after free (or double free in this case) as below, (link split into multiple lines) https://download.gluster.org/pub/gluster/glusterfs/static-analysis/ master/glusterfs-coverity/2018-08-22-0ebaa9c6/html/ 1/427switch.c.html#error Change-Id: I76681af6a8091666918a3d5dff30a152a7b97905 Updates: bz#789278 Signed-off-by: ShyamsundarR <srangana> COMMIT: https://review.gluster.org/20874 committed in master by "Amar Tumballi" <amarts> with a commit message- marker: fix for coverity issues Fixes CID: 1325591 1356503 1325540 1351704 Change-Id: I325b1184baa81402eaa009cb36ab95e5de812f6c updates: bz#789278 Signed-off-by: Hari Gowtham <hgowtham> COMMIT: https://review.gluster.org/20866 committed in master by "Amar Tumballi" <amarts> with a commit message- locks: coverity fixes Fixes CID: 1356583 1356582 1356581 1356580 Add logs and also replace gf_log with gf_msg_debug. Change-Id: I348dc94f7a52034542d29096c12a2cf60aabe97f updates: bz#789278 Signed-off-by: Bhumika Goyal <bgoyal> COMMIT: https://review.gluster.org/20629 committed in master by "Amar Tumballi" <amarts> with a commit message- stripe: FORWARD_NULL coverity fix Problem: frame could be NULL. Solution: Added condition checks to avoid NULL pointer dereferencing. CID: 1124478, 1124501, 1124504, 1124510 BUG: 789278 Change-Id: I5c81d912102a7e672386db3fdb820f883d08666f Signed-off-by: Shwetha Acharya <shwetha174> COMMIT: https://review.gluster.org/20711 committed in master by "Amar Tumballi" <amarts> with a commit message- features/cloudsync: Fix various resource leaks Addresses CID: 1394648, 1394653 Change-Id: Ie75d4a268bba090faa5c3fe0e87f0e5cef3ff773 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20978 committed in master by "Amar Tumballi" <amarts> with a commit message- block : fix few coverity issue Fixes 1128923, 1134020 and 1370936. updates: bz#789278 Change-Id: I2cadc09ffd0814a9390ba068006fa56704d3820d Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/20982 committed in master by "Amar Tumballi" <amarts> with a commit message- debug/error-gen: Prevent a possible null dereference Addresses CID: 1124492 Change-Id: I92f807b5e45537e68c318bcbf54ccaa23d18b0dd Updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20689 committed in master by "Shyamsundar Ranganathan" <srangana> with a commit message- cli : fix few coverity in cli This patch fixes DEADCODE and FORWARD_NULL. CID : 1124495, 1124380, 1124381 Change-Id: I79992e396dbcb1bfe6cd0614d49a8da3f67d648d updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/20991 (mgmt/glusterd: Coverity fixes for glusterd-utils.c) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/20992 (cli : fix coverity cli-rl.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/20917 committed in master by "Amar Tumballi" <amarts> with a commit message- storage/posix: Coverity fixes in posix-handle.c Addresses the following CIDs: 1370938: Out of bounds write in posix_make_ancestryfromgfid() 1351642: UnChecked return value from sys_stat() in posix_handle_init() Change-Id: I3483ebcd798793ce6c504e92b4ea203bcf99fc0e Updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/21004 (features/namespace: Fix a probable null dereference) posted (#1) for review on master by Vijay Bellur COMMIT: https://review.gluster.org/20991 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt/glusterd: Coverity fixes in glusterd-utils.c Addresses the following CIDs: 1388821: Unchecked return value from sys_lremovexattr() in glusterd_check_and_set_brick_xattr() 1370957: Unused return value in glusterd_volume_tier_use_rsp_dict() 1370950: Memory leak in glusterd_get_global_options_for_all_vols() 1370946: Redundant gf_strdup() leading to a memory leak in glusterd_get_global_options_for_all_vols() Change-Id: I2ab58207bc43b40f004ee18463430a141126bf94 Updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20992 committed in master by "Atin Mukherjee" <amukherj> with a commit message- cli : fix coverity cli-rl.c This fixes new coverity issue introduced by commit 5acb74d7da. Fixes 1395188. Change-Id: I629e5f214150672e309abb2fc58f55f1f58d8fb7 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/20956 committed in master by "Amar Tumballi" <amarts> with a commit message- feature/shard: Fix Coverity issue Fix following coverity issues- CID: 1394660 1394668 1394667 1389008 1389434 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=84880983&defectInstanceId=25821108&mergedDefectId=1389008 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=84880983&defectInstanceId=25821101&mergedDefectId=1389434 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=84880983&defectInstanceId=25821001&mergedDefectId=1394660 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=84880983&defectInstanceId=25821010&mergedDefectId=1394667 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=84880983&defectInstanceId=25821017&mergedDefectId=1394668 Change-Id: I08f09649dbe758ba0d367ae5330b48b18784dec3 updates: bz#789278 Signed-off-by: Ashish Pandey <aspandey> REVIEW: https://review.gluster.org/21009 (libglusterfs/gfdb_data_store: handle a range-overflow condition) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21012 (nfs-server : fix few coverity issues in mount3.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21013 (libglusterfs : fix coverity in store.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21014 (playground: fix coverity issue) posted (#1) for review on master by Amar Tumballi COMMIT: https://review.gluster.org/20916 committed in master by "Amar Tumballi" <amarts> with a commit message- cluster/ec: Prevent a possible out-of-bounds read Addresses CID 1370939 In ec_code_x64_epilog(), there is a possibility of reading from an incorrect index of ec_code_x64_regmap array Change-Id: Ib8a228bbe13631188343634b2bde5919cdaab5a4 Updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/21004 committed in master by "Amar Tumballi" <amarts> with a commit message- features/namespace: Fix a probable null dereference Addresses CID: 1388656 Change-Id: I614c29e993dd112ee02c5bffe8c737deb225c1f9 Updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> REVIEW: https://review.gluster.org/21017 (coverity: multiple fixes) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21020 (cli: dereferencing null coverity fix) posted (#1) for review on master by Sanju Rakonde COMMIT: https://review.gluster.org/20654 committed in master by "Amar Tumballi" <amarts> with a commit message- snapshot : fix few coverity issues in glusterd-snapshot-utils.c This patch fixes CID 1210987 and 1351650. Change-Id: Ic85bc6048651146a79fe68add19dcc095738a517 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21013 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs : fix coverity in store.c This patch fixes CID 1395103 and 1395102. Change-Id: I8c9fad85f254a55697b0bad185dcdd02be64f682 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21014 committed in master by "Amar Tumballi" <amarts> with a commit message- playground: fix coverity issue CID: 1395161 Updates: bz#789278 Change-Id: I6cc5c488a8aa12d312c34e6535786fd4debcb24c Signed-off-by: Amar Tumballi <amarts> REVIEW: https://review.gluster.org/21021 (glusterd: Fix coverity issues) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21022 (snapshot : fixed coverity issue in glusterd-snapshot.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21024 (cluster/afr: Coverity fixes in afr) posted (#1) for review on master by Karthik U S REVIEW: https://review.gluster.org/21026 (glusterd: Fix Buffer size issues) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21027 (glusterd : fix some coverity issues in glusterd-syncop.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21022 committed in master by "Atin Mukherjee" <amukherj> with a commit message- snapshot : fixed coverity issue in glusterd-snapshot.c This patch fixes CID 1395253 and indentation. Change-Id: Iffcd992d3d49765c7e47b864724f83c7c5d57579 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21020 committed in master by "Atin Mukherjee" <amukherj> with a commit message- cli: dereferencing null coverity fix CID: 1124489 https://scan6.coverity.com/reports.htm#v42375/p10714/fileInstanceId=85018660&defectInstanceId=25877775&mergedDefectId=577602 updates: bz#789278 Change-Id: I0ebfbc52ecd5e3b70574df5f286116f872514cc6 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/21032 (IO cache : fix coverity issues in io-cache.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21024 committed in master by "Ravishankar N" <ravishankar> with a commit message- cluster/afr: Coverity fixes in afr Fixes the deadcode issue in "afr-common.c" and null pointer dereference isse in "afr-dir-read.c". CIDs: 1395160, 1389018 Scan details: https://scan6.coverity.com/reports.htm#v42418/p10714/fileInstanceId=85017760&defectInstanceId=25877740&mergedDefectId=1395160 https://scan6.coverity.com/reports.htm#v42418/p10714/fileInstanceId=85017734&defectInstanceId=25877951&mergedDefectId=1389018 Change-Id: I65dff57305aa3ae43544be5353f801d761193e97 updates: bz#789278 Signed-off-by: karthik-us <ksubrahm> COMMIT: https://review.gluster.org/21021 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: Fix coverity issues This patch fixes CID's 1395250, 1395252 1395250 - Unintialized variable 1395252 - Out of bounds access updates: bz#789278 Change-Id: Icf646364b14d48fa2bd82ea78ca5cdb5c684355f Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/21037 (xlators: some high severity coverity fixes) posted (#1) for review on master by Bhumika Goyal COMMIT: https://review.gluster.org/21032 committed in master by "Raghavendra G" <rgowdapp> with a commit message- IO cache : fix coverity issues in io-cache.c This patch fixes CID 1382361, 1124714 and 1382432. Change-Id: I0407f35ee44ec6e4522de46092658223d0c8ee6a updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21042 (cli : fix coverity issue in cli-xml-output.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21043 (cluster/ec: Fix Coverity issue) posted (#1) for review on master by Ashish Pandey REVIEW: https://review.gluster.org/21044 (cli : fix coverity issue in cli-cmd-parser.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21046 (cli : fix coverity issue in cli-cmd-volume.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21027 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd : fix some coverity issues in glusterd-syncop.c This patch fixes CID 1382344, 1124655 and 1325537. Change-Id: I2412d6b88483e32a5de1baebb3823a985b2dcfb0 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21051 (crypt : fix coverity issues in crypt.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21009 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs/gfdb_data_store: handle a range-overflow condition As the value read from the file is not checked for the range, and the same value is directly used to allocate, and read further values, it can cause major issues. CID: 1351699 updates: bz#789278 Change-Id: I7ff4c1791343861ebf98d1c615b52af54cb2485e Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/21012 committed in master by "Amar Tumballi" <amarts> with a commit message- nfs-server : fix few coverity issues in mount3.c This patch fixes 1388767 and 1389057. Change-Id: Id4ee7c3cd72e46112315f6dccb08e76788b40d27 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21046 committed in master by "Amar Tumballi" <amarts> with a commit message- cli : fix coverity issue in cli-cmd-volume.c This patch fixes 1389756. Change-Id: I72d4f618368545a5dcee0ca59fe87ba6137ab4a1 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21017 committed in master by "Amar Tumballi" <amarts> with a commit message- coverity: multiple fixes CID: 1390477, 1124827 updates: bz#789278 Change-Id: I41060d131aec6e58e7267ac8531b29a70f8c4359 Signed-off-by: Amar Tumballi <amarts> COMMIT: https://review.gluster.org/20718 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs : fix coverity issues in common-utils.c Fixes CID 1351691, 1351678, 1274192, 1274117, 1124845. Change-Id: I65805524de85fb2186260288641390458a719499 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21051 committed in master by "Amar Tumballi" <amarts> with a commit message- crypt : fix coverity issues in crypt.c This patch fixes CID 1356527, 1356528, 1356529, 1356530, 1395251. Change-Id: Ibdbc56a3221bff3535f02a9e73b57fcbe35c3fbd updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21043 committed in master by "Amar Tumballi" <amarts> with a commit message- cluster/ec: Fix Coverity issue Fix following coverity issues- CID: 1382378 1382459 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85091670&defectInstanceId=25915064&mergedDefectId=1382459 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85091670&defectInstanceId=25915063&mergedDefectId=1382378 Problem: ASSERT_LOCAL(this, healer) function is supposed to get the local healer so that we can take advantage of it while healing and reading data. However, we are not using healer->local anywhere. Also, this is not as useful in context of EC as it is in AFR. In EC we have to raed fragments from 4 bricks to heal a bad fragment on other brick. Change-Id: Iea8ce127ea02cc84e3823cb2be82a47872217b33 updates: bz#789278 Signed-off-by: Ashish Pandey <aspandey> REVIEW: https://review.gluster.org/21057 (IO cache : fix coverity issue in page.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/20656 committed in master by "Amar Tumballi" <amarts> with a commit message- geo-rep : fix coverity issues in glusterd-geo-rep.c This patch fixes RESOURCE_LEAK at line number 1344, 2088, 4819, 1347, 2092, 1608, 1612, 2284, 3837. It also fixes FORWARD_NULL at line number 2955. CID : 1175012, 1175014, 1210989, 1223042, 1223043, 1382381, 1382429, 1389120, 1389474, 1390452, 1356512. Change-Id: I7de239944eb61073d208ecf3899999a1ea0c8e43 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21057 committed in master by "Amar Tumballi" <amarts> with a commit message- IO cache : fix coverity issue in page.c This patch fixes CID 1382439 and 1382412. Change-Id: I8696623c168ba76ae2ecac7c9582b4e50437bc53 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21074 (glusterd : fix some coverity issues in glusterd-store.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21026 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: Fix Buffer size issues This patch fixes buffer size issue 1138522. Change-Id: Ia12fc8f34f75704f8ed3efae2022c4fd67a8c76c updates: bz#789278 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/21077 (glusterd: Fix coverity issue) posted (#1) for review on master by Sanju Rakonde COMMIT: https://review.gluster.org/21074 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd : fix some coverity issues in glusterd-store.c This patch fixes CID 1382346, 1274190 and 1382403. Change-Id: I1968e686587719e74bd70fa1542c20bccc04a7f9 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21044 committed in master by "Atin Mukherjee" <amukherj> with a commit message- cli : fix coverity issue in cli-cmd-parser.c This patch fixes 1175017 and 1382401. This patch fixes resource leak by validating brick_count is valid or not. If brick_count is not valid we are coming out in "cli_cmd_bricks_parse" without allocating memory to "brick_str" which is eventually pointed by bricks. Change-Id: I8ed0f29495379ec49484c5c4069865db3653506f updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21082 (dht-helper.c, glusterd-store.c: fix 2 (unrelated) coverity issues) posted (#1) for review on master by Yaniv Kaul REVIEW: https://review.gluster.org/21106 (storage/posix: Fix coverity issue - Unchecked return value) posted (#1) for review on master by Ashish Pandey REVIEW: https://review.gluster.org/21125 (glusterd: Fix unused value coverity fix) posted (#1) for review on master by Sanju Rakonde COMMIT: https://review.gluster.org/21125 committed in master by "Sanju Rakonde" <srakonde> with a commit message- glusterd: Fix unused value coverity fix Commit 09198e203e has introduced a new coverity with ID 1395635. keylen variable is assigned to some value but stored value is overwritten before it is used. This patch addresses the issue. updates: bz#789278 Change-Id: Ice290dcb9d703cd2131b0f0803436660e670e10a Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/21138 (mgmt/glusterd : Fix coverity issue) posted (#1) for review on master by Ashish Pandey COMMIT: https://review.gluster.org/21138 committed in master by "Atin Mukherjee" <amukherj> with a commit message- mgmt/glusterd : Fix coverity issue CID: 727146, 727066 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85393035&defectInstanceId=26034751&mergedDefectId=727146 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85392913&defectInstanceId=26034571&mergedDefectId=727066 updates: bz#789278 Change-Id: Ieaef33829ec88e68690dabce4ea21d2e61dad9f6 Signed-off-by: Ashish Pandey <aspandey> COMMIT: https://review.gluster.org/21106 committed in master by "Amar Tumballi" <amarts> with a commit message- storage/posix: Fix coverity issue - Unchecked return value Fixes CID: 1388886 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85287446&defectInstanceId=25997291&mergedDefectId=1388886 Change-Id: Ic4e558bba7e15d213c07bc31affb2e175ace5502 updates: bz#789278 Signed-off-by: Ashish Pandey <aspandey> REVIEW: https://review.gluster.org/21149 (snpashot : fix coverity issue in glusterd-snapshot.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21153 (glusterd : fix coverity issue in glusterd-store.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21161 (glusterfsd/mgmt : Check for NULL after creating frame) posted (#1) for review on master by Ashish Pandey COMMIT: https://review.gluster.org/21153 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd : fix coverity issue in glusterd-store.c This patch fixes CID 1124356: Unchecked return value (CHECKED_RETURN) updates: bz#789278 Change-Id: I81f4637f19b81f820a2deb70cc7f84b79fe70236 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21196 (geo-rep : fix coverity issues in glusterd-geo-rep.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21208 (storage/posix: Check if fd->inode is NULL before using it) posted (#1) for review on master by Ashish Pandey COMMIT: https://review.gluster.org/21196 committed in master by "Atin Mukherjee" <amukherj> with a commit message- geo-rep : fix coverity issues in glusterd-geo-rep.c This patch fixes CID 1210979, 1214614, 1292650, 1357874, 1382404. 1. overflowed or a truncated value : call to sys_read has been reduced to 'sizeof(buf) -1' and after operation buf is properly terminated. 2. tainted_data_argument : truncation due to cast operation on operand : resulted form call to strtol: chaged data type from pid_t to long. 3. tainted_data_argument : call to fgets is reduced by 2 to make space for the '\n' and '\0'. updates: bz#789278 Change-Id: Ib883501205c85007771213071c8e182286eb0bc0 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21231 (dht: Coverity fixes) posted (#2) for review on master by Susant Palai REVIEW: https://review.gluster.org/21234 (glusterd: fix coverity issues in glusterd-locks.c) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21236 (glusterd: fix coverity issues) posted (#1) for review on master by Sanju Rakonde COMMIT: https://review.gluster.org/21208 committed in master by "Amar Tumballi" <amarts> with a commit message- storage/posix: Check if fd->inode is NULL before using it CID: 1395473, 1395472 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85588219&defectInstanceId=26115956&mergedDefectId=1395472 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=85588219&defectInstanceId=26115961&mergedDefectId=1395473 Change-Id: I2c3cc350e0ac156616df6f568ba28dbfa68064bf updates: bz#789278 Signed-off-by: Ashish Pandey <aspandey> REVIEW: https://review.gluster.org/21239 (block : fix coverity in bd.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21239 committed in master by "Amar Tumballi" <amarts> with a commit message- block : fix coverity in bd.c This patch fixes CID 1288097, 1128921, and 1128918 all of type RESOURCE_LEAK. Change-Id: If39be19c6310eab9880de6f0bebb4f38604a40b2 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21161 committed in master by "Amar Tumballi" <amarts> with a commit message- glusterfsd/mgmt : Check for NULL after creating frame CID: 1382390 https://scan6.coverity.com/reports.htm#v42607/p10714fileInstanceId=85472585&defectInstanceId=26074725&mergedDefectId=1382390 Change-Id: Iade073a5e72f29ad5e8f372955869bc287eb9793 updates: bz#789278 Signed-off-by: Ashish Pandey <aspandey> REVIEW: https://review.gluster.org/21241 (glusterd: fix resource leak coverity issues) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21244 (glusterd: fix coverity issues) posted (#1) for review on master by Sanju Rakonde COMMIT: https://review.gluster.org/21234 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: fix coverity issues in glusterd-locks.c This patch addresses CID 1395254, CID 1382436. We are allocating memory to mgmt_lock_timer and key_dup. while doing GF_VALIDATE_OR_GOTO for mgmt_lock_timer_xl or mgmt_lock_timer_ctx, if it is null going to out without freeing the memory. This patch will fix the issues. updates: bz#789278 Change-Id: Ic6bfb2052982b16373f90cbbc53d2b2da052c01f Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/21241 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: fix resource leak coverity issues This patch addresses CID 1288098,1370948 and 1382454 key_fixed is allocated with memory but missed to free it. updates: bz#789278 Change-Id: Iea805c668ba89759313f9e21b328757e570be97b Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/21231 committed in master by "Amar Tumballi" <amarts> with a commit message- dht: Coverity fixes CID: 1274236 Issue: Logically dead code (op_errno will never be -1) CID: 1351652 Issue: Dereference after null check. (local->fd is dereferenced anyway and it should not be NULL ever for dht_readdirp_cbk.) Change-Id: Ied9c5f5b72536be1ca944237165acdc62b792e58 updates: bz#789278 Signed-off-by: Susant Palai <spalai> REVIEW: https://review.gluster.org/21267 (features/marker: Avoid passing structures as parameters to functions) posted (#1) for review on master by Vijay Bellur COMMIT: https://review.gluster.org/21244 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: fix coverity issues This patch addreeses CID 1124812, 11248123, 1124833, and 1351706 1. We have a null check after GF_ASSERT. GF_ASSERT does a null check and fails if it is null. So removing the redundant null checks. 2. Added a log message to avoid unused value coverity issue Change-Id: Ib0d6dad8f40474afc8e5e60a531d37247cc8a081 updates: bz#789278 Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/21267 committed in master by "Amar Tumballi" <amarts> with a commit message- features/marker: Avoid passing structures as parameters to functions Fixes CIDs: 1388779,1390242,1390057 The patch does the following: 1. Changes the prototype of mq_inspect_file_xattr() and mq_xattr_state() to have a parameter of struct iatt * instead of struct iatt. 2. Remove unneeded struct iatt parameter from mq_inspect_directory_xattr() Change-Id: I1f6eabda042f0fe56d8c9bca010302f5e518dbe4 updates: bz#789278 Signed-off-by: Vijay Bellur <vbellur> COMMIT: https://review.gluster.org/20864 committed in master by "Amar Tumballi" <amarts> with a commit message- nfs : fix coverity issues Fixes 1388608 and 1274073. updates: bz#789278 Change-Id: Ibe2b948ae3b02feb938caffe81b2e484b4c7b221 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21279 (glusterd : fix coverity issues glusterd-store.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21280 (index : fix coverity issues in index.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21283 (libglusterfs : fix coverity issue in store.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21283 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs : fix coverity issue in store.c This patch fixes CID 1395102 and 1395103. Change-Id: Ia6093dc6a04dce3f523e015cf1d6d4c6bfccc1f6 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21298 (gfapi: mixing enum types coverity fixes) posted (#1) for review on master by Bhumika Goyal COMMIT: https://review.gluster.org/21236 committed in master by "Atin Mukherjee" <amukherj> with a commit message- glusterd: fix coverity issues This patch fixes CID 1274175, 1175018. 1274175: Buffer size warning 1175018: Resource leak Change-Id: Id18960c249447b8dae35de3ad92bc570e62ddb09 updates: bz#789278 Signed-off-by: Sanju Rakonde <srakonde> COMMIT: https://review.gluster.org/21280 committed in master by "Amar Tumballi" <amarts> with a commit message- index : fix coverity issues in index.c This patch fixes CID 1356508 and 1356577. Change-Id: I09bc5398fbf6ee49fc066b42aaedf1170df39df8 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21334 (dht: coverity fixes) posted (#1) for review on master by Susant Palai REVIEW: https://review.gluster.org/21335 (libglusterfs: coverity fix) posted (#1) for review on master by Susant Palai REVIEW: https://review.gluster.org/21345 (cloudsync: coverity fix) posted (#1) for review on master by Susant Palai REVIEW: https://review.gluster.org/21346 (cli : coverity fix in cli-rl.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21349 (libglusterfs : fix coverity issue in stack.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21350 (changetimerecorder : fix coverity issue) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21335 (libglusterfs: coverity fix) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21345 (cloudsync: coverity fix) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21349 (libglusterfs : fix coverity issue in stack.c) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21334 (dht: coverity fixes) posted (#2) for review on master by N Balachandran REVIEW: https://review.gluster.org/21346 (cli : coverity fix in cli-rl.c) posted (#2) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/21358 (cli: Resource leak coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21363 (cloudsync: coverity fix) posted (#1) for review on master by Susant Palai COMMIT: https://review.gluster.org/21350 committed in master by "Amar Tumballi" <amarts> with a commit message- changetimerecorder : fix coverity issue This patch fixes CID : 1124725 Issue : Resource leak updates: bz#789278 Change-Id: I2afe65875fa393fd2d2f90b6f7cf7f6782dabf89 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21358 committed in master by "Atin Mukherjee" <amukherj> with a commit message- cli: Resource leak coverity fix This patch fixes CID 1175017. Change-Id: I4968c35489aeb5bfa0461b2edf2a0d73b7f03c14 updates: bz#789278 Signed-off-by: Sanju Rakonde <srakonde> REVIEW: https://review.gluster.org/21367 (rpc: coverity fixes) posted (#1) for review on master by Milind Changire COMMIT: https://review.gluster.org/21367 committed in master by "Raghavendra G" <rgowdapp> with a commit message- rpc: coverity fixes CID: [1] 1394646 Unchecked return value from library CID: [2] 1394633 Unused value CID: 1382443 Sleeping while holding a lock [This is intentional] [1] https://scan6.coverity.com/reports.htm#v40014/p10714/fileInstanceId=86159112&defectInstanceId=26360786&mergedDefectId=1394646 [2] https://scan6.coverity.com/reports.htm#v40014/p10714/fileInstanceId=86159365&defectInstanceId=26360919&mergedDefectId=1394633 Change-Id: I03086f7a9672c9f50a2bc44cdbce0006c887357b updates: bz#789278 Signed-off-by: Milind Changire <mchangir> REVIEW: https://review.gluster.org/21374 (locks : fix coverity issue) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21363 committed in master by "Amar Tumballi" <amarts> with a commit message- cloudsync: coverity fix CID: 1394649 1394657 Issue: Explicit null dereferenced Change-Id: Ic1040ffa5548e1ecd49cfdc9a8716be445cbdf0f Updates: bz#789278 Signed-off-by: Susant Palai <spalai> COMMIT: https://review.gluster.org/21374 committed in master by "Amar Tumballi" <amarts> with a commit message- locks : fix coverity issue This patch fixes CID 1356544 and 1356539. Both are of type NULL_RETURNS. Change-Id: I2ef7c3ff9929c4d85b79fff00e835ebee3ff3ce0 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21382 (cluster/dht : Fix coverity issue) posted (#1) for review on master by Ashish Pandey COMMIT: https://review.gluster.org/21382 committed in master by "Amar Tumballi" <amarts> with a commit message- cluster/dht : Fix coverity issue To check if the gfid is null or not we should use function gf_uuid_is_null CID: 1382364 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=86243257&defectInstanceId=26374360&mergedDefectId=1382364 Change-Id: I81944b823c9ee6e6dcc9695f64f7e5966e0d7030 updates: bz#789278 Signed-off-by: Ashish Pandey <aspandey> REVIEW: https://review.gluster.org/21389 (features/locks: Fix Coverity issues) posted (#1) for review on master by Ashish Pandey REVIEW: https://review.gluster.org/21390 (libglusterfs : fix newly introduced coveity defect) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21392 (mount : fix high sev coverity issues in mount3.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21394 (snapshot : fix high sev coverity on snapview-server.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21394 committed in master by "Amar Tumballi" <amarts> with a commit message- snapshot : fix high sev coverity on snapview-server.c This patch fixes CID 1325525 (double free). updates: bz#789278 Change-Id: I26a5f428dde83dd7708815f06830decf4068b94c Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21389 committed in master by "Amar Tumballi" <amarts> with a commit message- features/locks: Fix Coverity issues CID: 1395812 Explicit null dereferenced 1356542 Dereference null return value https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=86261835&defectInstanceId=26407100&mergedDefectId=1395812 https://scan6.coverity.com/reports.htm#v42607/p10714/fileInstanceId=86261835&defectInstanceId=26407215&mergedDefectId=1356542 Change-Id: I2c20972a8080fa7a70b88eab0688b9cf734bbf24 updates: bz#789278 Signed-off-by: Ashish Pandey <aspandey> COMMIT: https://review.gluster.org/21390 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs : fix newly introduced coverity defect CID: 1396060 updates: bz#789278 Change-Id: Ia25aa9a4ca7505e747aa92bb3ae81415da7d19d1 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21402 (libglusterfs: fix sys_socket coverity issue) posted (#1) for review on master by Milind Changire REVIEW: https://review.gluster.org/21422 (coverity: ignore tainted access reported in gf_free) posted (#1) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/21423 (glusterfsd: Fix coverity issues around unused values) posted (#1) for review on master by Shyamsundar Ranganathan COMMIT: https://review.gluster.org/21392 committed in master by "Amar Tumballi" <amarts> with a commit message- mount : fix high sev coverity issues in mount3.c This patch fixes CID 1395067, 1388767 and 1395068. updates: bz#789278 Change-Id: Ie92252281bf559dd29fab462e121445ff4d3b865 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21402 committed in master by "Amar Tumballi" <amarts> with a commit message- libglusterfs: fix sys_socket coverity issue CID 1396081: Control flow issues (UNREACHABLE) Change-Id: Ifad303853224cb9abc91c1083bb1529f4c13b1d3 updates: bz#789278 Signed-off-by: Milind Changire <mchangir> REVIEW: https://review.gluster.org/21428 (shard : fix coverity issue in shard.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21423 committed in master by "Amar Tumballi" <amarts> with a commit message- glusterfsd: Fix coverity issues around unused values This patch fixes, CID: 1274064, 1274232 The fix is to not add into the return dict the throughput and time values on error computing the same. The pattern applied is the same as when an error occurs during adding either the throughput or the time value to the dict. Change-Id: I33e21e75efbc691f18b818934ef3bf70dd075097 Updates: bz#789278 Signed-off-by: ShyamsundarR <srangana> COMMIT: https://review.gluster.org/21422 committed in master by "Amar Tumballi" <amarts> with a commit message- coverity: ignore tainted access reported in gf_free Coverity reports tainted pointer access in _gf_free if the pointer passed in was used by any IO related function by the caller. The taint within gf_free is a false positive, as the tainted region is from the passed in pointer till its allocated lenght, and not for contents before the pointer (i.e the GF_MEM_HEADER_SIZE bytes before the passed in pointer), as that is exclusively handled by the gf_alloc family of functions. CID: 1228602, 1292646, 1292647, 1292648, 1292649, 1383192, 1383195, 1389691 Should additionally fix, CID: 1292650, 1292651, 1357874, 1382373, 1382404, 1382407 Change-Id: I48c5a4028e7b0224c432bbc30f8c29408c2a466b Updates: bz#789278 Signed-off-by: ShyamsundarR <srangana> REVIEW: https://review.gluster.org/21429 (trash : fix high sev coverity issue in trash.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21431 (nfs : fix coverity issue in nfs3.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21429 committed in master by "Amar Tumballi" <amarts> with a commit message- trash : fix high sev coverity issue in trash.c This patch fixes CID 1288790: RESOURCE_LEAK. updates: bz#789278 Change-Id: I34bb410f1d3027e2d4c21044e87e319360344e04 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21431 committed in master by "Amar Tumballi" <amarts> with a commit message- nfs : fix coverity issue in nfs3.c This patch fixes CID 1274073. updates: bz#789278 Change-Id: I34146bfdfe19bae4592062e710a89ab07b2c5c07 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21434 (ctr: fix coverity issue in changetimerecorder.c) posted (#1) for review on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/21435 (protocol/server: added check for positve value in server-handshake.c) posted (#1) for review on master by REVIEW: https://review.gluster.org/21438 (shard : fix newly introduced coverity) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21439 (socket : fix newly introduced coverity in socket.c) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21438 committed in master by "Krutika Dhananjay" <kdhananj> with a commit message- shard : fix newly introduced coverity This patch fixes CID: 1396177: NULL dereference. updates: bz#789278 Change-Id: Ic5d302a5e32d375acf8adc412763ab94e6dabc3d Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21434 committed in master by "Sunny Kumar" <sunkumar> with a commit message- ctr: fix coverity issue in changetimerecorder.c This patch fixes CID: 1396179: Read from pointer after free 1396178: Use after free Change-Id: I47a2e4aa257e0c4dbdf2e1fd2e0748902764463f fixes: bz#789278 Signed-off-by: Mohit Agrawal <moagrawal> REVIEW: https://review.gluster.org/21445 (performance/write-behind: Fix NULL dereference issue) posted (#1) for review on master by Varsha Rao REVIEW: https://review.gluster.org/20865 (rdma: coverity fixes) posted (#4) for review on master by Bhumika Goyal COMMIT: https://review.gluster.org/20865 committed in master by "Amar Tumballi" <amarts> with a commit message- rdma: coverity fixes Fixes CID: 1382442 1382415 1382379 1382355 Change-Id: Ia712e37cb5a6db452d3178386394f87f83b85d38 updates: bz#789278 Signed-off-by: Bhumika Goyal <bgoyal> COMMIT: https://review.gluster.org/21435 committed in master by "Amar Tumballi" <amarts> with a commit message- protocol/server: added check for positve value in server-handshake.c This patch fixes CID 1124651 Change-Id: I6f33954f08cfdd7cb4236f9a81ec7980f81d19e7 updates: bz#789278 Signed-off-by: Arjun <arjsharm> COMMIT: https://review.gluster.org/21445 committed in master by "Amar Tumballi" <amarts> with a commit message- performance/write-behind: Fix NULL dereference issue This patches fixes the following coverity issues: CID: 1396101, 1396102 - Dereference null return value. Change-Id: I7ec783a61c06a1378863e974ff6e0baae418aec2 updates: bz#789278 Signed-off-by: Varsha Rao <varao> COMMIT: https://review.gluster.org/21037 committed in master by "Amar Tumballi" <amarts> with a commit message- xlators: some high severity coverity fixes Fixes: 124759 1288787 Change-Id: Ib8999242fc3ea5f4ea80246659899d2d4f06c506 updates: bz#789278 Signed-off-by: Bhumika Goyal <bgoyal> REVIEW: https://review.gluster.org/21455 (src/glusterd-snapshot-utils.c: dereferencing the snap_vol before freeing it.) posted (#1) for review on master by COMMIT: https://review.gluster.org/21455 committed in master by "Amar Tumballi" <amarts> with a commit message- src/glusterd-snapshot-utils.c: dereferencing the snap_vol before freeing it The patch fixes CID: 1325520 Change-Id: Ic7d3fac6adabe96d1d44f13b57d6dc67da0476d1 updates: bz#789278 Signed-off-by: Arjun <arjsharm> REVIEW: https://review.gluster.org/21476 (posix : fix coverity issues in posix-inode-fd-ops.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21479 (geo-rep : fix high sev coverity isuue) posted (#1) for review on master by Sunny Kumar COMMIT: https://review.gluster.org/21428 committed in master by "Krutika Dhananjay" <kdhananj> with a commit message- shard : fix coverity issue in shard.c This patch fixes CID: 1394664 : CHECKED_RETURN 1356534 : Macro compares unsigned to 0 (NO_EFFECT) 1356532 : Macro compares unsigned to 0 (NO_EFFECT) updates: bz#789278 Change-Id: I04d64fd8c007627611710dc56109b76eeb59333a Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21479 committed in master by "Amar Tumballi" <amarts> with a commit message- geo-rep : fix high sev coverity isuue This patch fixes CID: 1382374: USE_AFTER_FREE. Change-Id: If408f52ee291312fb83095126ebd6bb79ae95e26 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> COMMIT: https://review.gluster.org/21476 committed in master by "Amar Tumballi" <amarts> with a commit message- posix : fix coverity issues in posix-inode-fd-ops.c This patch fixes CID: 1356526 and 1382369 : Argument cannot be negative Change-Id: I1aab5be2d217479db9f67a26b62854a0b38c1747 updates: bz#789278 Signed-off-by: Sunny Kumar <sunkumar> REVIEW: https://review.gluster.org/21504 (posix: Fix coverity issue) posted (#1) for review on master by Varsha Rao REVIEW: https://review.gluster.org/21504 (posix: Fix coverity issue) posted (#1) for review on master by Varsha Rao REVIEW: https://review.gluster.org/21515 (posix : fix coverity issues in posix-entry-ops.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21504 (posix: Fix coverity issue) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21279 (glusterd : fix high coverity issues glusterd-store.c) posted (#5) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/21515 (posix : fix coverity issues in posix-entry-ops.c) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21540 (glusterd: coverity fixes) posted (#1) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/21540 (glusterd: coverity fixes) posted (#3) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/21544 (glusterd : fix high sev coverity issue) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21544 (glusterd : fix high sev coverity issue) posted (#2) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/21579 (features/locks:Use pthread_mutex_unlock() instead of pthread_mutex_lock()) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/21582 (features/changelog: Avoid a potential null dereference) posted (#1) for review on master by Vijay Bellur REVIEW: https://review.gluster.org/21584 (coverity: ignore tainted access reported in gf_free) posted (#1) for review on master by Shyamsundar Ranganathan REVIEW: https://review.gluster.org/21579 (features/locks:Use pthread_mutex_unlock() instead of pthread_mutex_lock()) posted (#2) for review on master by Krutika Dhananjay REVIEW: https://review.gluster.org/21593 (feature/shard: Fix coverity issue - Use after free) posted (#1) for review on master by Susant Palai REVIEW: https://review.gluster.org/21584 (coverity: ignore tainted access reported in gf_free) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21595 (quiesce : fix coverity issue) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21596 (features/ctime: Fix Coverity issue) posted (#1) for review on master by Susant Palai REVIEW: https://review.gluster.org/21582 (features/changelog: Avoid a potential null dereference) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21595 (quiesce : fix coverity issue) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21596 (features/ctime: Fix Coverity issue) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21639 (posix: Fix null pointer dererfence) posted (#1) for review on master by Susant Palai REVIEW: https://review.gluster.org/21593 (feature/shard: Fix coverity issue - Use after free) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21639 (posix: Fix null pointer dererfence) posted (#4) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21649 (dht: fix buffer overflow) posted (#1) for review on master by Susant Palai REVIEW: https://review.gluster.org/21042 (cli : fix coverity issue in cli-xml-output.c) posted (#4) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/21684 (protocol/client: unchecked return value) posted (#1) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/21684 (protocol/client: unchecked return value) posted (#4) for review on master by Shwetha K Acharya REVIEW: https://review.gluster.org/21649 (dht: fix buffer overflow) posted (#5) for review on master by Raghavendra G REVIEW: https://review.gluster.org/21705 (coverity: Fix coverity issues) posted (#1) for review on master by mohammed rafi kc REVIEW: https://review.gluster.org/21706 (meta/coverity: Fix coverity in meta xlator) posted (#1) for review on master by mohammed rafi kc REVIEW: https://review.gluster.org/21708 (glusterd : fix high sev coverity issue) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21713 (glusterfsd: Fix coverity issue) posted (#1) for review on master by Iraj Jamali REVIEW: https://review.gluster.org/21706 (meta/coverity: Fix coverity in meta xlator) posted (#4) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21705 (coverity: Fix coverity issues) posted (#5) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21708 (glusterd : fix high sev coverity issue) posted (#2) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/20738 (afr: Resource leak coverity fixes) posted (#6) for review on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/21713 (glusterfsd: Fix coverity issue) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21884 (all: handle USE_AFTER_FREE warnings) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21885 (all: handle string-overflow warnings of coverity) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21884 (all: handle USE_AFTER_FREE warnings) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21885 (all: handle string-overflow warnings of coverity) posted (#4) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21921 (meta : fix coverity issue) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21921 (meta : fix coverity issue) posted (#4) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21934 (glusterd: coverity fixes) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21935 (rpc-transport/rdma: Fix coverity issue) posted (#1) for review on master by Rinku Kothiya REVIEW: https://review.gluster.org/21939 (posix: buffer_size_warning coverity fix) posted (#1) for review on master by Harpreet Kaur Lalwani REVIEW: https://review.gluster.org/21934 (glusterd: coverity fixes) posted (#3) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/21947 (rpc : fix coverity in rpc/rpc-lib/src/rpcsvc.c) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21949 (rpc/rpc-lib: fix coverity issue) posted (#1) for review on master by Sheetal Pamecha REVIEW: https://review.gluster.org/21950 (libgfapi : fix coverity issue) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/21947 (rpc : fix coverity in rpc/rpc-lib/src/rpcsvc.c) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21949 (rpc/rpc-lib: fix coverity issue) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21939 (posix: buffer_size_warning coverity fix) posted (#3) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21950 (libgfapi : fix coverity issue) posted (#2) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/21969 (gfapi: convert lease_type enums back/forth with switch/case) posted (#1) for review on master by Niels de Vos REVIEW: https://review.gluster.org/21995 (posix: fix coverity issue) posted (#1) for review on master by Iraj Jamali REVIEW: https://review.gluster.org/21995 (posix: fix coverity issue) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22382 (fuse : fix high sev coverity issue) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/22384 (server.c: fix Coverity CID 1399758) posted (#2) for review on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/22384 (server.c: fix Coverity CID 1399758) merged (#3) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22382 (fuse : fix high sev coverity issue) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22452 (GlusterD1: Resolves the issue of referencing memory after it has been freed) posted (#1) for review on master by Rishubh Jain REVIEW: https://review.gluster.org/22452 (GlusterD: Resolves the issue of referencing memory after it has been freed) merged (#12) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22525 (GlusterD: Avoiding explicit null pointer dereference.) posted (#1) for review on master by Rishubh Jain REVIEW: https://review.gluster.org/22514 (shd/mux: Fix coverity issues introduced by shd mux patch) merged (#7) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22585 (features/locks: fix coverity issues) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22585 (features/locks: fix coverity issues) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22530 (GlusterD:Checking for null value to void explicit dereferencing of null pointer) merged (#4) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22610 (afr-transaction.c : fix Coverity CID 1398627) posted (#1) for review on master by Rinku Kothiya REVIEW: https://review.gluster.org/22615 (glusterd: coverity fixes) posted (#1) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/22619 (glusterd: put coverity annotations) posted (#1) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/22615 (glusterd: coverity fixes) merged (#3) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22634 (glusterd: coverity fixes) posted (#1) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/22634 (glusterd: coverity fixes) merged (#2) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22643 (cloudsync/plugin: coverity fixes) posted (#1) for review on master by Susant Palai REVIEW: https://review.gluster.org/22643 (cloudsync/plugin: coverity fixes) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22619 (glusterd: Fix coverity defects & put coverity annotations) merged (#9) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22656 (glusterd: prevent use-after-free in glusterd_op_ac_send_brick_op()) posted (#1) for review on master by Niels de Vos REVIEW: https://review.gluster.org/22661 (glusterd: coverity fix) posted (#1) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/22656 (glusterd: prevent use-after-free in glusterd_op_ac_send_brick_op()) merged (#2) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22661 (glusterd: coverity fix) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/22610 (afr : fix Coverity CID 1398627) merged (#7) on master by Pranith Kumar Karampuri REVIEW: https://review.gluster.org/22737 (glusterd: coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/22741 (across: coverity fixes) posted (#1) for review on master by Sheetal Pamecha REVIEW: https://review.gluster.org/22767 (Fix some \"Null pointer dereference\" coverity issues) posted (#1) for review on master by Xavi Hernandez REVIEW: https://review.gluster.org/22737 (glusterd: coverity fix) merged (#3) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22767 (Fix some \"Null pointer dereference\" coverity issues) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/22778 (glusterd: coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/22783 (io-cache: remove a unused iov_copy) posted (#1) for review on master by Amar Tumballi REVIEW: https://review.gluster.org/22778 (glusterd: coverity fix) merged (#2) on master by Xavi Hernandez REVIEW: https://review.gluster.org/22795 (geo-rep/gsyncd: name is not freed in one of the cases) posted (#1) for review on master by Sheetal Pamecha REVIEW: https://review.gluster.org/22741 (across: coverity fixes) merged (#12) on master by Amar Tumballi REVIEW: https://review.gluster.org/22801 (glusterd: coverity fix) posted (#1) for review on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/22809 (posix: coverity fix) posted (#1) for review on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/22801 (glusterd: coverity fix) merged (#4) on master by Atin Mukherjee REVIEW: https://review.gluster.org/22795 (geo-rep/gsyncd: name is not freed in one of the cases) merged (#6) on master by Amar Tumballi REVIEW: https://review.gluster.org/23234 (storage/posix) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23235 (cluster/afr) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23236 (storage/posix) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23237 (features/cloudsync) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23249 (features/utime - fixing a coverity issue) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23250 (api - fixing a coverity issue) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23251 (protocol/client - fixing a coverity issue) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23255 (api -fixing a coverity issue) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23259 (cluster/afr - Unused variables) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23260 (mount/fuse - Fixing a coverity issue) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23261 (storage/posix - Fixing a coverity issue) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23264 (libglusterfs - fixing a coverity issue) posted (#1) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23236 (storage/posix - Moved pointed validity check in order to avoid possible seg-fault) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23251 (protocol/client - fixing a coverity issue) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23260 (mount/fuse - Fixing a coverity issue) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23270 (geo-replication: fixing a coverity issue (resource leak)) posted (#1) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23264 (libglusterfs - fixing a coverity issue) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23255 (api: fixing a coverity issue) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23234 (storage/posix - fixing a coverity issue) merged (#11) on master by Amar Tumballi REVIEW: https://review.gluster.org/23237 (features/cloudsync - fix a coverity issue) merged (#5) on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23249 (features/utime - fixing a coverity issue) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23261 (storage/posix - Fixing a coverity issue) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23259 (cluster/afr - Unused variables) merged (#5) on master by Ravishankar N REVIEW: https://review.gluster.org/23295 (glusterd/ganesha: fixing resource leak in tear_down_cluster()) posted (#1) for review on master by jiffin tony Thottan REVIEW: https://review.gluster.org/23299 (glusterd: Unused value coverity fix) posted (#1) for review on master by Sanju Rakonde REVIEW: https://review.gluster.org/23299 (glusterd: Unused value coverity fix) merged (#3) on master by Sanju Rakonde REVIEW: https://review.gluster.org/23386 (glusterd, rpc, glusterfsd: fix coverity defects and put required annotations) posted (#1) for review on master by Atin Mukherjee REVIEW: https://review.gluster.org/23386 (glusterd, rpc, glusterfsd: fix coverity defects and put required annotations) merged (#2) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23409 (Fixes CID 1274206.) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23414 (changes in CID-1398631 and CID-1398624) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23416 (fixes CID-1398624 and CID-1398631 Fixes: bz#789278 Change-Id: I19659d439f8d26956a32807dd0c8ec1257aa0475 Signed-off-by: yatip <ypadia>) posted (#2) for review on master by None REVIEW: https://review.gluster.org/23424 (libgfapi : Dereference after null check - coverity fix) posted (#1) for review on master by None REVIEW: https://review.gluster.org/23426 (xlators: fixes logically dead code.) posted (#1) for review on master by Yati Padia REVIEW: https://review.gluster.org/23429 (AFR xlator : UNUSED VALUE - coverity fix) posted (#1) for review on master by Purna Pavan Chandra Aekkaladevi REVIEW: https://review.gluster.org/23433 (posix/ctime: Fix coverity issue) posted (#1) for review on master by Kotresh HR REVIEW: https://review.gluster.org/23433 (posix/ctime: Fix coverity issue) merged (#2) on master by Sunny Kumar REVIEW: https://review.gluster.org/23295 (glusterd/ganesha: fixing resource leak in tear_down_cluster()) merged (#5) on master by Amar Tumballi REVIEW: https://review.gluster.org/23492 (glusterd/ganesha: use after free in tear_down_cluster()) posted (#1) for review on master by jiffin tony Thottan REVIEW: https://review.gluster.org/23424 (libgfapi : Dereference after null check - coverity fix) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/23426 (xlators: fixes logically dead code.) merged (#7) on master by Amar Tumballi REVIEW: https://review.gluster.org/23515 (POSIX/xlators: Unused value coverity issue) posted (#1) for review on master by Yati Padia REVIEW: https://review.gluster.org/23409 (Posix: UNUSED VALUE coverity fix) merged (#5) on master by Sunny Kumar REVIEW: https://review.gluster.org/23515 (POSIX/xlators: Unused and unchecked value coverity issue) merged (#5) on master by Sunny Kumar REVIEW: https://review.gluster.org/23414 (glusterfsd: fix unused value coverity issues) merged (#10) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23630 (glusterd/ganesha: fix Coverity CID 1405785) posted (#1) for review on master by Xie Changlong REVIEW: https://review.gluster.org/23630 (glusterd/ganesha: fix Coverity CID 1405785) merged (#2) on master by Atin Mukherjee REVIEW: https://review.gluster.org/23749 (cluster/afr - coverity issue fix) posted (#1) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23749 (cluster/afr - coverity issue fix) merged (#3) on master by Ravishankar N REVIEW: https://review.gluster.org/23795 (glusterd-store: fix Coverity CID 1407767) posted (#1) for review on master by Xie Changlong REVIEW: https://review.gluster.org/23798 (cloudsynx - fixing a coverity issue) posted (#1) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23795 (glusterd-store: fix Coverity CID 1407767) merged (#2) on master by Sunny Kumar REVIEW: https://review.gluster.org/23798 (cloudsync - fixing a coverity issue) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/23962 (cli - fixing a coverity issue) posted (#1) for review on master by Barak Sason Rofman REVIEW: https://review.gluster.org/23963 (lock: fix Coverity CID 1412107) posted (#1) for review on master by Xie Changlong REVIEW: https://review.gluster.org/23964 (nfs/drc: avoid drc memory leak) posted (#1) for review on master by Xie Changlong REVIEW: https://review.gluster.org/23963 (lock: fix Coverity CID 1412107) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/23962 (cli - fixing a coverity issue) merged (#2) on master by MOHIT AGRAWAL REVIEW: https://review.gluster.org/24021 (glusterd: fix use after free) posted (#1) for review on master by Xie Changlong REVIEW: https://review.gluster.org/24039 (snapview: fix memory leak) posted (#1) for review on master by Xie Changlong REVIEW: https://review.gluster.org/24021 (glusterd: fix use after free) merged (#3) on master by Amar Tumballi REVIEW: https://review.gluster.org/24039 (snapview: fix memory leak) merged (#4) on master by Amar Tumballi REVIEW: https://review.gluster.org/24086 (libgfapi: fix resource leak) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/24087 (posix: avoid dereferencing null pointer) posted (#1) for review on master by Sunny Kumar REVIEW: https://review.gluster.org/24086 (libgfapi: fix resource leak) merged (#2) on master by Amar Tumballi REVIEW: https://review.gluster.org/24230 (Subject: Concurrent data access violation) posted (#1) for review on master by Nikhil Ladha REVIEW: https://review.gluster.org/24234 (locks xlator: concurrent data access) posted (#1) for review on master by Nikhil Ladha REVIEW: https://review.gluster.org/24237 (afr xlator: null pointer dereference) posted (#1) for review on master by Nikhil Ladha This bug is moved to https://github.com/gluster/glusterfs/issues/1060, and will be tracked there from now on. Visit GitHub issues URL for further details. /sunny |