Bug 789332 (perl-Git-Repository)

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated


==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[-]: MUST License file installed when any subpackage combination is installed.
[!]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[!]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/contyk/src/review/789332/Git-Repository-1.25.tar.gz :
  MD5SUM this package     : b0a9d52caa4c2d6ca4c7f173a7f07664
  MD5SUM upstream package : b0a9d52caa4c2d6ca4c7f173a7f07664
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[-]: SHOULD Spec use %global instead of %define.

Issues:
TODO: +BR perl(Carp)
TODO: +BR perl(Exporter)
TODO: +BR perl(File::Temp)
TODO: +BR perl(IO::Handle)
TODO: +BR perl(Test::Builder)
TODO: Use %{_bindir} in git file requirements instead of hardcoded /usr/bin
TIP: I'd include Changes and README in perl-Test-Git as well; although
those files will be always installed with the base package, I don't think
users will know they should look to the Git::Repository doc directory;
or maybe you could add a special NOTE file with "look over there" to
Test::Git doc?

No actual show stoppers.  Approving.

Generated by fedora-review 0.1.1
External plugins:

New Package SCM Request
=======================
Package Name: perl-Git-Repository
Short Description: Perl interface to Git repositories
Owners: iarnell
Branches: f15 f16 f17
InitialCC: perl-sig

Git done (by process-git-requests).

(In reply to comment #1)
> TODO: Use %{_bindir} in git file requirements instead of hardcoded /usr/bin

That's an interesting catch. With /usr move, it makes sense to avoid hardcoding paths, but technically, Git-Repository only needs git somewhere in $PATH. How about just {Build,}Requires: git?

> TIP: I'd include Changes and README in perl-Test-Git as well; although
> those files will be always installed with the base package, I don't think
> users will know they should look to the Git::Repository doc directory;
> or maybe you could add a special NOTE file with "look over there" to
> Test::Git doc?

Well perl-Test-Git isn't really for users - it's only sub-packaged to avoid runtime deps on perl(Test::Builder). I'd hope that anyone who really cares about it would already know it's part of Git-Repository - or be able to find it on search.cpan.org.
 
> No actual show stoppers.  Approving.

Thanks for the review.

perl-Git-Repository-1.25-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-Git-Repository-1.25-2.fc16

perl-Git-Repository-1.25-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Git-Repository-1.25-2.fc15

perl-Git-Repository-1.25-2.fc16 has been pushed to the Fedora 16 testing repository.

(In reply to comment #4)
> (In reply to comment #1)
> > TODO: Use %{_bindir} in git file requirements instead of hardcoded /usr/bin
> 
> That's an interesting catch. With /usr move, it makes sense to avoid hardcoding
> paths, but technically, Git-Repository only needs git somewhere in $PATH. How
> about just {Build,}Requires: git?

You'd run in other problems if the git maintainer decides to package the git binary in git-cli or something.  File-based dependency is somewhat safer (well, that's just my opinion).

perl-Git-Repository-1.25-2.fc15 has been pushed to the Fedora 15 stable repository.

perl-Git-Repository-1.25-2.fc16 has been pushed to the Fedora 16 stable repository.