| Summary: | Review Request: mingw-gstreamer-plugins-base - Cross compiled GStreamer media framework base plug-ins | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paweł Forysiuk <tuxator> |
| Component: | Package Review | Assignee: | Kalev Lember <kalevlember> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-mingw, kalevlember, notting, package-review |
| Target Milestone: | --- | Flags: | kalevlember:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | mingw-gstreamer-plugins-base-0.10.35-2.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-22 02:02:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Paweł Forysiuk
2012-02-12 20:41:55 UTC
Fedora review of mingw-gstreamer-plugins-base-0.10.35-1.fc16.src.rpm 2012-02-12
+ OK
! needs attention
rpmlint output:
$ rpmlint mingw32-gstreamer-plugins-base \
mingw32-gstreamer-plugins-base-debuginfo-0.10.35-1.fc17.noarch.rpm \
mingw-gstreamer-plugins-base-0.10.35-1.fc17.src.rpm
mingw32-gstreamer-plugins-base.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-gstreamer-plugins-base-0.10.35/COPYING
mingw32-gstreamer-plugins-base-debuginfo.noarch: E: description-line-too-long C This package provides debug information for package mingw32-gstreamer-plugins-base.
mingw32-gstreamer-plugins-base-debuginfo.noarch: E: debuginfo-without-sources
mingw-gstreamer-plugins-base.src:114: W: macro-in-comment %{mingw32_libdir}
mingw-gstreamer-plugins-base.src:114: W: macro-in-comment %{majorminor}
mingw-gstreamer-plugins-base.src:115: W: macro-in-comment %{mingw32_libdir}
mingw-gstreamer-plugins-base.src:115: W: macro-in-comment %{majorminor}
mingw-gstreamer-plugins-base.src:139: W: macro-in-comment %{_mingw32_libdir}
mingw-gstreamer-plugins-base.src:139: W: macro-in-comment %{majorminor}
mingw-gstreamer-plugins-base.src:8: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 8)
3 packages and 0 specfiles checked; 3 errors, 7 warnings.
Should be easy to get rid of the mixed-use-of-spaces-and-tabs warning, but the
rest is mostly just noise.
To reduce the macro-in-comment rpmlint spew, I think I'd personally just remove
the commented out lines in %files section (easy enough to add them back when
needed), but it's fine the way it currently is as well.
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
native Fedora package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
1d300983525f4f09030eb3ba47cb04b0 gst-plugins-base-0.10.35.tar.bz2
1d300983525f4f09030eb3ba47cb04b0 Download/gst-plugins-base-0.10.35.tar.bz2
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ The spec file handles locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
! Package owns all directories it creates
The package creates %{_mingw32_libdir}/gstreamer-%{majorminor}/ directory, but
doesn't own it. One way to fix it would be to add:
%dir %{_mingw32_libdir}/gstreamer-%{majorminor}
to %files.
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Not applicable to MinGW packages.
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane, except for the directory mentioned above
+ Filenames are valid UTF-8
Summary
-------
Please fix the %{_mingw32_libdir}/gstreamer-%{majorminor}/ directory ownership
issue and take a look if it's possible to get rid of some of the rpmlint
warnings.
Updated files here Spec URL: http://dl.dropbox.com/u/2448780/mingw-gstreamer-plugins-base.spec SRPM URL: http://dl.dropbox.com/u/2448780/mingw-gstreamer-plugins-base-0.10.35-2.fc16.src.rpm Looks good. APPROVED New Package SCM Request ======================= Package Name: mingw-gstreamer-plugins-base Short Description: Cross compiled GStreamer media framework base plug-ins Tools Owners: pfor kalev epienbro Branches: f16 f17 InitialCC: Git done (by process-git-requests). mingw-gstreamer-plugins-base-0.10.35-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/mingw-gstreamer-plugins-base-0.10.35-2.fc16 mingw-gstreamer-plugins-base-0.10.35-2.fc16 has been pushed to the Fedora 16 testing repository. mingw-gstreamer-plugins-base-0.10.35-2.fc16 has been pushed to the Fedora 16 stable repository. |