Bug 789919

Summary:	IP address with just 3 octets are accepted as valid addresses in --a-rec option.
Product:	Red Hat Enterprise Linux 6	Reporter:	Gowrishankar Rajaiyan <grajaiya>
Component:	ipa	Assignee:	Rob Crittenden <rcritten>
Status:	CLOSED ERRATA	QA Contact:	IDM QE LIST <seceng-idm-qe-list>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.3	CC:	jgalipea, mkosek
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ipa-2.2.0-3.el6	Doc Type:	Bug Fix
Doc Text:	No documentation needed.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-20 13:32:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Gowrishankar Rajaiyan 2012-02-13 09:44:00 UTC

Description of problem:

This was detected by Niru as part of IPA DNS Test Day.

As part of negative testing, providing non-integers for --a-rec option gives appropriate error message, however, providing data with just 3 octets doesn't give any error. 

Version-Release number of selected component (if applicable):
ipa-server-2.2.0-101.20120209T0933zgit52cf9d9.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
1. [root@skyfire ~]# ipa dnsrecord-add lab.eng.pnq.redhat.com bumblebee --a-rec=a.b.c.d
ipa: ERROR: invalid 'ip_address': invalid IP address format
[root@skyfire ~]#

2. [root@skyfire ~]# ipa dnsrecord-add lab.eng.pnq.redhat.com bumblebee --a-rec=10.65.211
  Record name: bumblebee
  A record: 10.65.211
[root@skyfire ~]#

  
Actual results:
IP address with just 3 octets is accepted.

Expected results:
Should error out stating "ipa: ERROR: invalid 'ip_address': invalid IP address format"

Additional info:

Comment 2 Dmitri Pal 2012-02-13 13:06:09 UTC

Upstream ticket:
https://fedorahosted.org/freeipa/ticket/2379

Comment 3 Martin Kosek 2012-02-29 10:07:22 UTC

Fixed upstream:
master: https://fedorahosted.org/freeipa/changeset/45e92a338fe23ee1daea324e30e03d32f147e8bf
ipa-2-2: https://fedorahosted.org/freeipa/changeset/a100b7bc124dee3f056e5290744d329275d51792

Comment 5 Gowrishankar Rajaiyan 2012-03-07 12:23:50 UTC

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: ipa-dns-156: 789919 :: IP address with just 3 octets are accepted as valid addresses in --a-rec option
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [07:12:40] ::  verifies https://bugzilla.redhat.com/show_bug.cgi?id=789919
:: [07:12:40] ::  Executing: ipa dnsrecord-add newzone arec --a-rec=1.1.1
ipa: ERROR: invalid 'ip_address': invalid IP address format
:: [07:12:41] ::  "ipa dnsrecord-add newzone arec --a-rec=1.1.1" failed as expected.
:: [   PASS   ] :: Error message as expected: ipa: ERROR: invalid 'ip_address': invalid IP address format
'980eb873-bcca-43dd-81a5-dc9e10d1a360'
ipa-dns-156 result: PASS
   metric: 0
   Log: /tmp/beakerlib-4785235/journal.txt
    Info: Searching AVC errors produced since 1331122359.71 (Wed Mar  7 07:12:39 2012)
     Searching logs...
     Info: No AVC messages found.
 Writing to /mnt/testarea/tmp.pyDrbk
:
   AvcLog: /mnt/testarea/tmp.pyDrbk

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

Verified: ipa-server-2.2.0-3.el6.x86_64

Comment 7 Martin Kosek 2012-04-24 11:36:00 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No documentation needed.

Comment 10 errata-xmlrpc 2012-06-20 13:32:12 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0819.html