as5 plugin: "Client JAR [file:/foo.jar] does not exist or is not readable (note, this JAR may not be required for some app server versions)." warnings should not be logged for AS/EAP versions that do not require the corresponding jar
If a version of JON did not require a particular JAR, a "Client JAR does not exist or is not readable (note, this JAR may not be required for some app server versions)" warning would be logged whenever a server was discovered, or rediscovered. This caused unnecessary information in the logs, and caused customers to be concerned about the errors due to the severity of the log level. The fix changes the WARN-level message to DEBUG level. While it is not possible to distinguish between non-existent and non-readable JARs, activating the DEBUG log level will identify the originally-reported behavior, and the issue can then be investigated further.
Here's an example of the superfluous warnings:
2012-02-13 11:27:10,269 WARN [ResourceDiscoveryComponent.invoker.daemon-1] (org.rhq.plugins.jbossas5.ApplicationServerDiscoveryComponent)- Client JAR [file:/home/ips/Applications/jboss-eap-5.1.2/jboss-as/lib/jboss-classpool.jar] does not exist or is not readable (note, this JAR may not be required for some app server versions).
2012-02-13 11:27:10,270 WARN [ResourceDiscoveryComponent.invoker.daemon-1] (org.rhq.plugins.jbossas5.ApplicationServerDiscoveryComponent)- Client JAR [file:/home/ips/Applications/jboss-eap-5.1.2/jboss-as/lib/jboss-classpool-scoped.jar] does not exist or is not readable (note, this JAR may not be required for some app server versions).
2012-02-13 11:27:10,272 WARN [ResourceDiscoveryComponent.invoker.daemon-1] (org.rhq.plugins.jbossas5.ApplicationServerDiscoveryComponent)- Client JAR [file:/home/ips/Applications/jboss-eap-5.1.2/jboss-as/common/lib/jboss-as-profileservice.jar] does not exist or is not readable (note, this JAR may not be required for some app server versions).
Several of them get logged every time an AS or EAP instance is discovered or re-discovered. Besides cluttering the log, they could falsely alarm users.
master commit bed4b9a72f3f6ec19939e82a9fd27e392dc85a9c
Author: Jay Shaughnessy <jshaughn>
Date: Wed Aug 20 10:48:59 2014 -0400
I changed the offensive WARN-level message to DEBUG level. It's not really
possible to distinguish between non-existent and non-readable, or to know
which versions require which JAR. If there is a failure then we can turn
on debug to see the message.
release/jon3.3.x commit 038e60bf5b05101680a5693a18d2f492c287230e
Author: Jay Shaughnessy <jshaughn>
Date: Wed Aug 20 10:57:23 2014 -0400
Cherry-Pick master bed4b9a72f3f6ec19939e82a9fd27e392dc85a9c