| Summary: | Review Request: libverto-jsonrpc - JSON-RPC support for libverto | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nathaniel McCallum <nathaniel> |
| Component: | Package Review | Assignee: | Stephen Gallagher <sgallagh> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, sgallagh |
| Target Milestone: | --- | Flags: | sgallagh:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-23 14:07:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Nathaniel McCallum
2012-02-13 16:59:40 UTC
libverto-jsonrpc.x86_64: E: explicit-lib-dependency libverto-module-base libverto-jsonrpc-devel.x86_64: W: no-documentation 3 packages and 1 specfiles checked; 1 errors, 1 warnings. See the documentation for libverto to explain the dependency on libverto-module-base. libverto-jsonrpc-devel depends on libverto-jsonrpc which contains the appropriate documentation. SRPM: http://npmccallum.fedorapeople.org/libverto-jsonrpc/libverto-jsonrpc-0.1.0-2.fc16.src.rpm SPEC: http://npmccallum.fedorapeople.org/libverto-jsonrpc/libverto-jsonrpc.spec * Mon Feb 13 2012 Nathaniel McCallum <nathaniel> - 0.1.0-2 - Remove libverto-module-base dependency After some further thought, this dependency properly belongs in the app that consumes libverto-jsonrpc. I'm acking this review with only one (non-mandatory) recommendation. Instead of %{_includedir}/* it would be a good idea to list the headers explicitly so in the future if you grow a new public header, it won't be included accidentally. (Or if you accidentally stop installing one in the right location, you'll know immediately).
New Package SCM Request ======================= Package Name: libverto-json Short Description: JSON-RPC support for libverto Owners: npmccallum Branches: f16 f17 master InitialCC: SCM request package name and BZ summary name don't match, please rectify. Thanks! New Package SCM Request ======================= Package Name: libverto-jsonrpc Short Description: JSON-RPC support for libverto Owners: npmccallum Branches: f16 f17 master InitialCC: Thanks for the catch! Git done (by process-git-requests). |