| Summary: | Review Request: python-mwlib - MediaWiki parser and utility library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ian Weller <ian> |
| Component: | Package Review | Assignee: | Toshio Ernie Kuratomi <a.badger> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | a.badger, notting, package-review |
| Target Milestone: | --- | Flags: | a.badger:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-qserve-0.2.7-1.fc17 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-28 10:42:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Ian Weller
2012-02-13 19:37:05 UTC
There's a few needswork items but I'll APPROVE this if you fix those when you import the package.
Good:
* Matches naming guidelines
* License is BSD in source and spec
* License is spelled out in full in the README.rst file which is included in
the package
* Spec file is legible
* Source matches upstream
* No locale files that need to be handled
* No bundled libraries found
* Package not relocatable
* Package owns all directories it creates and no more.
* Proper permissions for files
* Macros used consistently
* Code, not content
* No large documentation
* Nothing in %doc affects application at runtime
* Not an elf library
* Not a GUI application
* All filenames are valid utf-8
Needswork:
* package doesn't build in koji -- needs:
BuildRequires: python-setuptools
- Tested that the package builds with that change made
* Package needs Requires: python-setuptools since it uses import pkg_resources
in the code
Cosmetic:
* rpmlint just has warnings for no man pages:
python-mwlib.x86_64: W: no-manual-page-for-binary mw-post (and all the other
%{_bindir} scripts). These are warnings and if no man pages are easily
available, ignorable.
Potential future issues:
* The package installs a toplevel argv.py file/module. This seems to just be
used for the command line scripts for parsing the command line. Since this
has the potential to pollute the python package namespace with a somewhat
common name, suggest to upstream that they may want to restructure like
this::
mv argv.py mwlib/._argv.py
sed s/import argv/from mwlib import _argv as argv/
(In reply to comment #1) > Needswork: > > * package doesn't build in koji -- needs: > BuildRequires: python-setuptools > - Tested that the package builds with that change made > * Package needs Requires: python-setuptools since it uses import pkg_resources > in the code Fixed in the version below. > > > Cosmetic: > > * rpmlint just has warnings for no man pages: > python-mwlib.x86_64: W: no-manual-page-for-binary mw-post (and all the other > %{_bindir} scripts). These are warnings and if no man pages are easily > available, ignorable. They aren't easily available so I plan to ignore :) > Potential future issues: > > * The package installs a toplevel argv.py file/module. This seems to just be > used for the command line scripts for parsing the command line. Since this > has the potential to pollute the python package namespace with a somewhat > common name, suggest to upstream that they may want to restructure like > this:: > mv argv.py mwlib/._argv.py > sed s/import argv/from mwlib import _argv as argv/ /me sighs I'll file a ticket with them. * Mon Feb 13 2012 Ian Weller <iweller> - 0.13.3-3 - BuildRequires: python-setuptools Files in http://ianweller.fedorapeople.org/SRPMS/python-mwlib/0.13.3-3/ argv ticket filed with upstream: https://github.com/pediapress/mwlib/issues/8 APPROVED. Also, I didn't see this fixed in the last update: * Package needs Requires: python-setuptools since it uses import pkg_resources in the code You can just fix this after you import the package. New Package SCM Request ======================= Package Name: python-mwlib Short Description: MediaWiki parser and utility library Owners: ianweller Branches: f16 f17 InitialCC: This package has been deprecated and needs to be undeprecated. Done. Please take ownership, then submit a package change request for f16 and f17 branches. Oops. Package Change Request ====================== Package Name: python-mwlib New Branches: f16 f17 Owners: ianweller InitialCC: python-mwlib-0.13.3-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-mwlib-0.13.3-4.fc17 python-mwlib-0.13.3-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-mwlib-0.13.3-4.fc16 Package python-mwlib-0.13.3-4.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-mwlib-0.13.3-4.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-1698/python-mwlib-0.13.3-4.fc16 then log in and leave karma (feedback). python-qserve-0.2.7-1.fc17, python-mwlib-0.13.4-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-qserve-0.2.7-1.fc17,python-mwlib-0.13.4-1.fc17 python-qserve-0.2.7-1.fc17, python-mwlib-0.13.4-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |