Bug 790193

Summary: pulp-admin accepts any argument after end of options
Product: [Retired] Pulp Reporter: James Slagle <jslagle>
Component: z_otherAssignee: pulp-bugs
Status: CLOSED WORKSFORME QA Contact: Preethi Thomas <pthomas>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: mhrivnak, tsanders
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-27 14:14:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description James Slagle 2012-02-13 21:18:10 UTC
After any syntactically correct pulp-admin command, you can type any string you want and the command will still run.

We should have better input validation and throw up a help message instead in this case.  The reason being is that we don't know if the arbitrary string was meant to be another option, and now we've executed a command the user didn't intend.

Here's an example. I wanted to sync a repo in the foreground.  I typo'd "-F" as "0F":

# pulp-admin repo sync --id candlepin-x86_64 --limit 5 0F

The command still ran, but was sync'ing in the background.

This seems to apply to any command:

$ pulp-admin repo list monkies

will do a repo list.

Comment 1 Michael Hrivnak 2013-09-27 14:14:07 UTC
this seems to have been fixed at some point.