| Summary: | [ovirt] [RFE] domain integrity should be validated before moving domain to active status | ||
|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Haim <hateya> |
| Component: | ovirt-engine-core | Assignee: | lpeer <lpeer> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | abaron, acathrow, amureini, bazulay, hateya, iheim, mgoldboi, yeylon, ykaul |
| Target Milestone: | --- | Keywords: | FutureFeature |
| Target Release: | 3.3.4 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | storage | ||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-12 07:33:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Following conversation I had with Miki, we decided to consider this issue as an RFE, as it requires changes in API, eventually, we night need new verb, anyhow, backend should not consider connectStorageServer as an absolute indication for domain status. Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug. |
Description of problem: today, there are validation on domain integrity, and we only count connectStorageServer (which deals with iscsi and multi path session but not with the actual data), which affects the following case: - domain no longer exists, engine-core sends connectStorageServer with domain params, connectStorageServer returns True, and domain move to up, later on, domain monitoring thread sample domain, see's that its broken (there is not data, no vg), try to deactivate it and fails (different issue - but yet again, we shouldn't enter this flow at all). btw - connectStoragePool might protect such cases, but its only true when faulty domain is master domain .. I suggest to add a simple test that checks domain integrity, to prevent such cases. Thread-17::INFO::2012-02-13 23:00:16,414::logUtils::37::dispatcher::(wrapper) Run and protect: connectStorageServer(domType=3, spUUID='2319b7ff-09f6-488c-83c4-aa78139db3b4', co nList=[{'connection': '10.35.115.150', 'iqn': 'iqn.2008-05.com.xtremio:001b21b545c0', 'portal': '1', 'user': '', 'password': '******', 'id': 'e9f45f40-3698-406c-ae69-3c3de0ad8e 52', 'port': '3260'}, {'connection': '10.35.115.151', 'iqn': 'iqn.2008-05.com.xtremio:001b21b545c1', 'portal': '1', 'user': '', 'password': '******', 'id': '532f818f-cf8f-4e46- b34c-c6a7b1cd18ef', 'port': '3260'}, {'connection': '10.35.116.153', 'iqn': 'iqn.2008-05.com.xtremio:001b21b54535', 'portal': '1', 'user': '', 'password': '******', 'id': '6b30 5599-3733-4adc-8759-3bccb7a0d997', 'port': '3260'}, {'connection': '10.35.64.81', 'iqn': 'script11', 'portal': '1', 'user': '', 'password': '******', 'id': 'ed288a23-0928-4bb6- bc9d-af6c11d87aea', 'port': '3260'}, {'connection': '10.35.116.152', 'iqn': 'iqn.2008-05.com.xtremio:001b21b54534', 'portal': '1', 'user': '', 'password': '******', 'id': '12d1 19de-6ca2-45d0-b2f7-216f7d61ee15', 'port': '3260'}, {'connection': '10.35.115.152', 'iqn': 'iqn.2008-05.com.xtremio:001b21b54534', 'portal': '1', 'user': '', 'password': '***** *', 'id': 'd2ea7c66-f932-4536-8574-96fd26f324ad', 'port': '3260'}, {'connection': '10.35.116.151', 'iqn': 'iqn.2008-05.com.xtremio:001b21b545c1', 'portal': '1', 'user': '', 'pa ssword': '******', 'id': 'd5f207fe-16f1-408a-b038-902509f45e37', 'port': '3260'}, {'connection': '10.35.116.150', 'iqn': 'iqn.2008-05.com.xtremio:001b21b545c0', 'portal': '1', 'user': '', 'password': '******', 'id': '4ab33648-2156-49b9-91e0-00797ad23f4d', 'port': '3260'}, {'connection': '10.35.115.153', 'iqn': 'iqn.2008-05.com.xtremio:001b21b54535', 'portal': '1', 'user': '', 'password': '******', 'id': '4b4babb3-e185-42b7-aa4a-e212cdd2969c', 'port': '3260'}], options=None) Thread-14438::INFO::2012-02-13 22:28:16,908::logUtils::39::dispatcher::(wrapper) Run and protect: connectStorageServer, Return response: {'statuslist': [{'status': 0, 'id': 'e9 f45f40-3698-406c-ae69-3c3de0ad8e52'}, {'status': 0, 'id': '532f818f-cf8f-4e46-b34c-c6a7b1cd18ef'}, {'status': 0, 'id': '6b305599-3733-4adc-8759-3bccb7a0d997'}, {'status': 0, 'i d': 'ed288a23-0928-4bb6-bc9d-af6c11d87aea'}, {'status': 0, 'id': '12d119de-6ca2-45d0-b2f7-216f7d61ee15'}, {'status': 0, 'id': 'd2ea7c66-f932-4536-8574-96fd26f324ad'}, {'status' : 0, 'id': 'd5f207fe-16f1-408a-b038-902509f45e37'}, {'status': 0, 'id': '4ab33648-2156-49b9-91e0-00797ad23f4d'}, {'status': 0, 'id': '4b4babb3-e185-42b7-aa4a-e212cdd2969c'}]} Thread-14438::DEBUG::2012-02-13 22:28:16,908::task::1174::TaskManager.Task::(prepare) Task=`45f791c0-8692-4c1b-a65a-f32fd4fa5167`::finished: {'statuslist': [{'status': 0, 'id': 'e9f45f40-3698-406c-ae69-3c3de0ad8e52'}, {'status': 0, 'id': '532f818f-cf8f-4e46-b34c-c6a7b1cd18ef'}, {'status': 0, 'id': '6b305599-3733-4adc-8759-3bccb7a0d997'}, {'status': 0 , 'id': 'ed288a23-0928-4bb6-bc9d-af6c11d87aea'}, {'status': 0, 'id': '12d119de-6ca2-45d0-b2f7-216f7d61ee15'}, {'status': 0, 'id': 'd2ea7c66-f932-4536-8574-96fd26f324ad'}, {'sta tus': 0, 'id': 'd5f207fe-16f1-408a-b038-902509f45e37'}, {'status': 0, 'id': '4ab33648-2156-49b9-91e0-00797ad23f4d'}, {'status': 0, 'id': '4b4babb3-e185-42b7-aa4a-e212cdd2969c'} ]} VG #PV #LV #SN Attr VSize VFree 05a78fd0-1f41-43cc-b6cd-490e18ac6715 2 309 0 wz--n- 599.25g 238.38g 7aa228a1-f4aa-4e55-aca1-a3d802ee09ad 1 6 0 wz--n- 99.62g 95.75g vg0 1script11 dm-35 IET,VIRTUAL-DISK size=15G features='0' hwhandler='0' wp=rw `-+- policy='round-robin 0' prio=1 status=active `- 350:0:0:1 sdm 8:192 active ready running [root@nott-vds3 ~]# iscsiadm -m session tcp: [349] 10.35.64.81:3260,1 script11