Bug 790293

Summary:	RequestTimer calls exception() incorrectly
Product:	[Retired] Beaker	Reporter:	Raymond Mancy <rmancy>
Component:	lab controller	Assignee:	Raymond Mancy <rmancy>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	0.8	CC:	bpeck, dcallagh, ebaak, mcsontos, rmancy, stl
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-04-12 01:39:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Raymond Mancy 2012-02-14 06:41:02 UTC

in proxy.py in RequestTimer class the offending line is:

  logger.exception()

It should be:
  logger.exception(str(e))

This causes any issue with the thread that keep the proxy process logged in,
as if there is an exception it will not log and recover as it is supposed to.

Comment 1 Dan Callaghan 2012-02-14 23:57:08 UTC

Better would be something like

    logger.exception('Failed to login to Beaker server')

The .exception() method already adds the complete stack trace from the exception so str(e) is not necessary.

Comment 2 Raymond Mancy 2012-04-12 01:39:24 UTC

This was already pushed on the 0.8.1 branch as a hotfix