Bug 790484

Summary: Web UI Status Not Updating Properly
Product: [Retired] Beaker Reporter: Sean Waite <swaite>
Component: web UIAssignee: Raymond Mancy <rmancy>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 0.8CC: bpeck, dcallagh, ebaak, jburke, jnicolet, mcsontos, rmancy, stl
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-09 08:06:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Sean Waite 2012-02-14 16:23:11 UTC
Description of problem:
Something is getting cached in the browsers copy of the web UI. When a system is automatically marked broken, it'll still appear as "Automated" if you already have that system page open. Other people will see it as Broken, and you can see it's broken status by checking the History tab.


Version-Release number of selected component (if applicable): 0.8.0, with various versions of firefox


How reproducible:
Happens pretty regularly

Steps to Reproduce:
Pretty sure you can do it this way - 
1. Load the page of an automated system in beaker that will fail to install
2. kick off a test
3. wait for the system to autodisable

  
Actual results:
Check the system page, again, it should still say automated, even after a refresh

Expected results:
Page should say broken


Additional info:
We've been seeing this for a while, now, even before the 0.8 rollout

Comment 1 Bill Peck 2012-02-14 16:54:04 UTC
this is because we are using a form to display the status as well as let you change it.

Are you hitting reload?  If you load the page new it will "correct" itself.

Looks like we should add autocomplete=off to the form element

http://stackoverflow.com/questions/4862606/when-using-html-select-tag-changed-selected-value-not-displayed-in-firefox

Comment 2 Sean Waite 2012-02-14 17:34:43 UTC
I'm entering "F5, " or hitting the reload button, both of which will do a reload. It's possible that a Ctrl-F5, which clears the cache and forces a reload, will fix it, but otherwise a simple reload does not.

Comment 3 Sean Waite 2012-02-14 20:34:38 UTC
Just confirmed. Reload will not clear it, but Cache Clear + Reload (Ctrl + F5 in Firefox will)

Comment 4 Dan Callaghan 2012-03-02 03:12:53 UTC
This is a browser feature, I don't think we should be trying to work around it. Especially not by wholesale disabling autocomplete, which is generally quite useful.

Comment 5 Bill Peck 2012-03-02 13:22:38 UTC
(In reply to comment #4)
> This is a browser feature, I don't think we should be trying to work around it.
> Especially not by wholesale disabling autocomplete, which is generally quite
> useful.

Maybe its time we separate the edit from the display then?  Currently we display everything in a form and allow users with the correct permissions to change it.  But most of the time you aren't interested in changing it, you're just looking for the current status/values.  We could simply have an edit link to make any changes to the system?

Comment 6 Dan Callaghan 2012-03-04 22:43:36 UTC
(In reply to comment #5)

+1 to this. I think it makes sense to display system info in an ordinary table, and have a separate form for editing.

Comment 7 Bill Peck 2012-05-04 19:24:28 UTC
moving to 0.9.2 so we can implement like comment #5

Comment 8 Raymond Mancy 2012-07-26 22:19:52 UTC
While we're here and commited to seperating the view from the editing does anyone have any ideas about how we might like to change the view of the system details?

Off the top of my head:

* Date created
* Last checkin
* Serial number
* Last modification
* Notify CC.

Do people want to be able to see these? Why not have a simple toggle 'button' that can show these details if the user wants, otherwise it keeps them hidden.

I'm going to guess the most common complaint will be the one extra click if you want to see all the details, and that the layout between the view and the edit would now be different.

Comment 9 Raymond Mancy 2012-07-27 03:56:36 UTC
For the time being I'm just going to hack it up to use the same display that we currently do. One day when someone who knows more about UX that I comes along and has some input, we should look at fixing it properly

Comment 10 Raymond Mancy 2012-08-01 20:54:27 UTC
http://gerrit.beaker-project.org/#/c/1268/

Comment 12 Dan Callaghan 2012-08-06 02:59:31 UTC
A minor issue identified during testing: the Condition Report field is no longer being hidden for working (i.e. Automated or Manual) systems on the system page.

This js in system_form.kid will need slight tweaking:

    if ($('#form_status :selected').text() == 'Manual' || $('#form_status :selected').text() == 'Automated') {

Comment 13 Dan Callaghan 2012-08-06 03:07:04 UTC
(In reply to comment #12)

Apart from that, this works really well and is a huge improvement to the system page IMHO.

Comment 14 Jeff Burke 2012-08-06 12:01:46 UTC
(In reply to comment #12)
> A minor issue identified during testing: the Condition Report field is no
> longer being hidden for working (i.e. Automated or Manual) systems on the
> system page.
> 
Dan,
 I believe we do not want it hidden for Automated or Manual. For example the system can be Automated and loaned to a person. We wanted to use the condition field to say who/why (ticket number) the system was loaned.

Best,
Jeff

Comment 15 Raymond Mancy 2012-08-07 04:35:41 UTC
Hi Jeff,

This 'Condition Report' was designed around the Broken status. In fact it is cleared if you move the system from Broken -> Automated/Manual.

Comment 16 Jeff Burke 2012-08-07 12:39:07 UTC
Ray,
 I understand. I only mention it because I have an outstanding issue that I brought up at the stakeholders meeting a few weeks ago. This BZ seemed relevante to that issue. Sorry to add confusion.

[] Bug 733347 - RFE: Add ability to update the "Condition Report" when a system is loaned in Beaker.
   * This would go a long way in helping us track why systems are loaned out.


Best,
Jeff

Comment 17 Dan Callaghan 2012-08-09 08:06:38 UTC
Beaker 0.9.2 has been released.