Bug 790516

Summary: aeolus should only return a valid ip or text indicating a valid ip was not found
Product: [Retired] CloudForms Cloud Engine Reporter: wes hayutin <whayutin>
Component: aeolus-conductorAssignee: Matt Wagner <matt.wagner>
Status: CLOSED CURRENTRELEASE QA Contact: wes hayutin <whayutin>
Severity: high Docs Contact:
Priority: unspecified    
Version: 1.0.0CC: akarol, athomas, deltacloud-maint, jeckersb, ssachdev
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://hp-sl2x170zg6-01.rhts.eng.bos.redhat.com/conductor/pools
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-30 17:15:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description wes hayutin 2012-02-14 18:25:41 UTC
Description of problem:

Currently depending on the client status.. deltacloud will report either

1. a valid ip
2. a mac addr
3. a vnc add (rhevm)

Deltacloud has fixed a bug that indicates and differentiates the type.

Aeolus should only return a valid ip 

or

some text indicating a valid ip is not reported from the instances


This will help reduce the confusion around ip addr and instances..
People sshing into rhevm clusters..etc..

Comment 1 Matt Wagner 2012-02-14 19:15:06 UTC
From https://issues.apache.org/jira/browse/DTACLOUD-143 --

  <public_addresses><address port='5902' type='vnc'>qeblade27.rhq.lab.eng.bos.redhat.com</address></public_addresses>
  <private_addresses></private_addresses> 

So the type='vnc' is key. I'll look at what we get for an instance IP, and I think we should discard anything that isn't that. (Unless we want to track MACs or VNC addresses separately, which might be a nice enhancement.)

Comment 3 Matt Wagner 2012-02-20 21:18:44 UTC
Pushed to master:

commit acd8031878cbabcef121646e61be6388c4e6d52f
Author: Matt Wagner <matt.wagner>
Date:   Tue Feb 14 16:03:24 2012 -0500

    BZ 790516 - Only accept ipv4, hostname addresses for instances
    
    Deltacloud labels 'vnc' and 'mac' addresses; don't set them as
    instance addresses! (There is no 'ipv6' type currently.)
    
    Resolves https://bugzilla.redhat.com/show_bug.cgi?id=790516

Comment 4 John Eckersberg 2012-02-20 21:45:04 UTC
acd8031 (maint 61e2cd2) in aeolus-conductor-0.8.0-31

Comment 5 wes hayutin 2012-02-24 03:15:16 UTC
verified in

 [root@qeblade31 ~]# rpm -qa | grep aeolus
aeolus-conductor-daemons-0.8.0-35.el6.noarch
rubygem-aeolus-image-0.3.0-9.el6.noarch
rubygem-aeolus-cli-0.3.0-10.el6.noarch
aeolus-all-0.8.0-35.el6.noarch
aeolus-conductor-0.8.0-35.el6.noarch
aeolus-conductor-doc-0.8.0-35.el6.noarch
aeolus-configure-2.5.0-15.el6.noarch