| Summary: | node update might fail because of old grub usage | ||
|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Fabian Deutsch <fabian.deutsch> |
| Component: | ovirt-node | Assignee: | Fabian Deutsch <fdeutsch> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | acathrow, apevec, jboggs, mburns, ovirt-bugs, ovirt-maint |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 2.4.0 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-14 13:35:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Fabian Deutsch
2012-02-14 19:08:38 UTC
After systemd patchset landed, "savedefault" is now at http://gerrit.ovirt.org/gitweb?p=ovirt-node.git;a=blob;f=scripts/ovirt-init-functions.sh;h=e1a09df64844c3726ac1241e02697e19d1cd6226;hb=HEAD#l1262 savedefault should be removed, and I think intended behavior (fallback after image update fails to boot) is default in Fedora grub2, there's GRUB_DEFAULT=saved in /etc/default/grub But not sure if this has been tested with ovirt-node after migration to grub2? We need to conditionalize that statement then. savedefault is still valid for distros using legacy grub, some of which we still use. defer to 2.4 so we can test fallback The following patch just executes the lagacy grub command if no grub2 is found. http://gerrit.ovirt.org/4173 Currently the code just greps the line for the GRUB_DEFAULT param and adds it to the log file. It might make sense to additionally update this param if needed. |