Bug 790969

Summary: Invalid certificate error message when add a certificate for a service
Product: Red Hat Enterprise Linux 6 Reporter: Jenny Severance <jgalipea>
Component: ipaAssignee: Rob Crittenden <rcritten>
Status: CLOSED NOTABUG QA Contact: IDM QE LIST <seceng-idm-qe-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.3CC: jcholast, mkosek
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-03-01 15:58:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jenny Severance 2012-02-15 20:22:08 UTC
Description of problem:

Regression causing multiple failures with automated tests because of incorrect error message.  Certificate is not a user Certificate but a service certificate.

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
 :: [   LOG    ] :: service_add_004: ipa service-add : add service for vpn with cert bytes and --force option ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

-------------------------------
 Added host "dummy.testrelm.com"
-------------------------------
    Host name: dummy.testrelm.com
    Principal name: host/dummy.testrelm.com
    Password: False
    Keytab: False
    Managed by: dummy.testrelm.com
 :: [   PASS   ] :: Adding dummy host with no DNS records
 :: [   PASS   ] :: Running 'ipa service-add vpn/dummy.testrelm.com --force --certificate=wrong>  /tmp/tmp.54jxy44gFx/service_add_004A.out 2>&1'
 :: [   FAIL   ] :: File '/tmp/tmp.54jxy44gFx/service_add_004A.out' should contain 'ipa: ERROR: Certificate format error: improperly formatted DER-encoded certificate'
 ipa: ERROR: invalid 'usercertificate': must be binary data


Version-Release number of selected component (if applicable):

ipa-server-2.2.0-101.20120215T0856zgit578669d.el6.x86_64


How reproducible:
always

Steps to Reproduce:
1. already automated
2.
3.
  
Actual results:
ipa: ERROR: invalid 'usercertificate': must be binary data


Expected results:
ipa: ERROR: Certificate format error: improperly formatted DER-encoded certificate

Additional info:

Comment 2 Rob Crittenden 2012-02-17 18:26:07 UTC
Upstream ticket:
https://fedorahosted.org/freeipa/ticket/2403

Comment 3 Jan Cholasta 2012-03-01 15:58:40 UTC
This is not a bug. The old behavior was not consistent with the rest of the framework, because Bytes parameters (such as certificates) were handled differently than the rest of the parameters and the initial type check (which causes the "must be binary data" error) was skipped.