Bug 79240

Summary: bad source code
Product: [Retired] Red Hat Linux Reporter: d.binderman
Component: reiserfs-utilsAssignee: John W. Linville <linville>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 8.0   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-08-26 14:14:53 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description d.binderman 2002-12-08 05:57:18 EST
Description of Problem:

Hello there,

I just tried to compile package reiserfs-utils-3.6.2-2 from Redhat 8.0.

Here are some of the compiler messages.

mkreiserfs.c:523: warning: operation on `program_name' may be undefined
tune.c:217: warning: operation on `program_name' may be undefined

Here is a patch which fixes the messages.

*** ./mkreiserfs/mkreiserfs.c.old	2002-11-20 12:23:24.000000000 +0000
--- ./mkreiserfs/mkreiserfs.c	2002-11-20 12:23:46.000000000 +0000
***************
*** 520,526 ****
  
  
      program_name = strrchr( argv[ 0 ], '/' );
!     program_name = program_name ? ++ program_name : argv[ 0 ];
      
      print_banner (program_name);
  
--- 520,526 ----
  
  
      program_name = strrchr( argv[ 0 ], '/' );
!     program_name = program_name ? (program_name + 1) : argv[ 0 ];
      
      print_banner (program_name);
  
*** ./tune/tune.c.old	2002-11-20 12:24:07.000000000 +0000
--- ./tune/tune.c	2002-11-20 12:24:21.000000000 +0000
***************
*** 214,220 ****
      int Is_journal_or_maxtrans_size_specified = 0;
  
      program_name = strrchr( argv[ 0 ], '/' );
!     program_name = program_name ? ++ program_name : argv[ 0 ];
      
      print_banner (program_name);
  
--- 214,220 ----
      int Is_journal_or_maxtrans_size_specified = 0;
  
      program_name = strrchr( argv[ 0 ], '/' );
!     program_name = program_name ? (program_name + 1) : argv[ 0 ];
      
      print_banner (program_name);
  


Version-Release number of selected component (if applicable):


How Reproducible:


Steps to Reproduce:
1. 
2. 
3. 

Actual Results:


Expected Results:


Additional Information: