Bug 793309 (JBEPP-393)

This has to do with processing incoming POST requests to the Shindig Gadget Server. The issue is with the "doPost" method on the "org.apache.shindig.gadgets.servlet.RpcServlet"

<code>
protected void doPost(HttpServletRequest request, HttpServletResponse response)
      throws IOException {

    int length = request.getContentLength();
    if (length <= 0) {
      logger.info("No Content-Length specified.");
      response.setStatus(HttpServletResponse.SC_LENGTH_REQUIRED);
      return;
    }
    if (length > POST_REQUEST_MAX_SIZE) {
      logger.info("Request size too large: " + length);
      response.setStatus(HttpServletResponse.SC_REQUEST_ENTITY_TOO_LARGE);
      return;
    }

    //Here is the issue.......
    ServletInputStream is = request.getInputStream();
    byte[] body = IOUtils.toByteArray(is);

    if (body.length != length) {
      logger.info("Wrong size. Length: " + length + " real: " + body.length);
      response.setStatus(HttpServletResponse.SC_BAD_REQUEST);
      return;
    }

    Result result = process(request, response, body);
    response.getWriter().write(result.getOutput());
  }
</code>

It reads the JSON payload from the http servlet's input stream. That in itself is not a bad thing. But the problem happens when you have some pre-processing that already reads this InputStream before it
hits the servlet. In our case, that happens when you activate the "RequestDumperValve". 

At this point I would say this issue is not in the code, but in "whatever pre-processing" that occurs before the doPost invocation. This invocation needs to happen with the 'InputStream unread".

Would a reset on the input stream (in shindig) work around ?

Requires an update to 1.0-r790473-Patch03

Affects: Added: [Release Notes]

This requires a fix in Shindig and an upgrade to 1.0-r790473-Patch03

Link: Added: This issue depends JBEPP-450

Link: Added: This issue related GTNPORTAL-1474