Bug 793917 (JBEPP-988)

Summary: LoginRedirectFilter only detects redirection for hardcoded "/portal/sso" context
Product: [JBoss] JBoss Enterprise Portal Platform 5 Reporter: Tomas Kyjovsky <tkyjovsk>
Component: Portal, Site PublisherAssignee: mposolda
Status: CLOSED NEXTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: unspecifiedCC: epp-bugs, tkyjovsk
Target Milestone: ---   
Target Release: 5.2.0.ER06   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/JBEPP-988
Whiteboard: LoginRedirectFilter OpenSSO SSO SitePublisher sso-agent
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-09 16:10:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
LoginRedirectFilter.java none

Description Tomas Kyjovsky 2011-06-23 13:33:54 UTC
project_key: JBEPP

LoginRedirectFilter only detects login redirection for a hardcoded URL context "/portal/sso". This makes it not to work properly with other non-default portal containers, for example "ecmdemo" which is shipped with the SitePublisher extension.

Project: org.gatein.sso:sso-agent
Class: org.gatein.sso.agent.filter.LoginRedirectFilter

...
private boolean isLoginInProgress(HttpServletRequest request)
{
	String action = request.getRequestURI();
	if (action != null && action.equals("/portal/sso"))
	{
		return true;
	}
	return false;
}
...

Comment 1 Tomas Kyjovsky 2011-06-23 13:42:39 UTC
I'd suggest either

a) adding a new init-param for the LoginRedirectFilter which would customize request URI, or

b) detecting the current portal container's context (which possibly could be done via the AbstractFilter.getContainer() method)

Comment 2 Tomas Kyjovsky 2011-06-27 14:24:08 UTC
I'm attaching a patched LoginRedirectFilter which implements option b) from the above comment and redirects logins from "/${portalContainerName}/sso" depending on the current portal container.

Comment 3 Tomas Kyjovsky 2011-06-27 14:24:08 UTC
Attachment: Added: LoginRedirectFilter.java


Comment 4 Tomas Kyjovsky 2011-08-18 18:20:32 UTC
Labels: Removed: LoginRedirectFilter sso-agent Added: LoginRedirectFilter OpenSSO SSO SitePublisher sso-agent


Comment 5 mposolda 2011-11-09 16:10:53 UTC
Release Notes Text: Added: Fixed in SSO 1.1.0-GA by commit rev. 7960 . Instead of "/portal/sso", we are using request.getContextPath() + "/sso" right now.


Comment 6 Jared MORGAN 2011-11-23 00:49:03 UTC
Moved comment from RN Text field:

Fixed in SSO 1.1.0-GA by commit rev. 7960 . Instead of "/portal/sso", we are using request.getContextPath() + "/sso" right now.

Comment 7 Jared MORGAN 2011-11-23 00:49:03 UTC
Release Notes Docs Status: Added: Not Required
Release Notes Text: Removed: Fixed in SSO 1.1.0-GA by commit rev. 7960 . Instead of "/portal/sso", we are using request.getContextPath() + "/sso" right now.