Bug 794237 (JBEPP-1293)

Summary:	Exception is not handled in SeamPhaseListenerWrapper.afterPhase() and just swallowed
Product:	[JBoss] JBoss Enterprise Portal Platform 5	Reporter:	Toshiya Kobayashi <tkobayas>
Component:	Portal	Assignee:	Ken Finnigan <ken>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	5.1.1.GA	CC:	tkobayas
Target Milestone:	---
Target Release:	5.2.0.ER06
Hardware:	Unspecified
OS:	Unspecified
URL:	http://jira.jboss.org/jira/browse/JBEPP-1293
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:	Portlet Bridge 2.1.2 tag / 2.x-EPP5 branch
Last Closed:	2011-11-02 12:16:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Toshiya Kobayashi 2011-10-17 11:08:29 UTC

Help Desk Ticket Reference: https://c.na7.visual.force.com/apex/Case_View?id=500A0000008RtL9&sfdc.override=1
project_key: JBEPP

Platform JIRA for [PBR-295] Exception is not handled in SeamPhaseListenerWrapper.afterPhase() and just swallowed

Comment 1 Toshiya Kobayashi 2011-10-17 11:09:09 UTC

Link: Added: This issue incorporates PBR-295

Comment 2 Toshiya Kobayashi 2011-11-02 07:29:17 UTC

Link: Added: This issue is incorporated by JBEPP-1330

Comment 3 Jared MORGAN 2011-11-22 23:53:30 UTC

Could I please get some draft content for the Release Notes here. This must be included in the Release Notes, because it is a helpdesk issue.

Comment 4 Jared MORGAN 2011-11-22 23:53:30 UTC

Release Notes Docs Status: Added: Needs More Info
Release Notes Text: Added: CAUSE:

CONSEQUENCE:

FIX:

RESULT:
Primary SME: Added: theute
NEEDINFO: Removed: Nobody Added: Subject Matter Expert

Comment 5 Jared MORGAN 2011-11-27 23:09:04 UTC

NEEDINFO Due Date: Added: 30/Nov/11

Comment 6 Toshiya Kobayashi 2011-11-28 01:00:33 UTC

Hi Jared,
Let me know if you want more info.

===========
CAUSE:

org.jboss.portletbridge.seam.SeamPhaseListenerWrapper.afterPhase() doesn't handle exceptions.

CONSEQUENCE:

Exceptions during afterPhase() are swallowed. (e.g. StaleObjectStateException in Hibernate commit) Seam exception handler is not notified of it so the application moves to a next page instead of an error page.

FIX:

Now org.jboss.portletbridge.seam.SeamPhaseListenerWrapper.afterPhase() catches exceptions and passes them to Seam exception handler like org.jboss.seam.jsf.SeamPhaseListener.

RESULT:

Exceptions during afterPhase() are handled. Seam exception handler is notified of it so the application moves to an error page.

Comment 8 Jared MORGAN 2011-11-28 02:11:09 UTC

Release Notes Docs Status: Removed: Needs More Info Added: Documented as Resolved Issue
Release Notes Text: Removed: CAUSE:

CONSEQUENCE:

FIX:

RESULT: Added: org.jboss.portletbridge.seam.SeamPhaseListenerWrapper.afterPhase() did not correctly handle exceptions. Exceptions that typically occurred during during afterPhase() were truncated (for example StaleObjectStateException in Hibernate commit). The Seam exception handler was not notified of the truncated exceptions therefore the application moves to a next page instead of an error page. The fix ensures org.jboss.portletbridge.seam.SeamPhaseListenerWrapper.afterPhase() catches exceptions and passes them to Seam exception handler (for example, org.jboss.seam.jsf.SeamPhaseListener). Because exceptions are handled correctly, the Seam exception handler displays and error page given the appropriate conditions.
NEEDINFO Due Date: Removed: 30/Nov/11 
NEEDINFO: Removed: Subject Matter Expert Added: Nobody