Bug 794793
Summary: | Review Request: openssl-ibmpkcs11 - An openssl PKCS#11 engine | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Kent Yoder <key> |
Component: | Package Review | Assignee: | Dan Horák <dan> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | brueckner, bugproxy, dan, hannsj_uhl, mgrf, ngompa13, package-review |
Target Milestone: | --- | Flags: | dan:
fedora-review?
|
Target Release: | --- | ||
Hardware: | s390x | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-01-22 08:44:20 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 467765, 1274387, 1525184 |
Description
Kent Yoder
2012-02-17 16:44:19 UTC
taking for review Hi Dan, any status? Thanks, Kent any update here? This should really make Fedora 19 ... to make RHEL xx based on F19 Thx in advance first notes: - Release must start with 1 for released projects, %{?dist} is missing - see https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag - use an acronym for License, see https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses for license list, also the licensing is unclear in the source code, simple inclusion of OpenSSL license in the LICENSE file is not sufficient, best option is to include licensing header in all source files or at least a notice in README (any file created by the authors), also read https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ - Group is wrong, see /usr/share/doc/rpm-*/GROUPS for a list, or omit Group compeltely - you can drop BuildRoot, %defattr and whole %clean because rpm will take care of it itself - there should be no need export CFLAGS/CPPFLAGS, teh %configure macro already does it - use -q in %setup, drop -n, the %{name}-%{version} format is used by default - I'd drop the license header on top of the spec completely (if possible), see https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#License_of_Fedora_SPEC_Files For more information about packaging rules in Fedora please see https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines and if you have any questions please ask. Also I think the %post/%pre ldconfig calls are not necessary if the module is opened by dlopen() from inside of the openssl library, and apps are not directly linked to it (https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Shared_Libraries) ------- Comment From mgrf.com 2013-03-06 15:01 EDT------- (In reply to Kent Yoder from comment #0) > Spec URL: http://kyoder.users.sourceforge.net/openssl-ibmpkcs11.spec > SRPM URL: > http://kyoder.users.sourceforge.net/openssl-ibmpkcs11-1.0.0-0.src.rpm > Description: This package contains a shared object OpenSSL dynamic engine > for the use with a PKCS#11 implementation such as openCryptoki. > > This package provides a library that will bridge the gap between a PKCS#11 > implementation, which provides support for storage of keys and certificates > and cryptographic hardware support, to the openssl libcrypto library. > . for the records ... the current upstream location for this package is https://sourceforge.net/projects/opencryptoki/files/PKCS%2311%20OpenSSL%20Engine/openssl-ibmpkcs11/ ... ------- Comment From hannsj_uhl.com 2016-03-17 08:39 EDT------- *** Bug 139187 has been marked as a duplicate of this bug. *** Dan, Claudio, are there still questions on this, or is all resolved ? ------- Comment From ebarretto.com 2017-01-31 06:38 EDT------- Hi Dan and Hans-Georg, the openssl-ibmpkcs11 is since last semester under my responsibility as well as opencryptoki. I'm working on make it stable, whenever I have a break from opencryptoki, as there are many issues on it. I was not aware of this Fedora requirement and I will make sure as soon as it gets stable that I will implement it. I don't have a specific date yet for this to be done. If you need more information or requests just let me know. Eduardo ------- Comment From mgrf.com 2017-12-11 06:03 EDT------- There is a new version of OpenSSL-ibmpkcs11 available upstream You can easily grab this release in tarball format on Github: https://github.com/opencryptoki/openssl-ibmpkcs11/archive/v1.0.1.tar.gz Please integrate into Fedora *** This bug has been marked as a duplicate of bug 1536990 *** |