Bug 794989

Description of problem:
I've been writing an experimental static analysis tool to detect bugs commonly occurring within C Python extension modules:
  https://fedorahosted.org/gcc-python-plugin/
  http://gcc-python-plugin.readthedocs.org/en/latest/cpychecker.html
  http://fedoraproject.org/wiki/Features/StaticAnalysisOfPythonRefcounts

I ran the latest version of the tool (in git master; post 0.9) on
libpwquality-1.0.0-2.fc17.src.rpm, and it reports various errors.

You can see a list of errors here, triaged into categories (from most significant to least significant):
http://fedorapeople.org/~dmalcolm/gcc-python-plugin/2012-02-18/libpwquality-1.0.0-2.fc17/

I've manually reviewed the issues reported by the tool.

Within the category "Reference leaks" the 1 issues reported:
  pwquality.c:pwqerror:ob_refcnt of '*py_errvalue' is 1 too high
appears to be a true bug: the tuple associated with the AttributeError still has another reference within the scope of pwqerror, and so will become immortal for the lifetime of the process.

Within the category "Possible reference leaks" the 2 issues reported
 pwquality.c:pwqsettings_setint:ob_refcnt of new ref from (unknown) pwqerror is 1 too high
 pwquality.c:pwqsettings_setstr:ob_refcnt of new ref from (unknown) pwqerror is 1 too high
may well be false positives: the checker doesn't know whether or not pwquality_set_int_value and pwquality_set_str_value "steal" the reference they're passed (taking ownership), or merely borrow it.  If the latter, then these are also reference leaks.

There may of course be other bugs in my checker tool.

Hope this is helpful; let me know if you need help reading the logs that the tool generates - I know that it could use some improvement.

Version-Release number of selected component (if applicable):
libpwquality-1.0.0-2.fc17
gcc-python-plugin post-0.9 git 771455b3128b1323e80bdda53939d8d140a84c68 running the checker in an *f16* chroot