Bug 795069
| Summary: | Review Request: sugar-countries - Countries is a game to play with identifying countries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalpa Welivitigoda <callkalpa> |
| Component: | Package Review | Assignee: | Jan-Frode Myklebust <janfrode> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | janfrode, notting, package-review, pbrobinson |
| Target Milestone: | --- | Flags: | janfrode:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | sugar-countries-33-2.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-16 21:20:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kalpa Welivitigoda
2012-02-19 04:33:37 UTC
The spec file lists URL: http://mulawa.net/olpc/countries which doesn't seem to tell much about this application. Isn't there a proper homepage for it ? Nitpick: you're doing "chmod +x setup.py" and later "%{__python} ./setup.py".. so I don't think the chmod should be needed. Could you please show output of rpmlint on fedora 16? fixed the issues and here are the new files Spec URL: http://callkalpa.fedorapeople.org/sugar-countries/sugar-countries.spec SRPM URL: http://callkalpa.fedorapeople.org/sugar-countries/sugar-countries-33-2.fc16.src.rpm rpmlint on spec and srpm on fedora 16 rpmlint sugar-countries.spec ../SRPMS/sugar-countries-33-2.fc16.src.rpm sugar-countries.spec:6: W: non-standard-group Sugar/Activities sugar-countries.src: W: non-standard-group Sugar/Activities 1 packages and 1 specfiles checked; 0 errors, 2 warnings. This updated srpm seems corrupted, or incompatible with RHEL6 (v33-1 works): unpacking of archive failed on file /home/janfrode/rpmbuild/SOURCES/countries-33.xo;4f5b6edc: cpio: read But the updated specfile seems OK. It was the non-standard-group I was wondering if rpmlint would complain about on f16 too. I see the is used in the sugar-packaging guidelines, so I assume it should be OK. Sorry I have cancelled it half way uploading to fedorapeople. Here is the new file SRPM URL: http://callkalpa.fedorapeople.org/sugar-countries/sugar-countries-33-2.fc16.src.rpm non-standard-group warning is there with sugar activities and it is ignored for them. New Package SCM Request ======================= Package Name: sugar-countries Short Description: a sugar activity to play with identifying countries Owners: callkalpa Branches: f15 f16 f17 InitialCC: pbrobinson Git done (by process-git-requests). sugar-countries-33-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/sugar-countries-33-2.fc15 sugar-countries-33-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/sugar-countries-33-2.fc16 sugar-countries-33-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/sugar-countries-33-2.fc17 sugar-countries-33-2.fc17 has been pushed to the Fedora 17 testing repository. sugar-countries-33-2.fc17 has been pushed to the Fedora 17 stable repository. sugar-countries-33-2.fc16 has been pushed to the Fedora 16 stable repository. sugar-countries-33-2.fc15 has been pushed to the Fedora 15 stable repository. |