Bug 795076

Summary: Compile error (duplicate symbol _virFileWrapperFdFlags) with MacOS X and libvirt 0.9.10
Product: [Community] Virtualization Tools Reporter: Lincoln <lincoln_myers>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED UPSTREAM QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: crobinso, veillard, xen-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Mac OS   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-20 03:28:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lincoln 2012-02-19 06:10:35 UTC 
As discussed here:

   http://www.redhat.com/archives/libvir-list/2012-February/msg00612.html

libvirt 0.9.10 final does not build on MacOS/X, while (according to
the list, I first started using with 0.9.10) 0.9.10-rc1 did build
correctly.

The following patch seems to fix it.  I believe virFileWrapperFdFlags
was accidentally declared as a global variable instead of as a type,
one way or another:

  --- a/src/util/virfile.h	Thu Feb 16 01:56:57 2012 -0800
  +++ b/src/util/virfile.h	Sat Feb 18 20:35:03 2012 -0800
  @@ -58,10 +58,10 @@
  
   int virFileDirectFdFlag(void);
   
  -enum {
  +enum virFileWrapperFdFlags {
       VIR_FILE_WRAPPER_BYPASS_CACHE   = (1 << 0),
       VIR_FILE_WRAPPER_NON_BLOCKING   = (1 << 1),
  -} virFileWrapperFdFlags;
  +};
  
   virFileWrapperFdPtr virFileWrapperFdNew(int *fd,
                                           const char *name,
Comment 1 Daniel Veillard 2012-02-20 03:28:46 UTC 
Thanks a lot, pushed upstream ! Hopefully your name informations are
right, I had to guess:

http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=102690648db583e83b729bab19fafa943e4468af


Daniel