Bug 795239

Summary: Typo in en.yml locale file
Product: [Retired] CloudForms Cloud Engine Reporter: Dan Macpherson <dmacpher>
Component: aeolus-conductorAssignee: Steve Linabery <slinaber>
Status: CLOSED ERRATA QA Contact: wes hayutin <whayutin>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 1.0.0CC: akarol, cpelland, dajohnso, deltacloud-maint, dgao, hbrock, jeckersb, slinaber, ssachdev
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-05-15 22:37:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
ref
none
ref1 none

Description Dan Macpherson 2012-02-20 03:59:53 UTC
Description of problem:
There seems to be a typo in the English locale file for Cloud Engine:

    flash:
      error:
        ...
        not_selected: "No application blueprint was not selected!"

Steps to reproduce:
1. Open /usr/share/aeolus-conductor/config/locales/en.yml
2. search for the above string


Actual results:
Error message returns as "No application blueprint was not selected!"

Expected results:

Either
"No application blueprint was selected!"
or
"Application blueprint was not selected!"

Comment 1 Steve Linabery 2012-02-20 21:15:05 UTC
fixed in 89302b5 on axiom

Comment 2 John Eckersberg 2012-02-20 21:46:49 UTC
89302b5 in aeolus-conductor-0.8.0-31

Comment 3 Shveta 2012-02-22 08:09:13 UTC
 File checked :    /usr/share/aeolus-conductor/config/locales/en.yml

I could not find the above string ""No application blueprint was not selected!"
but i could see this "not_selected: "No deployable was not selected!"



rpm -qa|grep aeolus
aeolus-conductor-daemons-0.8.0-33.el6.noarch
aeolus-configure-2.5.0-14.el6.noarch
rubygem-aeolus-image-0.3.0-8.el6.noarch
aeolus-conductor-0.8.0-33.el6.noarch
rubygem-aeolus-cli-0.3.0-9.el6.noarch
aeolus-conductor-doc-0.8.0-33.el6.noarch
aeolus-all-0.8.0-33.el6.noarch

Comment 4 Hugh Brock 2012-02-24 16:15:13 UTC
Can you retest on beta 2 which has correct strings?

Comment 5 dgao 2012-02-24 20:50:05 UTC
[root@dell-pem600-01 deltacloud-core]# rpm -qa | grep "conductor"
aeolus-conductor-daemons-0.8.0-35.el6.noarch
aeolus-conductor-0.8.0-35.el6.noarch
aeolus-conductor-doc-0.8.0-35.el6.noarch
[root@dell-pem600-01 deltacloud-core]# cat /usr/share/aeolus-conductor/config/locales/en.yml| grep -i "not_select"
        deployable_not_selected: "You need to select deployable"
        not_selected: "No deployable was not selected!"

Comment 6 Steve Linabery 2012-02-29 15:26:37 UTC
/usr/share/aeolus-conductor/config/locales/en.yml is overridden by the values in /usr/share/aeolus-conductor/config/locales/overrides/en.yml

So the correct test is to verify that the right string is displayed in the conductor UI.

I will patch /usr/share/aeolus-conductor/config/locales/en.yml right away, but this BZ is already fixed. Putting this ON_QA.

Comment 7 Steve Linabery 2012-02-29 16:15:25 UTC
93ebda80c19125e62c8a9c686f23a4070e02595e is on maint branch to fix the typo in /usr/share/aeolus-conductor/config/locales/en.yml. Resetting to MODIFIED for consistency's sake.

Comment 8 Aziza Karol 2012-03-02 05:17:13 UTC
"You need to select deployable" is still displayed in UI. 
see attached screenshot.

rpm -qa | grep aeolus
aeolus-conductor-doc-0.8.0-39.el6.noarch
rubygem-aeolus-cli-0.3.0-12.el6.noarch
aeolus-all-0.8.0-39.el6.noarch
aeolus-conductor-0.8.0-39.el6.noarch
rubygem-aeolus-image-0.3.0-11.el6.noarch
aeolus-configure-2.5.0-16.el6.noarch
aeolus-conductor-daemons-0.8.0-39.el6.noarch

Comment 9 Aziza Karol 2012-03-02 05:20:21 UTC
Created attachment 566993 [details]
ref

Comment 10 Steve Linabery 2012-03-19 15:27:35 UTC
9c3dd9f36dfddb0f8106dcfaf72312d8bd46bc63 pushed which adds the missing message to overrides/en.yml

Comment 12 Aziza Karol 2012-03-23 09:26:41 UTC
You need to select Application is now displayed. see attached screenshot.

#cat /usr/share/aeolus-conductor/config/locales/overrides/en.yml | grep -i "not_select"
        deployable_not_selected: "You need to select Application"
        not_selected: "No application blueprint was selected!"

verified in:
#rpm -qa | grep aeolus
rubygem-aeolus-image-0.3.0-12.el6.noarch
rubygem-aeolus-cli-0.3.1-1.el6.noarch
aeolus-conductor-doc-0.8.3-1.el6.noarch
aeolus-all-0.8.3-1.el6.noarch
aeolus-conductor-daemons-0.8.3-1.el6.noarch
aeolus-configure-2.5.2-1.el6.noarch
aeolus-conductor-0.8.3-1.el6.noarch

Comment 13 Aziza Karol 2012-03-23 09:28:04 UTC
Created attachment 572206 [details]
ref1

Comment 14 errata-xmlrpc 2012-05-15 22:37:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2012-0583.html