Bug 795451
Summary: | Review Request: basex - XML database and XPath/XQuery processor | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | dimitar <dimitar.popov> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | akurtako, mizdebsk, package-review |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-01-26 12:13:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
dimitar
2012-02-20 15:18:18 UTC
Are you sponsored? If not please block FE-NEEDSPONSOR * It would be good to keep the build.xml as SourceX instead of catting it in the spec. * checks like %if 0%{?suse_version} > 1000 make no sense in fedora, we either need it or not * please install javadocs into %{_javadocdir}/%{name} not in %{_javadocdir}/%{name}-%{version} and drop the symlink/ghost thing * no need for clean section and cleaning in the install section * please use desktop-file-install https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files * where did you get Source0 from ? if it's manually created please either add comments on the exact comments to recreate it or add a script for that as SourceX * I see references to lucene in the spec but it's not BR/R , would you explain? Thanks for the comments. I created a new SPEC file from scratch and a new SRPM. I think address all your remarks in the new version, but if there is anything else, I'll fix it. Spec URL: https://raw.github.com/BaseXdb/basex-dist/master/linux/fedora/basex.spec SRPM URL: https://raw.github.com/BaseXdb/basex-dist/master/linux/fedora/basex-7.1.1-1.fc16.src.rpm I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale. This fails to build for me; here is a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5321604 No response from submitter - closing as WONTFIX. Feel free to reopen this once basex is fixed. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days |