Bug 795529

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3805740

I'm taking this one

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[!]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST No %config files under /usr.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint fedora-gather-easyfix-0.1.1-1.fc18.noarch.rpm

fedora-gather-easyfix.noarch: W: spelling-error Summary(en_US) fedorahosted -> fedora hosted, fedora-hosted, foretasted
fedora-gather-easyfix.noarch: W: spelling-error %description -l en_US fedorahosted -> fedora hosted, fedora-hosted, foretasted
fedora-gather-easyfix.noarch: W: incoherent-version-in-changelog 0.1.0-1 ['0.1.1-1.fc18', '0.1.1-1']
fedora-gather-easyfix.noarch: W: no-manual-page-for-binary gather_easyfix.py
1 packages and 0 specfiles checked; 0 errors, 4 warnings.


rpmlint fedora-gather-easyfix-0.1.1-1.fc18.src.rpm

fedora-gather-easyfix.src: W: spelling-error Summary(en_US) fedorahosted -> fedora hosted, fedora-hosted, foretasted
fedora-gather-easyfix.src: W: spelling-error %description -l en_US fedorahosted -> fedora hosted, fedora-hosted, foretasted
fedora-gather-easyfix.src: W: invalid-url Source0: fedora-gather-easyfix-0.1.1.tar.gz
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


[!]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
Package has no sources or they are generated by developer
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[-]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5
See: None
[!]: MUST Rpmlint output is silent.

rpmlint fedora-gather-easyfix-0.1.1-1.fc18.noarch.rpm

fedora-gather-easyfix.noarch: W: spelling-error Summary(en_US) fedorahosted -> fedora hosted, fedora-hosted, foretasted
fedora-gather-easyfix.noarch: W: spelling-error %description -l en_US fedorahosted -> fedora hosted, fedora-hosted, foretasted
fedora-gather-easyfix.noarch: W: incoherent-version-in-changelog 0.1.0-1 ['0.1.1-1.fc18', '0.1.1-1']
fedora-gather-easyfix.noarch: W: no-manual-page-for-binary gather_easyfix.py
1 packages and 0 specfiles checked; 0 errors, 4 warnings.


rpmlint fedora-gather-easyfix-0.1.1-1.fc18.src.rpm

fedora-gather-easyfix.src: W: spelling-error Summary(en_US) fedorahosted -> fedora hosted, fedora-hosted, foretasted
fedora-gather-easyfix.src: W: spelling-error %description -l en_US fedorahosted -> fedora hosted, fedora-hosted, foretasted
fedora-gather-easyfix.src: W: invalid-url Source0: fedora-gather-easyfix-0.1.1.tar.gz
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


Some minors:
You should try to correct Source0.
changelog-version should match package version.

Fix Source0 and changelog

Spec URL: http://pingou.fedorapeople.org/RPMs//fedora-gather-easyfix.spec
SRPM URL:
http://pingou.fedorapeople.org/RPMs//fedora-gather-easyfix-0.1.1-2.fc16.src.rpm

Package APPROVED

Thanks for the review :)

New Package SCM Request
=======================
Package Name: fedora-gather-easyfix
Short Description: Gather easyfix tickets across the fedora infrastructure
Owners: pingou
Branches: el6 f17
InitialCC: 

I changed the description to reflect that the project is already (in trunk) gathering easyfix tickets for more than just fedorahosted.

I will update the summary line of the spec at the next release.

Git done (by process-git-requests).

Since it's imported, built and at least included in f17, I'll close this ticket.

Oups sorry that I forgot to close this bug. Thanks for doing it :)