Bug 795652

Summary: Inappropriate __com.redhat_spice_migrate_info error handler causes qemu monitor hanging
Product: Red Hat Enterprise Linux 6 Reporter: Shaolong Hu <shu>
Component: qemu-kvmAssignee: Yonit Halperin <yhalperi>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.3CC: acathrow, bsarathy, dblechte, juzhang, michen, mkenneth, qzhang, tburke, virt-maint, wdai, xfu
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-kvm-0.12.1.2-2.250.el6 Doc Type: Bug Fix
Doc Text:
Cause Wrong error report when the monitor command __com.redhat_spice_migrate_info is applied with bad parameters Consequence qemu monitor hangs Fix Fix the error reporting Result qemu monitor does not hang when the above monitor command is applied with bad parameters.
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-20 11:43:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Shaolong Hu 2012-02-21 07:12:56 UTC
Description of problem:
------------------------
__com.redhat_spice_migrate_info fails to deal with invalid parameter, cause qemu monitor hangs.


Version-Release number of selected component (if applicable):
--------------------------------------------------------------
qemu-kvm-0.12.1.2-2.232.el6.x86_64


How reproducible:
------------------
100%


Steps to Reproduce:
--------------------
1.boot guest with:
/usr/libexec/qemu-kvm -enable-kvm -M rhel6.3.0 -smp 4 -m 4G -name win2008r2 -uuid 3f2ea5cd-3d29-48ff-aab2-23df1b6ae213 -drive file=nfs/win2008r2-64-virtio.qcow2,cache=none,if=none,rerror=stop,werror=stop,id=drive-virtio-disk0,format=qcow2 -device virtio-blk-pci,drive=drive-virtio-disk0,id=device-virtio-disk0 -netdev tap,script=/etc/qemu-ifup,id=netdev0 -device virtio-net-pci,netdev=netdev0,id=device-net0 -boot order=cd -monitor stdio -usb -device usb-tablet,id=input0 -chardev socket,id=s1,path=/tmp/s1,server,nowait -device isa-serial,chardev=s1 -monitor unix:/tmp/tt,server,nowait -vga qxl -spice port=5920,disable-ticketing

2.in qemu monitor:
(qemu) __com.redhat_spice_migrate_info ?
spice_server_migrate_connect: 
An undefined error has ocurred

  
Actual results:
----------------
after step 2, qemu monitor hangs.


Expected results:
------------------
Prompt error correctly, qemu monitor should not hang.

Comment 3 daiwei 2012-03-22 10:53:29 UTC
Reproduced this issue with steps and environment as follows: 

# uname -r ; rpm -q qemu-kvm
2.6.32-220.el6.x86_64
qemu-kvm-0.12.1.2-2.209.el6.x86_64

1.boot guest
/usr/libexec/qemu-kvm -cpu cpu64-rhel6,+x2apic,family=0xf -rtc base=localtime,clock=host,driftfix=slew -M rhel6.2.0 -enable-kvm -name win7_x64 -smp 2 -m 2G -uuid bd85c229-6384-446d-bedd-c111008ecfce -boot menu=on -drive file=/nfs/win7sp1.qcow2,if=none,id=drive-virtio-disk0,format=qcow2,cache=none,aio=native,media=disk,werror=stop,rerror=stop -device virtio-blk-pci,drive=drive-virtio-disk0,id=virtio-blk-pci0,bootindex=1 -netdev tap,id=hostnet0,vhost=on,script=/etc/qemu-ifup -device virtio-net-pci,netdev=hostnet0,id=net0,mac=44:37:E6:5E:A3:F7 -spice port=9000,disable-ticketing -balloon none -monitor stdio -usb -device usb-tablet,id=input1

2.in qemu monitor:
(qemu) __com.redhat_spice_migrate_info ?
spice_server_migrate_connect: 
An undefined error has ocurred

---after step 2, qemu monitor hangs---

Verified this issue with steps and environment as follows: 

# uname -r;rpm -q qemu-kvm
2.6.32-251.el6.x86_64
qemu-kvm-0.12.1.2-2.255.el6.x86_64

1.boot guest with the above command line

2.in qemu monitor
(qemu) __com.redhat_spice_migrate_info ?
Parameter 'port/tls-port' is missing

---after step 2,qemu monitor works well---

So,this bug had been fixed.

Comment 4 Miya Chen 2012-03-29 05:36:58 UTC
*** Bug 750439 has been marked as a duplicate of this bug. ***

Comment 6 Yonit Halperin 2012-05-06 05:32:14 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause
Wrong error report when the monitor command __com.redhat_spice_migrate_info is  applied with bad parameters

Consequence
qemu monitor hangs

Fix
Fix the error reporting

Result
qemu monitor does not hang when the above monitor command is applied with bad parameters.

Comment 7 errata-xmlrpc 2012-06-20 11:43:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0746.html