Bug 795777
Summary: | qpid-python-test should by default pass not just broker host but also broker port | ||
---|---|---|---|
Product: | Red Hat Enterprise MRG | Reporter: | Frantisek Reznicek <freznice> |
Component: | python-qpid | Assignee: | Darryl L. Pierce <dpierce> |
Status: | CLOSED NOTABUG | QA Contact: | MRG Quality Engineering <mrgqe-bugs> |
Severity: | low | Docs Contact: | |
Priority: | medium | ||
Version: | Development | CC: | esammons, iboverma, jross, lzhaldyb, pematous, tross |
Target Milestone: | 2.3 | Keywords: | Improvement |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Enhancement | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-11-06 19:47:06 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Frantisek Reznicek
2012-02-21 14:12:32 UTC
This patch is posted upstream in QPID-4058. https://issues.apache.org/jira/secure/attachment/12531824/0001-Adds-the-port-to-the-default-broker-address-for-qpid.patch In attempting to replicate this bug, I'm failing to get it to occur. I have a RHEL 6.2 machine with the following packages installed: mcpierce@mcp-rhel-62:~ $ rpm -q qpid-cpp-server python-qpid qpid-cpp-server-0.14-22.el6_3.i686 python-qpid-0.14-11.el6_3.noarch When I execute any of the following: qpid-python-test qpid-python-test --broker=localhost qpid-python-test --broker=localhost:5672 the tests run as expected and pass. When I execute any of the following: qpid-python-test --broker=localhost:5762 qpid-python-test --broker=farkle tests fail but for the expected reason. I'm unable to replicate the original error since I'm apparently missing some tests since I see: mcpierce@mcp-rhel-62:~ $ qpid-python-test -m qpid_tests 'qpid_tests.*' Traceback (most recent call last): File "/usr/bin/qpid-python-test", line 522, in <module> m = __import__(name, None, None, ["dummy"]) ImportError: No module named qpid_tests Can you please point me to where I can find the proper modules to replicate the test failure? Thanks. Frantisek, regarding Darryl's question above, does he need the rh-qpid package? Taking this back to ASSIGNED because the patch we have may not be final. (In reply to comment #4) > In attempting to replicate this bug, I'm failing to get it to occur. > > I have a RHEL 6.2 machine with the following packages installed: > > mcpierce@mcp-rhel-62:~ $ rpm -q qpid-cpp-server python-qpid > qpid-cpp-server-0.14-22.el6_3.i686 > python-qpid-0.14-11.el6_3.noarch > > When I execute any of the following: > > qpid-python-test > qpid-python-test --broker=localhost > qpid-python-test --broker=localhost:5672 > > the tests run as expected and pass. > > When I execute any of the following: > > qpid-python-test --broker=localhost:5762 > qpid-python-test --broker=farkle > > tests fail but for the expected reason. > > I'm unable to replicate the original error since I'm apparently missing some > tests since I see: > > mcpierce@mcp-rhel-62:~ $ qpid-python-test -m qpid_tests 'qpid_tests.*' > Traceback (most recent call last): > File "/usr/bin/qpid-python-test", line 522, in <module> > m = __import__(name, None, None, ["dummy"]) > ImportError: No module named qpid_tests > > Can you please point me to where I can find the proper modules to replicate > the test failure? Thanks. The package requirements for running those unit tests are: - qpid-cpp-server* - python-qpid (providing qpid-python-test) - qpid-tests (providing qpid_tests dir missing in above message) I see four tests failing, but not due to the Qpid code base. Instead, they're failing due to the tests themselves have incorrect expectations. Error during test: Traceback (most recent call last): File "/usr/bin/qpid-python-test", line 311, in run phase() File "/usr/lib/python2.6/site-packages/qpid_tests/broker_0_10/management.py", line 457, in test_immediate_method url = "%s://%s:%d" % (self.broker.scheme or "amqp", self.broker.host, self.broker.port) TypeError: %d format: a number is required, not NoneType The test is trying to parse out the URL and is requiring a port be provided. However, the Qpid code allows the port to be implied and not explicitly set. def test_immediate_method(self): url = "%s://%s:%d" % (self.broker.scheme or "amqp", self.broker.host, self.broker.port) The same thing is happening here but in a different spot in the test: qpid_tests.broker_0_10.management.ManagementTest.test_timestamp_config ................................................................................. fail Error during test: Traceback (most recent call last): File "/usr/bin/qpid-python-test", line 311, in run phase() File "/usr/lib/python2.6/site-packages/qpid_tests/broker_0_10/management.py", line 612, in test_timestamp_config url = "%s://%s:%d" % (self.broker.scheme or "amqp", self.broker.host, self.broker.port) TypeError: %d format: a number is required, not NoneType Same here. qpid_tests.broker_0_10.message.MessageTests.test_credit_flow_bytes ..................................................................................... fail Error during test: Traceback (most recent call last): File "/usr/bin/qpid-python-test", line 311, in run phase() File "/usr/lib/python2.6/site-packages/qpid_tests/broker_0_10/message.py", line 454, in test_credit_flow_bytes self.assertDataEquals(session, q.get(timeout = 1), "abcdefgh") File "/usr/lib/python2.6/site-packages/qpid/queue.py", line 50, in get result = BaseQueue.get(self, block, timeout) File "/usr/lib/python2.6/Queue.py", line 176, in get raise Empty Empty There is a different failure going on, though. qpid_tests.broker_0_10.message.MessageTests.test_window_flow_bytes ..................................................................................... fail Error during test: Traceback (most recent call last): File "/usr/bin/qpid-python-test", line 311, in run phase() File "/usr/lib/python2.6/site-packages/qpid_tests/broker_0_10/message.py", line 524, in test_window_flow_bytes msg = q.get(timeout = 1) File "/usr/lib/python2.6/site-packages/qpid/queue.py", line 50, in get result = BaseQueue.get(self, block, timeout) File "/usr/lib/python2.6/Queue.py", line 176, in get raise Empty Empty Can we open a separate BZ for this if it can be shown to be an error in the Qpid code and not the test itself? |