Bug 796239

this is working as designed even if it is a bit confusing.  The user should only add repos + distros they want to the template.  Adding the entire product can definitely cause the issues you describe above.  In v 1.1 we will re-examine this workflow to improve this.

perhaps we may disable the option to add a product to a template since that really ends up causing more problems than solutions.

It should be possible not to add a single repository to a template, rather than the entire product.  This will allow you to create system templates that include *only* the package repo URLs for the added repositories.  For an example, see some of my recent templates at https://yttrium.idm.lab.bos.redhat.com/templates/

(In reply to comment #2)
> It should be possible not to add a single repository to a template, rather than
> the entire product.  This will allow you to create system templates that
> include *only* the package repo URLs for the added repositories.  For an
> example, see some of my recent templates at
> https://yttrium.idm.lab.bos.redhat.com/templates/

Ergh, phalanges!  "It should be possible to add a single repository..."

I don't find this very intuitive.

You add a product and it adds all the repos, but they don't show up as being added in the GUI but will in the template?   If they showed up and I could unselect the ones I didn't want, I would understand that flow.  

So as comments 2 & 3 suggest and as I state in the original text there is a method to do the activity, but it is not flow I at least expected. Is this clearly documented?

(In reply to comment #4)
> 
> I don't find this very intuitive.

I think the challenge for me was understanding the current state of affairs.  Currently, the product is "Red Hat Enterprise Linux Server".  That includes *all* major and minor versions of RHEL.  So by adding the product "Red Hat Enterprise Linux Server" to a template, you are effectively adding *all* versions and updates of RHEL.

I'm not sure if this understanding of a product is something unique to katello, or something it is representing that's previously established by RHN (manifest).

So I guess the question now is whether that representation of a product is clearly understood + documented ... and whether it's the best way to visualize this data. 

As for intuitive, I don't know if this is correct, but I would have expected to see a product list that contained ...

 * Red Hat Enterprise Linux Server 6 [x86_64, i386]
 * Red Hat Enterprise Linux Server 5 [x86_64, i386]

Adding one of those products would then add all enabled+synced update releases of RHEL6 (or RHEL5 if selected).  So that might not be 100% intuitive either.

Should this be extended further ...

 * Red Hat Enterprise Linux Server 5.7 [x86_64, i386]
 * Red Hat Enterprise Linux Server 5.8 [x86_64, i386]
 * Red Hat Enterprise Linux Server 5Server [x86_64, i386]
 * Red Hat Enterprise Linux Server 6.1 [x86_64, i386]
 * Red Hat Enterprise Linux Server 6.2 [x86_64, i386]
 * Red Hat Enterprise Linux Server 6Server [x86_64, i386]

I suspect this might address your concerns regarding intuitiveness ... but might clutter up the UI horribly.  

Justin: Any thoughts on how katello is representing RHEL as a product?  Is lumping all major+minor versions of RHEL into a single "product" a katello construct, or something established elsewhere?

An additional thought

Is the way repos handled consistent with other objects, say distros

When you add a product to the template the distro becomes selectable but is not added to the template until you select it.

When you add a prodcut to the template, all the repos get added to the template but no the UI, this un selectable/unselectable.

(In reply to comment #6)
> When you add a product to the template the distro becomes selectable but is not
> added to the template until you select it.
> 
> When you add a prodcut to the template, all the repos get added to the template
> but no the UI, this un selectable/unselectable.

Hi Steve, all valid points.  For Justin's sanity, can we keep one issue per bug?  Would you mind logging issues

If adding the RHEL product to a template doesn't work properly, I would advocate for just removing the ability to add products to a template.  No real point in having a broken feature causing support calls.


Thoughts Bryan?

(In reply to comment #9)
> 
> If adding the RHEL product to a template doesn't work properly, I would
> advocate for just removing the ability to add products to a template.  No real
> point in having a broken feature causing support calls.

Does this have any UI implications?

> katello> template info --name rhel-i386-server-6-cf-tools
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>                                                                                                  Template Info
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> 
> Id:                       9
> Name:                     rhel-i386-server-6-cf-tools
> Revision:                 9
> Description:
>     None
> Environment Id:           3
> Parent Id:                None
> Products:
>     
> Repositories:
>     Red Hat Enterprise Linux 6 Server RPMs i386 6Server
>     Red Hat CloudForms Tools for RHEL 6 RPMs i386 6Server
>     Red Hat CloudForms Tools for RHEL 6 Beta RPMs i386 6Server
> Packages:
>     aeolus-audrey-agent
>     katello-agent
>     open-vm-tools
>     rhev-agent
> Parameters:
>     
> Package Groups:
>     
> Package Group Categories:

Also, CLI implications?

> katello> template update -h
> Usage: katello [options]
> 
> Options:
>   -h, --help            show this help message and exit
>   -g                    grep friendly output
>   -v                    verbose, more structured output
>   -d DELIMITER          grep friendly output column delimiter
> <snip>
>   --add_product=ADD_PRODUCTS
>                         name of the product
>   --remove_product=REMOVE_PRODUCTS
>                         name of the product

Yes, it has both UI, cli,and api implications.

Disabled adding product to system templates in the UI.  
d46df430ae1cc90516e63d18fe01086293fa2ad6

Opened bug for cli/api as i figure it will be faster/safer for a backend member to handle that.

-Justin

Sorry, the referenced bug: https://bugzilla.redhat.com/show_bug.cgi?id=799149

*** Bug 759277 has been marked as a duplicate of this bug. ***

mass move ON_QA after brewing

Verified - can no longer add products to templates. 
Katello Version: 0.2.9-1.git.0.aede6b1.el6