Bug 796247

Summary: update valid_credentials? to use new Deltacloud client
Product: [Retired] CloudForms Cloud Engine Reporter: Martyn Taylor <mtaylor>
Component: aeolus-conductorAssignee: Martyn Taylor <mtaylor>
Status: CLOSED CURRENTRELEASE QA Contact: wes hayutin <whayutin>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 1.0.0CC: akarol, cpelland, deltacloud-maint, hbrock, mfojtik, morazi, rlandy, ssachdev
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-13 19:50:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Invalid Creds - error saving account none

Description Martyn Taylor 2012-02-22 14:58:45 UTC
Description of problem:

Need to update valid_credentials? to use new Deltacloud behaviour.

i.e. catch UnauthorizedException instead of expecting false.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 wes hayutin 2012-02-22 23:47:15 UTC
moving version to 1.0.0 .  version = found in version

Comment 2 Martyn Taylor 2012-02-24 15:17:54 UTC
*** Bug 796868 has been marked as a duplicate of this bug. ***

Comment 3 Michal Fojtik 2012-02-29 15:39:25 UTC
commit 7ee08d5a7119fc31d0cc754802a4582854b98ba5
Author: Michal Fojtik <mfojtik>
Date:   Mon Feb 27 16:40:36 2012 +0100

    Core: Display user-defined exception message
    
    The exception handling DSL we're using allow user
    to define custom exception message using the 'message'
    directive. This message is then used in XML/HTML view
    and client can fetch it.
    However DC logs the original error message to system log.
    This patch should make DC log user-defined message to log.

These patches should fix this issue on Deltacloud API side:

commit d6b59298cc643009358b828b1d6593e086f2d1e1
Author: Michal Fojtik <mfojtik>
Date:   Fri Feb 10 13:56:01 2012 +0100

    Client: Revamped client/server error handling
    
    This patch will various HTTP error exceptions to
    client library. The exception classes are then used
    to properly report server/client exceptions and they
    should help handle various HTTP errors.
    
    Signed-off-by: Michal fojtik <mfojtik>

commit 6562a1c9d7233c568d0afa40eee9e05c5d3d243b
Author: Michal Fojtik <mfojtik>
Date:   Fri Feb 10 13:56:00 2012 +0100

    Core: Added XML output for 504 and 502 errors
    
    The 501, 502 and 504 errors previously has no XML view
    associated and thus client cannot report errors correctly.
    This patch add these missing HAML templates.
    
    Signed-off-by: Michal fojtik <mfojtik>

Comment 4 Ronelle Landy 2012-09-25 18:56:17 UTC
See comments in https://issues.apache.org/jira/browse/DTACLOUD-127 for verification of valid_credentials on the Deltacloud side

Checking Conductor: 

>> rpm -qa |grep aeolus
aeolus-configure-2.8.7-1.el6cf.noarch
rubygem-aeolus-image-0.3.0-12.el6.noarch
rubygem-aeolus-cli-0.7.2-1.el6cf.noarch
aeolus-conductor-0.13.14-1.el6cf.noarch
aeolus-conductor-daemons-0.13.14-1.el6cf.noarch
aeolus-conductor-doc-0.13.14-1.el6cf.noarch
aeolus-all-0.13.14-1.el6cf.noarch

>> rpm -qa |grep deltacloud
rubygem-deltacloud-client-0.5.0-2.el6.noarch
deltacloud-core-vsphere-0.5.0-10.el6_2.noarch
deltacloud-core-rhevm-0.5.0-10.el6_2.noarch
deltacloud-core-ec2-0.5.0-10.el6_2.noarch
deltacloud-core-0.5.0-10.el6_2.noarch

When a users tries to save a new account on a provider using incorrect creds, Conductor returns:

**********

  Cloud Resource Provider Account wasn't updated
  
1 error prohibited this Cloud Resource Provider Account from being saved
An error occurred when checking Cloud Resource Provider credentials. Please check your setup and try again.


**********

See attached screenshot.

Marking this BZ as 'verified'.

Comment 5 Ronelle Landy 2012-09-25 18:56:53 UTC
Created attachment 617219 [details]
Invalid Creds - error saving account