Bug 796602

Description of problem:
I was able to create LV names with the "/" using the lvconvert command:

# lvconvert --splitmirrors 1 --name test/testlv1 test/testlv

The command returns errors:

 Name "test-test/testlv1" invalid. It contains "/".
  Failed to rename test-testlv_mimage_1 (253:3) to test-test/testlv1
  Failed to rename newly split LV in the kernel
  libdevmapper exiting with 1 device(s) still suspended.

But the LVM metadata are modified, so now we have a LV named "test/testlv1":

# lvs
  LV              VG       Attr   LSize   Origin Snap%  Move Log Copy%  Convert
  lv_root         VolGroup -wi-ao   8.54g                                      
  lv_swap         VolGroup -wi-ao 992.00m                                      
  test/testlv1    test     -wa-s-  12.00m                                      
  testlv          test     -wa-a-  12.00m                                      
  testlv_mimage_0 test     vwa-a-  12.00m             

This LV is impossible to remove using lvremove.

Version-Release number of selected component (if applicable):
Reproduced on the latest LVM2 package on RHEL6 (lvm2-2.02.87-6.el6.x86_64)

How reproducible:
ALways


Steps to Reproduce:
1. Create a mirrored LV
2. Split the logical volume using as name "xxxx/yyyyy"
3. The command will give an error but the LV is present in the lvs output
  
Actual results:
The metadata are modified and the not valid name is used.


Expected results:
The lvconvert should raise an error and not insert the lv metadata.


Additional info:

These are the tests I've done:

# lvcreate -m1 --alloc anywhere --mirrorlog core -L10MB -n testlv test

# lvconvert --splitmirrors 1 --name test/testlv1 test/testlv
  Name "test-test/testlv1" invalid. It contains "/".
  Failed to rename test-testlv_mimage_1 (253:3) to test-test/testlv1
  Failed to rename newly split LV in the kernel
  libdevmapper exiting with 1 device(s) still suspended.

# lvs
  LV              VG       Attr   LSize   Origin Snap%  Move Log Copy%  Convert
  lv_root         VolGroup -wi-ao   8.54g                                      
  lv_swap         VolGroup -wi-ao 992.00m                                      
  test/testlv1    test     -wa-s-  12.00m                                      
  testlv          test     -wa-a-  12.00m                                      
  testlv_mimage_0 test     vwa-a-  12.00m                                     


# dmsetup info -c
Name                 Maj Min Stat Open Targ Event  UUID                                                                
VolGroup-lv_swap     253   1 L--w    1    1      0 LVM-nVuLBqbbvI8SrGo7i3vzetJbfMaOikyCzoNWkcsukJjWY4xPFetOBefvy2M9fUfd
VolGroup-lv_root     253   0 L--w    1    1      0 LVM-nVuLBqbbvI8SrGo7i3vzetJbfMaOikyCCa3zIo1ufjkjluvqDUe2cJInd0jnn2NC
test-testlv          253   4 L--w    0    1      1 LVM-8o1OhBGDPPZFMV0qGlguT9hgL4j2j0EFp0xLyMunDX61SJ4lhVwJ38lCVkuEZPPT
test-testlv_mimage_1 253   3 L-sw    0    1      0 LVM-8o1OhBGDPPZFMV0qGlguT9hgL4j2j0EFq0Js0lfTsjp0GbxpnqdiCyYd9Gu4s0b6
test-testlv_mimage_0 253   2 L--w    0    1      0 LVM-8o1OhBGDPPZFMV0qGlguT9hgL4j2j0EFEu3US3n1wEgf3ooIQ1XaLsmUjZDowb5p

# dmsetup ls --tree
VolGroup-lv_swap (253:1)
 └─ (252:2)
VolGroup-lv_root (253:0)
 └─ (252:2)
test-testlv (253:4)
 └─ (252:16)
test-testlv_mimage_1 (253:3)
 └─ (252:16)
test-testlv_mimage_0 (253:2)


The LV is removable by restoring a modified backup:

# diff -u test_00036-1793593470.vg /etc/lvm/archive/test_00036-1793593470.vg 
--- test_00036-1793593470.vg	2012-02-23 07:45:31.716806707 +0000
+++ /etc/lvm/archive/test_00036-1793593470.vg	2012-02-22 17:01:04.283832033 +0000
@@ -69,7 +69,7 @@
 			}
 		}
 
-		test_testlv1 {
+		test/testlv1 {
 			id = "q0Js0l-fTsj-p0Gb-xpnq-diCy-Yd9G-u4s0b6"
 			status = ["READ", "WRITE", "VISIBLE"]
 			flags = []


# vgcfgrestore -f test_00036-1793593470.vg test
  Restored volume group test


# lvs
  LV              VG       Attr   LSize   Origin Snap%  Move Log Copy%  Convert
  lv_root         VolGroup -wi-ao   8.54g                                      
  lv_swap         VolGroup -wi-ao 992.00m                                      
  test_testlv1    test     -wa---  12.00m                                      
  testlv          test     -wa-a-  12.00m                                      
  testlv_mimage_0 test     vwa-a-  12.00m                                      


# lvremove test/test_testlv1
  Logical volume "test_testlv1" successfully removed

# lvs
  LV              VG       Attr   LSize   Origin Snap%  Move Log Copy%  Convert
  lv_root         VolGroup -wi-ao   8.54g                                      
  lv_swap         VolGroup -wi-ao 992.00m                                      
  testlv          test     -wa-a-  12.00m                                      
  testlv_mimage_0 test     vwa-a-  12.00m                                      

# lvremove testlv
  Volume group "testlv" not found
  Skipping volume group testlv

# lvremove test/testlv
Do you really want to remove active logical volume testlv? [y/n]: y
  Logical volume "testlv" successfully removed

# lvremove test/testlv_mimage_0
Do you really want to remove active logical volume testlv_mimage_0? [y/n]: y
  Logical volume "testlv_mimage_0" successfully removed

# lvs
  LV      VG       Attr   LSize   Origin Snap%  Move Log Copy%  Convert
  lv_root VolGroup -wi-ao   8.54g                                      
  lv_swap VolGroup -wi-ao 992.00m