Bug 796797

Summary: Move Role strings out of seeds.rb to allow overrides
Product: [Retired] CloudForms Cloud Engine Reporter: Jason Guiditta <jguiditt>
Component: aeolus-conductorAssignee: Jason Guiditta <jguiditt>
Status: CLOSED CURRENTRELEASE QA Contact: wes hayutin <whayutin>
Severity: low Docs Contact:
Priority: unspecified    
Version: 1.0.0CC: akarol, deltacloud-maint, hbrock, slinaber, ssachdev
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: v0.8.0-39 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jason Guiditta 2012-02-23 16:52:30 UTC 
Description of problem: 

The current setup has strings for Roles embedded in seeds.rb. I propose to split this out into i18n files to allow overrides as needed.  This will alleviate some merge conflicts between upstream releases and the Red Hat product, as an initial benefit
Comment 1 Jason Guiditta 2012-02-23 16:53:19 UTC 
This is already in progress, just needed a BZ to track it
Comment 2 Jason Guiditta 2012-02-27 17:32:54 UTC 
Sent patches to list:

<1330362738-16239-1-git-send-email-jguiditt>
and 
<1330363918-18411-1-git-send-email-jguiditt>
Comment 3 Jason Guiditta 2012-02-28 22:36:30 UTC 
Pushed to master:

(conductor)

commit 14163aae5b501411ac7e3c182734d0266484398c
Author: Jason Guiditta <jguiditt>
Date:   Tue Feb 21 10:12:24 2012 -0500

    BZ #796797: Move Role strings out of seeds.rb to allow overrides.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=796797
    
    Make db/seeds use i18n stuff instead of text for role defs. As a side
    effect, the UI now uses the keys and pulls the i18n trnaslation as well

commit 7bb422082c6845da936900df5a8a9a51351ecab3
Author: Jason Guiditta <jguiditt>
Date:   Mon Feb 27 12:29:50 2012 -0500

    BZ #796797: Fix Role string for sql statement
    
    https://bugzilla.redhat.com/show_bug.cgi?id=796797
    
    This does not address the larger issue that we _have_ a sql
    statement here, will leave that to fix later.
Comment 4 Steve Linabery 2012-02-29 23:44:11 UTC 
361d50b  774cad0
Comment 5 Steve Linabery 2012-02-29 23:49:27 UTC 
10cfd49 in aeolus-configure-2.5.0-16
Comment 6 wes hayutin 2012-04-04 14:09:12 UTC 
this is not customer facing.. moving to verified..