Bug 796953
| Summary: | Review Request: trac-vatar-plugin - Add gravatar icons to various points around trac | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andrea Veri <andrea.veri> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-25 20:04:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Andrea Veri
2012-02-23 22:25:28 UTC
I'll review this. Look for a full review later today hopefully. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Please include the LICENSE and README.rst as doc files. :) 2. Please use the full url in source0: Source0: http://pypi.python.org/packages/source/t/tracvatar/tracvatar-1.4.tar.gz 3. rpmlint says: trac-vatar-plugin.noarch: W: spelling-error Summary(en_US) gravatar -> gr avatar, gr-avatar, avatar trac-vatar-plugin.noarch: W: no-documentation trac-vatar-plugin.src: W: spelling-error Summary(en_US) gravatar -> gr avatar, gr-avatar, avatar trac-vatar-plugin.src: W: invalid-url Source0: trac-vatar-plugin-1.4.tar.gz 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Please fix the doc files and source url before importing. Otherwise this package is APPROVED. Both done and uploaded new files at the same location, requesting branches now. New Package SCM Request ======================= Package Name: trac-vatar-plugin Short Description: Add gravatar icons to various points around trac Owners: averi nirik Branches: f15 f16 el5 el6 InitialCC: averi nirik Git done (by process-git-requests). Corrected nirik's FAS account name. trac-vatar-plugin-1.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-vatar-plugin-1.4-1.el6 trac-vatar-plugin-1.4-1.el6 has been pushed to the Fedora EPEL 6 testing repository. Seems we are missing a f17 branch (and all the Fedora builds here): Package Change Request ====================== Package Name: trac-vatar-plugin New Branches: f17 Owners: averi kevin InitialCC: Git done (by process-git-requests). trac-vatar-plugin-1.6-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-vatar-plugin-1.6-1.el6 trac-vatar-plugin-1.6-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |