Bug 797066

Summary: Output message error when create a bridge base on an existing network device
Product: Red Hat Enterprise Linux 6 Reporter: yanbing du <ydu>
Component: libvirtAssignee: Laine Stump <laine>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 6.3CC: acathrow, dallan, dyuan, mzhan, rwu, veillard, zhpeng
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-0.9.10-3.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-20 06:49:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description yanbing du 2012-02-24 07:28:22 UTC
Description of problem:
After create a bridge base on existing network device, the output message with a reverse order of the bridge and ethernet device name. 

Version-Release number of selected component (if applicable):
libvirt-0.9.10-2.el6.x86_64

How reproducible:
always

Steps to Reproduce:
1. Use virsh command to create a bridge device
# virsh iface-bridge eth0 br0 --no-stp
Created bridge eth0 with attached device br0
Bridge interface br0 started


Actual results:
the output message with a reverse order of the bridge and ethernet device name. 

Expected results:
the output message should be:
Created bridge br0 with attached device eth0

Additional info:

Comment 3 Laine Stump 2012-02-28 02:18:16 UTC
Sorry, I forgot to post when I pushed the fix for this on Friday - there is a fix for this (literally one line) pushed upstream:

commit 4a92360091fd036152a7980f38ab01c54874061d
Author: Laine Stump <laine>
Date:   Fri Feb 24 14:32:33 2012 -0500

    virsh: fix informational message in iface-bridge command
    
    See: https://bugzilla.redhat.com/show_bug.cgi?id=797066
    
    The position of the bridge name and ethernet device name were
    accidentally swapped in the message informing of success creating the
    bridge.

I don't see any reason to delay this until 6.4, since it is a single line, is trivial to test, has 0 possibility of a merge conflict, and will eliminate confusion.

Comment 5 yanbing du 2012-02-29 06:50:38 UTC
Bug verified.
# rpm -q libvirt
libvirt-0.9.10-3.el6.x86_64

# virsh iface-bridge eth0 br0 --no-stp
Created bridge br0 with attached device eth0
Bridge interface br0 started

# virsh iface-unbridge br0
Device eth0 un-attached from bridge br0
Interface eth0 started

Comment 7 errata-xmlrpc 2012-06-20 06:49:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html