| Summary: | Review Request: python-ssh - A Python SSH2 library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Silas Sewell <silas> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | bobbypowers, notting, package-review, tomspur |
| Target Milestone: | --- | Flags: | tomspur:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-ssh-1.7.13-2.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-17 23:35:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Silas Sewell
2012-02-25 08:41:14 UTC
Review: - name ok - license ok - URL ok - source ok 26800ef2c1ee3f185f48fd05258302f4 ssh-1.7.13.tar.gz - noarch ok - files ok - rpmlint contains the incorrect-fsf-addresses from above nothing else, ok NEEDSWORK: - please add a %check section: %check ./test.py --verbose - There is a python3-crypto package in fc17 onwards. Could you please add a python3 subpackage here too? Might be that ipython could use this too, and I'm trying to get all the python3 dependencies fulfilled... (When you need a co-maintainer, let me know.) It seems to work after 2to3 and replacing tabs with 8 spaces. - Please delete rm -rf ssh.egg-info/ in %prep just to be sure, that it's not used laterly. SRPM Url: https://github.com/downloads/silas/rpms/python-ssh-1.7.13-2.fc18.src.rpm Spec Diff: https://github.com/silas/rpms/commit/d29e69fb785237642105df8af3a9d7cceb575ee2 Notes: - Added check section - Attempted to add python3, but tests failed because UserDict.DictMixin isn't in python3 (imported and used in ssh/hostkeys.py) -- I might try to come up with a patch to convert this to collections.MutableMapping - Added rm -fr to prep section (In reply to comment #2) > - Added check section > - Added rm -fr to prep section Thanks. > - Attempted to add python3, but tests failed because UserDict.DictMixin isn't > in python3 (imported and used in ssh/hostkeys.py) -- I might try to come up > with a patch to convert this to collections.MutableMapping I just tried it quick and dirty and it turns out that internal python-ssh doesn't care much bytes vs strings so this will involve some deeper patches/rewrite. Python3 support is talked about here: https://github.com/bitprophet/ssh/issues/7 ######################################################################### APPROVED New Package SCM Request ======================= Package Name: python-ssh Short Description: Python SSH2 library Owners: silas Branches: f16 f17 el6 InitialCC: Git done (by process-git-requests). python-ssh-1.7.13-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-ssh-1.7.13-2.fc16 Thanks for the review Thomas. python-ssh-1.7.13-2.fc16 has been pushed to the Fedora 16 testing repository. this is great! I'm using this with a fabric-1.4 rpm with great success. Let me know if you want the git diff, although its fairly trivial with python-ssh being packaged. testing on f17, I should add python-ssh-1.7.13-2.fc16 has been pushed to the Fedora 16 stable repository. |