| Summary: | Review Request: dbus-tools - DBus developer tools | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Minar <miminar> |
| Component: | Package Review | Assignee: | Jaroslav Reznik <jreznik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jreznik, notting, package-review |
| Target Milestone: | --- | Flags: | jreznik:
fedora-review+
miminar: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | noarch | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-05 14:03:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Michal Minar
2012-02-28 09:57:00 UTC
Name: not ok, the upstream project is called dbus-tools, shouldn't be better to use it as well? as dbus-tools is a set of dbus-cli and zsh autocompetition, personally I prefer dbus-tools Version: not ok, version should be 0 Release: not ok, should be 0.1.20120227svn, you don't have to add revision as it's commented in sources part License: ISC, ok URL: ok Sources: SVN snapshot, ok, correct description to get the source codes BuildArch: ok BuildRequires: not ok, missing python2-devel according to package guidelines for Python Requires: not ok, python(abi) >= 2.7, python(abi) < 3.0 has to be removed Description: ok but should be updated - dcop section is not correct anymore Macros used consistently: ok Documentation: ok rpmlint dbus-cli-20120227svn8-1.fc16.src.rpm dbus-cli.src: W: spelling-error %description -l en_US dcop -> cop, drop, d cop - ok dbus-cli.src: W: invalid-url Source0: dbus-cli-20120227.tar.xz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. - svn snapshot Scratch build: ok, http://koji.fedoraproject.org/koji/taskinfo?taskID=3827843 Thanks for feedback, here is fixed version: Spec URL: http://www.minami.cz/public/dbus-tools.spec SRPM URL: http://www.minami.cz/public/dbus-tools-0-0.1.20120227svn.src.rpm Two issues, python-lxml should be required and zsh tab completion should be in separate subpackage. Zsh is not a common shell and package has to own the directory. Damn, forgot that. Good point with zsh, now there is one subpackage (dbus-tools-zsh): Spec URL: http://www.minami.cz/public/dbus-tools.spec SRPM URL: http://www.minami.cz/public/dbus-tools-0-0.1.20120227svn.src.rpm Thanks, it's ok now. Just a little spec file structure notice - usually the new package description is in the beginning and files for subpackages are grouped. But this is not a blocker. APPROVED New Package SCM Request ======================= Package Name: dbus-tools Short Description: DBus developer tools Owners: miminar Branches: f15 f16 f17 el5 el6 InitialCC: Git done (by process-git-requests). dbus-tools-0-0.1.20120227svn.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/dbus-tools-0-0.1.20120227svn.fc15 dbus-tools-0-0.1.20120227svn.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/dbus-tools-0-0.1.20120227svn.fc16 dbus-tools-0-0.1.20120227svn.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/dbus-tools-0-0.1.20120227svn.fc17 Package Change Request ====================== Package Name: dbus-tools New Branches: f18 Owners: miminar InitialCC: dbus-tools-0-0.1.20120227svn.fc17 has been pushed to the Fedora 17 stable repository. dbus-tools-0-0.1.20120227svn.fc16 has been pushed to the Fedora 16 stable repository. |