Bug 798614

Review Request: jboss-ejb3-ext-api -  JBoss EJB 3 Extension API, part of JBoss packaging tasks
Spec : http://braoru.fedorapeople.org/jboss-ejb3-ext-api.spec
SRPM : http://braoru.fedorapeople.org/jboss-ejb3-ext-api-2.0.0-1.fc17.src.rpm

Description : 

hi ! 

I just finished cleaning of the jboss-ejb3-ext-api originally packaged by mgoldman. I would appreciate a review :)

Spec : http://braoru.fedorapeople.org/jboss-ejb3-ext-api.spec
SRPM : http://braoru.fedorapeople.org/jboss-ejb3-ext-api-2.0.0-1.fc17.src.rpm


Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:
jboss-ejb3-ext-api.src: I: enchant-dictionary-not-found en_US
jboss-ejb3-ext-api.src: W: invalid-url URL: http://www.jboss.org/ejb3 HTTP Error 403: Forbidden
jboss-ejb3-ext-api.src: W: invalid-url Source0: jboss-ejb3-ext-api-2.0.0.beta2.tar.xz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[X]  Package is named according to the Package Naming Guidelines[1].
[X]  Spec file name must match the base package name, in the format %{name}.spec.
[X]  Package meets the Packaging Guidelines[2].
[X]  Package successfully compiles and builds into binary rpms.
[X]  Buildroot definition is not present
[X]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[X ]  License field in the package spec file matches the actual license.

License type:
[X]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[X]  All independent sub-packages have license of their own
[X]  Spec file is legible and written in American English.
[X]  Sources used to build the package matches the upstream source, as provided in the spec URL.

MD5SUM this package    :
[root@localhost ~]# md5sum rpmbuild/SOURCES/jboss-ejb3-ext-api-2.0.0.tar.xz 
75ec41f430ad2cabfa42e679812534f9  rpmbuild/SOURCES/jboss-ejb3-ext-api-2.0.0.tar.xz

MD5SUM upstream package:
[X]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[X]  Package must own all directories that it creates or must require other packages for directories it uses.
[X]  Package does not contain duplicates in %files.
[X]  File sections do not contain %defattr(-,root,root,-) unless changed with good reason
[X]  Permissions on files are set properly.
[X]  Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore)
[X]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing)
[X]  Package contains code, or permissable content.
[X]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[-]  Package does not own files or directories owned by other packages.
[X]  Javadoc documentation files are generated and included in -javadoc subpackage
[X]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[X]  Packages have proper BuildRequires/Requires on jpackage-utils
[X]  Javadoc subpackages have Require: jpackage-utils
[X]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[-]  If source tarball includes bundled jar/class files these need to be removed prior to building
[X]  All filenames in rpm packages must be valid UTF-8.
[X]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[X]  If package contains pom.xml files install it (including depmaps) even when building with ant
[X]  pom files has correct add_maven_depmap


=== Maven ===
[X]  Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment
[X]  Package DOES NOT use %update_maven_depmap in %post/%postun
[X]  Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[X]  If possible use upstream build method (maven/ant/javac)
[X]  Avoid having BuildRequires on exact NVR unless necessary
[X]  Package has BuildArch: noarch (if possible)
[X]  Latest version is packaged.
[X]  Reviewer should test that the package builds in mock.

[makerpm@localhost ~]$ /usr/bin/mock  rpmbuild/SRPMS/jboss-ejb3-ext-api-2.0.0-1.fc17.src.rpm 
INFO: mock.py version 1.1.21 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
INFO: Start(rpmbuild/SRPMS/jboss-ejb3-ext-api-2.0.0-1.fc17.src.rpm)  Config(fedora-17-x86_64)
State Changed: lock buildroot
State Changed: clean
State Changed: unlock buildroot
State Changed: init
State Changed: lock buildroot
Mock Version: 1.1.21
INFO: Mock Version: 1.1.21
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled yum cache
State Changed: cleaning yum metadata
INFO: enabled ccache
State Changed: running yum
State Changed: creating cache
State Changed: unlock buildroot
INFO: Installed packages:
State Changed: setup
State Changed: build
INFO: Done(rpmbuild/SRPMS/jboss-ejb3-ext-api-2.0.0-1.fc17.src.rpm) Config(default) 4 minutes 29 seconds
INFO: Results and/or logs in: /var/lib/mock/fedora-17-x86_64/result
State Changed: end
[makerpm@localhost ~]$