Bug 798681
| Summary: | Review Request: python-pyotp - Python One Time Password library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Konstantin Ryabitsev <icon> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-pyotp-1.3.1-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-16 21:18:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Konstantin Ryabitsev
2012-02-29 15:03:53 UTC
I'd be happy to review this. Look for a full review hopefully later today. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 7c45ca9a13f863caa1e8146e07d2b8b2 pyotp-1.3.1.tar.gz 7c45ca9a13f863caa1e8146e07d2b8b2 pyotp-1.3.1.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. See below - Package has a correct %clean section. See below - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. You may need to add %clean and buildroot for EPEL branches. They are of course not required for Fedora anymore. 2. The PKG-INFO says: License: UNKNOWN Might ask upstream to fix that. I see no blockers here, so this package is APPROVED. Nice! Thanks, Kevin. New Package SCM Request ======================= Package Name: python-pyotp Short Description: A Python library for generating one time passwords Owners: icon Branches: f16, f17, el5, el6 InitialCC: Git done (by process-git-requests). python-pyotp-1.3.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-pyotp-1.3.1-1.el6 python-pyotp-1.3.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-pyotp-1.3.1-1.fc16 python-pyotp-1.3.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-pyotp-1.3.1-1.fc17 python-pyotp-1.3.1-1.fc17 has been pushed to the Fedora 17 testing repository. python-pyotp-1.3.1-1.fc17 has been pushed to the Fedora 17 stable repository. python-pyotp-1.3.1-1.fc16 has been pushed to the Fedora 16 stable repository. python-pyotp-1.3.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |